learning-credentials 0.4.1rc3__tar.gz → 0.4.1rc5__tar.gz

{learning_credentials-0.4.1rc3/learning_credentials.egg-info → learning_credentials-0.4.1rc5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: learning-credentials
-Version: 0.4.1rc3
+Version: 0.4.1rc5
 Summary: A pluggable service for preparing Open edX credentials.
 Author-email: OpenCraft <help@opencraft.com>
 License-Expression: AGPL-3.0-or-later

{learning_credentials-0.4.1rc3 → learning_credentials-0.4.1rc5}/learning_credentials/generators.py

@@ -276,9 +276,6 @@ def _write_text_on_template(
     # Build and render text elements.
     elements = _build_text_elements(options)
 
-    if elements['context']:
-        elements['context']['text'] = elements['context']['text'].replace(';', '\n')
-
     for config in elements.values():
         _render_text_element(pdf_canvas, template_width, config, placeholders)
 
@@ -341,7 +338,7 @@ def generate_pdf_credential(
     Options:
 
       - template (required): The slug of the PDF template asset.
-      - template_multiline: Alternative template for multiline context names (when using '\n' or ';').
+      - template_multiline: Alternative template for multiline context names (when using '\n').
       - defaults: Global defaults for all text elements.
           - font: Font name (asset slug). Default: Helvetica.
           - color: Hex color code. Default: #000.
@@ -379,14 +376,15 @@ def generate_pdf_credential(
 
     username = _get_user_name(user)
 
-    # Handle multiline context name (semicolon separator for backward compatibility).
-    context_name = get_learning_context_name(learning_context_key).replace(';', '\n')
+    # Handle multiline context name.
+    context_name = get_learning_context_name(learning_context_key)
+    custom_context_name = ''
     custom_context_text_element = options.get('text_elements', {}).get('context', {})
     if isinstance(custom_context_text_element, dict):
-        context_name = custom_context_text_element.get('text', '').replace(';', '\n') or context_name
+        custom_context_name = custom_context_text_element.get('text', '')
 
     template_path = options.get('template')
-    if '\n' in context_name:
+    if '\n' in context_name or '\n' in custom_context_name:
         template_path = options.get('template_multiline', template_path)
 
     if not template_path:

{learning_credentials-0.4.1rc3 → learning_credentials-0.4.1rc5/learning_credentials.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: learning-credentials
-Version: 0.4.1rc3
+Version: 0.4.1rc5
 Summary: A pluggable service for preparing Open edX credentials.
 Author-email: OpenCraft <help@opencraft.com>
 License-Expression: AGPL-3.0-or-later

{learning_credentials-0.4.1rc3 → learning_credentials-0.4.1rc5}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "learning-credentials"
-version = "0.4.1rc3"
+version = "0.4.1rc5"
 description = "A pluggable service for preparing Open edX credentials."
 dynamic = ["readme"]
 requires-python = ">=3.11"

{learning_credentials-0.4.1rc3 → learning_credentials-0.4.1rc5}/tests/test_generators.py

@@ -477,8 +477,6 @@ def test_save_credential(mock_contentfile: Mock, mock_token_hex: Mock, storage:
         ('Test Course', {'template': 'default', 'template_multiline': 'multiline'}, 'default', 'Test Course'),
         # Specify a different template for multiline course names and replace \n with newline.
         ('Test\nCourse', {'template': 'default', 'template_multiline': 'multiline'}, 'multiline', 'Test\nCourse'),
-        # Backward compatibility with semicolon separator.
-        ('Test\nCourse;', {'template_multiline': 'multiline'}, 'multiline', 'Test\nCourse\n'),
         # Ensure that the default template is used when no multiline template is specified.
         ('Test\nCourse', {'template': 'default'}, 'default', 'Test\nCourse'),
         # Custom context text with newlines uses multiline template.
@@ -486,14 +484,15 @@ def test_save_credential(mock_contentfile: Mock, mock_token_hex: Mock, storage:
             'Single Line',
             {'template_multiline': 'multiline', 'text_elements': {'context': {'text': 'Line 1\nLine 2'}}},
             'multiline',
-            'Line 1\nLine 2',
+            'Single Line',
         ),
-        # Custom context text with semicolon uses multiline template.
+        # Custom context text without newlines still uses multiline template if the original context name has newlines.
+        # This allows using the `context_name` placeholder in the `context` text element.
         (
-            'Single Line',
-            {'template_multiline': 'multiline', 'text_elements': {'context': {'text': 'Line 1;Line 2'}}},
+            'Multi\nLine',
+            {'template_multiline': 'multiline', 'text_elements': {'context': {'text': 'Single Line'}}},
             'multiline',
-            'Line 1\nLine 2',
+            'Multi\nLine',
         ),
         # Disabled context element falls back to learning context name for template selection.
         (