learn-cli 0.5.0__tar.gz → 0.5.1__tar.gz

{learn_cli-0.5.0 → learn_cli-0.5.1}/CHANGELOG.md

@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
 Format follows [Keep a Changelog](https://keepachangelog.com/). This project
 adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.1] - 2026-07-11
+
+### Fixed
+
+- API worker: the /learn zone-mount proxy strips Cookie/Authorization before forwarding to the Pages origin (review finding: session leak)
+- API worker: withCors appends to an existing Vary header instead of overwriting it
+- Profile ledger: created 0600 like auth.json (learner data is private)
+- Profile ledger: a malformed ledger line is skipped instead of crashing progress/next/sync
+
 ## [0.5.0] - 2026-07-11
 
 ### Added

{learn_cli-0.5.0 → learn_cli-0.5.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: learn-cli
-Version: 0.5.0
+Version: 0.5.1
 Summary: A CLI, MCP server, and web front for learning — a hosted site where humans and agents learn a subject step by step. Fronts the french-cli and spanish-cli language tutors, and generalizes to other learnable domains such as leading teams of agents. The learn command is the local operator surface and how agents drive it.
 Project-URL: Homepage, https://github.com/agentculture/learn-cli
 Project-URL: Issues, https://github.com/agentculture/learn-cli/issues

{learn_cli-0.5.0 → learn_cli-0.5.1}/learn/profile/_ledger.py

@@ -8,26 +8,44 @@ written to by ``learn record`` (never by a subject CLI directly) and read by
 every motivation computation. Append-only by design — nothing here ever
 rewrites or deletes a row, so the sync cursor (:mod:`learn.profile._syncstate`)
 can track "pushed so far" as a simple row count.
+
+The ledger is learner data: the file is created ``0600`` (like ``auth.json``),
+and a malformed line — a crash mid-append, a manual edit — is skipped rather
+than crashing every ``progress``/``next``/sync flow. Because the ledger is
+append-only and a malformed line never becomes valid, skipping is stable, so
+the sync cursor's count-of-valid-rows arithmetic stays consistent across runs.
 """
 
 from __future__ import annotations
 
 import json
+import os
 from typing import Any
 
 from learn.profile._paths import ensure_store_dir, ledger_path
 
+#: Learner data is private to the local user, like ``auth.json``.
+_LEDGER_MODE = 0o600
+
 
 def append_ledger(row: dict[str, Any]) -> None:
     """Append one row to the local ledger, creating the store dir if needed."""
     ensure_store_dir()
-    with ledger_path().open("a", encoding="utf-8") as handle:
+    path = ledger_path()
+    created = not path.exists()
+    with path.open("a", encoding="utf-8") as handle:
         handle.write(json.dumps(row, ensure_ascii=False))
         handle.write("\n")
+    if created:
+        os.chmod(path, _LEDGER_MODE)
 
 
 def read_ledger() -> list[dict[str, Any]]:
-    """Read every row, in append order. Empty list when the ledger doesn't exist yet."""
+    """Read every valid row, in append order. Empty list when no ledger exists yet.
+
+    A line that fails to parse (or parses to a non-object) is skipped — one
+    corrupt row must not take down ``progress``/``next``/sync.
+    """
     path = ledger_path()
     if not path.is_file():
         return []
@@ -37,7 +55,12 @@ def read_ledger() -> list[dict[str, Any]]:
             stripped = line.strip()
             if not stripped:
                 continue
-            rows.append(json.loads(stripped))
+            try:
+                parsed = json.loads(stripped)
+            except json.JSONDecodeError:
+                continue
+            if isinstance(parsed, dict):
+                rows.append(parsed)
     return rows
 
 

{learn_cli-0.5.0 → learn_cli-0.5.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "learn-cli"
-version = "0.5.0"
+version = "0.5.1"
 description = "A CLI, MCP server, and web front for learning — a hosted site where humans and agents learn a subject step by step. Fronts the french-cli and spanish-cli language tutors, and generalizes to other learnable domains such as leading teams of agents. The learn command is the local operator surface and how agents drive it."
 readme = "README.md"
 license = "Apache-2.0"

{learn_cli-0.5.0 → learn_cli-0.5.1}/tests/test_profile_store.py

@@ -72,6 +72,23 @@ def test_read_ledger_skips_blank_lines(profile_home) -> None:
     assert len(p.read_ledger()) == 1
 
 
+def test_ledger_file_is_created_private(profile_home) -> None:
+    p.append_ledger({"subject": "french", "item_id": "fr.x", "result": "pass"})
+    mode = p.ledger_path().stat().st_mode & 0o777
+    assert mode == 0o600
+
+
+def test_read_ledger_skips_malformed_lines(profile_home) -> None:
+    p.append_ledger({"subject": "french", "item_id": "fr.a", "result": "pass"})
+    with p.ledger_path().open("a", encoding="utf-8") as handle:
+        handle.write("{not json\n")
+        handle.write("[1, 2, 3]\n")
+    p.append_ledger({"subject": "french", "item_id": "fr.b", "result": "partial"})
+    rows = p.read_ledger()
+    assert [r["item_id"] for r in rows] == ["fr.a", "fr.b"]
+    assert p.ledger_count() == 2
+
+
 # --- auth state ------------------------------------------------------------
 
 

{learn_cli-0.5.0 → learn_cli-0.5.1}/uv.lock

@@ -474,7 +474,7 @@ wheels = [
 
 [[package]]
 name = "learn-cli"
-version = "0.5.0"
+version = "0.5.1"
 source = { editable = "." }
 dependencies = [
     { name = "agentfront", extra = ["mcp"] },

{learn_cli-0.5.0 → learn_cli-0.5.1}/workers/learn-api/src/index.js

@@ -102,7 +102,13 @@ async function proxyToPages(request, env, url) {
   requireConfig(env, "PAGES_ORIGIN");
   const origin = env.PAGES_ORIGIN.replace(/\/+$/, "");
   const upstream = origin + url.pathname + url.search;
-  return fetch(new Request(upstream, { method: request.method, headers: request.headers }));
+  // Never forward credentials to the static origin: the session cookie (and
+  // any Authorization header) is for this API only — the Pages origin serves
+  // public files and must not see learner sessions.
+  const headers = new Headers(request.headers);
+  headers.delete("Cookie");
+  headers.delete("Authorization");
+  return fetch(new Request(upstream, { method: request.method, headers }));
 }
 
 // --- public routes ---------------------------------------------------------
@@ -325,6 +331,6 @@ function withCors(env, request, response) {
   headers.set("Access-Control-Allow-Credentials", "true");
   headers.set("Access-Control-Allow-Methods", "GET, POST, OPTIONS");
   headers.set("Access-Control-Allow-Headers", "Content-Type, Authorization");
-  headers.set("Vary", "Origin");
+  headers.append("Vary", "Origin");
   return new Response(response.body, { status: response.status, headers });
 }

{learn_cli-0.5.0 → learn_cli-0.5.1}/workers/learn-api/test/worker.test.js

@@ -429,3 +429,47 @@ test("POST under the /learn site mount is rejected (read-only proxy)", async ()
   const res = await call(env, new Request(`${BASE}/learn/french/`, { method: "POST" }));
   assert.equal(res.status, 405);
 });
+
+test("proxy to PAGES_ORIGIN strips Cookie and Authorization headers", async () => {
+  let seenHeaders = null;
+  const realFetch = globalThis.fetch;
+  globalThis.fetch = async (req) => {
+    seenHeaders = req.headers;
+    return new Response("ok", { status: 200 });
+  };
+  try {
+    const env = makeEnv({ PAGES_ORIGIN: "https://agentculture-learn.pages.dev" });
+    const req = new Request(`${BASE}/learn/french/`, {
+      headers: { Cookie: "session=supersecret", Authorization: "Bearer tok", Accept: "text/html" },
+    });
+    const res = await call(env, req);
+    assert.equal(res.status, 200);
+    assert.equal(seenHeaders.get("Cookie"), null);
+    assert.equal(seenHeaders.get("Authorization"), null);
+    assert.equal(seenHeaders.get("Accept"), "text/html");
+  } finally {
+    globalThis.fetch = realFetch;
+  }
+});
+
+test("withCors appends to an existing Vary header instead of overwriting", async () => {
+  let called = 0;
+  const realFetch = globalThis.fetch;
+  globalThis.fetch = async () => {
+    called += 1;
+    return new Response("ok", { status: 200, headers: { Vary: "Accept-Encoding" } });
+  };
+  try {
+    const env = makeEnv({
+      PAGES_ORIGIN: "https://agentculture-learn.pages.dev",
+      CORS_ORIGIN: "https://agentculture.org",
+    });
+    const res = await call(env, new Request(`${BASE}/learn/french/`, { headers: { Origin: "https://agentculture.org" } }));
+    assert.equal(called, 1);
+    const vary = res.headers.get("Vary");
+    assert.ok(vary.includes("Accept-Encoding"), `Vary lost upstream value: ${vary}`);
+    assert.ok(vary.includes("Origin"), `Vary missing Origin: ${vary}`);
+  } finally {
+    globalThis.fetch = realFetch;
+  }
+});