lambda-erp 0.3.0__tar.gz → 0.3.2__tar.gz

{lambda_erp-0.3.0 → lambda_erp-0.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: lambda-erp
-Version: 0.3.0
+Version: 0.3.2
 Summary: Core ERP logic - accounting, sales, purchasing, inventory
 Author: TORUS INVESTMENTS AG
 License-Expression: Apache-2.0

{lambda_erp-0.3.0 → lambda_erp-0.3.2}/api/chat.py

@@ -583,7 +583,7 @@ TOOLS = [
         "type": "function",
         "function": {
             "name": "search_masters",
-            "description": "Search master data (customers, suppliers, items, warehouses, accounts, companies, cost centers). Case-insensitive, with fuzzy fallback for misspellings. By default matches across standard text fields (name, display name, address/city/zip); large free-text columns like description/templates are skipped unless named in `fields`. PREFER passing `fields` whenever you know which attribute you're matching on (e.g. a city, an email, a tax id) — it's faster, more precise, and avoids false hits from other columns. Returns matching records.",
+            "description": "Search master data (customers, suppliers, items, warehouses, accounts, companies, cost centers). Case-insensitive, with fuzzy fallback for misspellings. By default matches across standard text fields (name, display name, address/city/zip); large free-text columns like description/templates are skipped unless named in `fields`. PREFER passing `fields` whenever you know which attribute you're matching on (e.g. a city, an email, a tax id) — it's faster, more precise, and avoids false hits from other columns. Returns ALL matching records by default (no cap); pass `limit` only to bound a large list.",
             "parameters": {
                 "type": "object",
                 "properties": {
@@ -594,6 +594,7 @@ TOOLS = [
                         "items": {"type": "string"},
                         "description": "Recommended: the column(s) to search, e.g. [\"city\"] or [\"customer_name\"]. Narrowing here is faster and avoids matching unrelated columns. Omit only when you genuinely don't know which field holds the value, to search all standard text fields.",
                     },
+                    "limit": {"type": "integer", "description": "Optional max number of results. OMIT for no cap — returns ALL matches (e.g. to see the entire chart of accounts). Pass a number only to bound a large list."},
                 },
                 "required": ["master_type"],
             },
@@ -1308,6 +1309,17 @@ def _handle_search_masters(args):
     master_type = args["master_type"]
     query = (args.get("query") or "").strip()
 
+    # Optional result cap the caller sets per call; omit for NO cap (return all —
+    # e.g. the whole chart of accounts). Coerced to int so the LIMIT clause below
+    # can't be injected.
+    _raw_limit = args.get("limit")
+    limit = None
+    if _raw_limit not in (None, "", 0):
+        try:
+            limit = max(1, int(_raw_limit))
+        except (TypeError, ValueError):
+            limit = None
+
     entry = services.MASTER_TABLES.get(master_type)
     if not entry:
         return {"error": f"Unknown master type: {master_type}"}
@@ -1317,7 +1329,7 @@ def _handle_search_masters(args):
 
     if not query:
         filters = {"disabled": 0} if has_disabled else None
-        return db.get_all(doctype, filters=filters, fields=["*"], limit=20)
+        return db.get_all(doctype, filters=filters, fields=["*"], limit=limit)
 
     # Optional `fields` narrows the search to specific columns — cheaper, more
     # precise, and the only way to reach bulk columns (description, templates)
@@ -1338,15 +1350,16 @@ def _handle_search_masters(args):
     # silently broke prod search); CAST lets targeted non-text columns match too.
     where = " OR ".join(f'lower(CAST("{col}" AS TEXT)) LIKE ?' for col in search_cols)
     pattern = f"%{query.lower()}%"
+    limit_sql = f" LIMIT {limit}" if limit else ""
     rows = db.sql(
-        f'SELECT * FROM "{doctype}" WHERE {active_prefix}({where}) LIMIT 20',
+        f'SELECT * FROM "{doctype}" WHERE {active_prefix}({where}){limit_sql}',
         [pattern] * len(search_cols),
     )
     if rows:
         return [dict(r) for r in rows]
 
     # Nothing matched literally — try fuzzy matching to catch misspellings.
-    return _fuzzy_master_search(db, doctype, search_cols, query, has_disabled, limit=20)
+    return _fuzzy_master_search(db, doctype, search_cols, query, has_disabled, limit=limit)
 
 
 def _ignored_master_fields(master_type: str, data: dict) -> list[str]:
@@ -1891,6 +1904,12 @@ If `jurisdiction.is_fallback` is true, tell the user their country isn't localiz
 
 You help users manage their business by creating documents, looking up data, and running reports — all through natural conversation.
 
+## Never fabricate actions or results
+Only state that something was done — created, changed, enabled/disabled, booked, repointed — **after a tool call returns a success result that confirms it**, and check the returned record actually reflects the change (after `update_master` with {{"disabled": 0}}, confirm the returned row shows `disabled = 0`; after submitting a journal entry, confirm it posted non-zero GL). If a tool returns an error, a warning, or a record that doesn't reflect your intent, tell the user it did **not** work and why — never smooth it over as success.
+- If a capability doesn't exist, say so plainly. There is **no rename** for accounts or other masters — a master's identifying `name`/number is immutable; you can only edit display fields or create a new record and migrate. Never claim you "renamed" an account.
+- Never assert a field or capability is missing without checking (e.g. an item's income account) — verify with `get_master_fields` / `search_masters` first.
+- If you can't confirm an action took effect, re-fetch and look, or tell the user you couldn't confirm it — never guess.
+
 ## Answering data questions — three paths
 
 **Path 1: single-record lookup → `list_documents` / `get_document`.** For "is SINV-0042 paid", "what did customer X order last", "show me the latest 5 purchase orders" — fetch the rows directly. Don't try to aggregate in your head unless there are only a handful of rows in front of you.

{lambda_erp-0.3.0 → lambda_erp-0.3.2}/api/routers/masters.py

@@ -187,7 +187,14 @@ def _generate_master_name(db, doctype: str, prefix: str) -> str:
 def _normalize_master_data(data: dict) -> dict:
     normalized = _dict(data)
     for key, value in list(normalized.items()):
-        if isinstance(value, str) and value.strip() == "":
+        # Flag columns (disabled, is_group, …) are INTEGER, not boolean. The chat
+        # may send a JSON bool; coerce true/false -> 1/0 so e.g. re-enabling an
+        # account with {"disabled": false} actually persists (on Postgres a bool
+        # into an INTEGER column errors, which then gets narrated as "done"). Check
+        # bool BEFORE int — in Python bool is a subclass of int.
+        if isinstance(value, bool):
+            normalized[key] = int(value)
+        elif isinstance(value, str) and value.strip() == "":
             normalized[key] = None
     return normalized
 

{lambda_erp-0.3.0 → lambda_erp-0.3.2}/lambda_erp/accounting/journal_entry.py

@@ -70,10 +70,33 @@ class JournalEntry(Document):
         if not self.posting_date:
             self.posting_date = nowdate()
 
+        self._normalize_amounts()
         self._validate_debit_credit()
         self._validate_references()
         self._set_totals()
 
+    def _normalize_amounts(self):
+        """Keep each row's base debit/credit and its *_in_account_currency twin in
+        sync. lambda-erp has no per-line exchange rate (base == account currency),
+        so back-fill whichever side is missing. Without this, a row created with
+        the amount ONLY in debit_in_account_currency (as the chat's create path
+        did) leaves base debit/credit at 0 — it passes the 0==0 balance check,
+        submits "successfully", and posts NOTHING (GL is built from the base
+        fields, and _get_gl_entries skips 0/0 rows). Idempotent."""
+        for row in self.get("accounts") or []:
+            debit = flt(row.get("debit"))
+            credit = flt(row.get("credit"))
+            dr_ac = flt(row.get("debit_in_account_currency"))
+            cr_ac = flt(row.get("credit_in_account_currency"))
+            if not debit and dr_ac:
+                row["debit"] = dr_ac
+            if not credit and cr_ac:
+                row["credit"] = cr_ac
+            if not dr_ac and debit:
+                row["debit_in_account_currency"] = debit
+            if not cr_ac and credit:
+                row["credit_in_account_currency"] = credit
+
     def _validate_debit_credit(self):
         """Ensure total debits == total credits.
 
@@ -100,6 +123,11 @@ class JournalEntry(Document):
     def on_submit(self):
         """Post GL entries directly from account rows."""
         gl_entries = self._get_gl_entries()
+        if not gl_entries:
+            raise ValidationError(
+                "Journal Entry has no non-zero lines to post — every account row is "
+                "0/0. Set a debit or credit amount before submitting."
+            )
         make_gl_entries(gl_entries)
         self._update_referenced_outstanding()
 

{lambda_erp-0.3.0 → lambda_erp-0.3.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "lambda-erp"
-version = "0.3.0"
+version = "0.3.2"
 description = "Core ERP logic - accounting, sales, purchasing, inventory"
 readme = "README.md"
 license = "Apache-2.0"