ladybug 0.20.2.dev20260908__tar.gz → 0.21.0.dev20260909__tar.gz

sdist/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ladybug
-Version: 0.20.2.dev20260908
+Version: 0.21.0.dev20260909
 Summary: Highly scalable, extremely fast, easy-to-use embeddable graph database
 Home-page: https://github.com/LadybugDB/ladybug
 License: MIT

sdist/ladybug-source/CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.15)
 
-project(Lbug VERSION 0.20.2.20260908 LANGUAGES CXX C)
+project(Lbug VERSION 0.21.0.20260909 LANGUAGES CXX C)
 
 option(SINGLE_THREADED "Single-threaded mode" FALSE)
 if(SINGLE_THREADED)

sdist/ladybug-source/src/include/storage/file_handle.h

@@ -12,12 +12,14 @@
 #include "common/concurrent_vector.h"
 #include "common/constants.h"
 #include "common/copy_constructors.h"
+#include "common/exception/runtime.h"
 #include "common/file_system/file_info.h"
 #include "common/types/types.h"
 #include "storage/buffer_manager/page_state.h"
 #include "storage/buffer_manager/vm_region.h"
 #include "storage/enums/page_read_policy.h"
 #include "storage/page_manager.h"
+#include <format>
 
 namespace lbug {
 namespace main {
@@ -91,6 +93,17 @@ public:
     void readPageFromDisk(uint8_t* frame, common::page_idx_t pageIdx) const {
         DASSERT(!isInMemoryMode());
         DASSERT(pageIdx < numPages);
+        // Fail fast with an actionable error instead of issuing a wild pread far
+        // beyond EOF (issue #843: a corrupted PIP chain turned into
+        // "Cannot read from file ... position: 4727899947008"). DASSERT alone is
+        // stripped in release builds.
+        if (pageIdx >= numPages) {
+            const auto numPagesSnapshot = numPages.load();
+            throw common::RuntimeException(
+                std::format("Cannot read page {} from disk: out of bounds for file with {} pages. "
+                            "The database file may be corrupted.",
+                    pageIdx, numPagesSnapshot));
+        }
         fileInfo->readFromFile(frame, getPageSize(), pageIdx * getPageSize());
     }
     void writePageToFile(const uint8_t* buffer, common::page_idx_t pageIdx) {

sdist/ladybug-source/src/optimizer/count_rel_table_optimizer.cpp

@@ -63,6 +63,8 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::visitOperator(
 
 static LogicalOperator* skipProjections(LogicalOperator* op);
 static bool containsOp(const LogicalOperator* root, const LogicalOperator* target);
+static bool isNativeRelGroupEntry(const RelGroupCatalogEntry* entry);
+static bool isNativeNodeEntry(const NodeTableCatalogEntry* entry);
 
 std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteAntiEdgeChainCount(
     std::shared_ptr<LogicalOperator> op) {
@@ -234,7 +236,8 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteAntiEdgeChain
                 continue;
             }
             auto* relGroupEntry = rel->getEntry(0)->ptrCast<RelGroupCatalogEntry>();
-            if (relGroupEntry->getScanFunction().has_value()) {
+            if (relGroupEntry->getScanFunction().has_value() ||
+                !isNativeRelGroupEntry(relGroupEntry)) {
                 continue;
             }
             auto* extendChild = skipProjections((ext->getChild(0).get()));
@@ -405,7 +408,8 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteAntiEdgeChain
                 return op;
             }
             auto* relGroupEntry = rel->getEntry(0)->ptrCast<RelGroupCatalogEntry>();
-            if (relGroupEntry->getScanFunction().has_value()) {
+            if (relGroupEntry->getScanFunction().has_value() ||
+                !isNativeRelGroupEntry(relGroupEntry)) {
                 return op;
             }
             if (ext->getDirection() == ExtendDirection::BOTH) {
@@ -449,6 +453,14 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteAntiEdgeChain
                 toTableID != toNode->getTableIDs()[0]) {
                 return op;
             }
+            // Parity with the extend-chain path, which gates every node it touches. The
+            // binder refuses to mix icebug-disk tables with native ones, but there is no
+            // equivalent guard for Arrow-backed tables, so the rel group's format alone
+            // cannot vouch for its endpoints.
+            if (!isNativeNodeEntry(fromNode->getEntry(0)->ptrCast<NodeTableCatalogEntry>()) ||
+                !isNativeNodeEntry(toNode->getEntry(0)->ptrCast<NodeTableCatalogEntry>())) {
+                return op;
+            }
             hop.relScans.push_back({relGroupEntry->getRelEntryInfos()[0].oid, scanDirection,
                 fromTableID, toTableID, relGroupEntry->getName()});
             matched = true;
@@ -468,6 +480,11 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteAntiEdgeChain
     if (antiNodeA->getTableIDs()[0] != midTableID || antiNodeB->getTableIDs()[0] != midTableID) {
         return op;
     }
+    // n0, n1 and n2 all bind midTableID, so gating that one entry covers every node the
+    // operator's node-group arithmetic touches.
+    if (!isNativeNodeEntry(midNode->getEntry(0)->ptrCast<NodeTableCatalogEntry>())) {
+        return op;
+    }
 
     std::vector<common::table_id_t> antiRelTableIDs;
     antiRelTableIDs.push_back(antiRelEntry->getRelEntryInfos()[0].oid);
@@ -570,15 +587,6 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::tryRewriteExtendChainCo
 
     // Validate the extends form a simple path over single-table nodes with single-entry,
     // storage-backed rel groups.
-    // The fast path below iterates the committed node-group grid of native node tables and
-    // reads the CSR of native rel tables. Arrow-backed and icebug-disk tables have neither,
-    // so they must be left to the regular plan.
-    auto isNativeRelGroupEntry = [](const RelGroupCatalogEntry* entry) {
-        return entry->getStorage().empty() && entry->getStorageFormat() == StorageFormat::NONE;
-    };
-    auto isNativeNodeEntry = [](const NodeTableCatalogEntry* entry) {
-        return entry->getStorage().empty() && entry->getStorageFormat() == StorageFormat::NONE;
-    };
     struct ChainEdge {
         std::string u;
         std::string v;
@@ -1143,6 +1151,17 @@ std::shared_ptr<LogicalOperator> CountRelTableOptimizer::visitAggregateReplace(
     return projection;
 }
 
+// The count-chain fast paths iterate the committed node-group grid of native node tables and
+// read the CSR of native rel tables. Arrow-backed and icebug-disk tables have neither, so they
+// must be left to the regular plan.
+static bool isNativeRelGroupEntry(const RelGroupCatalogEntry* entry) {
+    return entry->getStorage().empty() && entry->getStorageFormat() == StorageFormat::NONE;
+}
+
+static bool isNativeNodeEntry(const NodeTableCatalogEntry* entry) {
+    return entry->getStorage().empty() && entry->getStorageFormat() == StorageFormat::NONE;
+}
+
 static LogicalOperator* skipProjections(LogicalOperator* op) {
     while (op->getOperatorType() == LogicalOperatorType::PROJECTION) {
         op = op->getChild(0).get();

sdist/ladybug-source/src/storage/disk_array.cpp

@@ -33,6 +33,14 @@ PageStorageInfo::PageStorageInfo(uint64_t elementSize)
 
 PIPWrapper::PIPWrapper(const FileHandle& fileHandle, page_idx_t pipPageIdx)
     : pipPageIdx(pipPageIdx) {
+    // Validate before issuing the read so a corrupted PIP pointer fails fast with
+    // the offending index instead of a wild pread beyond EOF (issue #843).
+    if (pipPageIdx >= fileHandle.getNumPages()) {
+        throw RuntimeException(std::format("Cannot read PIP page {} from disk: out of bounds "
+                                           "for file with {} pages. The database file may be "
+                                           "corrupted.",
+            pipPageIdx, fileHandle.getNumPages()));
+    }
     fileHandle.readPageFromDisk(reinterpret_cast<uint8_t*>(&pipContents), pipPageIdx);
 }
 

sdist/ladybug-source/src/storage/disk_array_collection.cpp

@@ -7,6 +7,7 @@
 #include "common/types/types.h"
 #include "storage/file_handle.h"
 #include "storage/shadow_utils.h"
+#include <format>
 
 using namespace lbug::common;
 
@@ -29,6 +30,14 @@ DiskArrayCollection::DiskArrayCollection(FileHandle& fileHandle, ShadowFile& sha
     // Read headers from disk (no external state in lambda: optimistic read may run multiple times)
     page_idx_t headerPageIdx = firstHeaderPage;
     do {
+        // Fail fast on a corrupted nextHeaderPage link instead of issuing a wild
+        // read far beyond EOF (issue #843).
+        if (headerPageIdx >= fileHandle.getNumPages()) {
+            throw RuntimeException(std::format("Cannot read header page {} from disk: out of "
+                                               "bounds for file with {} pages. The database file "
+                                               "may be corrupted.",
+                headerPageIdx, fileHandle.getNumPages()));
+        }
         std::unique_ptr<HeaderPage> headerPage;
         page_idx_t nextHeaderPageIdx = INVALID_PAGE_IDX;
         fileHandle.optimisticReadPage(headerPageIdx, [&](auto* frame) {

sdist/ladybug-source/src/storage/table/column_chunk_data.cpp

@@ -375,7 +375,15 @@ void ColumnChunkData::initializeScanState(SegmentState& state, const Column* col
 
 void ColumnChunkData::scan(ValueVector& output, offset_t offset, length_t length,
     sel_t posInOutputVector) const {
+    // Scanning zero rows must not touch data buffers: empty (e.g. freshly created)
+    // chunks may hold null/zero-size buffers, and memcpy with a null source is UB
+    // even when the byte count is 0 (issue #840: SIGSEGV in memmove under
+    // NodeTableScanState::scanNext on empty tables via a parallel scan morsel).
+    if (length == 0) {
+        return;
+    }
     DASSERT(offset + length <= numValues);
+    DASSERT(getData() != nullptr);
     if (nullData) {
         nullData->scan(output, offset, length, posInOutputVector);
     }
@@ -785,6 +793,9 @@ std::unique_ptr<NullChunkData> NullChunkData::deserialize(MemoryManager& memoryM
 
 void NullChunkData::scan(ValueVector& output, offset_t offset, length_t length,
     sel_t posInOutputVector) const {
+    if (length == 0) {
+        return;
+    }
     output.setNullFromBits(getNullMask().getData(), offset, posInOutputVector, length);
 }
 

sdist/ladybug-source/src/storage/table/node_table.cpp

@@ -867,6 +867,10 @@ bool NodeTable::isVisible(const Transaction* transaction, offset_t offset) const
 }
 
 bool NodeTable::isVisibleNoLock(const Transaction* transaction, offset_t offset) const {
+    if (offset == INVALID_OFFSET) {
+        throw RuntimeException(
+            "Index contains an invalid node offset. Please drop and rebuild the index.");
+    }
     if (transaction && transaction->isUnCommitted(tableID, offset)) {
         const auto localTable = transaction->getLocalStorage()->getLocalTable(tableID);
         DASSERT(localTable);
@@ -874,11 +878,13 @@ bool NodeTable::isVisibleNoLock(const Transaction* transaction, offset_t offset)
     }
     auto [nodeGroupIdx, offsetInGroup] = StorageUtils::getNodeGroupIdxAndOffsetInChunk(offset);
     if (nodeGroupIdx >= nodeGroups->getNumNodeGroupsNoLock()) {
-        return false;
+        throw RuntimeException(
+            "Index contains an invalid node offset. Please drop and rebuild the index.");
     }
     const auto* nodeGroup = getNodeGroupNoLock(nodeGroupIdx);
-    if (nodeGroup == nullptr) {
-        return false;
+    if (nodeGroup == nullptr || offsetInGroup >= nodeGroup->getNumRows()) {
+        throw RuntimeException(
+            "Index contains an invalid node offset. Please drop and rebuild the index.");
     }
     return nodeGroup->isVisibleNoLock(transaction, offsetInGroup);
 }
@@ -931,32 +937,7 @@ bool NodeTable::lookupPK(const Transaction* transaction, ValueVector* keyVector,
     }
     if (auto* pkIndex = tryGetPrimaryKeyIndex()) {
         return pkIndex->lookupPrimaryKey(transaction, keyVector, vectorPos, result,
-            [&](offset_t offset) {
-                // A stale/corrupt PK index entry must not reach isVisibleNoLock(), where an
-                // invalid node offset could otherwise be dereferenced in a release build. Keep
-                // this validation O(1) on the normal lookup path and fail the transaction instead
-                // of treating a corrupt entry as a missing key.
-                if (offset == INVALID_OFFSET) {
-                    throw RuntimeException(
-                        "Primary-key index contains an invalid node offset. Please drop and "
-                        "rebuild the _PK index.");
-                }
-                const auto nodeGroupIdx = StorageUtils::getNodeGroupIdx(offset);
-                if (nodeGroupIdx >= nodeGroups->getNumNodeGroupsNoLock()) {
-                    throw RuntimeException(
-                        "Primary-key index points to a missing node group. Please drop and "
-                        "rebuild the _PK index.");
-                }
-                const auto* nodeGroup = getNodeGroupNoLock(nodeGroupIdx);
-                const auto offsetInGroup =
-                    offset - StorageUtils::getStartOffsetOfNodeGroup(nodeGroupIdx);
-                if (nodeGroup == nullptr || offsetInGroup >= nodeGroup->getNumRows()) {
-                    throw RuntimeException(
-                        "Primary-key index contains an out-of-range node offset. Please drop "
-                        "and rebuild the _PK index.");
-                }
-                return isVisibleNoLock(transaction, offset);
-            });
+            [&](offset_t offset) { return isVisibleNoLock(transaction, offset); });
     }
     auto keyToLookup = keyVector->getAsValue(vectorPos);
     ColumnPredicateSet predicateSet;

sdist/ladybug.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ladybug
-Version: 0.20.2.dev20260908
+Version: 0.21.0.dev20260909
 Summary: Highly scalable, extremely fast, easy-to-use embeddable graph database
 Home-page: https://github.com/LadybugDB/ladybug
 License: MIT

sdist/pyproject.toml

@@ -4,7 +4,7 @@ description = "Highly scalable, extremely fast, easy-to-use embeddable graph dat
 readme = "README.md"
 license = { text = "MIT" }
 keywords = ["graph", "database"]
-version = "0.20.2.dev20260908"
+version = "0.21.0.dev20260909"
 requires-python = ">=3.10,<3.15"
 
 [project.urls]