kryten-webqueue 0.34.0__tar.gz → 0.34.1__tar.gz

{kryten_webqueue-0.34.0 → kryten_webqueue-0.34.1}/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [0.34.1] - 2026-08-12
+
+### Fixed
+
+- `JobScheduler._register()`: bad cron expressions in the DB (e.g. hour=27)
+  are now logged at WARNING and skipped rather than raising `ValueError` during
+  startup and preventing the service from starting.
+- `JobScheduler.upsert()`: validates the cron expression via APScheduler before
+  persisting; raises `ValueError` with a clear message so the API route can
+  return HTTP 400 instead of saving an unrunnable schedule.
+- `/admin/job-schedules` POST and PUT: APScheduler validation errors now surface
+  as HTTP 400 with the rejection reason.
+
 ## [0.34.0] - 2026-08-11
 
 ### Added

{kryten_webqueue-0.34.0 → kryten_webqueue-0.34.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: kryten-webqueue
-Version: 0.34.0
+Version: 0.34.1
 Summary: Netflix/Tubi-style catalog browser and pay-to-play queue management for CyTube
 Author: grobertson
 License-Expression: MIT

{kryten_webqueue-0.34.0 → kryten_webqueue-0.34.1}/kryten_webqueue/jobs/job_scheduler.py

@@ -57,21 +57,30 @@ class JobScheduler:
             )
             return False
         minute, hour, day, month, day_of_week = parts
-        trigger = CronTrigger(
-            minute=minute,
-            hour=hour,
-            day=day,
-            month=month,
-            day_of_week=day_of_week,
-            timezone="UTC",
-        )
-        self._aps.add_job(
-            self._fire,
-            trigger=trigger,
-            args=[job_name],
-            id=f"jsch_{job_name}",
-            replace_existing=True,
-        )
+        try:
+            trigger = CronTrigger(
+                minute=minute,
+                hour=hour,
+                day=day,
+                month=month,
+                day_of_week=day_of_week,
+                timezone="UTC",
+            )
+            self._aps.add_job(
+                self._fire,
+                trigger=trigger,
+                args=[job_name],
+                id=f"jsch_{job_name}",
+                replace_existing=True,
+            )
+        except (ValueError, Exception) as exc:  # noqa: BLE001 - bad stored cron must not crash startup
+            logger.warning(
+                "JobScheduler: skipping invalid cron %r for %r: %s",
+                cron_expression,
+                job_name,
+                exc,
+            )
+            return False
         logger.info("JobScheduler: registered %r cron=%r", job_name, cron_expression)
         return True
 
@@ -134,7 +143,26 @@ class JobScheduler:
         is_active: bool = True,
         created_by: str | None = None,
     ) -> None:
-        """Persist a schedule and (re)register it with APScheduler."""
+        """Persist a schedule and (re)register it with APScheduler.
+
+        Raises ValueError if cron_expression is rejected by APScheduler.
+        """
+        # Validate before persisting so a bad expression is rejected at save time.
+        if is_active:
+            parts = (cron_expression or "").strip().split()
+            if len(parts) != 5:
+                raise ValueError(
+                    f"cron_expression must have exactly 5 fields (min hour dom mon dow), got: {cron_expression!r}"
+                )
+            minute, hour, day, month, day_of_week = parts
+            try:
+                CronTrigger(
+                    minute=minute, hour=hour, day=day,
+                    month=month, day_of_week=day_of_week, timezone="UTC",
+                )
+            except Exception as exc:
+                raise ValueError(f"Invalid cron expression {cron_expression!r}: {exc}") from exc
+
         params_json = json.dumps(params) if params is not None else None
         await self._db.upsert_job_schedule(
             job_name,

{kryten_webqueue-0.34.0 → kryten_webqueue-0.34.1}/kryten_webqueue/routes/admin_job_schedules.py

@@ -40,15 +40,18 @@ async def upsert_job_schedule(request: Request, user: dict = Depends(require_adm
         raise HTTPException(400, "cron_expression must have exactly 5 fields (min hour dom mon dow)")
 
     job_scheduler = request.app.state.job_scheduler
-    await job_scheduler.upsert(
-        job_name,
-        cron_expression,
-        params=body.get("params") or None,
-        label=body.get("label") or None,
-        run_next_job=body.get("run_next_job") or None,
-        is_active=bool(body.get("is_active", True)),
-        created_by=user["username"],
-    )
+    try:
+        await job_scheduler.upsert(
+            job_name,
+            cron_expression,
+            params=body.get("params") or None,
+            label=body.get("label") or None,
+            run_next_job=body.get("run_next_job") or None,
+            is_active=bool(body.get("is_active", True)),
+            created_by=user["username"],
+        )
+    except ValueError as exc:
+        raise HTTPException(400, str(exc))
     return {"success": True}
 
 
@@ -65,15 +68,18 @@ async def update_job_schedule(
         raise HTTPException(400, "cron_expression must have exactly 5 fields (min hour dom mon dow)")
 
     job_scheduler = request.app.state.job_scheduler
-    await job_scheduler.upsert(
-        job_name,
-        cron_expression,
-        params=body.get("params") or None,
-        label=body.get("label") or None,
-        run_next_job=body.get("run_next_job") or None,
-        is_active=bool(body.get("is_active", True)),
-        created_by=user["username"],
-    )
+    try:
+        await job_scheduler.upsert(
+            job_name,
+            cron_expression,
+            params=body.get("params") or None,
+            label=body.get("label") or None,
+            run_next_job=body.get("run_next_job") or None,
+            is_active=bool(body.get("is_active", True)),
+            created_by=user["username"],
+        )
+    except ValueError as exc:
+        raise HTTPException(400, str(exc))
     return {"success": True}
 
 

{kryten_webqueue-0.34.0 → kryten_webqueue-0.34.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "kryten-webqueue"
-version = "0.34.0"
+version = "0.34.1"
 description = "Netflix/Tubi-style catalog browser and pay-to-play queue management for CyTube"
 readme = "README.md"
 license = "MIT"