kleinkram 0.44.0.dev20250409080532__tar.gz → 0.44.1.dev20250414055151__tar.gz

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kleinkram
-Version: 0.44.0.dev20250409080532
+Version: 0.44.1.dev20250414055151
 Summary: give me your bags
 Author: Cyrill Püntener, Dominique Garmier, Johann Schwabe
 Author-email: pucyril@ethz.ch, dgarmier@ethz.ch, jschwab@ethz.ch

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/kleinkram/api/file_transfer.py

@@ -17,6 +17,7 @@ from uuid import UUID
 import boto3.s3.transfer
 import botocore.config
 import httpx
+from httpx import RemoteProtocolError
 from rich.console import Console
 from tqdm import tqdm
 
@@ -44,6 +45,9 @@ MAX_UPLOAD_RETRIES = 3
 S3_MAX_RETRIES = 60  # same as frontend
 S3_READ_TIMEOUT = 60 * 5  # 5 minutes
 
+RETRY_BACKOFF_BASE = 2  # exponential backoff base
+MAX_RETRIES = 5
+
 
 class UploadCredentials(NamedTuple):
     access_key: str
@@ -264,23 +268,69 @@ def _get_file_download(client: AuthenticatedClient, id: UUID) -> str:
 def _url_download(
     url: str, *, path: Path, size: int, overwrite: bool = False, verbose: bool = False
 ) -> None:
-    if path.exists() and not overwrite:
-        raise FileExistsError(f"file already exists: {path}")
-
-    with httpx.stream("GET", url, timeout=S3_READ_TIMEOUT) as response:
-        response.raise_for_status()
-        with open(path, "wb") as f:
-            with tqdm(
-                total=size,
-                desc=f"downloading {path.name}",
-                unit="B",
-                unit_scale=True,
-                leave=False,
-                disable=not verbose,
-            ) as pbar:
-                for chunk in response.iter_bytes(chunk_size=DOWNLOAD_CHUNK_SIZE):
-                    f.write(chunk)
-                    pbar.update(len(chunk))
+    if path.exists():
+        if overwrite:
+            path.unlink()
+            downloaded = 0
+        else:
+            downloaded = path.stat().st_size
+            if downloaded >= size:
+                raise FileExistsError(f"file already exists and is complete: {path}")
+    else:
+        downloaded = 0
+
+    attempt = 0
+    while downloaded < size:
+        try:
+            headers = {"Range": f"bytes={downloaded}-"}
+            with httpx.stream(
+                "GET", url, headers=headers, timeout=S3_READ_TIMEOUT
+            ) as response:
+                # Accept both 206 Partial Content and 200 OK if starting from 0
+                if not (
+                    response.status_code == 206
+                    or (downloaded == 0 and response.status_code == 200)
+                ):
+                    response.raise_for_status()
+                    raise RuntimeError(
+                        f"Expected 206 Partial Content, got {response.status_code}"
+                    )
+
+                mode = "ab" if downloaded > 0 else "wb"
+                with open(path, mode) as f:
+                    with tqdm(
+                        total=size,
+                        initial=downloaded,
+                        desc=f"downloading {path.name}",
+                        unit="B",
+                        unit_scale=True,
+                        leave=False,
+                        disable=not verbose,
+                    ) as pbar:
+                        for chunk in response.iter_bytes(
+                            chunk_size=DOWNLOAD_CHUNK_SIZE
+                        ):
+                            attempt = 0  # reset attempt counter on successful download of non-empty chunk
+                            if not chunk:
+                                break
+                            f.write(chunk)
+                            downloaded += len(chunk)
+                            pbar.update(len(chunk))
+            break  # download complete
+        except RemoteProtocolError as e:
+            logger.info(f"Error: {e}, retrying...")
+            attempt += 1
+            if attempt > MAX_RETRIES:
+                raise RuntimeError(
+                    f"Download failed after {MAX_RETRIES} retries due to RemoteProtocolError"
+                ) from e
+            if verbose:
+                print(
+                    f"RemoteProtocolError on attempt {attempt}/{MAX_RETRIES}, retrying after backoff..."
+                )
+            sleep(RETRY_BACKOFF_BASE**attempt)
+        except Exception as e:
+            raise RuntimeError(f"Failed to download: {e}") from e
 
 
 class DownloadState(Enum):

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/kleinkram/printing.py

@@ -85,8 +85,8 @@ def format_bytes(size: int) -> str:
     index = 0
 
     fsize: float = size
-    while fsize >= 1024 and index < len(units) - 1:
-        fsize /= 1024.0
+    while fsize >= 1000 and index < len(units) - 1:
+        fsize /= 1000.0
         index += 1
 
     # Format to 2 decimal places if needed

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/kleinkram/utils.py

@@ -229,10 +229,10 @@ def format_bytes(size_bytes: int | float, speed: bool = False) -> str:
         return "0 B/s" if speed else "0 B"
 
     units = ["B", "KB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"]
-    power = math.floor(math.log(size_bytes, 1024))
+    power = math.floor(math.log(size_bytes, 1000))
     unit_index = min(power, len(units) - 1)
 
-    value = size_bytes / (1024**unit_index)
+    value = size_bytes / (1000**unit_index)
 
     unit_suffix = "/s" if speed else ""
     return f"{value:.2f} {units[unit_index]}{unit_suffix}"

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/kleinkram.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kleinkram
-Version: 0.44.0.dev20250409080532
+Version: 0.44.1.dev20250414055151
 Summary: give me your bags
 Author: Cyrill Püntener, Dominique Garmier, Johann Schwabe
 Author-email: pucyril@ethz.ch, dgarmier@ethz.ch, jschwab@ethz.ch

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = kleinkram
-version = 0.44.0-dev20250409080532
+version = 0.44.1-dev20250414055151
 description = give me your bags
 long_description = file: README.md
 long_description_content_type = text/markdown

{kleinkram-0.44.0.dev20250409080532 → kleinkram-0.44.1.dev20250414055151}/tests/test_printing.py

@@ -15,14 +15,14 @@ from kleinkram.printing import parse_metadata_value
 def test_format_bytes():
     assert format_bytes(0) == "0 B"
     assert format_bytes(1) == "1 B"
-    assert format_bytes(1000) == "1000 B"
-    assert format_bytes(1024) == "1.00 KB"
-    assert format_bytes(1025) == "1.00 KB"
-    assert format_bytes(2048) == "2.00 KB"
-    assert format_bytes(2**20) == "1.00 MB"
-    assert format_bytes(2**30) == "1.00 GB"
-    assert format_bytes(2**40) == "1.00 TB"
-    assert format_bytes(2**50) == "1.00 PB"
+    assert format_bytes(999) == "999 B"
+    assert format_bytes(1000) == "1.00 KB"
+    assert format_bytes(1001) == "1.00 KB"
+    assert format_bytes(2000) == "2.00 KB"
+    assert format_bytes(10**6) == "1.00 MB"
+    assert format_bytes(10**9) == "1.00 GB"
+    assert format_bytes(10**12) == "1.00 TB"
+    assert format_bytes(10**15) == "1.00 PB"
 
 
 def test_add_placeholder_row():