kleinkram 0.43.6.dev20250401131403__tar.gz → 0.44.0.dev20250407065841__tar.gz

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kleinkram
-Version: 0.43.6.dev20250401131403
+Version: 0.44.0.dev20250407065841
 Summary: give me your bags
 Author: Cyrill Püntener, Dominique Garmier, Johann Schwabe
 Author-email: pucyril@ethz.ch, dgarmier@ethz.ch, jschwab@ethz.ch

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/api/file_transfer.py

@@ -309,10 +309,10 @@ def download_file(
     if path.exists():
         local_hash = b64_md5(path)
         if local_hash != file.hash and not overwrite and file.hash is not None:
-            return DownloadState.SKIPPED_INVALID_HASH
+            return DownloadState.SKIPPED_INVALID_HASH, 0
 
         elif local_hash == file.hash:
-            return DownloadState.SKIPPED_OK
+            return DownloadState.SKIPPED_OK, 0
 
         # this has to be here
         if verbose:

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/cli/_verify.py

@@ -32,7 +32,15 @@ def verify(
         None, "--project", "-p", help="project id or name"
     ),
     mission: str = typer.Option(..., "--mission", "-m", help="mission id or name"),
-    skip_hash: bool = typer.Option(False, help="skip hash check"),
+    skip_hash: bool = typer.Option(None, help="skip hash check"),
+    check_file_hash: bool = typer.Option(
+        True,
+        help="check file hash. If True, file names and file hashes are checked.",
+    ),
+    check_file_size: bool = typer.Option(
+        True,
+        help="check file size. If True, file names and file sizes are checked.",
+    ),
 ) -> None:
     # get all filepaths
     file_paths = [Path(file) for file in files]
@@ -51,6 +59,8 @@ def verify(
         query=mission_query,
         file_paths=file_paths,
         skip_hash=skip_hash,
+        check_file_hash=check_file_hash,
+        check_file_size=check_file_size,
         verbose=verbose,
     )
     print_file_verification_status(file_status, pprint=verbose)

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/core.py

@@ -133,9 +133,20 @@ def verify(
     client: AuthenticatedClient,
     query: MissionQuery,
     file_paths: Sequence[Path],
-    skip_hash: bool = False,
+    skip_hash: Optional[bool] = None,
+    check_file_hash: bool = True,
+    check_file_size: bool = False,
     verbose: bool = False,
 ) -> Dict[Path, FileVerificationStatus]:
+
+    # add deprecated warning for skip_hash
+    if skip_hash is not None:
+        print(
+            "Warning: --skip-hash is deprecated and will be removed in a future version. "
+            "Use --check-file-hash=False instead.",
+        )
+        check_file_hash = not skip_hash
+
     # check that file paths are for valid files and have valid suffixes
     check_file_paths(file_paths)
 
@@ -167,14 +178,30 @@ def verify(
         if remote_file.state == FileState.UPLOADING:
             file_status[file] = FileVerificationStatus.UPLOADING
         elif remote_file.state == FileState.OK:
-            if remote_file.hash is None:
-                file_status[file] = FileVerificationStatus.COMPUTING_HASH
-            elif skip_hash or remote_file.hash == b64_md5(file):
-                file_status[file] = FileVerificationStatus.UPLAODED
-            else:
-                file_status[file] = FileVerificationStatus.MISMATCHED_HASH
+
+            # default case, will be overwritten if we find a mismatch
+            file_status[file] = FileVerificationStatus.UPLAODED
+
+            if check_file_size:
+                if remote_file.size == file.stat().st_size:
+                    file_status[file] = FileVerificationStatus.UPLAODED
+                else:
+                    file_status[file] = FileVerificationStatus.MISMATCHED_SIZE
+
+            if file_status[file] != FileVerificationStatus.UPLAODED:
+                continue  # abort if we already found a mismatch
+
+            if check_file_hash:
+                if remote_file.hash is None:
+                    file_status[file] = FileVerificationStatus.COMPUTING_HASH
+                elif remote_file.hash == b64_md5(file):
+                    file_status[file] = FileVerificationStatus.UPLAODED
+                else:
+                    file_status[file] = FileVerificationStatus.MISMATCHED_HASH
+
         else:
             file_status[file] = FileVerificationStatus.UNKNOWN
+
     return file_status
 
 

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/models.py

@@ -82,4 +82,5 @@ class FileVerificationStatus(str, Enum):
     COMPUTING_HASH = "computing hash"
     MISSING = "missing"
     MISMATCHED_HASH = "hash mismatch"
+    MISMATCHED_SIZE = "size mismatch"
     UNKNOWN = "unknown"

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/printing.py

@@ -42,6 +42,7 @@ FILE_VERIFICATION_STATUS_STYLES = {
     FileVerificationStatus.UPLOADING: "yellow",
     FileVerificationStatus.MISSING: "yellow",
     FileVerificationStatus.MISMATCHED_HASH: "red",
+    FileVerificationStatus.MISMATCHED_SIZE: "red",
     FileVerificationStatus.UNKNOWN: "gray",
     FileVerificationStatus.COMPUTING_HASH: "purple",
 }

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram/wrappers.py

@@ -9,7 +9,7 @@ conversion to the internal representation
 from __future__ import annotations
 
 from pathlib import Path
-from typing import Collection
+from typing import Collection, Any
 from typing import Dict
 from typing import List
 from typing import Literal
@@ -39,6 +39,11 @@ def _args_to_project_query(
     project_names: Optional[Sequence[str]] = None,
     project_ids: Optional[Sequence[IdLike]] = None,
 ) -> ProjectQuery:
+
+    # verify types of passed arguments
+    _verify_string_sequence("project_names", project_names)
+    _verify_sequence("project_ids", project_ids)
+
     return ProjectQuery(
         ids=[parse_uuid_like(_id) for _id in project_ids or []],
         patterns=list(project_names or []),
@@ -51,6 +56,13 @@ def _args_to_mission_query(
     project_names: Optional[Sequence[str]] = None,
     project_ids: Optional[Sequence[IdLike]] = None,
 ) -> MissionQuery:
+
+    # verify types of passed arguments
+    _verify_string_sequence("mission_names", mission_names)
+    _verify_sequence("mission_ids", mission_ids)
+    _verify_string_sequence("project_names", project_names)
+    _verify_sequence("project_ids", project_ids)
+
     return MissionQuery(
         ids=[parse_uuid_like(_id) for _id in mission_ids or []],
         patterns=list(mission_names or []),
@@ -60,6 +72,27 @@ def _args_to_mission_query(
     )
 
 
+def _verify_sequence(arg_name: str, arg_value: Optional[Sequence[Any]]) -> None:
+    """Verifies that an argument is either None, or a sequence."""
+    if arg_value is not None:
+        if not isinstance(arg_value, Sequence):
+            raise TypeError(f"{arg_name} must be a Sequence, None, or empty array.")
+
+
+def _verify_string_sequence(arg_name: str, arg_value: Optional[Sequence[Any]]) -> None:
+    """Verifies that an argument is either None, an empty sequence, or a sequence of strings."""
+    if arg_value is not None:
+        if not isinstance(arg_value, Sequence):
+            raise TypeError(f"{arg_name} must be a Sequence, None, or empty array.")
+        if isinstance(arg_value, str):
+            raise TypeError(
+                f"{arg_name} cannot be a string, but a sequence of strings."
+            )
+        for item in arg_value:
+            if not isinstance(item, str):
+                raise TypeError(f"{arg_name} must contain strings only.")
+
+
 def _args_to_file_query(
     file_names: Optional[Sequence[str]] = None,
     file_ids: Optional[Sequence[IdLike]] = None,
@@ -68,6 +101,15 @@ def _args_to_file_query(
     project_names: Optional[Sequence[str]] = None,
     project_ids: Optional[Sequence[IdLike]] = None,
 ) -> FileQuery:
+
+    # verify types of passed arguments
+    _verify_string_sequence("file_names", file_names)
+    _verify_sequence("file_ids", file_ids)
+    _verify_string_sequence("mission_names", mission_names)
+    _verify_sequence("mission_ids", mission_ids)
+    _verify_string_sequence("project_names", project_names)
+    _verify_sequence("project_ids", project_ids)
+
     return FileQuery(
         ids=[parse_uuid_like(_id) for _id in file_ids or []],
         patterns=list(file_names or []),
@@ -288,6 +330,9 @@ def verify(
         project_names=singleton_list(project_name),
         project_ids=singleton_list(project_id),
     )
+
+    _verify_string_sequence("files", files)
+
     return kleinkram.core.verify(
         client=AuthenticatedClient(),
         query=query,

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/kleinkram.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kleinkram
-Version: 0.43.6.dev20250401131403
+Version: 0.44.0.dev20250407065841
 Summary: give me your bags
 Author: Cyrill Püntener, Dominique Garmier, Johann Schwabe
 Author-email: pucyril@ethz.ch, dgarmier@ethz.ch, jschwab@ethz.ch

{kleinkram-0.43.6.dev20250401131403 → kleinkram-0.44.0.dev20250407065841}/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = kleinkram
-version = 0.43.6-dev20250401131403
+version = 0.44.0-dev20250407065841
 description = give me your bags
 long_description = file: README.md
 long_description_content_type = text/markdown