kicad-sch-api 0.3.5__tar.gz → 0.4.0__tar.gz

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/CHANGELOG.md

@@ -5,6 +5,71 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.0] - 2025-10-26
+
+### Added
+- **Phase 4 Manager Architecture**: Complete refactoring of schematic data management
+  - Introduced `ComponentManager` for component operations and lib_symbols synchronization
+  - Introduced `WireManager` for wire and bus operations
+  - Introduced `JunctionManager` for junction operations
+  - Introduced `SheetManager` for hierarchical sheet management
+  - Introduced `TextElementManager` for label and text operations
+  - Introduced `GraphicsManager` for graphical elements (rectangles, circles, arcs, polylines)
+  - Composition-based architecture replacing monolithic schematic class
+
+- **Text Box Support**: Full text box functionality with complete KiCAD compatibility
+  - `add_text_box()` method with rotation, font size, margins, and justification
+  - Support for stroke styling and fill options
+  - Proper serialization matching KiCAD format exactly
+
+- **Enhanced Hierarchical Sheet Support**: Complete sheet management functionality
+  - Sheet creation with proper position, size, and styling
+  - Sheet pin management with multiple pin types (input, output, bidirectional, tri_state, passive)
+  - Sheet hierarchy validation and traversal
+  - Proper data structure matching KiCAD parser expectations
+
+- **Rectangle Color Support**: Full color support for graphical rectangles
+  - Stroke color customization (RGBA)
+  - Fill color customization (RGBA)
+  - Proper color serialization in S-expression output
+
+### Fixed
+- **Hierarchical Sheet Data Structure**: Fixed sheet serialization format
+  - Changed storage key from "sheet" (singular) to "sheets" (plural)
+  - Fixed position format from lists to dictionaries: `{"x": x, "y": y}`
+  - Fixed size format from lists to dictionaries: `{"width": w, "height": h}`
+  - Fixed fill_color default from white (255,255,255,0.0) to transparent black (0,0,0,0.0)
+  - Fixed sheet pin structure: "pin" → "pins", "shape" → "pin_type"
+
+- **Rectangle Color Flow**: Fixed color parameter propagation through managers and parser
+  - GraphicsManager now extracts and stores stroke_color and fill_color from stroke/fill dicts
+  - Parser now serializes colors in stroke and fill S-expression sections
+  - Complete color support for bounding box visualization
+
+- **Text Box Data Structure**: Fixed text box format to match parser expectations
+  - Changed storage key from "text_box" to "text_boxes" (plural)
+  - Implemented complete parameter set (rotation, font_size, margins, stroke, fill, justification)
+  - Fixed position/size format to use dictionaries instead of lists
+
+### Changed
+- **Schematic Class Refactoring**: Delegated operations to specialized managers
+  - Schematic class now composes managers instead of implementing all operations
+  - Cleaner separation of concerns and improved maintainability
+  - All existing APIs maintained for backward compatibility
+
+- **Test Suite**: All 302 tests passing (295 run, 7 skipped)
+  - Added tests for hierarchical sheets with proper serialization
+  - Added tests for rectangle colors with stroke and fill
+  - Added tests for text boxes with full parameter support
+  - Format preservation tests validate exact KiCAD compatibility
+
+### Technical Notes
+- Manager architecture enables easier feature additions and maintenance
+- All data structures now properly synchronized between managers and parser
+- Singular/plural key consistency enforced throughout codebase
+- Position and size formats standardized to dictionary format
+- 100% backward compatibility maintained - no breaking changes
+
 ## [0.3.0] - 2025-10-12
 
 ### Added

{kicad_sch_api-0.3.5/kicad_sch_api.egg-info → kicad_sch_api-0.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kicad-sch-api
-Version: 0.3.5
+Version: 0.4.0
 Summary: Professional KiCAD schematic manipulation library with exact format preservation
 Author-email: Circuit-Synth <shane@circuit-synth.com>
 Maintainer-email: Circuit-Synth <shane@circuit-synth.com>

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/__init__.py

@@ -8,9 +8,9 @@ indexing, performance optimization, and management capabilities.
 
 from .base import IndexedCollection
 from .components import ComponentCollection
-from .wires import WireCollection
 from .junctions import JunctionCollection
 from .labels import LabelCollection
+from .wires import WireCollection
 
 __all__ = [
     "IndexedCollection",
@@ -18,4 +18,4 @@ __all__ = [
     "WireCollection",
     "JunctionCollection",
     "LabelCollection",
-]
+]

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/base.py

@@ -11,7 +11,7 @@ from typing import Any, Callable, Dict, Generic, Iterator, List, Optional, TypeV
 
 logger = logging.getLogger(__name__)
 
-T = TypeVar('T')  # Type variable for collection items
+T = TypeVar("T")  # Type variable for collection items
 
 
 class IndexedCollection(Generic[T], ABC):
@@ -183,6 +183,7 @@ class IndexedCollection(Generic[T], ABC):
         Returns:
             List of matching items
         """
+
         def matches_criteria(item: T) -> bool:
             for attr, value in criteria.items():
                 if not hasattr(item, attr) or getattr(item, attr) != value:
@@ -257,10 +258,7 @@ class IndexedCollection(Generic[T], ABC):
     def _rebuild_indexes(self) -> None:
         """Rebuild all indexes."""
         # Rebuild UUID index
-        self._uuid_index = {
-            self._get_item_uuid(item): i
-            for i, item in enumerate(self._items)
-        }
+        self._uuid_index = {self._get_item_uuid(item): i for i, item in enumerate(self._items)}
 
         # Let subclasses rebuild their additional indexes
         self._build_additional_indexes()
@@ -282,7 +280,7 @@ class IndexedCollection(Generic[T], ABC):
             "uuid_index_size": len(self._uuid_index),
             "modified": self._modified,
             "indexes_dirty": self._dirty_indexes,
-            "collection_type": self.__class__.__name__
+            "collection_type": self.__class__.__name__,
         }
 
     @property
@@ -293,4 +291,4 @@ class IndexedCollection(Generic[T], ABC):
     def mark_clean(self) -> None:
         """Mark collection as clean (not modified)."""
         self._modified = False
-        logger.debug(f"Marked {self.__class__.__name__} as clean")
+        logger.debug(f"Marked {self.__class__.__name__} as clean")

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/components.py

@@ -250,6 +250,7 @@ class ComponentCollection(IndexedCollection[Component]):
 
         # Always snap component position to KiCAD grid (1.27mm = 50mil)
         from ..core.geometry import snap_to_grid
+
         snapped_pos = snap_to_grid((position.x, position.y), grid_size=1.27)
         position = Point(snapped_pos[0], snapped_pos[1])
 
@@ -269,7 +270,7 @@ class ComponentCollection(IndexedCollection[Component]):
             in_bom=True,
             on_board=True,
             footprint=footprint,
-            properties=properties.copy()
+            properties=properties.copy(),
         )
 
         # Create component wrapper
@@ -335,16 +336,27 @@ class ComponentCollection(IndexedCollection[Component]):
 
         # Map common component types to standard prefixes
         ref_prefixes = {
-            "R": "R", "Resistor": "R",
-            "C": "C", "Capacitor": "C",
-            "L": "L", "Inductor": "L",
-            "D": "D", "Diode": "D",
-            "Q": "Q", "Transistor": "Q",
-            "U": "U", "IC": "U", "Amplifier": "U",
-            "J": "J", "Connector": "J",
-            "SW": "SW", "Switch": "SW",
-            "F": "F", "Fuse": "F",
-            "TP": "TP", "TestPoint": "TP",
+            "R": "R",
+            "Resistor": "R",
+            "C": "C",
+            "Capacitor": "C",
+            "L": "L",
+            "Inductor": "L",
+            "D": "D",
+            "Diode": "D",
+            "Q": "Q",
+            "Transistor": "Q",
+            "U": "U",
+            "IC": "U",
+            "Amplifier": "U",
+            "J": "J",
+            "Connector": "J",
+            "SW": "SW",
+            "Switch": "SW",
+            "F": "F",
+            "Fuse": "F",
+            "TP": "TP",
+            "TestPoint": "TP",
         }
 
         prefix = ref_prefixes.get(base_ref, "U")
@@ -419,4 +431,4 @@ class ComponentCollection(IndexedCollection[Component]):
         self._mark_indexes_dirty()
 
         logger.info(f"Bulk updated {len(matching_components)} components")
-        return len(matching_components)
+        return len(matching_components)

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/junctions.py

@@ -89,26 +89,22 @@ class JunctionCollection(IndexedCollection[Junction]):
         pos_key = (position.x, position.y)
         if pos_key in self._position_index:
             existing = self._position_index[pos_key]
-            raise ValueError(f"Junction already exists at position {position} (UUID: {existing.uuid})")
+            raise ValueError(
+                f"Junction already exists at position {position} (UUID: {existing.uuid})"
+            )
 
         # Generate UUID if not provided
         if junction_uuid is None:
             junction_uuid = str(uuid_module.uuid4())
 
         # Create junction
-        junction = Junction(
-            uuid=junction_uuid,
-            position=position,
-            diameter=diameter
-        )
+        junction = Junction(uuid=junction_uuid, position=position, diameter=diameter)
 
         # Add to collection using base class method
         return super().add(junction)
 
     def get_junction_at_position(
-        self,
-        position: Union[Point, Tuple[float, float]],
-        tolerance: float = 0.0
+        self, position: Union[Point, Tuple[float, float]], tolerance: float = 0.0
     ) -> Optional[Junction]:
         """
         Get junction at a specific position.
@@ -137,7 +133,7 @@ class JunctionCollection(IndexedCollection[Junction]):
             for junction in self._items:
                 dx = abs(junction.position.x - target_x)
                 dy = abs(junction.position.y - target_y)
-                distance = (dx ** 2 + dy ** 2) ** 0.5
+                distance = (dx**2 + dy**2) ** 0.5
 
                 if distance <= tolerance:
                     return junction
@@ -145,9 +141,7 @@ class JunctionCollection(IndexedCollection[Junction]):
             return None
 
     def has_junction_at_position(
-        self,
-        position: Union[Point, Tuple[float, float]],
-        tolerance: float = 0.0
+        self, position: Union[Point, Tuple[float, float]], tolerance: float = 0.0
     ) -> bool:
         """
         Check if a junction exists at a specific position.
@@ -162,11 +156,7 @@ class JunctionCollection(IndexedCollection[Junction]):
         return self.get_junction_at_position(position, tolerance) is not None
 
     def find_junctions_in_region(
-        self,
-        min_x: float,
-        min_y: float,
-        max_x: float,
-        max_y: float
+        self, min_x: float, min_y: float, max_x: float, max_y: float
     ) -> List[Junction]:
         """
         Find all junctions within a rectangular region.
@@ -183,16 +173,13 @@ class JunctionCollection(IndexedCollection[Junction]):
         matching_junctions = []
 
         for junction in self._items:
-            if (min_x <= junction.position.x <= max_x and
-                min_y <= junction.position.y <= max_y):
+            if min_x <= junction.position.x <= max_x and min_y <= junction.position.y <= max_y:
                 matching_junctions.append(junction)
 
         return matching_junctions
 
     def update_junction_position(
-        self,
-        junction_uuid: str,
-        new_position: Union[Point, Tuple[float, float]]
+        self, junction_uuid: str, new_position: Union[Point, Tuple[float, float]]
     ) -> bool:
         """
         Update the position of an existing junction.
@@ -286,8 +273,9 @@ class JunctionCollection(IndexedCollection[Junction]):
 
             # Allow small tolerance for floating point precision
             tolerance = grid_size * 0.01
-            if (x_remainder > tolerance and x_remainder < grid_size - tolerance) or \
-               (y_remainder > tolerance and y_remainder < grid_size - tolerance):
+            if (x_remainder > tolerance and x_remainder < grid_size - tolerance) or (
+                y_remainder > tolerance and y_remainder < grid_size - tolerance
+            ):
                 misaligned.append(junction)
 
         return misaligned
@@ -310,8 +298,10 @@ class JunctionCollection(IndexedCollection[Junction]):
             aligned_y = round(junction.position.y / grid_size) * grid_size
 
             # Check if position needs to change
-            if (abs(junction.position.x - aligned_x) > 0.001 or
-                abs(junction.position.y - aligned_y) > 0.001):
+            if (
+                abs(junction.position.x - aligned_x) > 0.001
+                or abs(junction.position.y - aligned_y) > 0.001
+            ):
 
                 # Update position
                 junction.position = Point(aligned_x, aligned_y)
@@ -326,11 +316,7 @@ class JunctionCollection(IndexedCollection[Junction]):
 
     # Bulk operations
     def remove_junctions_in_region(
-        self,
-        min_x: float,
-        min_y: float,
-        max_x: float,
-        max_y: float
+        self, min_x: float, min_y: float, max_x: float, max_y: float
     ) -> int:
         """
         Remove all junctions within a rectangular region.
@@ -365,14 +351,16 @@ class JunctionCollection(IndexedCollection[Junction]):
         # Calculate diameter statistics
         diameters = [junction.diameter for junction in self._items]
         if diameters:
-            stats.update({
-                "diameter_stats": {
-                    "min": min(diameters),
-                    "max": max(diameters),
-                    "average": sum(diameters) / len(diameters)
-                },
-                "grid_aligned": len(self._items) - len(self.validate_grid_alignment()),
-                "misaligned": len(self.validate_grid_alignment())
-            })
-
-        return stats
+            stats.update(
+                {
+                    "diameter_stats": {
+                        "min": min(diameters),
+                        "max": max(diameters),
+                        "average": sum(diameters) / len(diameters),
+                    },
+                    "grid_aligned": len(self._items) - len(self.validate_grid_alignment()),
+                    "misaligned": len(self.validate_grid_alignment()),
+                }
+            )
+
+        return stats

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/labels.py

@@ -25,7 +25,7 @@ class Label:
         position: Point,
         rotation: float = 0.0,
         label_type: str = "label",
-        effects: Optional[Dict[str, Any]] = None
+        effects: Optional[Dict[str, Any]] = None,
     ):
         self.uuid = uuid
         self.text = text
@@ -150,7 +150,7 @@ class LabelCollection(IndexedCollection[Label]):
             position=position,
             rotation=rotation,
             label_type=label_type,
-            effects=effects or {}
+            effects=effects or {},
         )
 
         # Add to collection using base class method
@@ -176,9 +176,7 @@ class LabelCollection(IndexedCollection[Label]):
             return self._text_index.get(text_key, []).copy()
 
     def get_labels_at_position(
-        self,
-        position: Union[Point, Tuple[float, float]],
-        tolerance: float = 0.0
+        self, position: Union[Point, Tuple[float, float]], tolerance: float = 0.0
     ) -> List[Label]:
         """
         Get all labels at a specific position.
@@ -208,7 +206,7 @@ class LabelCollection(IndexedCollection[Label]):
             for label in self._items:
                 dx = abs(label.position.x - target_x)
                 dy = abs(label.position.y - target_y)
-                distance = (dx ** 2 + dy ** 2) ** 0.5
+                distance = (dx**2 + dy**2) ** 0.5
 
                 if distance <= tolerance:
                     matching_labels.append(label)
@@ -251,11 +249,7 @@ class LabelCollection(IndexedCollection[Label]):
         return self.get_labels_by_text(net_name, case_sensitive)
 
     def find_labels_in_region(
-        self,
-        min_x: float,
-        min_y: float,
-        max_x: float,
-        max_y: float
+        self, min_x: float, min_y: float, max_x: float, max_y: float
     ) -> List[Label]:
         """
         Find all labels within a rectangular region.
@@ -272,8 +266,7 @@ class LabelCollection(IndexedCollection[Label]):
         matching_labels = []
 
         for label in self._items:
-            if (min_x <= label.position.x <= max_x and
-                min_y <= label.position.y <= max_y):
+            if min_x <= label.position.x <= max_x and min_y <= label.position.y <= max_y:
                 matching_labels.append(label)
 
         return matching_labels
@@ -308,9 +301,7 @@ class LabelCollection(IndexedCollection[Label]):
         return True
 
     def update_label_position(
-        self,
-        label_uuid: str,
-        new_position: Union[Point, Tuple[float, float]]
+        self, label_uuid: str, new_position: Union[Point, Tuple[float, float]]
     ) -> bool:
         """
         Update the position of an existing label.
@@ -399,14 +390,15 @@ class LabelCollection(IndexedCollection[Label]):
         stats = super().get_statistics()
 
         # Add label-specific statistics
-        stats.update({
-            "unique_texts": len(self._text_index),
-            "unique_positions": len(self._position_index),
-            "label_types": {
-                label_type: len(labels)
-                for label_type, labels in self._type_index.items()
-            },
-            "net_count": len(self.get_net_names())
-        })
-
-        return stats
+        stats.update(
+            {
+                "unique_texts": len(self._text_index),
+                "unique_positions": len(self._position_index),
+                "label_types": {
+                    label_type: len(labels) for label_type, labels in self._type_index.items()
+                },
+                "net_count": len(self.get_net_names()),
+            }
+        )
+
+        return stats

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/collections/wires.py

@@ -65,7 +65,7 @@ class WireCollection(IndexedCollection[Wire]):
                 self._endpoint_index[endpoint].append(wire)
 
             # Type index
-            wire_type = getattr(wire, 'wire_type', WireType.WIRE)
+            wire_type = getattr(wire, "wire_type", WireType.WIRE)
             if wire_type not in self._type_index:
                 self._type_index[wire_type] = []
             self._type_index[wire_type].append(wire)
@@ -114,7 +114,7 @@ class WireCollection(IndexedCollection[Wire]):
             points=[start, end],
             wire_type=wire_type,
             stroke_width=stroke_width,
-            stroke_type=stroke_type
+            stroke_type=stroke_type,
         )
 
         # Add to collection using base class method
@@ -165,7 +165,7 @@ class WireCollection(IndexedCollection[Wire]):
             points=converted_points,
             wire_type=wire_type,
             stroke_width=stroke_width,
-            stroke_type=stroke_type
+            stroke_type=stroke_type,
         )
 
         # Add to collection using base class method
@@ -262,9 +262,7 @@ class WireCollection(IndexedCollection[Wire]):
         return networks
 
     def modify_wire_path(
-        self,
-        wire_uuid: str,
-        new_points: List[Union[Point, Tuple[float, float]]]
+        self, wire_uuid: str, new_points: List[Union[Point, Tuple[float, float]]]
     ) -> bool:
         """
         Modify the path of an existing wire.
@@ -325,7 +323,7 @@ class WireCollection(IndexedCollection[Wire]):
         self,
         wire_type: Optional[WireType] = None,
         stroke_width: Optional[float] = None,
-        stroke_type: Optional[str] = None
+        stroke_type: Optional[str] = None,
     ) -> int:
         """
         Bulk update stroke properties for wires.
@@ -368,15 +366,16 @@ class WireCollection(IndexedCollection[Wire]):
         stats = super().get_statistics()
 
         # Add wire-specific statistics
-        stats.update({
-            "endpoint_count": len(self._endpoint_index),
-            "wire_types": {
-                wire_type.value: len(wires)
-                for wire_type, wires in self._type_index.items()
-            },
-            "networks": len(self.find_wire_networks()),
-            "total_length": sum(self._calculate_wire_length(wire) for wire in self._items)
-        })
+        stats.update(
+            {
+                "endpoint_count": len(self._endpoint_index),
+                "wire_types": {
+                    wire_type.value: len(wires) for wire_type, wires in self._type_index.items()
+                },
+                "networks": len(self.find_wire_networks()),
+                "total_length": sum(self._calculate_wire_length(wire) for wire in self._items),
+            }
+        )
 
         return stats
 
@@ -400,8 +399,8 @@ class WireCollection(IndexedCollection[Wire]):
 
             dx = end_point.x - start_point.x
             dy = end_point.y - start_point.y
-            segment_length = (dx ** 2 + dy ** 2) ** 0.5
+            segment_length = (dx**2 + dy**2) ** 0.5
 
             total_length += segment_length
 
-        return total_length
+        return total_length

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/core/components.py

@@ -38,6 +38,11 @@ class Component:
         self._validator = SchematicValidator()
 
     # Core properties with validation
+    @property
+    def uuid(self) -> str:
+        """Component UUID."""
+        return self._data.uuid
+
     @property
     def reference(self) -> str:
         """Component reference (e.g., 'R1')."""

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/core/formatter.py

@@ -55,7 +55,9 @@ class ExactFormatter:
         self.rules["generator"] = FormatRule(inline=True, quote_indices={1})
         self.rules["generator_version"] = FormatRule(inline=True, quote_indices={1})
         self.rules["uuid"] = FormatRule(inline=True, quote_indices={1})
-        self.rules["paper"] = FormatRule(inline=True, quote_indices={1})  # Paper size should be quoted per KiCad format
+        self.rules["paper"] = FormatRule(
+            inline=True, quote_indices={1}
+        )  # Paper size should be quoted per KiCad format
 
         # Title block
         self.rules["title_block"] = FormatRule(inline=False)

{kicad_sch_api-0.3.5 → kicad_sch_api-0.4.0}/kicad_sch_api/core/labels.py

@@ -10,7 +10,7 @@ import uuid
 from typing import Any, Callable, Dict, Iterator, List, Optional, Tuple, Union
 
 from ..utils.validation import SchematicValidator, ValidationError, ValidationIssue
-from .types import Point, Label
+from .types import Label, Point
 
 logger = logging.getLogger(__name__)
 
@@ -345,4 +345,4 @@ class LabelCollection:
 
     def __bool__(self) -> bool:
         """Return True if collection has labels."""
-        return len(self._labels) > 0
+        return len(self._labels) > 0

kicad_sch_api-0.4.0/kicad_sch_api/core/managers/__init__.py

@@ -0,0 +1,26 @@
+"""
+Schematic management modules for separating responsibilities.
+
+This package contains specialized managers for different aspects of schematic
+manipulation, enabling clean separation of concerns and better maintainability.
+"""
+
+from .file_io import FileIOManager
+from .format_sync import FormatSyncManager
+from .graphics import GraphicsManager
+from .metadata import MetadataManager
+from .sheet import SheetManager
+from .text_elements import TextElementManager
+from .validation import ValidationManager
+from .wire import WireManager
+
+__all__ = [
+    "FileIOManager",
+    "FormatSyncManager",
+    "GraphicsManager",
+    "MetadataManager",
+    "SheetManager",
+    "TextElementManager",
+    "ValidationManager",
+    "WireManager",
+]