kernels 0.17.2__tar.gz → 0.17.3__tar.gz

{kernels-0.17.2 → kernels-0.17.3}/Cargo.lock

@@ -1056,7 +1056,7 @@ dependencies = [
 
 [[package]]
 name = "hf-kernel-builder"
-version = "0.17.2"
+version = "0.17.3"
 dependencies = [
  "base32",
  "built",
@@ -1537,7 +1537,7 @@ dependencies = [
 
 [[package]]
 name = "kernel-abi-check"
-version = "0.17.2"
+version = "0.17.3"
 dependencies = [
  "cpp_demangle",
  "eyre",
@@ -1551,7 +1551,7 @@ dependencies = [
 
 [[package]]
 name = "kernels-common"
-version = "0.17.2"
+version = "0.17.3"
 dependencies = [
  "base64",
  "digest",
@@ -1572,7 +1572,7 @@ dependencies = [
 
 [[package]]
 name = "kernels-python"
-version = "0.17.2"
+version = "0.17.3"
 dependencies = [
  "kernels-common",
  "pyo3",

{kernels-0.17.2 → kernels-0.17.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: kernels
-Version: 0.17.2
+Version: 0.17.3
 Requires-Dist: huggingface-hub>=1.10.0
 Requires-Dist: packaging>=20.0
 Requires-Dist: pyyaml>=6

{kernels-0.17.2 → kernels-0.17.3}/kernels/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "kernels-python"
-version = "0.17.2"
+version = "0.17.3"
 edition = "2024"
 description = "Kernels data structures (Python bindings)"
 homepage = "https://github.com/huggingface/kernels"
@@ -19,4 +19,4 @@ serde_json = "1"
 
 [dependencies.kernels-common]
 path = "../kernels-common"
-version = "0.17.2"
+version = "0.17.3"

{kernels-0.17.2 → kernels-0.17.3}/kernels/tests/test_variants.py

@@ -250,6 +250,42 @@ def test_resolve_rocm():
     assert {vs.variant for vs in trace} == set(RESOLVE_VARIANTS)
 
 
+ROCM_VARIANTS = [
+    parse_variant(f"torch215-cxx11-{rocm}-x86_64-linux") for rocm in ["rocm72", "rocm100", "rocm101", "rocm102"]
+]
+
+
+def _resolve_rocm(rocm_version: str):
+    return _resolve_variant_for_system(
+        variants=ROCM_VARIANTS,
+        selected_backend=ROCm(Version(rocm_version)),
+        cpu="x86_64",
+        os="linux",
+        torch_version=Version("2.15"),
+        torch_cxx11_abi=True,
+        tvm_ffi_version=None,
+    )
+
+
+def test_resolve_rocm_best_older_minor():
+    # Newest minor that is not newer than the system, same major only.
+    result, _ = _resolve_rocm("10.1")
+    assert [v.variant_str for v in result] == [
+        "torch215-cxx11-rocm101-x86_64-linux",
+        "torch215-cxx11-rocm100-x86_64-linux",
+    ]
+
+
+def test_resolve_rocm_no_different_major():
+    result, _ = _resolve_rocm("7.2")
+    assert [v.variant_str for v in result] == ["torch215-cxx11-rocm72-x86_64-linux"]
+
+
+def test_resolve_rocm_no_newer_minor():
+    result, _ = _resolve_rocm("10.0")
+    assert [v.variant_str for v in result] == ["torch215-cxx11-rocm100-x86_64-linux"]
+
+
 def test_resolve_cpu_linux():
     result, trace = _resolve_variant_for_system(
         variants=RESOLVE_VARIANTS,

{kernels-0.17.2 → kernels-0.17.3}/kernels/uv.lock

@@ -1158,7 +1158,7 @@ wheels = [
 
 [[package]]
 name = "kernels"
-version = "0.17.2"
+version = "0.17.3"
 source = { editable = "." }
 dependencies = [
     { name = "huggingface-hub" },

{kernels-0.17.2 → kernels-0.17.3}/kernels-common/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "kernels-common"
-version = "0.17.2"
+version = "0.17.3"
 edition = "2024"
 description = "Code shared by kernel-builder and kernels"
 homepage = "https://github.com/huggingface/kernels"

{kernels-0.17.2 → kernels-0.17.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "kernels"
-version = "0.17.2"
+version = "0.17.3"
 description = "Download compute kernels"
 authors = [
   { name = "Daniel de Kok", email = "daniel@huggingface.co" },

{kernels-0.17.2 → kernels-0.17.3}/src/kernels/backends.py

@@ -232,7 +232,12 @@ def _backend() -> Backend:
             cuda_version = Version(torch.version.cuda)
             return CUDA(version=cuda_version)
         elif torch.version.hip is not None:
-            rocm_version = Version(torch.version.hip.split("-")[0])
+            # Note: the ROCm version does not always match the HIP version
+            # (e.g. ROCm 10.0 uses HIP 7.15). So, we should use
+            # `torch.version.rocm`. However, this attribute is only available
+            # since Torch 2.10, so use `torch.version.hip` as a fallback.
+            rocm = getattr(torch.version, "rocm", None) or torch.version.hip
+            rocm_version = Version(rocm.split("-")[0])
             return ROCm(version=rocm_version)
         elif torch.backends.mps.is_available():
             return Metal()

{kernels-0.17.2 → kernels-0.17.3}/src/kernels/cli/benchmark.py

@@ -403,7 +403,8 @@ def collect_machine_info() -> MachineInfo:
             gpu = torch.cuda.get_device_name(0)
             # ROCm uses the CUDA API but has torch.version.hip
             if hasattr(torch.version, "hip") and torch.version.hip:
-                backend_type = f"ROCm {torch.version.hip}"
+                rocm_version = getattr(torch.version, "rocm", None) or torch.version.hip
+                backend_type = f"ROCm {rocm_version}"
             else:
                 backend_type = f"CUDA {torch.version.cuda}" if torch.version.cuda else "CUDA"
         elif backend_name == "xpu":

{kernels-0.17.2 → kernels-0.17.3}/src/kernels/variants.py

@@ -474,6 +474,20 @@ def _check_variants(
                         )
                     )
                     continue
+            # Same for ROCm: given a system ROCm version of x.y, only ROCm
+            # versions x.z, where z <= y qualify.
+            elif isinstance(selected_backend, ROCm) and isinstance(v.arch.backend, ROCm):
+                if (
+                    v.arch.backend.version.major != selected_backend.version.major
+                    or v.arch.backend.version.minor > selected_backend.version.minor
+                ):
+                    result.append(
+                        VariantRejected(
+                            variant=v,
+                            reason=f"ROCm version ({v.arch.backend.version}) is not compatible with system ROCm version ({selected_backend.version})",
+                        )
+                    )
+                    continue
             elif v.arch.backend.variant_str != selected_backend.variant_str:
                 result.append(
                     VariantRejected(