katalyst-plugin-context 0.2.1a3__tar.gz → 0.2.1a4__tar.gz

{katalyst_plugin_context-0.2.1a3 → katalyst_plugin_context-0.2.1a4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: katalyst-plugin-context
-Version: 0.2.1a3
+Version: 0.2.1a4
 Summary: Katalyst context plugin — the right context from the taxonomy for an agent working on a node
 Author: eSimplicity
 License: Proprietary

{katalyst_plugin_context-0.2.1a3 → katalyst_plugin_context-0.2.1a4}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "katalyst-plugin-context"
-version = "0.2.1a3"
+version = "0.2.1a4"
 description = "Katalyst context plugin — the right context from the taxonomy for an agent working on a node"
 license = { text = "Proprietary" }
 requires-python = ">=3.12"

{katalyst_plugin_context-0.2.1a3 → katalyst_plugin_context-0.2.1a4}/src/katalyst_plugin_context/domain/context.py

@@ -120,6 +120,7 @@ def _walk(
     policy: Policy,
     *,
     exclude: frozenset[str],
+    open_to_named: frozenset[str] = frozenset(),
     inherited: bool,
     parent_rel: str,
     collect_every_level: bool,
@@ -127,8 +128,10 @@ def _walk(
     """Every node reached from *start* by following *steps*, with the hops that reached it.
 
     A node never appears twice on one branch (cycles stop). *exclude* (the focus node and
-    its ancestors) is never reached. From an ancestor, its structural parent edges are
-    never followed: they would only reach siblings.
+    its ancestors) is never reached, except that a step which names its relationship
+    (not ``*``) may reach the nodes of *open_to_named*: asking for ``CHILD_OF:out`` is
+    asking for the ancestors. From an ancestor, its structural parent edges are never
+    followed: they would only reach siblings.
     """
     frontier: list[tuple[str, tuple[_Hop, ...]]] = [(start, ())]
     arrivals: list[_Arrival] = []
@@ -140,7 +143,11 @@ def _walk(
                 if inherited and index == 0 and neighbour.rel == parent_rel:
                     continue
                 other = graph.nodes[neighbour.other]
-                if neighbour.other in exclude or neighbour.other in on_branch:
+                if neighbour.other in on_branch:
+                    continue
+                if neighbour.other in exclude and not (
+                    step.rel != "*" and neighbour.other in open_to_named
+                ):
                     continue
                 if not step.matches(neighbour.rel, neighbour.direction, other.kind):
                     continue
@@ -491,7 +498,8 @@ def _collect(
     """Every item *sources* reach, at its best rank, and each view's and path's members.
 
     The ancestors are never items of a source that inherits, or of any source when the
-    call inherits; otherwise (inheritance off) they can be.
+    call inherits, unless a step names the relationship that reaches them; otherwise
+    (inheritance off) they can be.
     """
     entries: dict[str, _Entry] = {}
     group_members: dict[tuple[str | None, str], set[str]] = {}
@@ -508,6 +516,7 @@ def _collect(
                 steps,
                 policy,
                 exclude=exclude,
+                open_to_named=frozenset(ancestors),
                 inherited=start != focus,
                 parent_rel=schema.parent_rel,
                 collect_every_level=source.repeat > 1,

{katalyst_plugin_context-0.2.1a3 → katalyst_plugin_context-0.2.1a4}/tests/test_context.py

@@ -184,6 +184,43 @@ def test_an_always_view_keeps_its_inheritance_when_the_request_turns_it_off() ->
     assert "repo:d-region" in _names(result, view="governance")
 
 
+def test_a_path_that_names_the_parent_relationship_returns_the_ancestors_by_default() -> None:
+    """#303: the ancestors were items only with inheritance off; the default made the path dead."""
+    result = service().query(UNIT, ContextRequest(paths=("CHILD_OF:out",), depth=2))
+    assert result["effective"]["inherit"] is True
+    assert set(_names(result, view=None)) == {"repo:north.east", "repo:north"}
+    parent = next(i for i in result["items"] if i["qualifiedName"] == "repo:north.east")
+    assert (parent["path"], parent["inheritedFrom"]) == ("CHILD_OF:out", None)
+
+
+def test_a_declared_view_path_on_the_parent_relationship_returns_the_ancestors() -> None:
+    parents = {"title": "Parents", "paths": ["CHILD_OF:out"], "inherit": True}
+    settings = {
+        "views": {"governance": GOVERNANCE, "parents": parents},
+        "policy": {"always_include": ["governance"]},
+    }
+    result = service(registry(unit_settings=settings)).query(
+        UNIT, ContextRequest(views=("parents",))
+    )
+    assert set(_names(result, view="parents")) == {"repo:north.east"}
+
+
+def test_a_wildcard_step_never_returns_the_ancestors_with_inheritance_on() -> None:
+    result = service().query(UNIT, ContextRequest(paths=("*:out",)))
+    assert not {"repo:north.east", "repo:north"} & set(_names(result, view=None))
+    assert not {"repo:north.east", "repo:north"} & set(_names(result))
+
+
+def test_the_map_row_and_the_items_of_the_parent_path_agree() -> None:
+    mapped = service().map(UNIT)
+    row = next(
+        r for r in mapped["relationships"] if r["path"] == "CHILD_OF:out" and not r.get("inherited")
+    )
+    assert row["count"] == 1
+    items = service().query(UNIT, ContextRequest(paths=("CHILD_OF:out",)))["items"]
+    assert [i["qualifiedName"] for i in items if i["path"] == "CHILD_OF:out"] == ["repo:north.east"]
+
+
 def test_policy_can_take_an_always_view_out_and_says_which_layer() -> None:
     config: dict[str, Any] = {"policy": {"always_include": []}}
     svc = service(config=config)