jusi-shell 0.2.0__tar.gz → 0.2.2__tar.gz

jusi_shell-0.2.2/.gitignore

@@ -0,0 +1,4 @@
+__pycache__/
+.pytest_cache/
+dist/
+*.egg-info/

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: jusi-shell
-Version: 0.2.0
+Version: 0.2.2
 Summary: Shell plugin for Jusi
 Author: Jusi contributors
 License: MIT License

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "jusi-shell"
-version = "0.2.0"
+version = "0.2.2"
 description = "Shell plugin for Jusi"
 readme = "README.md"
 requires-python = ">=3.9"

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/src/jusi_shell/__init__.py

@@ -1,5 +1,5 @@
 """Jusi 1.0 interactive shell plugin."""
 
-__version__ = "0.2.0"
+__version__ = "0.2.2"
 
 __all__ = ["__version__"]

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/src/jusi_shell/completion.py

@@ -5,6 +5,13 @@ from pathlib import Path
 from typing import Any
 
 
+MAX_COMPLETION_ITEMS = 500
+
+
+class CompletionLimitExceeded(Exception):
+    """The completion would exceed Jusi's protocol item limit."""
+
+
 def _active_word(prefix: str) -> tuple[str, int]:
     line_start = prefix.rfind("\n") + 1
     line = prefix[line_start:]
@@ -39,6 +46,8 @@ def complete_paths(payload: dict[str, Any], cwd: str) -> dict[str, list[dict[str
     for entry in entries:
         if not entry.name.startswith(name_prefix):
             continue
+        if len(items) == MAX_COMPLETION_ITEMS:
+            raise CompletionLimitExceeded
         text = typed_parent + entry.name
         if entry.is_dir():
             text += "/"

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/src/jusi_shell/worker.py

@@ -11,7 +11,7 @@ from typing import Any
 
 from jusi.plugin_api import OperationRejected, WorkerResult, copy_text, open_text, show_diff, terminal_surface
 
-from .completion import complete_paths
+from .completion import CompletionLimitExceeded, MAX_COMPLETION_ITEMS, complete_paths
 from .control import exchange
 
 
@@ -40,7 +40,15 @@ class ShellWorker:
         if operation == "complete":
             status = self._request({"type": "status"})
             cwd = str(status.get("cwd", "")).strip() or self.cwd
-            return WorkerResult(complete_paths(payload, cwd))
+            try:
+                completion = complete_paths(payload, cwd)
+            except CompletionLimitExceeded:
+                raise OperationRejected(
+                    f"Path completion has more than {MAX_COMPLETION_ITEMS} matches; "
+                    "type more characters to narrow it down",
+                    reason="invalid_request",
+                ) from None
+            return WorkerResult(completion)
         if operation == "editor_action":
             return self._editor_action(payload)
         raise OperationRejected(f"Unsupported shell operation: {operation}", reason="unsupported")

{jusi_shell-0.2.0 → jusi_shell-0.2.2}/tests/test_shell_plugin.py

@@ -4,6 +4,7 @@ import json
 import os
 from pathlib import Path
 import pty
+import re
 import select
 import subprocess
 import sys
@@ -24,6 +25,15 @@ from jusi_shell.kernel import configure_jusi_runtime_v1, jusi_kernel_adapter_v1,
 from jusi_shell.worker import ShellWorker, _followup_body
 
 
+class VersionTest(unittest.TestCase):
+    def test_runtime_version_matches_project_metadata(self) -> None:
+        pyproject = Path(__file__).parents[1] / "pyproject.toml"
+        match = re.search(r'^version = "([^"]+)"$', pyproject.read_text(), re.MULTILINE)
+
+        self.assertIsNotNone(match)
+        self.assertEqual(match.group(1), __version__)
+
+
 class FakeIPython:
     def __init__(self) -> None:
         self.magics_manager = type("MagicsManager", (), {"magics": {"cell": {}}})()
@@ -137,6 +147,26 @@ class WorkerTest(unittest.TestCase):
             worker.handle("execute", {"cwd": "/definitely/not/a/jusi-shell-directory"})
         self.assertIsNone(worker.runtime_directory)
 
+    def test_too_many_completions_are_recoverable(self) -> None:
+        from jusi.plugin_api import OperationRejected
+
+        worker = ShellWorker(object())
+        with tempfile.TemporaryDirectory() as crowded, tempfile.TemporaryDirectory() as narrow:
+            for index in range(501):
+                Path(crowded, f"item-{index:03}").touch()
+            Path(narrow, "item-only").touch()
+
+            with patch.object(worker, "_request", side_effect=({"cwd": crowded}, {"cwd": narrow})):
+                with self.assertRaisesRegex(OperationRejected, "more than 500 matches") as raised:
+                    worker.handle("complete", {"prefix": "cat item-", "cursor_pos": len("cat item-")})
+                self.assertEqual("invalid_request", raised.exception.reason)
+
+                result = worker.handle(
+                    "complete", {"prefix": "cat item-", "cursor_pos": len("cat item-")}
+                )
+
+        self.assertEqual(["item-only"], [item["text"] for item in result.result["items"]])
+
     def test_editor_actions_export_content_not_paths(self) -> None:
         worker = ShellWorker(object())
         copied = worker.handle("editor_action", {"action": "copy", "selection": {"text": "/target/file"}})