ipor-fusion 4.0.0.dev206__tar.gz → 4.0.0.dev210__tar.gz

{ipor_fusion-4.0.0.dev206 → ipor_fusion-4.0.0.dev210}/MIGRATION_4.md

@@ -950,6 +950,13 @@ and `log_index` was passed through as given (a hex string from a raw log); the e
 These apply to every caller, type-checked or not. Changes described in full above
 are listed with a link.
 
+- **`CcipLane.open` refuses a spoke it cannot reach.** The executor's
+  `ccipRoute(spoke)` must be registered and point at the dispatcher at the
+  executor's own address; otherwise `open` (and `open_lane` / `open_lanes`)
+  raises `CrosschainDiscoveryError`, where 3.x built a lane whose default send
+  parameters carried a zero fee cap and gas limit and failed only on chain. A
+  registered but disabled route still opens, but `default_send` raises.
+
 - **The reconciliation counts the rewards claim manager.** `PlasmaVault.totalAssets`
   adds `RewardsClaimManager.balanceOf()` (vested rewards) to the vault's idle
   underlying and its markets; 3.x left it out, so a vault with vested rewards showed

{ipor_fusion-4.0.0.dev206 → ipor_fusion-4.0.0.dev210}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: ipor-fusion
-Version: 4.0.0.dev206
+Version: 4.0.0.dev210
 Summary: The IPOR Fusion SDK for Python
 Project-URL: homepage, https://ipor.io
 Project-URL: repository, https://github.com/IPOR-Labs/ipor-fusion.py

{ipor_fusion-4.0.0.dev206 → ipor_fusion-4.0.0.dev210}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "ipor-fusion"
-version = "4.0.0.dev206"
+version = "4.0.0.dev210"
 description = "The IPOR Fusion SDK for Python"
 authors = [
     { name = "Adam Mydlarz", email = "amydlarz@gmail.com" },

{ipor_fusion-4.0.0.dev206 → ipor_fusion-4.0.0.dev210}/src/ipor_fusion/crosschain/ccip/lane.py

@@ -22,7 +22,8 @@ from ipor_fusion.crosschain.fuses.ccip import (
 )
 from ipor_fusion.crosschain.lane import CrosschainLane, LaneFuses, LaneObservation
 from ipor_fusion.crosschain.messages import CommandStatus, CrosschainTransportKind
-from ipor_fusion.types import Amount, Period, ProposalId
+from ipor_fusion.errors import CrosschainDiscoveryError
+from ipor_fusion.types import Amount, ChainId, Period, ProposalId
 
 
 class CcipLane(CrosschainLane):
@@ -30,7 +31,12 @@ class CcipLane(CrosschainLane):
     send parameters come from the executor's registered ``route`` (fee
     ceiling, fee token, token or message gas limit). ``decimal_conversion_rate``
     is the executor's ``DECIMAL_CONVERSION_RATE`` (local per shared unit), used
-    to report the dispatcher observation in local decimals."""
+    to report the dispatcher observation in local decimals.
+
+    `open` refuses a spoke the executor has no route to, or whose route names
+    another peer than the dispatcher at the executor's address; a registered but
+    disabled route opens (state can still be read) and refuses the default send
+    parameters."""
 
     transport_kind = CrosschainTransportKind.CHAINLINK_CCIP
     enforces_min_received = False
@@ -77,13 +83,15 @@ class CcipLane(CrosschainLane):
         fuses: LaneFuses,
     ) -> CcipLane:
         hub_executor = CcipCrosschainExecutor(executor)
+        route = hub_executor.ccip_route(spoke_ctx.chain_id).call(hub_ctx)
+        _require_route_to_dispatcher(route, hub_executor.address, spoke_ctx.chain_id)
         return cls(
             hub_ctx=hub_ctx,
             spoke_ctx=spoke_ctx,
             executor=hub_executor,
             dispatcher=CcipCrosschainDispatcher(executor),
             fuses=fuses,
-            route=hub_executor.ccip_route(spoke_ctx.chain_id).call(hub_ctx),
+            route=route,
             decimal_conversion_rate=hub_executor.decimal_conversion_rate().call(
                 hub_ctx
             ),
@@ -93,6 +101,11 @@ class CcipLane(CrosschainLane):
         return self.executor.balance_staleness_max()
 
     def default_send(self, *, token: bool) -> CcipSendParams:
+        if not self.route.enabled:
+            raise CrosschainDiscoveryError(
+                f"CCIP route of executor {self.executor.address} to chain "
+                f"{self.spoke_chain_id} is disabled"
+            )
         return CcipSendParams.from_route(self.route, token=token)
 
     def default_command_send(self) -> CcipSendParams:
@@ -156,3 +169,19 @@ def _to_lane(observation: CcipObservation, rate: int) -> LaneObservation:
         command_config_epoch=observation.command_config_epoch,
         tracked_position_set_hash=observation.tracked_position_set_hash,
     )
+
+
+def _require_route_to_dispatcher(
+    route: CcipRouteConfig, executor: ChecksumAddress, spoke: ChainId
+) -> None:
+    """The executor sends to the dispatcher at its own address on the spoke; an
+    unregistered route reads back as all zeros."""
+    if route.chain_selector == 0 or int(route.peer, 16) == 0:
+        raise CrosschainDiscoveryError(
+            f"CCIP executor {executor} has no route to chain {spoke}"
+        )
+    if route.peer != executor:
+        raise CrosschainDiscoveryError(
+            f"CCIP executor {executor} routes chain {spoke} to {route.peer}, "
+            "not to the dispatcher at its own address"
+        )

{ipor_fusion-4.0.0.dev206 → ipor_fusion-4.0.0.dev210}/tests/test_crosschain_lane.py

@@ -3,7 +3,7 @@ the per-transport fuses encode, normalizes reads, and finds its own parts."""
 
 from __future__ import annotations
 
-from dataclasses import astuple
+from dataclasses import astuple, replace
 from unittest.mock import MagicMock
 
 import pytest
@@ -662,7 +662,8 @@ def _deployment_ctx() -> MagicMock:
     probe_vault = PlasmaVault(VAULT)
     probe_exec = StargateCrosschainExecutor(EXECUTOR)
     route_raw = encode(
-        ["(uint64,address,address,uint96,uint96,uint256,bool)"], [ROUTE.as_tuple()]
+        ["(uint64,address,address,uint96,uint96,uint256,bool)"],
+        [replace(ROUTE, peer=CCIP_EXECUTOR).as_tuple()],
     )
     by_selector: dict[tuple[str, bytes], bytes] = {
         (VAULT, _sel(probe_vault.get_market_substrates(MARKET))): encode(
@@ -845,7 +846,10 @@ class TestDeploymentDiscovery:
             CCIP_EXECUTOR,
         ]
         ccip = next(lane for lane in lanes if isinstance(lane, CcipLane))
-        assert ccip.route == ROUTE and ccip.fuses == CCIP_FUSES
+        assert (
+            ccip.route == replace(ROUTE, peer=CCIP_EXECUTOR)
+            and ccip.fuses == CCIP_FUSES
+        )
         assert ccip.decimal_conversion_rate == DECIMAL_CONVERSION_RATE
 
 
@@ -1036,6 +1040,57 @@ class TestContextOwnership:
         assert observation.accounted_balance == 7
         hub.call.assert_not_called()
 
+    def _ccip_hub(self, route: CcipRouteConfig) -> MagicMock:
+        return _ctx_answering(
+            {
+                selector("ccipRoute(uint256)"): encode(
+                    ["(uint64,address,address,uint96,uint96,uint256,bool)"],
+                    [route.as_tuple()],
+                ),
+                selector("DECIMAL_CONVERSION_RATE()"): encode(
+                    ["uint256"], [DECIMAL_CONVERSION_RATE]
+                ),
+            }
+        )
+
+    def test_ccip_open_refuses_a_spoke_without_a_route(self):
+        unregistered = CcipRouteConfig(
+            chain_selector=0,
+            peer=ZERO_ADDRESS,  # type: ignore[arg-type]
+            fee_token=ZERO_ADDRESS,  # type: ignore[arg-type]
+            message_gas_limit=0,
+            token_gas_limit=0,
+            max_fee=0,
+            enabled=False,
+        )
+        with pytest.raises(CrosschainDiscoveryError, match="has no route to chain"):
+            CcipLane.open(
+                self._ccip_hub(unregistered),
+                self._wrong_chain(SPOKE),
+                executor=EXECUTOR,
+                fuses=FUSES,
+            )
+
+    def test_ccip_open_refuses_a_route_to_another_peer(self):
+        foreign = replace(ROUTE, peer=REMOTE_VAULT)
+        with pytest.raises(CrosschainDiscoveryError, match="not to the dispatcher"):
+            CcipLane.open(
+                self._ccip_hub(foreign),
+                self._wrong_chain(SPOKE),
+                executor=EXECUTOR,
+                fuses=FUSES,
+            )
+
+    def test_a_disabled_route_opens_but_refuses_default_send(self):
+        lane = CcipLane.open(
+            self._ccip_hub(replace(ROUTE, enabled=False)),
+            self._wrong_chain(SPOKE),
+            executor=EXECUTOR,
+            fuses=FUSES,
+        )
+        with pytest.raises(CrosschainDiscoveryError, match="is disabled"):
+            lane.default_send(token=True)
+
     def test_ccip_open_reads_the_route_on_the_hub(self):
         route_raw = encode(
             ["(uint64,address,address,uint96,uint96,uint256,bool)"], [ROUTE.as_tuple()]