ipmg 3.1.2__tar.gz → 3.1.4__tar.gz

{ipmg-3.1.2/src/ipmg.egg-info → ipmg-3.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ipmg
-Version: 3.1.2
+Version: 3.1.4
 Summary: IP Management & Ping Monitoring CLI Tool
 Author: Sameer Alam
 Maintainer-email: Sameer Alam <sameeralam3127@gmail.com>

{ipmg-3.1.2 → ipmg-3.1.4}/pyproject.toml

@@ -13,7 +13,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ipmg"
-version = "3.1.2"  # Managed automatically by semantic-release
+version = "3.1.4"  # Managed automatically by semantic-release
 description = "IP Management & Ping Monitoring CLI Tool"
 readme = "README.md"
 requires-python = ">=3.9"

{ipmg-3.1.2 → ipmg-3.1.4}/src/ipmg/__init__.py

@@ -2,4 +2,4 @@
 ipmg - IP Management & Ping Monitoring Tool
 """
 
-__version__ = "3.1.2"
+__version__ = "3.1.4"

{ipmg-3.1.2 → ipmg-3.1.4}/src/ipmg/infrastructure/file_io.py

@@ -424,16 +424,22 @@ def _xlsx_cell(value: Any) -> Any:
 
 def _render_xlsx(table: ReportTable) -> bytes:
     from openpyxl import Workbook
+    from openpyxl.cell import WriteOnlyCell
 
-    workbook = Workbook()
-    sheet = workbook.active
-    sheet.title = "Sheet1"
+    # Write-only mode streams rows out. A normal sheet rescans every cell for
+    # max_row, which made a /16 take minutes to write (#102).
+    workbook = Workbook(write_only=True)
+    sheet = workbook.create_sheet("Sheet1")
     sheet.append(list(table.columns))
     for row in sanitize_table(table).rows:
-        sheet.append([_xlsx_cell(row.get(column)) for column in table.columns])
-        for cell in sheet[sheet.max_row]:
-            if isinstance(cell.value, datetime):
-                cell.number_format = _XLSX_DATETIME_FORMAT
+        cells = []
+        for column in table.columns:
+            value = _xlsx_cell(row.get(column))
+            if isinstance(value, datetime):
+                value = WriteOnlyCell(sheet, value=value)
+                value.number_format = _XLSX_DATETIME_FORMAT
+            cells.append(value)
+        sheet.append(cells)
     buffer = io.BytesIO()
     workbook.save(buffer)
     return buffer.getvalue()

{ipmg-3.1.2 → ipmg-3.1.4/src/ipmg.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ipmg
-Version: 3.1.2
+Version: 3.1.4
 Summary: IP Management & Ping Monitoring CLI Tool
 Author: Sameer Alam
 Maintainer-email: Sameer Alam <sameeralam3127@gmail.com>

{ipmg-3.1.2 → ipmg-3.1.4}/tests/test_file_io.py

@@ -1,4 +1,6 @@
 import json
+import time
+from datetime import datetime
 
 import openpyxl
 import pytest
@@ -187,6 +189,36 @@ def test_save_results_neutralizes_formulas_in_csv_and_xlsx(tmp_path, monkeypatch
     assert raw[0]["Hostname"] == HOSTILE_HOSTNAME
 
 
+def _xlsx_table(rows, checked):
+    return ReportTable(
+        rows=[
+            {"IP Address": f"10.0.{i // 256}.{i % 256}", "Status": "Up", "Checked At": checked}
+            for i in range(rows)
+        ],
+        columns=("IP Address", "Status", "Checked At"),
+    )
+
+
+def test_xlsx_writes_a_large_scan_in_linear_time(tmp_path, monkeypatch):
+    monkeypatch.setattr("ipmg.infrastructure.file_io.timestamp_str", lambda: "20260628_120000")
+    checked = datetime(2026, 6, 28, 12, 0, 0, 123456)
+
+    def seconds_to_save(rows):
+        started = time.perf_counter()
+        save_results(_xlsx_table(rows, checked), str(tmp_path / f"scan{rows}"), ["xlsx"])
+        return time.perf_counter() - started
+
+    # 4x the rows should take ~4x the time. The old writer rescanned the sheet
+    # for every row, so it took ~15x (#102). A ratio holds on slow CI runners.
+    small, large = seconds_to_save(2_000), seconds_to_save(8_000)
+    assert large < 8 * small
+
+    sheet = openpyxl.load_workbook(tmp_path / "scan8000_20260628_120000.xlsx").active
+    assert sheet.max_row == 8_001
+    assert sheet["C2"].value == checked.replace(microsecond=123000)
+    assert sheet["C2"].number_format == "YYYY-MM-DD HH:MM:SS"
+
+
 @pytest.mark.parametrize(
     "name", ["targts.txt", "hosts.list", "hosts.csv", "hosts.json", "hosts.xlsx", "hosts.xls"]
 )

{ipmg-3.1.2 → ipmg-3.1.4}/tests/test_notify.py

@@ -254,7 +254,6 @@ def test_smtp_user_with_security_none_is_allowed_for_loopback_hosts(loopback_hos
     assert settings.port == 25
 
 
-
 # ---------------------------------------------------------------- messages
 
 
@@ -553,7 +552,9 @@ def test_send_email_follows_the_security_setting(diff, fake_smtp, security, user
 
 
 def test_send_email_refuses_cleartext_auth_on_remote_host(diff, fake_smtp):
-    settings = SmtpSettings("mail.example.test", 25, "none", "ipmg@x.test", ("ops@x.test",), "u", "pw")
+    settings = SmtpSettings(
+        "mail.example.test", 25, "none", "ipmg@x.test", ("ops@x.test",), "u", "pw"
+    )
 
     with pytest.raises(NotifyError, match=r"starttls.*ssl"):
         send_email(settings, email_message(diff, settings))
@@ -567,4 +568,3 @@ def test_send_email_allows_cleartext_auth_on_loopback_host(diff, fake_smtp):
     send_email(settings, email_message(diff, settings))
 
     assert fake_smtp[0].calls == [("login", "u", "pw"), ("send", "ops@x.test"), "quit"]
-