invenio-app-ils 4.4.0__tar.gz → 4.6.0__tar.gz

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/CHANGES.rst

@@ -8,6 +8,15 @@
 Changes
 =======
 
+Version 4.6.0 (released 2025-06-25)
+
+- installation: remove breaking package version constraints
+
+Version 4.5.0 (released 2025-06-04)
+
+- closures: added endpoint for closure periods in a year
+- circulation: self-checkout of MISSING items marks them as CAN_CIRCULATE
+- tests: Fix comment on running tests by bumping Postgres & adding param
 
 Version 4.4.0 (released 2025-02-21)
 

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: invenio-app-ils
-Version: 4.4.0
+Version: 4.6.0
 Summary: Invenio Integrated Library System.
 Home-page: https://github.com/inveniosoftware/invenio-app-ils
 Author: CERN
@@ -47,7 +47,6 @@ Requires-Dist: invenio-stats<5.0.0,>=4.0.0
 Requires-Dist: Flask-Debugtoolbar<1.0.0,>=0.10.1
 Requires-Dist: pycountry<23.0.0,>=20.0.0
 Requires-Dist: simplejson<4.0.0,>=3.8.1
-Requires-Dist: pluggy<1.0.0,>=0.13.1
 Requires-Dist: jsonschema<5.0.0,>=4.3.0
 Requires-Dist: itsdangerous<2.1,>=1.1
 Requires-Dist: SQLAlchemy<2.0.0,>=1.3.0
@@ -66,6 +65,7 @@ Requires-Dist: lorem>=0.1.1; extra == "lorem"
 Provides-Extra: opensearch2
 Requires-Dist: invenio-search[opensearch2]<3.0.0,>=2.0.0; extra == "opensearch2"
 Provides-Extra: docs
+Dynamic: license-file
 
 ..
     Copyright (C) 2018-2020 CERN.
@@ -101,6 +101,15 @@ https://invenioils.docs.cern.ch
 Changes
 =======
 
+Version 4.6.0 (released 2025-06-25)
+
+- installation: remove breaking package version constraints
+
+Version 4.5.0 (released 2025-06-04)
+
+- closures: added endpoint for closure periods in a year
+- circulation: self-checkout of MISSING items marks them as CAN_CIRCULATE
+- tests: Fix comment on running tests by bumping Postgres & adding param
 
 Version 4.4.0 (released 2025-02-21)
 

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils/__init__.py

@@ -7,6 +7,6 @@
 
 """invenio-app-ils."""
 
-__version__ = "4.4.0"
+__version__ = "4.6.0"
 
 __all__ = ("__version__",)

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils/circulation/api.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 #
-# Copyright (C) 2018-2020 CERN.
+# Copyright (C) 2018-2025 CERN.
 #
 # invenio-app-ils is free software; you can redistribute it and/or modify it
 # under the terms of the MIT License; see LICENSE file for more details.
@@ -78,9 +78,9 @@ def _validate_delivery(delivery):
             )
 
 
-def _set_item_to_can_circulate(item_pid):
+def _set_item_to_can_circulate(item_pid_value):
     """Change the item status to CAN_CIRCULATE."""
-    item = Item.get_record_by_pid(item_pid["value"])
+    item = Item.get_record_by_pid(item_pid_value)
     if item["status"] != "CAN_CIRCULATE":
         item["status"] = "CAN_CIRCULATE"
         item.commit()
@@ -245,7 +245,7 @@ def checkout_loan(
         _validate_delivery(optional_delivery)
 
     if force:
-        _set_item_to_can_circulate(item_pid)
+        _set_item_to_can_circulate(item_pid["value"])
 
     return _checkout_loan(
         item_pid,
@@ -256,14 +256,19 @@ def checkout_loan(
     )
 
 
-def _ensure_item_loanable_via_self_checkout(item_pid):
+def _ensure_item_loanable_via_self_checkout(item_pid_value):
     """Self-checkout: return loanable item or raise when not loanable.
 
     Implements the self-checkout rules to loan an item.
     """
-    item = current_app_ils.item_record_cls.get_record_by_pid(item_pid)
+    item = current_app_ils.item_record_cls.get_record_by_pid(item_pid_value)
     item_dict = item.replace_refs()
 
+    if item_dict["status"] == "MISSING":
+        _set_item_to_can_circulate(item_pid_value)
+        item = current_app_ils.item_record_cls.get_record_by_pid(item_pid_value)
+        item_dict = item.replace_refs()
+
     if item_dict["status"] != "CAN_CIRCULATE":
         raise ItemCannotCirculateError()
 

invenio_app_ils-4.6.0/invenio_app_ils/closures/api.py

@@ -0,0 +1,134 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (C) 2020-2025 CERN.
+#
+# invenio-app-ils is free software; you can redistribute it and/or modify it
+# under the terms of the MIT License; see LICENSE file for more details.
+
+"""ILS location closures API."""
+
+from datetime import date, timedelta
+from calendar import day_name
+
+import arrow
+
+from invenio_app_ils.errors import IlsException
+from invenio_app_ils.proxies import current_app_ils
+
+_ONE_DAY_INCREMENT = timedelta(days=1)  # Atomic increment
+
+
+def _is_in_interval(date, interval):
+    """Checks if a date is included in an interval."""
+    return (
+        arrow.get(interval["start_date"]).date()
+        <= date
+        <= arrow.get(interval["end_date"]).date()
+    )
+
+
+def _is_normally_open(location, date):
+    """Checks if the location is normally opened on a given date."""
+    opening = location["opening_weekdays"]
+    opening_weekday = opening[date.weekday()]
+    return opening_weekday["is_open"]
+
+
+def _is_exceptionally_open(location, date):
+    """Checks if the location is exceptionally opened on a given date."""
+    for exception in location.get("opening_exceptions", []):
+        if _is_in_interval(date, exception):
+            return exception["is_open"]
+    return None  # Date is not included in any interval
+
+
+def _is_open_on(location, date):
+    """Checks if the location is open or closed on a given date."""
+    exceptionally_open = _is_exceptionally_open(location, date)
+    if exceptionally_open is not None:
+        return exceptionally_open
+    return _is_normally_open(location, date)
+
+
+def find_next_open_date(location_pid, date):
+    """Finds the next day where this location is open."""
+    location = current_app_ils.location_record_cls.get_record_by_pid(location_pid)
+    _infinite_loop_guard = date + timedelta(days=365)
+    while date < _infinite_loop_guard:
+        if _is_open_on(location, date):
+            return date
+        date += _ONE_DAY_INCREMENT
+
+    # Termination is normally guaranteed if there is at least one weekday open
+    raise IlsException(
+        description="Cannot find any date for which the "
+        "location %s is open after the given date %s."
+        "Please check opening/closures dates." % (location_pid, date.isoformat())
+    )
+
+
+def get_closure_periods(location, start, end):
+    """
+    Return date ranges within a specified period when the location is closed.
+    """
+    if (
+        not location
+        or not isinstance(start, date)
+        or not isinstance(end, date)
+        or start > end
+    ):
+        raise ValueError("Invalid input parameters")
+
+    one_day_delta = timedelta(days=1)
+
+    weekday_name_to_index = {name.lower(): i for i, name in enumerate(day_name)}
+    closed_weekdays = set()
+    for weekday_rule in location.get("opening_weekdays", []):
+        if weekday_rule.get("is_open") is False:
+            weekday_str = weekday_rule.get("weekday", "").lower()
+            closed_weekdays.add(weekday_name_to_index[weekday_str])
+
+    exception_overrides = {}
+    for exception in location.get("opening_exceptions", []):
+        is_closed_override = not exception.get("is_open")
+
+        ex_start = date.fromisoformat(exception["start_date"])
+        ex_end = date.fromisoformat(exception["end_date"])
+
+        current_ex_date = ex_start
+        while current_ex_date <= ex_end:
+            exception_overrides[current_ex_date] = is_closed_override
+            current_ex_date += one_day_delta
+
+    closure_periods = []
+    closure_streak_start = None
+    current_date = start
+
+    while current_date <= end:
+        is_date_closed = False
+
+        override_status = exception_overrides.get(current_date)
+
+        if override_status is not None:
+            is_date_closed = override_status
+        else:
+            if current_date.weekday() in closed_weekdays:
+                is_date_closed = True
+
+        if is_date_closed:
+            if closure_streak_start is None:
+                closure_streak_start = current_date
+        else:
+            if closure_streak_start is not None:
+                closure_periods.append(
+                    {"start": closure_streak_start, "end": current_date - one_day_delta}
+                )
+                closure_streak_start = None
+
+        current_date += one_day_delta
+
+    # Handle trailing closed period
+    if closure_streak_start is not None:
+        closure_periods.append({"start": closure_streak_start, "end": end})
+
+    return closure_periods

invenio_app_ils-4.6.0/invenio_app_ils/closures/serializers/__init__.py

@@ -0,0 +1,16 @@
+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2025-2025 CERN.
+#
+# Invenio is free software; you can redistribute it and/or modify it
+# under the terms of the MIT License; see LICENSE file for more details.
+
+
+from invenio_app_ils.closures.serializers.response import closure_periods_responsify
+from invenio_app_ils.closures.serializers.schema import ClosurePeriodsV1
+
+
+closure_periods_response = closure_periods_responsify(
+    ClosurePeriodsV1, "application/json"
+)

invenio_app_ils-4.6.0/invenio_app_ils/closures/serializers/response.py

@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2025-2025 CERN.
+#
+# Invenio is free software; you can redistribute it and/or modify it
+# under the terms of the MIT License; see LICENSE file for more details.
+
+"""Invenio App ILS Closures response serializers."""
+
+import json
+from flask import current_app
+
+
+def closure_periods_responsify(schema_class, mimetype):
+    """Closure periods response serializer.
+
+    :param schema_class: Schema instance.
+    :param mimetype: MIME type of response.
+    """
+
+    def view(data, code=200, headers=None):
+        """Generate the response object."""
+        response_data = schema_class().dump(data)
+
+        response = current_app.response_class(
+            json.dumps(response_data), mimetype=mimetype
+        )
+        response.status_code = code
+
+        if headers is not None:
+            response.headers.extend(headers)
+        return response
+
+    return view

invenio_app_ils-4.6.0/invenio_app_ils/closures/serializers/schema.py

@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2025-2025 CERN.
+#
+# Invenio is free software; you can redistribute it and/or modify it
+# under the terms of the MIT License; see LICENSE file for more details.
+
+"""Invenio App ILS Closures response schemas."""
+
+from marshmallow import Schema, fields
+
+
+class DateRangeSchema(Schema):
+    """Schema for a single closure period."""
+
+    start = fields.Date(required=True, description="Start date of the closure period.")
+    end = fields.Date(required=True, description="End date of the closure period.")
+
+
+class ClosurePeriodsV1(Schema):
+    """Schema for a list of closure periods."""
+
+    closure_periods = fields.List(
+        fields.Nested(DateRangeSchema),
+        required=True,
+        description="List of closure date periods.",
+    )

invenio_app_ils-4.6.0/invenio_app_ils/closures/views.py

@@ -0,0 +1,66 @@
+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2025-2025 CERN.
+#
+# Invenio is free software; you can redistribute it and/or modify it
+# under the terms of the MIT License; see LICENSE file for more details.
+
+"""Invenio App ILS Closure views."""
+
+from flask import Blueprint, abort
+from flask_login import current_user
+from datetime import date
+from invenio_records_rest.views import pass_record
+from invenio_rest import ContentNegotiatedMethodView
+from invenio_app_ils.locations.api import LOCATION_PID_TYPE
+from invenio_app_ils.closures.serializers import closure_periods_response
+from invenio_app_ils.closures.api import get_closure_periods
+from invenio_app_ils.permissions import backoffice_permission
+from invenio_app_ils.records.permissions import RecordPermission
+
+
+def create_closures_blueprint(app):
+    """Create location closed periods blueprint."""
+    blueprint = Blueprint("invenio_app_ils_closures", __name__, url_prefix="")
+    endpoints = app.config["RECORDS_REST_ENDPOINTS"]
+
+    options = endpoints[LOCATION_PID_TYPE]
+    default_media_type = options.get("default_media_type", "")
+    closure_periods_serializers = {"application/json": closure_periods_response}
+
+    closure_periods_view = LocationClosurePeriodsResource.as_view(
+        LocationClosurePeriodsResource.view_name,
+        serializers=closure_periods_serializers,
+        default_media_type=default_media_type,
+    )
+    blueprint.add_url_rule(
+        "{0}/closure_periods/<int:year>".format(options["item_route"]),
+        view_func=closure_periods_view,
+        methods=["GET"],
+    )
+
+    return blueprint
+
+
+class LocationClosurePeriodsResource(ContentNegotiatedMethodView):
+    """Returns the closure periods of a Location"""
+
+    view_name = "location_closure_periods"
+
+    @pass_record
+    def get(self, pid, record, year, **kwargs):
+        """Get the date ranges for which a location is closure based in the specified year"""
+
+        factory = RecordPermission(record, "read")
+        if not factory.is_public() and not backoffice_permission().can():
+            if not current_user.is_authenticated:
+                abort(401)
+            abort(403)
+
+        start_date = date(year, 1, 1)
+        end_date = date(year, 12, 31)
+
+        closure_periods = get_closure_periods(record, start_date, end_date)
+
+        return self.make_response({"closure_periods": closure_periods}, 200)

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: invenio-app-ils
-Version: 4.4.0
+Version: 4.6.0
 Summary: Invenio Integrated Library System.
 Home-page: https://github.com/inveniosoftware/invenio-app-ils
 Author: CERN
@@ -47,7 +47,6 @@ Requires-Dist: invenio-stats<5.0.0,>=4.0.0
 Requires-Dist: Flask-Debugtoolbar<1.0.0,>=0.10.1
 Requires-Dist: pycountry<23.0.0,>=20.0.0
 Requires-Dist: simplejson<4.0.0,>=3.8.1
-Requires-Dist: pluggy<1.0.0,>=0.13.1
 Requires-Dist: jsonschema<5.0.0,>=4.3.0
 Requires-Dist: itsdangerous<2.1,>=1.1
 Requires-Dist: SQLAlchemy<2.0.0,>=1.3.0
@@ -66,6 +65,7 @@ Requires-Dist: lorem>=0.1.1; extra == "lorem"
 Provides-Extra: opensearch2
 Requires-Dist: invenio-search[opensearch2]<3.0.0,>=2.0.0; extra == "opensearch2"
 Provides-Extra: docs
+Dynamic: license-file
 
 ..
     Copyright (C) 2018-2020 CERN.
@@ -101,6 +101,15 @@ https://invenioils.docs.cern.ch
 Changes
 =======
 
+Version 4.6.0 (released 2025-06-25)
+
+- installation: remove breaking package version constraints
+
+Version 4.5.0 (released 2025-06-04)
+
+- closures: added endpoint for closure periods in a year
+- circulation: self-checkout of MISSING items marks them as CAN_CIRCULATE
+- tests: Fix comment on running tests by bumping Postgres & adding param
 
 Version 4.4.0 (released 2025-02-21)
 

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils.egg-info/SOURCES.txt

@@ -125,6 +125,10 @@ invenio_app_ils/circulation/transitions/transitions.py
 invenio_app_ils/closures/__init__.py
 invenio_app_ils/closures/api.py
 invenio_app_ils/closures/tasks.py
+invenio_app_ils/closures/views.py
+invenio_app_ils/closures/serializers/__init__.py
+invenio_app_ils/closures/serializers/response.py
+invenio_app_ils/closures/serializers/schema.py
 invenio_app_ils/demo_data/documents.json
 invenio_app_ils/demo_data/items.json
 invenio_app_ils/document_requests/__init__.py

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils.egg-info/entry_points.txt

@@ -24,6 +24,7 @@ ils_rest = invenio_app_ils.ext:InvenioAppIlsREST
 [invenio_base.api_blueprints]
 ils_circulation = invenio_app_ils.circulation.views:create_circulation_blueprint
 ils_circulation_stats = invenio_app_ils.circulation.stats.views:create_circulation_stats_blueprint
+ils_closures = invenio_app_ils.closures.views:create_closures_blueprint
 ils_document_request = invenio_app_ils.document_requests.views:create_document_request_action_blueprint
 ils_document_stats = invenio_app_ils.records.views:create_document_stats_blueprint
 ils_files = invenio_app_ils.files.views:create_files_blueprint

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/invenio_app_ils.egg-info/requires.txt

@@ -33,7 +33,6 @@ invenio-stats<5.0.0,>=4.0.0
 Flask-Debugtoolbar<1.0.0,>=0.10.1
 pycountry<23.0.0,>=20.0.0
 simplejson<4.0.0,>=3.8.1
-pluggy<1.0.0,>=0.13.1
 jsonschema<5.0.0,>=4.3.0
 itsdangerous<2.1,>=1.1
 SQLAlchemy<2.0.0,>=1.3.0

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/run-tests.sh

@@ -1,13 +1,13 @@
 #!/usr/bin/env bash
 # -*- coding: utf-8 -*-
 #
-# Copyright (C) 2020 CERN.
+# Copyright (C) 2020-2025 CERN.
 #
 # invenio-app-ils is free software; you can redistribute it and/or modify it
 # under the terms of the MIT License; see LICENSE file for more details.
 
 # To run a test locally:
-# 1. eval "$(docker-services-cli up --db postgresql12 --search opensearch2 --cache redis --env)"
+# 1. eval "$(docker-services-cli up --db postgresql14 --search opensearch2 --cache redis --mq  rabbitmq --env)"
 # 2. python -m pytest -svvvv tests/api/ils/test_apis.py
 # 3. eval "$(docker-services-cli down --env)"
 

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/setup.cfg

@@ -53,7 +53,6 @@ install_requires =
 	Flask-Debugtoolbar>=0.10.1,<1.0.0
 	pycountry>=20.0.0,<23.0.0
 	simplejson>=3.8.1,<4.0.0
-	pluggy>=0.13.1,<1.0.0
 	jsonschema>=4.3.0,<5.0.0
 	itsdangerous>=1.1,<2.1
 	SQLAlchemy>=1.3.0,<2.0.0
@@ -106,6 +105,7 @@ invenio_base.api_blueprints =
 	ils_relations = invenio_app_ils.records_relations.views:create_relations_blueprint
 	ils_document_request = invenio_app_ils.document_requests.views:create_document_request_action_blueprint
 	ils_document_stats = invenio_app_ils.records.views:create_document_stats_blueprint
+	ils_closures = invenio_app_ils.closures.views:create_closures_blueprint
 	ils_files = invenio_app_ils.files.views:create_files_blueprint
 	ils_patrons = invenio_app_ils.patrons.views:get_user_loan_information_blueprint
 	ils_notifications = invenio_app_ils.notifications.views:get_notifications_blueprint

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/tests/api/circulation/test_loan_checkout.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 #
-# Copyright (C) 2018-2020 CERN.
+# Copyright (C) 2018-2025 CERN.
 #
 # invenio-app-ils is free software; you can redistribute it and/or modify it
 # under the terms of the MIT License; see LICENSE file for more details.
@@ -249,15 +249,29 @@ def test_self_checkout_search(app, client, json_headers, users, testdata):
     assert res.status_code == 400
 
     # test that an error is returned when the item cannot circulate
-    missing_item_barcode = "123456789-1"
+    in_binding_item_barcode = "123456789-74"
     url = url_for("invenio_app_ils_circulation.loan_self_checkout")
-    res = client.get(f"{url}?barcode={missing_item_barcode}", headers=json_headers)
+    res = client.get(f"{url}?barcode={in_binding_item_barcode}", headers=json_headers)
     assert res.status_code == 400
     # assert that the payload will contain the key error with a msg
     response = res.get_json()
     assert LoanSelfCheckoutItemInvalidStatus.description in response["message"]
     assert LoanSelfCheckoutItemInvalidStatus.supportCode in response["supportCode"]
 
+    # test that no error is returned when the item is marked as missing
+    missing_item_barcode = "123456789-1"
+    missing_item_pid = "itemid-1"
+    url = url_for("invenio_app_ils_circulation.loan_self_checkout")
+    res = client.get(f"{url}?barcode={missing_item_barcode}", headers=json_headers)
+    assert res.status_code == 200
+
+    # assert item is no longer marked as missing
+    response = res.get_json()
+    item_pid = response["metadata"]["pid"]
+    assert item_pid == missing_item_pid
+    item = Item.get_record_by_pid(item_pid)
+    assert item["status"] == "CAN_CIRCULATE"
+
     # create a loan on the same patron, and another one on another patron
     user_login(client, "librarian", users)
     url = url_for("invenio_app_ils_circulation.loan_checkout")
@@ -326,6 +340,7 @@ def test_self_checkout(app, client, json_headers, users, testdata):
         current_search.flush_and_refresh(index="*")
 
     def _self_checkout(patron, item_pid, document_pid):
+        url = url_for("invenio_app_ils_circulation.loan_self_checkout")
         params = deepcopy(NEW_LOAN)
         params["document_pid"] = document_pid
         params["item_pid"] = dict(type="pitmid", value=item_pid)
@@ -394,3 +409,14 @@ def test_self_checkout(app, client, json_headers, users, testdata):
     assert res.status_code == 202
     response = res.get_json()
     assert response["metadata"]["delivery"]["method"] == "SELF-CHECKOUT"
+
+    # test self-checkout with item marked as missing raises no error and marks the item as CAN_CIRCULATE
+    missing_item_pid = "itemid-1"
+    app.config["ILS_SELF_CHECKOUT_ENABLED"] = True
+    patron2 = user_login(client, "patron2", users)
+    res = _self_checkout(patron2, missing_item_pid, "docid-1")
+    assert res.status_code == 202
+    response = res.get_json()
+    assert response["metadata"]["delivery"]["method"] == "SELF-CHECKOUT"
+    item = Item.get_record_by_pid(missing_item_pid)
+    assert item["status"] == "CAN_CIRCULATE"

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/tests/api/ils/test_closures.py

@@ -10,6 +10,7 @@
 import json
 
 import arrow
+import pytest
 from flask import url_for
 
 from invenio_app_ils.closures.api import find_next_open_date
@@ -21,6 +22,7 @@ _LOCATION_PID = "locid-1"
 _LOCATION_NAME = "Location name"
 _ITEM_ENDPOINT = "invenio_records_rest.locid_item"
 _LIST_ENDPOINT = "invenio_records_rest.locid_list"
+_CLOSURE_PERIODS_ENDPOINT = "invenio_app_ils_closures.location_closure_periods"
 _WEEKDAYS = [
     "monday",
     "tuesday",
@@ -261,7 +263,8 @@ def test_location_validation(client, json_headers, users, testdata):
     )
 
 
-def test_find_next_open_date(app, db, testdata):
+@pytest.fixture
+def location_closures_testdata(db, testdata):
     def _update_location_closures_data(closed_weekdays, exceptions):
         Location = current_app_ils.location_record_cls
         record = Location.get_record_by_pid(_LOCATION_PID)
@@ -273,13 +276,6 @@ def test_find_next_open_date(app, db, testdata):
 
         return record
 
-    def _test(start_date, expected_next_open_date):
-        next_open = find_next_open_date(_LOCATION_PID, _date_from_string(start_date))
-        if expected_next_open_date:
-            assert next_open == _date_from_string(expected_next_open_date)
-        else:
-            assert next_open is None
-
     """
     Mon. Tue. Wed. Thu. Fri. Sat. Sun.
      27   28   29   30   31  -01  -02
@@ -300,6 +296,15 @@ def test_find_next_open_date(app, db, testdata):
     ]
     _update_location_closures_data(closed_weekdays, exceptions)
 
+
+def test_find_next_open_date(app, location_closures_testdata):
+    def _test(start_date, expected_next_open_date):
+        next_open = find_next_open_date(_LOCATION_PID, _date_from_string(start_date))
+        if expected_next_open_date:
+            assert next_open == _date_from_string(expected_next_open_date)
+        else:
+            assert next_open is None
+
     _test("2000-01-01", "2000-01-06")
     _test("2000-01-04", "2000-01-06")
     _test("2000-01-06", "2000-01-06")
@@ -313,3 +318,36 @@ def test_find_next_open_date(app, db, testdata):
     _test("2000-01-30", "2000-01-30")
 
     _test("2000-02-05", "2000-02-07")
+
+
+def test_get_closure_periods(client, location_closures_testdata, json_headers):
+    """Test get closure periods."""
+    url = url_for(
+        _CLOSURE_PERIODS_ENDPOINT,
+        pid_value=_LOCATION_PID,
+        year=2000,
+    )
+    res = client.get(url, headers=json_headers)
+    assert res.status_code in _HTTP_OK
+
+    hits = json.loads(res.data.decode("utf-8"))["closure_periods"]
+    hits = [
+        (_date_from_string(hit["start"]), _date_from_string(hit["end"])) for hit in hits
+    ]
+
+    def _is_in_interval(date, interval):
+        return interval[0] <= date <= interval[1]
+
+    def _test(date, closed):
+        date = _date_from_string(date)
+        assert (
+            any(_is_in_interval(date, hit) for hit in hits) == closed
+        ), f"Date {date} is wrongfully marked as {'Open' if closed else 'Closed'}"
+
+    _test("2000-01-01", True)
+    _test("2000-01-06", False)
+    _test("2000-01-22", True)
+    _test("2000-01-23", True)
+    _test("2000-01-30", False)
+    _test("2000-02-01", False)
+    _test("2000-02-05", True)

{invenio_app_ils-4.4.0 → invenio_app_ils-4.6.0}/tests/data/items.json

@@ -289,5 +289,16 @@
     "medium": "NOT_SPECIFIED",
     "status": "CAN_CIRCULATE",
     "document": {}
+  },
+  {
+    "pid": "itemid-74",
+    "created_by": { "type": "script", "value": "demo" },
+    "barcode": "123456789-74",
+    "document_pid": "docid-17",
+    "internal_location_pid": "ilocid-1",
+    "circulation_restriction": "NO_RESTRICTION",
+    "medium": "NOT_SPECIFIED",
+    "status": "IN_BINDING",
+    "document": {}
   }
 ]