insightconnect-plugin-runtime 5.5.2__tar.gz → 5.5.4__tar.gz

{insightconnect_plugin_runtime-5.5.2/insightconnect_plugin_runtime.egg-info → insightconnect_plugin_runtime-5.5.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: insightconnect-plugin-runtime
-Version: 5.5.2
+Version: 5.5.4
 Summary: InsightConnect Plugin Runtime
 Home-page: https://github.com/rapid7/komand-plugin-sdk-python
 Author: Rapid7 Integrations Alliance
@@ -211,6 +211,8 @@ contributed. Black is installed as a test dependency and the hook can be initial
 after cloning this repository.
 
 ## Changelog
+* 5.5.4 - Support pagination parameters within AWS client.
+* 5.5.3 - Adding in a new endpoint that can be called to run a task connection test
 * 5.5.2 - Address bug with typing for type `List` in Python 3.8
 * 5.5.1 - Address bug with typing for type `Tuple` in Python 3.8
 * 5.5.0 - Updated helper class to add `make_request`, `response_handler`, `extract_json`, and `request_error_handling` for HTTP requests, and `hash_sha1` and `compare_and_dedupe_hashes` to provide support for hash comparisons | Add `METHOD_NOT_ALLOWED`, `CONFLICT`, `REDIRECT_ERROR`, and `CONNECTION_ERROR` to PluginException presets

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/README.md

@@ -182,6 +182,8 @@ contributed. Black is installed as a test dependency and the hook can be initial
 after cloning this repository.
 
 ## Changelog
+* 5.5.4 - Support pagination parameters within AWS client.
+* 5.5.3 - Adding in a new endpoint that can be called to run a task connection test
 * 5.5.2 - Address bug with typing for type `List` in Python 3.8
 * 5.5.1 - Address bug with typing for type `Tuple` in Python 3.8
 * 5.5.0 - Updated helper class to add `make_request`, `response_handler`, `extract_json`, and `request_error_handling` for HTTP requests, and `hash_sha1` and `compare_and_dedupe_hashes` to provide support for hash comparisons | Add `METHOD_NOT_ALLOWED`, `CONFLICT`, `REDIRECT_ERROR`, and `CONNECTION_ERROR` to PluginException presets

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/insightconnect-plugin-swagger.json

@@ -415,10 +415,19 @@
         }
       }
     },
-    "/api/v1/connection/test": {
+    "/api/v1/connection/{connection_test_type}": {
       "post": {
         "summary": "Run connection test",
         "description": "Run InsightConnect plugin connection test",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "connection_test_type",
+            "description": "Type of connection test to be run",
+            "type": "string",
+            "required": true
+          }
+        ],
         "responses": {
           "200": {
             "description": "Connection test output to be returned",

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/insightconnect_plugin_runtime/api/endpoints.py

@@ -634,14 +634,19 @@ class Endpoints:
             schema = conn.schema
             return jsonify(ConnectionDetailsSchema().dump(schema))
 
-        @v1.route("/connection/test", methods=["POST"])
-        def connection_test():
+        @v1.route("/connection/<string:connection_test_type>", methods=["POST"])
+        def connection_test(connection_test_type: str):
             """
             Run connection test endpoint
             ---
             post:
               summary: Run connection test
               description: Run InsightConnect plugin connection test
+              parameters:
+                - in: path
+                  name: connection_test_type
+                  description: Type of connection test to be run
+                  type: string
               responses:
                 200:
                   description: Connection test output to be returned
@@ -658,12 +663,26 @@ class Endpoints:
             status_code = 200
             output = None
 
+            supported_tests = ["test", "test_task"]
+            if connection_test_type not in supported_tests:
+                return make_response(
+                    jsonify(
+                        {
+                            "error": f"The requested endpoint is not available, only {supported_tests} are supported.",
+                            "code": 404,
+                            "method": "POST",
+                            "name": "Not Found"
+                        }
+                    ),
+                    404,
+                )
+
             input_message = request.get_json(force=True)
             Endpoints.validate_action_trigger_task_empty_input(input_message)
 
             try:
                 output = self.plugin.handle_step(
-                    input_message, is_debug=self.debug, is_test=True
+                    input_message, is_debug=self.debug, is_test=True, connection_test_type=connection_test_type
                 )
                 if output.get("body", {}).get("output") is None:
                     status_code = 204

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/insightconnect_plugin_runtime/clients/aws_client.py

@@ -36,6 +36,7 @@ class PaginationHelper:
         limit_key: str = None,
         more_results: str = None,
         non_aggregate_keys: List[str] = None,
+        max_pages : int = None,  # if we want to limit how many pages of data we pull from AWS
     ):
         self.input_token = input_token
         self.output_token = output_token
@@ -46,6 +47,7 @@ class PaginationHelper:
         self.keys_to_remove = []
         self.keys_to_remove.extend(input_token)
         self.keys_to_remove.extend(output_token)
+        self.max_pages = max_pages
         if more_results:
             self.keys_to_remove.append(self.more_results)
 
@@ -83,6 +85,20 @@ class PaginationHelper:
 
         return is_paginated
 
+    def check_total_results(self, params, response: dict[str, Any]) -> bool:
+        """
+        Check if we have ran the AWS call too many times, eg params[max_keys] * max_pages = len response
+        :param params: parameters used within the ListObjectsv2 command
+        :param response: response contents from ListObjectsv2
+        :return: boolean to indicate if we have reached the max amount of objects to be returned in one execution.
+        """
+        if self.max_pages:
+            max_allowed = params[self.limit_key] * self.max_pages
+            if max_allowed >= len(response[self.result_key[0]]):
+                return True
+
+        return False
+
     def merge_responses(
         self,
         input_: Dict[str, Any],
@@ -429,7 +445,7 @@ class AWSAction(Action):
         helper = self.connection.helper
 
         # Format the input parameters for the botocall call
-        self.logger.info(params)
+        self.logger.debug(params)
         try:
             params = helper.format_input(params)
         except Exception:
@@ -437,7 +453,7 @@ class AWSAction(Action):
             raise PluginException(cause="Unable to format input parameters")
 
         # Execute the botocore function
-        self.logger.info(params)
+        self.logger.debug(params)
         response = self._handle_botocore_function(client_function, params)
 
         # Format the output parameters for the komand action output schema
@@ -495,13 +511,21 @@ class AWSAction(Action):
         # Handle possible pagination if this action supports pagination.
         if self.pagination_helper:
             while self.pagination_helper.check_pagination(params, response):
+                if self.pagination_helper.check_total_results(params, response):
+                    self.logger.info("Reached max amount of pages per execution breaking...")
+                    break
+
                 self.logger.info("Response was paginated. Performing another call.")
                 response, max_hit = self.pagination_helper.merge_responses(
                     params, self.handle_rest_call(client_function, params), response
                 )
-                if max_hit:
+
+                if max_hit:  # all data possible in this particular AWS call
                     break
-            self.pagination_helper.remove_keys(response)
+
+            # if we have pagination enabled for AWS we want to take note of the tokens
+            if not self.pagination_helper.max_pages:
+                self.pagination_helper.remove_keys(response)
 
         return response
 

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/insightconnect_plugin_runtime/plugin.py

@@ -362,7 +362,7 @@ class Plugin(object):
         if "input" not in body:
             body["input"] = {}
 
-    def handle_step(self, input_message, is_test=False, is_debug=False):
+    def handle_step(self, input_message, is_test=False, is_debug=False, connection_test_type="test"):
         """
         Executes a single step, given the input message dictionary.
 
@@ -427,6 +427,7 @@ class Plugin(object):
                     log_stream,
                     is_test,
                     is_debug,
+                    connection_test_type=connection_test_type
                 )
             elif message_type == "trigger_start":
                 out_type = "trigger_event"
@@ -437,6 +438,7 @@ class Plugin(object):
                     log_stream,
                     is_test,
                     is_debug,
+                    connection_test_type=connection_test_type
                 )
             elif message_type == "task_start":
                 out_type = "task_event"
@@ -449,6 +451,7 @@ class Plugin(object):
                         log_stream,
                         is_test,
                         is_debug,
+                        connection_test_type=connection_test_type
                     )
                 else:
                     (
@@ -464,6 +467,7 @@ class Plugin(object):
                         log_stream,
                         is_test,
                         is_debug,
+                        connection_test_type=connection_test_type
                     )
             elif message_type == "connection_test":
                 out_type = "connection_test"
@@ -475,6 +479,7 @@ class Plugin(object):
                     is_test,
                     is_debug,
                     is_connection_test=True,
+                    connection_test_type=connection_test_type
                 )
         except (ClientException, ServerException, PluginException, Exception) as e:
             success = False
@@ -513,6 +518,7 @@ class Plugin(object):
         is_test=False,
         is_debug=False,
         is_connection_test=False,
+        connection_test_type="test"
     ):
         """
         Starts an action.
@@ -523,6 +529,7 @@ class Plugin(object):
         :param is_test: True if the action's test method should execute
         :param is_debug: True if debug is enabled
         :param is_connection_test: True if connection test is running
+        :param connection_test_type: The type of connection test to be run
         :return: An action_event message
         """
         connection = self.connection_cache.get(message_body["connection"], logger)
@@ -534,7 +541,9 @@ class Plugin(object):
                     plugin_version=connection.meta.version,
                 )
             )
-            if hasattr(connection, "test"):
+            if hasattr(connection, "test_task") and connection_test_type == "test_task":
+                func = connection.test_task
+            elif hasattr(connection, "test"):
                 func = connection.test
             else:
                 raise NotImplementedError(
@@ -617,7 +626,10 @@ class Plugin(object):
             if is_test:
                 # Check if connection test func available. If so - use it (preferred). Else fallback to action/trigger test
                 if hasattr(step.connection, "test"):
-                    func = step.connection.test
+                    if hasattr(step.connection, "test") and connection_test_type == "test_task":
+                        func = step.connection.task_test
+                    else:
+                        func = step.connection.test
                 else:
                     func = step.test
             else:

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4/insightconnect_plugin_runtime.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: insightconnect-plugin-runtime
-Version: 5.5.2
+Version: 5.5.4
 Summary: InsightConnect Plugin Runtime
 Home-page: https://github.com/rapid7/komand-plugin-sdk-python
 Author: Rapid7 Integrations Alliance
@@ -211,6 +211,8 @@ contributed. Black is installed as a test dependency and the hook can be initial
 after cloning this repository.
 
 ## Changelog
+* 5.5.4 - Support pagination parameters within AWS client.
+* 5.5.3 - Adding in a new endpoint that can be called to run a task connection test
 * 5.5.2 - Address bug with typing for type `List` in Python 3.8
 * 5.5.1 - Address bug with typing for type `Tuple` in Python 3.8
 * 5.5.0 - Updated helper class to add `make_request`, `response_handler`, `extract_json`, and `request_error_handling` for HTTP requests, and `hash_sha1` and `compare_and_dedupe_hashes` to provide support for hash comparisons | Add `METHOD_NOT_ALLOWED`, `CONFLICT`, `REDIRECT_ERROR`, and `CONNECTION_ERROR` to PluginException presets

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/setup.py

@@ -5,7 +5,7 @@ with open("README.md", "r") as fh:
 
 setup(
     name="insightconnect-plugin-runtime",
-    version="5.5.2",
+    version="5.5.4",
     description="InsightConnect Plugin Runtime",
     long_description=long_description,
     long_description_content_type="text/markdown",

{insightconnect_plugin_runtime-5.5.2 → insightconnect_plugin_runtime-5.5.4}/tests/unit/test_aws_action.py

@@ -10,7 +10,7 @@ import botocore.response as br
 from parameterized import parameterized
 
 from insightconnect_plugin_runtime import Input, Output, Connection
-from insightconnect_plugin_runtime.clients.aws_client import AWSAction, ActionHelper
+from insightconnect_plugin_runtime.clients.aws_client import AWSAction, ActionHelper, PaginationHelper
 from insightconnect_plugin_runtime.exceptions import PluginException
 
 
@@ -80,6 +80,37 @@ class TestAwsAction(unittest.TestCase):
         self.aws_action.connection.helper.format_input.assert_called_once()
         self.aws_action.connection.helper.format_output.assert_called_once()
 
+    @unittest.mock.patch("botocore.session.Session", return_value=unittest.mock.Mock())
+    @unittest.mock.patch("boto3.client", return_value=Boto3Stub())
+    def test_run_action_pagination(self, mock_session, mock_sts_client):
+        """
+        Test when max_pages attribute is on the pagination_helper that the response is not cleaned
+        allowing the two tokens (next_continuation_token & contination_token) to be returned.
+        """
+        client_function = getattr(mock_session, "service")
+        # Mock connection as we're calling action.run() in this unit test
+        self.aws_action.connection.assume_role_params = {}
+        self.aws_action.connection.auth_params = {}
+        self.aws_action.connection.client = {}
+
+        self.aws_action.pagination_helper = unittest.mock.create_autospec(PaginationHelper)
+        self.aws_action.connection.client = mock_session
+
+        # First run has no pagination set so we clean the response
+        self.aws_action.pagination_helper.max_pages = None
+        self.aws_action.run()
+
+        client_function.assert_called_once()
+        self.aws_action.connection.helper.format_input.assert_called_once()
+        self.aws_action.connection.helper.format_output.assert_called_once()
+        self.aws_action.pagination_helper.remove_keys.assert_called_once()
+
+        # Call again with max_pages set and this means remove_keys is not called
+        self.aws_action.pagination_helper.max_pages = 1
+        self.aws_action.pagination_helper.remove_keys.reset_mock()
+        self.aws_action.run()
+        self.aws_action.pagination_helper.remove_keys.assert_not_called()
+
     def _mock_call_raise_endpoint_connection_error(self):
         raise be.EndpointConnectionError(**{"endpoint_url": "test_url"})