ingestify 0.9.2__tar.gz → 0.9.3__tar.gz

{ingestify-0.9.2 → ingestify-0.9.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ingestify
-Version: 0.9.2
+Version: 0.9.3
 Summary: Data Ingestion Framework
 Author: Koen Vossen
 Author-email: info@koenvossen.nl

{ingestify-0.9.2 → ingestify-0.9.3}/ingestify/__init__.py

@@ -9,4 +9,4 @@ if not __INGESTIFY_SETUP__:
     from .source_base import Source, DatasetResource
     from .main import debug_source
 
-__version__ = "0.9.2"
+__version__ = "0.9.3"

{ingestify-0.9.2 → ingestify-0.9.3}/ingestify/infra/store/dataset/sqlalchemy/repository.py

@@ -470,9 +470,14 @@ class SqlAlchemyDatasetRepository(DatasetRepository):
                 dataset_ids = [row.dataset_id for row in dataset_query]
                 datasets = self._load_datasets(dataset_ids)
 
+                last_modified_values = [
+                    dataset.last_modified_at
+                    for dataset in datasets
+                    if dataset.last_modified_at is not None
+                ]
                 dataset_collection_metadata = DatasetCollectionMetadata(
-                    last_modified=max(dataset.last_modified_at for dataset in datasets)
-                    if datasets
+                    last_modified=max(last_modified_values)
+                    if last_modified_values
                     else None,
                     row_count=len(datasets),
                 )

{ingestify-0.9.2 → ingestify-0.9.3}/ingestify/tests/test_engine.py

@@ -526,12 +526,22 @@ def test_post_load_files_hook(config_file):
 def test_force_save_creates_revision(config_file):
     """Test that datasets get a revision even when no files are persisted."""
     engine = get_engine(config_file, "main")
+
+    # Create one dataset with files and one without
+    add_ingestion_plan(
+        engine, SimpleFakeSource("fake-source"), competition_id=1, season_id=2
+    )
     add_ingestion_plan(
-        engine, NoFilesSource("fake-source"), competition_id=1, season_id=2
+        engine, NoFilesSource("fake-source"), competition_id=1, season_id=3
     )
 
     engine.load()
-    dataset = engine.store.get_dataset_collection().first()
 
-    assert len(dataset.revisions) == 1
-    assert len(dataset.current_revision.modified_files) == 0
+    # This should not fail even though one dataset has no last_modified_at
+    datasets = engine.store.get_dataset_collection()
+    assert len(datasets) == 2
+
+    # Verify the dataset without files still has a revision
+    dataset_without_files = engine.store.get_dataset_collection(season_id=3).first()
+    assert len(dataset_without_files.revisions) == 1
+    assert len(dataset_without_files.current_revision.modified_files) == 0

{ingestify-0.9.2 → ingestify-0.9.3}/ingestify.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ingestify
-Version: 0.9.2
+Version: 0.9.3
 Summary: Data Ingestion Framework
 Author: Koen Vossen
 Author-email: info@koenvossen.nl