imio.smartweb.core 1.2.84__tar.gz → 1.2.85__tar.gz

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/CHANGES.rst

@@ -2,6 +2,22 @@ Changelog
 =========
 
 
+1.2.85 (2025-02-10)
+-------------------
+
+- WEB-3538 : Accessibility : Add video source information in title attribute of the iframe
+  [boulch]
+
+- WEB-4217 : Accessibility : Warn the user that the link will open in a new tab (title attribute)
+  [boulch]
+
+- WEB-3872 : Accessibility : Files in "files section" are automaticaly open in a new (target blank) tab
+  [boulch]
+
+- WEB-4211 : Accessibility : Improve behavior of the "alt" attribute for images in a gallery section
+  [boulch]
+
+
 1.2.84 (2025-01-29)
 -------------------
 

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.1
+Metadata-Version: 2.2
 Name: imio.smartweb.core
-Version: 1.2.84
+Version: 1.2.85
 Summary: Core product for iMio websites
 Home-page: https://github.com/imio/imio.smartweb.core
 Author: Christophe Boulanger
@@ -57,6 +57,18 @@ Requires-Dist: plone.restapi[test]; extra == "test"
 Requires-Dist: requests-mock; extra == "test"
 Requires-Dist: beautifulsoup4; extra == "test"
 Requires-Dist: freezegun; extra == "test"
+Dynamic: author
+Dynamic: author-email
+Dynamic: classifier
+Dynamic: description
+Dynamic: home-page
+Dynamic: keywords
+Dynamic: license
+Dynamic: project-url
+Dynamic: provides-extra
+Dynamic: requires-dist
+Dynamic: requires-python
+Dynamic: summary
 
 .. This README is meant for consumption by humans and pypi. Pypi can render rst files so please do not use Sphinx features.
    If you want to learn more about writing documentation, please check out: http://docs.plone.org/about/documentation_styleguide.html
@@ -191,6 +203,22 @@ Changelog
 =========
 
 
+1.2.85 (2025-02-10)
+-------------------
+
+- WEB-3538 : Accessibility : Add video source information in title attribute of the iframe
+  [boulch]
+
+- WEB-4217 : Accessibility : Warn the user that the link will open in a new tab (title attribute)
+  [boulch]
+
+- WEB-3872 : Accessibility : Files in "files section" are automaticaly open in a new (target blank) tab
+  [boulch]
+
+- WEB-4211 : Accessibility : Improve behavior of the "alt" attribute for images in a gallery section
+  [boulch]
+
+
 1.2.84 (2025-01-29)
 -------------------
 

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/setup.py

@@ -16,7 +16,7 @@ long_description = "\n\n".join(
 
 setup(
     name="imio.smartweb.core",
-    version="1.2.84",
+    version="1.2.85",
     description="Core product for iMio websites",
     long_description=long_description,
     # Get more from https://pypi.org/classifiers/

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/common_templates/carousel.pt

@@ -49,6 +49,7 @@
                   <a  tal:omit-tag="not: item/url"
                       tal:attributes="href item/url;
                                       class item/container_id | nothing;
+                                      title python:view.a_tag_item_title(item);
                                       target python:'_blank' if (open_in_new_tab and not can_edit_sections) else ''">
                     <div class="swiper-image"
                          tal:condition="python: item_has_image and show_lead_image"

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/common_templates/table.pt

@@ -59,6 +59,7 @@
                         tal:attributes="class string:table_display ${item/container_id | nothing} ${item/smartweb_type | nothing};"
                       >
                       <a tal:attributes="class python:'table_image no-image' if no_icon_no_image else 'table_image';
+                                         title python:view.a_tag_item_title(item);
                                          href python:view.retrieve_item_url(item);
                                          target python:'_blank' if (open_in_new_tab and not can_edit_sections) else '';">
                         <tal:if tal:condition="show_lead_image">

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/files/view.py

@@ -3,9 +3,11 @@ from imio.smartweb.core.contents import IPublication
 from imio.smartweb.core.contents.sections.views import CarouselOrTableSectionView
 from imio.smartweb.core.utils import batch_results
 from imio.smartweb.core.utils import get_scale_url
+from imio.smartweb.locales import SmartwebMessageFactory as _
 from plone import api
 from plone.protect.interfaces import IDisableCSRFProtection
 from zope.component import queryMultiAdapter
+from zope.i18n import translate
 from zope.interface import alsoProvides
 
 
@@ -32,6 +34,7 @@ class FilesView(CarouselOrTableSectionView):
                 "url": url,
                 "image": scale_url,
                 "has_image": has_image,
+                "open_in_new_tab": True,
             }
             dict_item["item_infos"] = (
                 None if file_view is None else file_view.human_readable_size()
@@ -62,3 +65,10 @@ class FilesView(CarouselOrTableSectionView):
         for prop in extra_properties:
             dict_item[prop] = getattr(item, prop, None)
         return dict_item
+
+    def a_tag_item_title(self, item):
+        # Files always open in a new tab
+        title = item.get("title") or ""
+        current_lang = api.portal.get_current_language()[:2]
+        new_tab_txt = translate(_("New tab"), target_language=current_lang)
+        return f"{title} ({new_tab_txt})"

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/gallery/view.pt

@@ -38,7 +38,7 @@
                              title item/title;
                              data-description item/description">
             <img tal:attributes="src python:view.get_scale_url(item, thumb_scale);
-                                 alt item/title;
+                                 alt python:view.alt_label(item);
                                  title item/title" />
           </a>
         </tal:images>

imio_smartweb_core-1.2.85/src/imio/smartweb/core/contents/sections/gallery/views.py

@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+
+from plone.gallery.views.photo_gallery import PhotoGallery
+from imio.smartweb.core.utils import get_scale_url
+from imio.smartweb.core.contents.sections.views import SectionView
+
+
+class GalleryView(SectionView, PhotoGallery):
+    """Gallery Section view"""
+
+    def get_scale_url(self, item, scale, orientation="paysage"):
+        request = self.request
+        return get_scale_url(item, request, "image", scale, orientation)
+
+    def alt_label(self, item):
+        title = item.title or ""
+        description = item.description or ""
+        # Accessibility: if title is the same as the filename, return empty string because, filename is not a good practice in alt tag for an img.
+        if item.image and title == item.image.filename and len(description) == 0:
+            title = ""
+        # Accessibility : Return description if longer is same or greater than title.
+        if len(description) >= len(title):
+            return description
+        return title

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/links/view.py

@@ -3,7 +3,9 @@
 from imio.smartweb.core.contents.sections.views import CarouselOrTableSectionView
 from imio.smartweb.core.utils import batch_results
 from imio.smartweb.core.utils import get_scale_url
+from imio.smartweb.locales import SmartwebMessageFactory as _
 from plone import api
+from zope.i18n import translate
 
 
 class LinksView(CarouselOrTableSectionView):
@@ -41,3 +43,11 @@ class LinksView(CarouselOrTableSectionView):
                 }
             )
         return batch_results(results, self.context.nb_results_by_batch)
+
+    def a_tag_item_title(self, item):
+        title = item.get("title") or ""
+        if item.get("open_in_new_tab", False):
+            current_lang = api.portal.get_current_language()[:2]
+            new_tab_txt = translate(_("New tab"), target_language=current_lang)
+            return f"{title} ({new_tab_txt})"
+        return title

imio_smartweb_core-1.2.85/src/imio/smartweb/core/contents/sections/video/views.py

@@ -0,0 +1,61 @@
+# -*- coding: utf-8 -*-
+
+from embeddify import Embedder
+from embeddify import Vimeo
+from embeddify import YouTube
+from embeddify.embeddify import STANDARD_PLUGINS
+from imio.smartweb.core.contents.sections.views import SectionView
+from imio.smartweb.locales import SmartwebMessageFactory as _
+from plone import api
+from zope.i18n import translate
+
+import html
+
+
+class VideoView(SectionView):
+    def get_embed_video(self, width=800, height=600):
+        plugins = STANDARD_PLUGINS
+        plugins = [
+            SmartwebYoutube() if isinstance(plugin, YouTube) else plugin
+            for plugin in plugins
+        ]
+        plugins = [
+            SmartwebVimeo() if isinstance(plugin, Vimeo) else plugin
+            for plugin in plugins
+        ]
+        embedder = Embedder(width=width, height=height, plugins=plugins)
+        return embedder(self.context.video_url, params=dict(autoplay=False))
+
+
+class SmartwebYoutube(YouTube):
+
+    def do_request(self, parts, config):
+        if self.test(parts):
+            res = super(SmartwebYoutube, self).do_request(parts, config)
+            title = res.get("title", "")
+            current_lang = api.portal.get_current_language()[:2]
+            additional_accessibility_info = translate(
+                _("Youtube video"), target_language=current_lang
+            )
+            res["title"] = f"{title} ({additional_accessibility_info})"
+            if title != "":
+                res["html"] = res["html"].replace(html.escape(title), res["title"])
+            return res
+        return
+
+
+class SmartwebVimeo(Vimeo):
+
+    def do_request(self, parts, config):
+        if self.test(parts):
+            res = super(SmartwebVimeo, self).do_request(parts, config)
+            title = res.get("title", "")
+            current_lang = api.portal.get_current_language()[:2]
+            additional_accessibility_info = translate(
+                _("Vimeo video"), target_language=current_lang
+            )
+            res["title"] = f"{title} ({additional_accessibility_info})"
+            if title != "":
+                res["html"] = res["html"].replace(html.escape(title), res["title"])
+            return res
+        return

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/contents/sections/views.py

@@ -100,6 +100,10 @@ class SectionView(BrowserView):
         )
         return json.dumps({"id": section_size, "title": size_txt})
 
+    def a_tag_item_title(self, item):
+        title = item.get("title") or ""
+        return title
+
 
 class CarouselOrTableSectionView(SectionView):
     """Section view that can display a carousel"""

imio_smartweb_core-1.2.85/src/imio/smartweb/core/tests/test_section_gallery.py

@@ -0,0 +1,75 @@
+# -*- coding: utf-8 -*-
+
+from imio.smartweb.core.testing import IMIO_SMARTWEB_CORE_INTEGRATION_TESTING
+from imio.smartweb.core.testing import ImioSmartwebTestCase
+from imio.smartweb.core.tests.utils import make_named_image
+from plone import api
+from plone.app.testing import login
+from plone.app.testing import logout
+from plone.app.testing import setRoles
+from plone.app.testing import TEST_USER_ID
+from plone.namedfile.file import NamedBlobImage
+from zope.component import queryMultiAdapter
+
+
+class TestSectionGallery(ImioSmartwebTestCase):
+    layer = IMIO_SMARTWEB_CORE_INTEGRATION_TESTING
+
+    def setUp(self):
+        self.request = self.layer["request"]
+        self.portal = self.layer["portal"]
+        setRoles(self.portal, TEST_USER_ID, ["Manager"])
+        self.page = api.content.create(
+            container=self.portal,
+            type="imio.smartweb.Page",
+            id="page",
+        )
+
+    def test_alt_label(self):
+        gallery_section = api.content.create(
+            container=self.page,
+            type="imio.smartweb.SectionGallery",
+            title="Gallery section",
+        )
+        blob_image = NamedBlobImage(**make_named_image("plone.png"))
+
+        # image1 has no defined title (by default img blob filename) and no description
+        image1 = api.content.create(
+            container=gallery_section,
+            type="Image",
+            title="plone.png",
+        )
+        image1.image = blob_image
+
+        # image2 has a defined title and no description
+        image2 = api.content.create(
+            container=gallery_section,
+            type="Image",
+            title="Kamoulox",
+        )
+        image2.image = blob_image
+
+        # image3 has a defined title and description (greater than title)
+        image3 = api.content.create(
+            container=gallery_section,
+            type="Image",
+            title="Hello Plone !",
+        )
+        image3.image = blob_image
+        image3.description = "Hello Plone, what's up ?!"
+
+        # image4 has a defined title and a mistaked blank description (smaller than title)
+        image4 = api.content.create(
+            container=gallery_section,
+            type="Image",
+            title="Hello Plone !",
+        )
+        # This is a mistaked blank description
+        image4.image = blob_image
+        image4.description = "  "
+
+        view = queryMultiAdapter((gallery_section, self.request), name="view")
+        self.assertEqual(view.alt_label(image1), "")
+        self.assertEqual(view.alt_label(image2), "Kamoulox")
+        self.assertEqual(view.alt_label(image3), "Hello Plone, what's up ?!")
+        self.assertEqual(view.alt_label(image4), "Hello Plone !")

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio/smartweb/core/tests/test_sections.py

@@ -116,6 +116,14 @@ class TestSections(ImioSmartwebTestCase):
         self.assertIn(
             "https://www.youtube.com/embed/_dOAthafoGQ?feature=oembed", embedded_video
         )
+        self.assertIn("(Youtube video)", embedded_video)
+
+        section.video_url = "https://vimeo.com/110990510"
+        view = queryMultiAdapter((section, self.request), name="view")
+        embedded_video = view.get_embed_video()
+        self.assertIn("iframe", embedded_video)
+        self.assertIn("https://player.vimeo.com/video/110990510", embedded_video)
+        self.assertIn("(Vimeo video)", embedded_video)
 
     def test_external_content_section(self):
         setRoles(self.portal, TEST_USER_ID, ["Contributor"])
@@ -283,6 +291,7 @@ class TestSections(ImioSmartwebTestCase):
         logout()
         view = queryMultiAdapter((page, self.request), name="full_view")()
         self.assertEqual(view.count('<h2 class="section-title">Title of my '), 5)
+
         login(self.portal, "test")
         gallery_section = getattr(page, "title-of-my-imio-smartweb-sectiongallery")
         api.content.create(
@@ -290,6 +299,7 @@ class TestSections(ImioSmartwebTestCase):
             type="Image",
             title="Image",
         )
+
         files_section = getattr(page, "title-of-my-imio-smartweb-sectionfiles")
         file_obj = api.content.create(
             container=files_section,
@@ -297,12 +307,14 @@ class TestSections(ImioSmartwebTestCase):
             title="My file",
         )
         file_obj.file = NamedBlobFile(data="file data", filename="file.txt")
+
         links_section = getattr(page, "title-of-my-imio-smartweb-sectionlinks")
         api.content.create(
             container=links_section,
             type="imio.smartweb.BlockLink",
             title="My link",
         )
+
         view = queryMultiAdapter((page, self.request), name="full_view")()
         self.assertEqual(
             view.count('<h2 class="section-title">Title of my '), len(section_types)
@@ -531,12 +543,12 @@ class TestSections(ImioSmartwebTestCase):
         )
         view = getMultiAdapter((self.page, self.request), name="full_view")
         self.assertIn(
-            '<a class="table_image no-image" href="http://nohost/plone/page/section-links/my-link" target="">',
+            '<a class="table_image no-image" title="My link" href="http://nohost/plone/page/section-links/my-link" target="">',
             view(),
         )
         link.image = NamedBlobImage(**make_named_image())
         self.assertIn(
-            '<a class="table_image" href="http://nohost/plone/page/section-links/my-link" target="">',
+            '<a class="table_image" title="My link" href="http://nohost/plone/page/section-links/my-link" target="">',
             view(),
         )
         link.open_in_new_tab = True
@@ -548,7 +560,7 @@ class TestSections(ImioSmartwebTestCase):
         clear_cache(self.request)
         view = getMultiAdapter((self.page, self.request), name="full_view")
         self.assertIn(
-            '<a class="table_image" href="http://nohost/plone/page/section-links/my-link" target="_blank">',
+            '<a class="table_image" title="My link (New tab)" href="http://nohost/plone/page/section-links/my-link" target="_blank">',
             view(),
         )
         link.remoteUrl = "http://www.perdu.com"

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio.smartweb.core.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.1
+Metadata-Version: 2.2
 Name: imio.smartweb.core
-Version: 1.2.84
+Version: 1.2.85
 Summary: Core product for iMio websites
 Home-page: https://github.com/imio/imio.smartweb.core
 Author: Christophe Boulanger
@@ -57,6 +57,18 @@ Requires-Dist: plone.restapi[test]; extra == "test"
 Requires-Dist: requests-mock; extra == "test"
 Requires-Dist: beautifulsoup4; extra == "test"
 Requires-Dist: freezegun; extra == "test"
+Dynamic: author
+Dynamic: author-email
+Dynamic: classifier
+Dynamic: description
+Dynamic: home-page
+Dynamic: keywords
+Dynamic: license
+Dynamic: project-url
+Dynamic: provides-extra
+Dynamic: requires-dist
+Dynamic: requires-python
+Dynamic: summary
 
 .. This README is meant for consumption by humans and pypi. Pypi can render rst files so please do not use Sphinx features.
    If you want to learn more about writing documentation, please check out: http://docs.plone.org/about/documentation_styleguide.html
@@ -191,6 +203,22 @@ Changelog
 =========
 
 
+1.2.85 (2025-02-10)
+-------------------
+
+- WEB-3538 : Accessibility : Add video source information in title attribute of the iframe
+  [boulch]
+
+- WEB-4217 : Accessibility : Warn the user that the link will open in a new tab (title attribute)
+  [boulch]
+
+- WEB-3872 : Accessibility : Files in "files section" are automaticaly open in a new (target blank) tab
+  [boulch]
+
+- WEB-4211 : Accessibility : Improve behavior of the "alt" attribute for images in a gallery section
+  [boulch]
+
+
 1.2.84 (2025-01-29)
 -------------------
 

{imio_smartweb_core-1.2.84 → imio_smartweb_core-1.2.85}/src/imio.smartweb.core.egg-info/SOURCES.txt

@@ -449,6 +449,7 @@ src/imio/smartweb/core/tests/test_search.py
 src/imio/smartweb/core/tests/test_section_contact.py
 src/imio/smartweb/core/tests/test_section_events.py
 src/imio/smartweb/core/tests/test_section_external_content.py
+src/imio/smartweb/core/tests/test_section_gallery.py
 src/imio/smartweb/core/tests/test_section_news.py
 src/imio/smartweb/core/tests/test_section_sendinblue.py
 src/imio/smartweb/core/tests/test_sections.py

imio_smartweb_core-1.2.84/src/imio/smartweb/core/contents/sections/gallery/views.py

@@ -1,13 +0,0 @@
-# -*- coding: utf-8 -*-
-
-from plone.gallery.views.photo_gallery import PhotoGallery
-from imio.smartweb.core.utils import get_scale_url
-from imio.smartweb.core.contents.sections.views import SectionView
-
-
-class GalleryView(SectionView, PhotoGallery):
-    """Gallery Section view"""
-
-    def get_scale_url(self, item, scale, orientation="paysage"):
-        request = self.request
-        return get_scale_url(item, request, "image", scale, orientation)

imio_smartweb_core-1.2.84/src/imio/smartweb/core/contents/sections/video/views.py

@@ -1,10 +0,0 @@
-# -*- coding: utf-8 -*-
-
-from embeddify import Embedder
-from imio.smartweb.core.contents.sections.views import SectionView
-
-
-class VideoView(SectionView):
-    def get_embed_video(self, width=800, height=600):
-        embedder = Embedder(width=width, height=height)
-        return embedder(self.context.video_url, params=dict(autoplay=False))