iii-sdk 0.21.0.dev1__tar.gz → 0.21.2.dev1__tar.gz

{iii_sdk-0.21.0.dev1 → iii_sdk-0.21.2.dev1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: iii-sdk
-Version: 0.21.0.dev1
+Version: 0.21.2.dev1
 Summary: III SDK for Python
 Project-URL: Homepage, https://github.com/iii-hq/iii
 Project-URL: Repository, https://github.com/iii-hq/iii
@@ -14,7 +14,7 @@ Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Requires-Python: >=3.10
-Requires-Dist: iii-helpers==0.21.0.dev1
+Requires-Dist: iii-helpers==0.21.2.dev1
 Requires-Dist: opentelemetry-api>=1.25
 Requires-Dist: pydantic>=2.0
 Requires-Dist: websockets>=12.0

{iii_sdk-0.21.0.dev1 → iii_sdk-0.21.2.dev1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "iii-sdk"
-version = "0.21.0.dev1"
+version = "0.21.2.dev1"
 description = "III SDK for Python"
 authors = [{ name = "III" }]
 license = { text = "Apache-2.0" }
@@ -23,7 +23,7 @@ dependencies = [
     "websockets>=12.0",
     "pydantic>=2.0",
     "opentelemetry-api>=1.25",
-    "iii-helpers==0.21.0.dev1",
+    "iii-helpers==0.21.2.dev1",
 ]
 
 [project.urls]

{iii_sdk-0.21.0.dev1 → iii_sdk-0.21.2.dev1}/tests/test_baggage_span_processor.py

@@ -10,10 +10,7 @@ from opentelemetry.sdk.trace.export.in_memory_span_exporter import (
 )
 from opentelemetry.sdk.trace.sampling import ALWAYS_OFF
 
-from iii_helpers.observability import (
-    DEFAULT_ALLOWLIST,
-    BaggageSpanProcessor,
-)
+from iii_helpers.observability import BaggageSpanProcessor
 
 
 def _build_test_provider(
@@ -40,26 +37,35 @@ def _first_span_attr(exporter: InMemorySpanExporter, key: str) -> object | None:
     return spans[0].attributes.get(key) if spans[0].attributes else None
 
 
-def test_copies_default_allowlist_from_baggage_to_attributes() -> None:
+def test_copies_every_baggage_entry_to_attributes() -> None:
+    """No key policy: baggage copies to span attributes unconditionally.
+
+    Which attributes *mean* something (`iii.tag.*`, `iii.session.*`) is a
+    query-side convention owned by the engine's traces API — a filtering
+    policy baked into worker binaries would silently drop newer keys from
+    any worker running an older SDK.
+    """
     provider, exporter = _build_test_provider(BaggageSpanProcessor())
     tracer = provider.get_tracer("test")
 
-    token = _attach_baggage(
-        {
-            "iii.session.id": "S-1",
-            "iii.message.id": "M-1",
-            "iii.function.id": "auth::set_token",
-        }
-    )
+    entries = {
+        "iii.session.id": "S-1",
+        "iii.session.name": "refactor auth",
+        "iii.message.id": "M-1",
+        "iii.function.id": "auth::set_token",
+        "iii.tag.message": "fix the login bug",
+        # Non-iii baggage is a first-class tag source too.
+        "tenant.id": "t-42",
+    }
+    token = _attach_baggage(entries)
     try:
         with tracer.start_as_current_span("inner"):
             pass
     finally:
         context.detach(token)
 
-    assert _first_span_attr(exporter, "iii.session.id") == "S-1"
-    assert _first_span_attr(exporter, "iii.message.id") == "M-1"
-    assert _first_span_attr(exporter, "iii.function.id") == "auth::set_token"
+    for key, value in entries.items():
+        assert _first_span_attr(exporter, key) == value, key
 
 
 def test_missing_baggage_entry_means_attribute_not_set() -> None:
@@ -78,51 +84,6 @@ def test_missing_baggage_entry_means_attribute_not_set() -> None:
     assert _first_span_attr(exporter, "iii.function.id") is None
 
 
-def test_baggage_entries_not_in_allowlist_are_dropped() -> None:
-    provider, exporter = _build_test_provider(BaggageSpanProcessor())
-    tracer = provider.get_tracer("test")
-
-    token = _attach_baggage(
-        {
-            "iii.message.id": "M",
-            "tenant.id": "t-42",
-            "debug.feature_flag": "on",
-        }
-    )
-    try:
-        with tracer.start_as_current_span("inner"):
-            pass
-    finally:
-        context.detach(token)
-
-    assert _first_span_attr(exporter, "iii.message.id") == "M"
-    assert _first_span_attr(exporter, "tenant.id") is None
-    assert _first_span_attr(exporter, "debug.feature_flag") is None
-
-
-def test_custom_allowlist_is_honored() -> None:
-    processor = BaggageSpanProcessor(allowlist=["tenant.id", "iii.message.id"])
-    provider, exporter = _build_test_provider(processor)
-    tracer = provider.get_tracer("test")
-
-    token = _attach_baggage(
-        {
-            "tenant.id": "t-1",
-            "iii.message.id": "M",
-            "iii.session.id": "S-not-copied",
-        }
-    )
-    try:
-        with tracer.start_as_current_span("inner"):
-            pass
-    finally:
-        context.detach(token)
-
-    assert _first_span_attr(exporter, "tenant.id") == "t-1"
-    assert _first_span_attr(exporter, "iii.message.id") == "M"
-    assert _first_span_attr(exporter, "iii.session.id") is None
-
-
 def test_empty_parent_context_produces_no_attributes() -> None:
     provider, exporter = _build_test_provider(BaggageSpanProcessor())
     tracer = provider.get_tracer("test")
@@ -151,12 +112,3 @@ def test_noop_guard_skips_processing_when_sampled_out() -> None:
         context.detach(token)
 
     assert exporter.get_finished_spans() == ()
-
-
-def test_default_allowlist_matches_other_sdks() -> None:
-    """DEFAULT_ALLOWLIST drift across languages would break worker chains."""
-    assert tuple(DEFAULT_ALLOWLIST) == (
-        "iii.session.id",
-        "iii.message.id",
-        "iii.function.id",
-    )

{iii_sdk-0.21.0.dev1 → iii_sdk-0.21.2.dev1}/tests/test_register_function_args.py

@@ -2,6 +2,7 @@
 
 import json
 import time
+from collections.abc import Callable
 from types import SimpleNamespace
 from typing import Any
 
@@ -17,6 +18,8 @@ from iii.iii_types import RegisterFunctionFormat
 # FakeWs helpers
 # ---------------------------------------------------------------------------
 
+_CREATED_CLIENTS: list[III] = []
+
 
 class FakeWebSocket:
     def __init__(self) -> None:
@@ -51,10 +54,38 @@ def _patch_ws(monkeypatch: pytest.MonkeyPatch) -> FakeWebSocket:
 
 def _make_client() -> III:
     client = III("ws://fake", InitOptions())
-    time.sleep(0.05)
+    _CREATED_CLIENTS.append(client)
+    _wait_for(lambda: client.get_connection_state() == "connected", "fake WebSocket client to connect")
     return client
 
 
+@pytest.fixture(autouse=True)
+def _shutdown_created_clients() -> None:
+    yield
+    while _CREATED_CLIENTS:
+        client = _CREATED_CLIENTS.pop()
+        if client._thread.is_alive():
+            client.shutdown()
+
+
+def _wait_for(predicate: Callable[[], bool], what: str, timeout: float = 2.0) -> None:
+    deadline = time.monotonic() + timeout
+    while time.monotonic() < deadline:
+        if predicate():
+            return
+        time.sleep(0.005)
+    pytest.fail(f"timed out waiting for {what}")
+
+
+def _registration_messages(ws: FakeWebSocket, function_id: str) -> list[dict[str, Any]]:
+    return [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == function_id]
+
+
+def _wait_for_registration(ws: FakeWebSocket, function_id: str) -> list[dict[str, Any]]:
+    _wait_for(lambda: bool(_registration_messages(ws, function_id)), f"registration for {function_id}")
+    return _registration_messages(ws, function_id)
+
+
 # ---------------------------------------------------------------------------
 # Two-arg register_function tests
 # ---------------------------------------------------------------------------
@@ -78,9 +109,8 @@ def test_register_function_str_with_request_format(monkeypatch: pytest.MonkeyPat
         return data
 
     client.register_function("demo.with_args", handler, request_format=req_fmt)
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.with_args"]
+    reg_msgs = _wait_for_registration(ws, "demo.with_args")
     assert len(reg_msgs) == 1
 
     sent_req_fmt = reg_msgs[0].get("request_format")
@@ -127,9 +157,8 @@ def test_register_function_str_with_both_formats(monkeypatch: pytest.MonkeyPatch
         response_format=res_fmt,
         metadata={"version": "1"},
     )
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.both_formats"]
+    reg_msgs = _wait_for_registration(ws, "demo.both_formats")
     assert len(reg_msgs) == 1
     assert reg_msgs[0].get("description") == "A search function"
     assert reg_msgs[0].get("request_format") is not None
@@ -149,9 +178,8 @@ def test_register_function_str_minimal(monkeypatch: pytest.MonkeyPatch) -> None:
         return data
 
     client.register_function("demo.minimal", handler)
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.minimal"]
+    reg_msgs = _wait_for_registration(ws, "demo.minimal")
     assert len(reg_msgs) == 1
     assert "request_format" not in reg_msgs[0]
     assert "response_format" not in reg_msgs[0]
@@ -179,9 +207,8 @@ def test_register_function_str_with_http_invocation_and_format(monkeypatch: pyte
         HttpInvocationConfig(url="https://example.com/fn", method="POST"),
         request_format=req_fmt,
     )
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "external::with_format"]
+    reg_msgs = _wait_for_registration(ws, "external::with_format")
     assert len(reg_msgs) == 1
     assert reg_msgs[0].get("invocation", {}).get("url") == "https://example.com/fn"
     assert reg_msgs[0].get("request_format") is not None
@@ -230,9 +257,8 @@ def test_register_function_str_id_auto_extracts_formats(monkeypatch: pytest.Monk
         return UserOutput(message=f"Hello {data.name}")
 
     client.register_function("demo.auto", handler, description="Auto-extract demo")
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.auto"]
+    reg_msgs = _wait_for_registration(ws, "demo.auto")
     assert len(reg_msgs) == 1
     msg = reg_msgs[0]
 
@@ -282,9 +308,8 @@ def test_register_function_str_id_explicit_formats_override(monkeypatch: pytest.
         request_format=explicit_req,
         response_format=explicit_res,
     )
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.explicit"]
+    reg_msgs = _wait_for_registration(ws, "demo.explicit")
     assert len(reg_msgs) == 1
     msg = reg_msgs[0]
 
@@ -306,9 +331,8 @@ def test_register_function_str_id_no_annotations(monkeypatch: pytest.MonkeyPatch
         return data
 
     client.register_function("demo.no_hints", handler)
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.no_hints"]
+    reg_msgs = _wait_for_registration(ws, "demo.no_hints")
     assert len(reg_msgs) == 1
     assert "request_format" not in reg_msgs[0]
     assert "response_format" not in reg_msgs[0]
@@ -325,9 +349,8 @@ def test_register_function_str_id_with_metadata(monkeypatch: pytest.MonkeyPatch)
         return data
 
     client.register_function("demo.meta", handler, metadata={"version": "2.0"})
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.meta"]
+    reg_msgs = _wait_for_registration(ws, "demo.meta")
     assert len(reg_msgs) == 1
     assert reg_msgs[0]["metadata"] == {"version": "2.0"}
 
@@ -352,9 +375,8 @@ def test_register_function_str_id_with_http_invocation(monkeypatch: pytest.Monke
         HttpInvocationConfig(url="https://example.com/fn", method="POST"),
         description="HTTP function",
     )
-    time.sleep(0.02)
 
-    reg_msgs = [m for m in ws.sent if m.get("type") == "registerfunction" and m.get("id") == "demo.http"]
+    reg_msgs = _wait_for_registration(ws, "demo.http")
     assert len(reg_msgs) == 1
     assert reg_msgs[0]["invocation"]["url"] == "https://example.com/fn"
     assert reg_msgs[0]["description"] == "HTTP function"