ign-pdal-tools 1.8.0__tar.gz → 1.10.0__tar.gz

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ign-pdal-tools
-Version: 1.8.0
+Version: 1.10.0
 Summary: Library for common LAS files manipulation with PDAL
 Author-email: Guillaume Liegard <guillaume.liegard@ign.fr>
 Description-Content-Type: text/markdown

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/ign_pdal_tools.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ign-pdal-tools
-Version: 1.8.0
+Version: 1.10.0
 Summary: Library for common LAS files manipulation with PDAL
 Author-email: Guillaume Liegard <guillaume.liegard@ign.fr>
 Description-Content-Type: text/markdown

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/ign_pdal_tools.egg-info/SOURCES.txt

@@ -13,6 +13,7 @@ pdaltools/las_clip.py
 pdaltools/las_info.py
 pdaltools/las_merge.py
 pdaltools/las_remove_dimensions.py
+pdaltools/las_rename_dimension.py
 pdaltools/pcd_info.py
 pdaltools/replace_attribute_in_las.py
 pdaltools/standardize_format.py
@@ -24,7 +25,9 @@ test/test_las_clip.py
 test/test_las_info.py
 test/test_las_merge.py
 test/test_las_remove_dimensions.py
+test/test_las_rename_dimension.py
 test/test_pcd_info.py
+test/test_pdal_custom.py
 test/test_replace_attribute_in_las.py
 test/test_standardize_format.py
 test/test_unlock.py

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/pdaltools/_version.py

@@ -1,4 +1,4 @@
-__version__ = "1.8.0"
+__version__ = "1.10.0"
 
 
 if __name__ == "__main__":

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/pdaltools/add_points_in_pointcloud.py

@@ -1,5 +1,6 @@
 import argparse
 from shutil import copy2
+import tempfile
 
 import geopandas as gpd
 import laspy
@@ -10,6 +11,8 @@ from shapely.geometry import MultiPoint, Point, box
 
 from pdaltools.las_info import get_epsg_from_las, get_tile_bbox
 
+import pdal
+
 
 def parse_args(argv=None):
     parser = argparse.ArgumentParser("Add points from GeoJSON in LIDAR tile")
@@ -127,10 +130,12 @@ def add_points_to_las(
         crs (str): CRS of the data.
         virtual_points_classes (int): The classification value to assign to those virtual points (default: 66).
     """
+
     if input_points_with_z.empty:
         print(
             "No points to add. All points of the geojson file are outside the tile. Copying the input file to output"
         )
+        copy2(input_las, output_las)
         return
 
     # Extract XYZ coordinates and additional attribute (classification)
@@ -141,32 +146,34 @@ def add_points_to_las(
     classes = virtual_points_classes * np.ones(nb_points)
 
     # Open the input LAS file to check and possibly update the header of the output
-    with laspy.open(input_las) as las:
+    with laspy.open(input_las, "r") as las:
         header = las.header
         if not header:
             header = laspy.LasHeader(point_format=8, version="1.4")
+
+    new_points = laspy.ScaleAwarePointRecord.zeros(nb_points, header=header)  # use header for input_las
+    # then fill in the gaps (X, Y, Z an classification)
+    new_points.x = x_coords.astype(new_points.x.dtype)
+    new_points.y = y_coords.astype(new_points.y.dtype)
+    new_points.z = z_coords.astype(new_points.z.dtype)
+    new_points.classification = classes.astype(new_points.classification.dtype)
+
+    with tempfile.NamedTemporaryFile(suffix="_new_points.las") as tmp:
+        with laspy.open(tmp.name, mode="w", header=header) as las_file:
+            las_file.write_points(new_points)
+
         if crs:
-            try:
-                crs_obj = CRS.from_user_input(crs)  # Convert to a pyproj.CRS object
-            except CRSError:
-                raise ValueError(f"Invalid CRS: {crs}")
-            header.add_crs(crs_obj)
-
-    # Copy data pointcloud
-    copy2(input_las, output_las)
-
-    # Add the new points with 3D points
-    nb_points = len(x_coords)
-    with laspy.open(output_las, mode="a", header=header) as output_las:  # mode `a` for adding points
-        # create nb_points points with "0" everywhere
-        new_points = laspy.ScaleAwarePointRecord.zeros(nb_points, header=header)  # use header for input_las
-        # then fill in the gaps (X, Y, Z an classification)
-        new_points.x = x_coords.astype(new_points.x.dtype)
-        new_points.y = y_coords.astype(new_points.y.dtype)
-        new_points.z = z_coords.astype(new_points.z.dtype)
-        new_points.classification = classes.astype(new_points.classification.dtype)
-
-        output_las.append_points(new_points)
+            a_srs = crs
+        else:
+            a_srs = get_epsg_from_las(input_las)
+
+        # Use pdal to merge the new points with the existing points
+        pipeline = pdal.Pipeline()
+        pipeline |= pdal.Reader.las(filename=input_las)
+        pipeline |= pdal.Reader.las(filename=tmp.name)
+        pipeline |= pdal.Filter.merge()
+        pipeline |= pdal.Writer.las(filename=output_las, forward="all", a_srs=a_srs)
+        pipeline.execute()
 
 
 def line_to_multipoint(line, spacing: float, z_value: float = None):

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/pdaltools/las_add_buffer.py

@@ -158,7 +158,6 @@ def remove_points_from_buffer(input_file: str, output_file: str):
         pipeline |= pdal.Filter.range(limits=f"{ORIGINAL_TILE_TAG}[1:1]")
         pipeline |= pdal.Writer.las(filename=tmp_las.name, forward="all", extra_dims="all")
         pipeline.execute()
-
         remove_dimensions_from_las(tmp_las.name, dimensions=[ORIGINAL_TILE_TAG], output_las=output_file)
 
 

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/pdaltools/las_remove_dimensions.py

@@ -5,22 +5,36 @@ import pdal
 from pdaltools.las_info import get_writer_parameters_from_reader_metadata
 
 
-def remove_dimensions_from_las(input_las: str, dimensions: [str], output_las: str):
+def remove_dimensions_from_points(points, metadata, dimensions: [str], output_las: str):
     """
     export new las without some dimensions
     """
-    pipeline = pdal.Pipeline() | pdal.Reader.las(input_las)
-    pipeline.execute()
-    points = pipeline.arrays[0]
+
+    mandatory_dimensions = ["X", "Y", "Z", "x", "y", "z"]
+    output_dimensions_test = [dim for dim in dimensions if dim not in mandatory_dimensions]
+    assert len(output_dimensions_test) == len(
+        dimensions
+    ), "All dimensions to remove must not be mandatory dimensions (X,Y,Z,x,y,z)"
+
     input_dimensions = list(points.dtype.fields.keys())
     output_dimensions = [dim for dim in input_dimensions if dim not in dimensions]
     points_pruned = points[output_dimensions]
-    params = get_writer_parameters_from_reader_metadata(pipeline.metadata)
+    params = get_writer_parameters_from_reader_metadata(metadata)
     pipeline_end = pdal.Pipeline(arrays=[points_pruned])
     pipeline_end |= pdal.Writer.las(output_las, forward="all", **params)
     pipeline_end.execute()
 
 
+def remove_dimensions_from_las(input_las: str, dimensions: [str], output_las: str):
+    """
+    export new las without some dimensions
+    """
+    pipeline = pdal.Pipeline() | pdal.Reader.las(input_las)
+    pipeline.execute()
+    points = pipeline.arrays[0]
+    remove_dimensions_from_points(points, pipeline.metadata, dimensions, output_las)
+
+
 def parse_args():
     parser = argparse.ArgumentParser("Remove dimensions from las")
     parser.add_argument(

ign_pdal_tools-1.10.0/pdaltools/las_rename_dimension.py

@@ -0,0 +1,79 @@
+"""
+Rename dimensions in a LAS file using PDAL's Python API.
+
+This script allows renaming dimensions in a LAS file while preserving all other data.
+"""
+
+import argparse
+import pdal
+import sys
+from pathlib import Path
+from pdaltools.las_remove_dimensions import remove_dimensions_from_points
+
+
+def rename_dimension(input_file: str, output_file: str, old_dims: list[str], new_dims: list[str]):
+    """
+Rename one or multiple dimensions in a LAS file using PDAL.
+
+Args:
+    input_file: Path to the input LAS file
+    output_file: Path to save the output LAS file
+    old_dims: List of names of dimensions to rename
+    new_dims: List of new names for the dimensions
+"""
+
+    # Validate dimensions
+    if len(old_dims) != len(new_dims):
+        raise ValueError("Number of old dimensions must match number of new dimensions")
+
+    mandatory_dimensions = ['X', 'Y', 'Z', 'x', 'y', 'z']
+    for dim in new_dims:
+        if dim in mandatory_dimensions:
+            raise ValueError(f"New dimension {dim} cannot be a mandatory dimension (X,Y,Z,x,y,z)")
+
+    pipeline = pdal.Pipeline() | pdal.Reader.las(input_file)
+    for old, new in zip(old_dims, new_dims):
+        pipeline |= pdal.Filter.ferry(dimensions=f"{old} => {new}")
+    pipeline |= pdal.Writer.las(output_file)
+    pipeline.execute()
+    points = pipeline.arrays[0]
+
+    # Remove old dimensions
+    remove_dimensions_from_points(points, pipeline.metadata, old_dims, output_file)
+
+
+def main():
+    parser = argparse.ArgumentParser(description="Rename dimensions in a LAS file")
+    parser.add_argument("input_file", help="Input LAS file")
+    parser.add_argument("output_file", help="Output LAS file")
+    parser.add_argument(
+        "--old-dims",
+        nargs="+",
+        required=True,
+        help="Names of dimensions to rename (can specify multiple)",
+    )
+    parser.add_argument(
+        "--new-dims",
+        nargs="+",
+        required=True,
+        help="New names for the dimensions (must match --old-dims count)",
+    )
+
+    args = parser.parse_args()
+    
+    # Validate input file
+    input_path = Path(args.input_file)
+    if not input_path.exists():
+        print(f"Error: Input file {args.input_file} does not exist", file=sys.stderr)
+        sys.exit(1)
+    
+    # Validate output file
+    output_path = Path(args.output_file)
+    if output_path.exists():
+        print(f"Warning: Output file {args.output_file} already exists. It will be overwritten.")
+    
+    rename_dimension(args.input_file, args.output_file, args.old_dims, args.new_dims)
+
+
+if __name__ == "__main__":
+    main()

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/pdaltools/unlock_file.py

@@ -1,5 +1,4 @@
-"""Tools to handle malformed las/laz files
-    """
+"""Tools to handle malformed las/laz files"""
 
 # https://gis.stackexchange.com/questions/413191/python-pdal-error-reading-format-1-4-las-file-readers-las-error-global-enco
 

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/test/test_add_points_in_pointcloud.py

@@ -26,6 +26,7 @@ INPUT_LIGNES_2D_GEOJSON = os.path.join(DATA_LIGNES_PATH, "Lignes_2d_0292_6833.ge
 INPUT_LIGNES_3D_GEOJSON = os.path.join(DATA_LIGNES_PATH, "Lignes_3d_0292_6833.geojson")
 INPUT_LIGNES_SHAPE = os.path.join(DATA_LIGNES_PATH, "Lignes_3d_0292_6833.shp")
 OUTPUT_FILE = os.path.join(TMP_PATH, "test_semis_2023_0292_6833_LA93_IGN69.laz")
+INPUT_EMPTY_POINTS_2D = os.path.join(DATA_POINTS_3D_PATH, "Points_virtuels_2d_empty.geojson")
 
 # Cropped las tile used to test adding points that belong to the theorical tile but not to the
 # effective las file extent
@@ -81,19 +82,21 @@ def test_clip_3d_lines_to_tile(input_file, epsg):
 
 
 @pytest.mark.parametrize(
-    "input_file, epsg, expected_nb_points",
+    "input_file, epsg, input_points_2d, expected_nb_points",
     [
-        (INPUT_PCD, "EPSG:2154", 2423),  # should work when providing an epsg value
-        (INPUT_PCD, None, 2423),  # Should also work with no epsg value (get from las file)
-        (INPUT_PCD_CROPPED, None, 2423),
+        (INPUT_PCD, "EPSG:2154", INPUT_POINTS_2D, 2423),  # should work when providing an epsg value
+        (INPUT_PCD, None, INPUT_POINTS_2D, 2423),  # Should also work with no epsg value (get from las file)
+        (INPUT_PCD_CROPPED, None, INPUT_POINTS_2D_FOR_CROPPED_PCD, 451),
+        # Should also work if there is no points (direct copy of the input file)
+        (INPUT_PCD_CROPPED, None, INPUT_EMPTY_POINTS_2D, 0),
     ],
 )
-def test_add_points_to_las(input_file, epsg, expected_nb_points):
+def test_add_points_to_las(input_file, epsg, input_points_2d, expected_nb_points):
     # Ensure the output file doesn't exist before the test
     if Path(OUTPUT_FILE).exists():
         os.remove(OUTPUT_FILE)
 
-    points = gpd.read_file(INPUT_POINTS_2D)
+    points = gpd.read_file(input_points_2d)
     add_points_in_pointcloud.add_points_to_las(points, input_file, OUTPUT_FILE, epsg, 68)
     assert Path(OUTPUT_FILE).exists()  # check output exists
 
@@ -269,6 +272,22 @@ def test_add_points_from_geometry_to_las(input_file, input_points, epsg, expecte
         input_points, input_file, OUTPUT_FILE, 68, epsg, 1000, spacing, altitude_column
     )
     assert Path(OUTPUT_FILE).exists()  # check output exists
+    
+    # Read input and output files to compare headers
+    input_las = laspy.read(input_file)
+    output_las = laspy.read(OUTPUT_FILE)
+    
+    # Compare headers
+    assert input_las.header.version == output_las.header.version
+    assert input_las.header.system_identifier == output_las.header.system_identifier
+    assert input_las.header.extra_header_bytes == output_las.header.extra_header_bytes
+    assert input_las.header.extra_vlr_bytes == output_las.header.extra_vlr_bytes
+    assert input_las.header.number_of_evlrs == output_las.header.number_of_evlrs
+    assert input_las.header.point_format == output_las.header.point_format
+    assert np.array_equal(input_las.header.scales, output_las.header.scales)
+    assert np.array_equal(input_las.header.offsets, output_las.header.offsets)
+    assert input_las.header.vlrs[0].string == output_las.header.vlrs[0].string
+    
     point_count = compute_count_one_file(OUTPUT_FILE)["68"]
     assert point_count == expected_nb_points  # Add all points from geojson
 

{ign_pdal_tools-1.8.0 → ign_pdal_tools-1.10.0}/test/test_color.py

@@ -80,8 +80,12 @@ def test_download_image_ok():
 
     # check there is no noData
     raster = gdal.Open(tif_output)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -96,8 +100,12 @@ def test_download_image_ok_one_download():
     # check there is no noData
     raster = gdal.Open(tif_output)
     assert raster.ReadAsArray().shape == (3, expected_pixel_size, expected_pixel_size)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -117,8 +125,12 @@ def test_download_image_ok_one_download_with_extra_pixel(pixel_per_meter, expect
     raster = gdal.Open(tif_output)
 
     assert raster.ReadAsArray().shape == (3, expected_pixel_size, expected_pixel_size)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -144,8 +156,12 @@ def test_download_image_ok_more_downloads(pixel_per_meter, expected_pixel_size):
     # check there is no noData
     raster = gdal.Open(tif_output)
     assert raster.ReadAsArray().shape == (3, expected_pixel_size, expected_pixel_size)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -166,8 +182,12 @@ def test_download_image_ok_more_downloads_with_extra_pixel(pixel_per_meter, expe
     # check there is no noData
     raster = gdal.Open(tif_output)
     assert raster.ReadAsArray().shape == (3, expected_pixel_size, expected_pixel_size)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -177,8 +197,12 @@ def test_download_image_download_size_gpf_bigger():
 
     # check there is no noData
     raster = gdal.Open(tif_output)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf
@@ -191,8 +215,12 @@ def test_download_image_download_size_gpf_size_almost_ok():
 
     # check there is no noData
     raster = gdal.Open(tif_output)
-    for i in range(raster.RasterCount):
-        assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
+    assert np.any(raster.ReadAsArray())  # Check that the raster array is not empty
+    # TODO: Fix this test: it did not correspond to what was expected:
+    # - GetNoDataValue returns the value of no_data, not the number of occurrences
+    # - it is possible to have occasional no data values if no_data == 255. (white pixels)
+    # for i in range(raster.RasterCount):
+    #     assert raster.GetRasterBand(i + 1).GetNoDataValue() is None
 
 
 @pytest.mark.geopf

ign_pdal_tools-1.10.0/test/test_las_rename_dimension.py

@@ -0,0 +1,159 @@
+import os
+import pytest
+import tempfile
+import numpy as np
+import laspy
+import sys
+from pdaltools.las_rename_dimension import rename_dimension, main
+from pyproj import CRS
+
+def create_test_las_file():
+    """Create a temporary LAS file with test data."""
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        # Create a LAS file with some test points
+        header = laspy.LasHeader(point_format=3, version="1.4")
+        header.add_extra_dim(laspy.ExtraBytesParams(name="test_dim", type=np.float32))
+        header.add_extra_dim(laspy.ExtraBytesParams(name="test_dim2", type=np.int32))
+        
+        las = laspy.LasData(header)
+
+        crs_pyproj = CRS.from_string("epsg:4326")
+        las.header.add_crs(crs_pyproj)
+
+        # Add some test points
+        las.x = np.array([1.0, 2.0, 3.0])
+        las.y = np.array([4.0, 5.0, 6.0])
+        las.z = np.array([7.0, 8.0, 9.0])
+        las.test_dim = np.array([10.0, 11.0, 12.0])
+        las.test_dim2 = np.array([12, 13, 14])
+        
+        las.write(tmp_file.name)
+        return tmp_file.name
+
+def test_rename_dimension():
+    """Test renaming a dimension in a LAS file."""
+    # Create a temporary input LAS file
+    input_file = create_test_las_file()
+    
+    # Create temporary output file
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        output_file = tmp_file.name
+    
+    try:
+        # Rename dimension using direct function call
+        rename_dimension(input_file, output_file, ["test_dim", "test_dim2"], ["new_test_dim", "new_test_dim2"])
+        
+        # Verify the dimension was renamed
+        with laspy.open(output_file) as las_file:
+            las = las_file.read()
+            assert "new_test_dim" in las.point_format.dimension_names
+            assert "test_dim" not in las.point_format.dimension_names
+            assert "new_test_dim2" in las.point_format.dimension_names
+            assert "test_dim2" not in las.point_format.dimension_names
+            
+            # Verify the data is preserved
+            np.testing.assert_array_equal(las.x, [1.0, 2.0, 3.0])
+            np.testing.assert_array_equal(las.y, [4.0, 5.0, 6.0])
+            np.testing.assert_array_equal(las.z, [7.0, 8.0, 9.0])
+            np.testing.assert_array_equal(las["new_test_dim"], [10.0, 11.0, 12.0])
+            np.testing.assert_array_equal(las["new_test_dim2"], [12, 13, 14])
+    finally:
+        # Clean up temporary files
+        try:
+            os.unlink(input_file)
+            os.unlink(output_file)
+        except:
+            pass
+
+def test_rename_nonexistent_dimension():
+    """Test attempting to rename a dimension that doesn't exist."""
+    input_file = create_test_las_file()
+    
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        output_file = tmp_file.name
+    
+    try:
+        with pytest.raises(RuntimeError):
+            rename_dimension(input_file, output_file, ["nonexistent_dim"], ["new_dim"])
+    finally:
+        os.unlink(input_file)
+        os.unlink(output_file)
+
+def test_rename_to_existing_dimension():
+    """Test attempting to rename to an existing dimension."""
+    input_file = create_test_las_file()
+    
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        output_file = tmp_file.name
+    
+    try:
+        with pytest.raises(ValueError):
+            rename_dimension(input_file, output_file, ["test_dim"], ["x"])
+    finally:
+        os.unlink(input_file)
+        os.unlink(output_file)
+
+def test_rename_dimension_case_sensitive():
+    """Test that dimension renaming is case-sensitive."""
+    input_file = create_test_las_file()
+    
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        output_file = tmp_file.name
+    
+    try:
+        with pytest.raises(RuntimeError):
+            rename_dimension(input_file, output_file, ["TEST_DIM"], ["new_dim"])
+    finally:
+        os.unlink(input_file)
+        os.unlink(output_file)
+
+
+def test_rename_dimension_main():
+    """Test renaming dimensions using the main() function."""
+    # Create a temporary input LAS file
+    input_file = create_test_las_file()
+    
+    # Create temporary output file
+    with tempfile.NamedTemporaryFile(suffix='.las', delete=False) as tmp_file:
+        output_file = tmp_file.name
+    
+    try:
+        # Save original sys.argv
+        original_argv = sys.argv
+        
+        # Mock command-line arguments
+        sys.argv = [
+            "las_rename_dimension.py",  # script name
+            input_file,
+            output_file,
+            "--old-dims", "test_dim", "test_dim2",
+            "--new-dims", "new_test_dim", "new_test_dim2"
+        ]
+        
+        # Call main() function
+        main()
+        
+        # Restore original sys.argv
+        sys.argv = original_argv
+        
+        # Verify the dimension was renamed
+        with laspy.open(output_file) as las_file:
+            las = las_file.read()
+            assert "new_test_dim" in las.point_format.dimension_names
+            assert "test_dim" not in las.point_format.dimension_names
+            assert "new_test_dim2" in las.point_format.dimension_names
+            assert "test_dim2" not in las.point_format.dimension_names
+            
+            # Verify the data is preserved
+            np.testing.assert_array_equal(las.x, [1.0, 2.0, 3.0])
+            np.testing.assert_array_equal(las.y, [4.0, 5.0, 6.0])
+            np.testing.assert_array_equal(las.z, [7.0, 8.0, 9.0])
+            np.testing.assert_array_equal(las["new_test_dim"], [10.0, 11.0, 12.0])
+            np.testing.assert_array_equal(las["new_test_dim2"], [12, 13, 14])
+    finally:
+        # Clean up temporary files
+        try:
+            os.unlink(input_file)
+            os.unlink(output_file)
+        except:
+            pass

ign_pdal_tools-1.10.0/test/test_pdal_custom.py

@@ -0,0 +1,24 @@
+import os
+
+import pdal
+import pytest
+
+TEST_PATH = os.path.dirname(os.path.abspath(__file__))
+
+
+# this test only works with PDAL compiled on a custom fork and branch, so we mark it to avoid running it.
+@pytest.mark.pdal_custom
+def test_pdal_read_severals_extra_dims():
+    test_file = os.path.join(TEST_PATH, "data/las_with_several_extra_byte_bloc.laz")
+
+    pipeline = pdal.Reader.las(filename=test_file).pipeline()
+    metadata = pipeline.quickinfo["readers.las"]
+
+    # dimensions should contains 'Deviation' and 'confidence'
+    assert "Deviation" in metadata["dimensions"]
+    assert "confidence" in metadata["dimensions"]
+
+    # Test Python PDAL bindings
+    pipeline = pdal.Reader.las(filename=test_file).pipeline()
+    num_points = pipeline.execute()
+    assert num_points > 0