ign-pdal-tools 1.15.2__tar.gz → 1.15.4__tar.gz

{ign_pdal_tools-1.15.2 → ign_pdal_tools-1.15.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ign-pdal-tools
-Version: 1.15.2
+Version: 1.15.4
 Summary: Library for common LAS files manipulation with PDAL
 Author-email: Guillaume Liegard <guillaume.liegard@ign.fr>
 Description-Content-Type: text/markdown

{ign_pdal_tools-1.15.2 → ign_pdal_tools-1.15.4}/ign_pdal_tools.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ign-pdal-tools
-Version: 1.15.2
+Version: 1.15.4
 Summary: Library for common LAS files manipulation with PDAL
 Author-email: Guillaume Liegard <guillaume.liegard@ign.fr>
 Description-Content-Type: text/markdown

{ign_pdal_tools-1.15.2 → ign_pdal_tools-1.15.4}/pdaltools/_version.py

@@ -1,4 +1,4 @@
-__version__ = "1.15.2"
+__version__ = "1.15.4"
 
 
 if __name__ == "__main__":

{ign_pdal_tools-1.15.2 → ign_pdal_tools-1.15.4}/pdaltools/replace_area_in_pointcloud.py

@@ -102,21 +102,29 @@ def get_writer_params(input_file):
 
 
 def pipeline_read_from_cloud(filename):
+    print("source cloud: ", filename)
     pipeline_source = pdal.Pipeline()
     pipeline_source |= pdal.Reader.las(filename=filename)
     return pipeline_source
 
 
 def pipeline_read_from_DSM(dsm, ground_mask, classification):
+    print("DSM: ", dsm)
+    print("ground_mask: ", ground_mask)
+    print("classification: ", classification)
+
     # get nodata value
     ds = gdal.Open(dsm)
     band = ds.GetRasterBand(1)
     nodata_value = band.GetNoDataValue()
+    print("DSM: nodata:", nodata_value)
     ds.Close()
 
     pipeline = pdal.Pipeline()
     pipeline |= pdal.Reader.gdal(filename=dsm, header="Z")
-    pipeline |= pdal.Filter.expression(expression=f"Z != {nodata_value}")
+
+    if nodata_value is not None:  # nodata_value may be None and cause bugs
+        pipeline |= pdal.Filter.expression(expression=f"Z != {nodata_value}")
 
     pipeline |= pdal.Filter.ferry(dimensions="=> ground")
     pipeline |= pdal.Filter.assign(assignment="ground[:]=-1")
@@ -134,6 +142,11 @@ def pipeline_read_from_DSM(dsm, ground_mask, classification):
 def replace_area(
     target_cloud, pipeline_source, replacement_area, output_cloud, source_pdal_filter="", target_pdal_filter=""
 ):
+    print("target cloud: ", target_cloud)
+    print("replacement area: ", replacement_area)
+    print("output cloud: ", output_cloud)
+    print("source pdal filter: ", source_pdal_filter)
+    print("target pdal filter: ", target_pdal_filter)
     crops = []
     # pipeline to read target_cloud and remove points inside the polygon
     pipeline_target = pdal.Pipeline()
@@ -146,7 +159,8 @@ def replace_area(
     pipeline_target |= pdal.Filter.overlay(column="fid", dimension="geometryFid", datasource=replacement_area)
     # Keep only points out of the area
     pipeline_target |= pdal.Filter.expression(expression="geometryFid==-1", tag="A")
-    pipeline_target.execute()
+    target_count = pipeline_target.execute()
+    print("Step 1: target count: ", target_count)
 
     # get input dimensions dtype from target
     if pipeline_target.arrays:
@@ -177,10 +191,11 @@ def replace_area(
     pipeline_source |= pdal.Filter.overlay(column="fid", dimension="geometryFid", datasource=replacement_area)
     # Keep only points in the area
     pipeline_source |= pdal.Filter.expression(expression="geometryFid>=0", tag="B")
-    pipeline_source.execute()
+    source_count = pipeline_source.execute()
+    print("Step 2: source count: ", source_count)
 
     # add source to the result
-    if pipeline_source.arrays:
+    if source_count:
         # eventually add dimensions in source to have same dimensions as target cloud
         # we do that in numpy (instead of PDAL filter) to keep dimension types
         source_cloud_crop = pipeline_source.arrays[0]