httpr 0.4.6__tar.gz → 0.4.7__tar.gz

{httpr-0.4.6 → httpr-0.4.7}/Cargo.lock

@@ -492,7 +492,7 @@ checksum = "6dbf3de79e51f3d586ab4cb9d5c3e2c14aa28ed23d180cf89b4df0454a69cc87"
 
 [[package]]
 name = "httpr"
-version = "0.4.6"
+version = "0.4.7"
 dependencies = [
  "anyhow",
  "bytes",

{httpr-0.4.6 → httpr-0.4.7}/Cargo.toml

@@ -2,7 +2,7 @@
 name = "httpr"
 # Version is set dynamically by CI from git tags (e.g., v1.2.3 -> 1.2.3).
 # Do not edit manually. See .github/actions/set-version/ for details.
-version = "0.4.6"
+version = "0.4.7"
 edition = "2021"
 description = "Fast HTTP client for python"
 authors = ["thomasht86"]

{httpr-0.4.6 → httpr-0.4.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: httpr
-Version: 0.4.6
+Version: 0.4.7
 Classifier: Programming Language :: Rust
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3 :: Only

{httpr-0.4.6 → httpr-0.4.7}/pyproject.toml

@@ -11,7 +11,7 @@ keywords = [ "python", "request",]
 classifiers = [ "Programming Language :: Rust", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", "Programming Language :: Python :: 3.13", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: Implementation :: PyPy", "Topic :: Internet :: WWW/HTTP", "Topic :: Software Development :: Libraries :: Python Modules",]
 # Version is set dynamically by CI from git tags (e.g., v1.2.3 -> 1.2.3).
 # Do not edit manually. See .github/actions/set-version/ for details.
-version = "0.4.6"
+version = "0.4.7"
 dependencies = []
 [[project.authors]]
 name = "thomasht86"

{httpr-0.4.6 → httpr-0.4.7}/src/lib.rs

@@ -204,24 +204,25 @@ impl RClient {
                     client_builder = client_builder.add_root_certificate(cert);
                 }
             }
-            // Load client pem identity if provided
-            // Either from file path (client_pem) or direct data (client_pem_data)
-            let client_identity_pem = if let Some(pem_data) = &client_pem_data {
-                Some(pem_data.clone())
-            } else if let Some(pem_path) = &client_pem {
-                Some(fs::read(pem_path).map_err(|e| map_anyhow_error(anyhow::Error::new(e)))?)
-            } else {
-                None
-            };
-
-            if let Some(pem_bytes) = client_identity_pem {
-                let identity = Identity::from_pem(&pem_bytes).map_err(map_reqwest_error)?;
-                client_builder = client_builder.identity(identity);
-            }
         } else {
             client_builder = client_builder.danger_accept_invalid_certs(true);
         }
 
+        // Client mTLS identity must be applied regardless of `verify`: disabling
+        // server verification doesn't imply disabling client authentication.
+        let client_identity_pem = if let Some(pem_data) = &client_pem_data {
+            Some(pem_data.clone())
+        } else if let Some(pem_path) = &client_pem {
+            Some(fs::read(pem_path).map_err(|e| map_anyhow_error(anyhow::Error::new(e)))?)
+        } else {
+            None
+        };
+
+        if let Some(pem_bytes) = client_identity_pem {
+            let identity = Identity::from_pem(&pem_bytes).map_err(map_reqwest_error)?;
+            client_builder = client_builder.identity(identity);
+        }
+
         // Https_only
         if let Some(true) = https_only {
             client_builder = client_builder.https_only(true);

{httpr-0.4.6 → httpr-0.4.7}/tests/unit/test_ssl.py

@@ -184,6 +184,38 @@ class TestClientSSL(unittest.TestCase):
                 ca_cert_file=self.client_ca_path,
             )
 
+    def test_client_cert_sent_when_verify_disabled(self):
+        """Regression for issue #65: client cert must still be presented when verify=False.
+
+        Disabling server verification should not disable client authentication.
+        """
+        # client_pem (file path) + verify=False
+        with Client(client_pem=self.client_cert_path, verify=False) as client:
+            response = client.get(f"https://localhost:{self.server_port}")
+            self.assertEqual(response.status_code, 200)
+            self.assertEqual(response.text, "OK")
+
+        # client_pem_data (bytes) + verify=False
+        with open(self.client_cert_path, "rb") as f:
+            cert_data = f.read()
+        with Client(client_pem_data=cert_data, verify=False) as client:
+            response = client.get(f"https://localhost:{self.server_port}")
+            self.assertEqual(response.status_code, 200)
+            self.assertEqual(response.text, "OK")
+
+    def test_async_client_cert_sent_when_verify_disabled(self):
+        """Regression for issue #65 on the AsyncClient Python wrapper."""
+        with open(self.client_cert_path, "rb") as f:
+            cert_data = f.read()
+
+        async def make_request():
+            async with AsyncClient(client_pem_data=cert_data, verify=False) as client:
+                return await client.get(f"https://localhost:{self.server_port}")
+
+        response = asyncio.run(make_request())
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.text, "OK")
+
     def test_async_client_pem_and_data_are_mutually_exclusive(self):
         """AsyncClient should also enforce mutual exclusivity."""
         with open(self.client_cert_path, "rb") as f: