housebroken-cli 0.2.6__tar.gz → 0.2.8__tar.gz

{housebroken_cli-0.2.6 → housebroken_cli-0.2.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: housebroken-cli
-Version: 0.2.6
+Version: 0.2.8
 Summary: Agent-written pull requests that do not make a mess in someone else's house.
 Project-URL: Repository, https://github.com/lenamonj/housebroken
 License-Expression: MIT

{housebroken_cli-0.2.6 → housebroken_cli-0.2.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "housebroken-cli"
-version = "0.2.6"
+version = "0.2.8"
 description = "Agent-written pull requests that do not make a mess in someone else's house."
 dynamic = ["readme"]
 license = "MIT"

{housebroken_cli-0.2.6 → housebroken_cli-0.2.8}/scripts/inbox.sh

@@ -126,12 +126,18 @@ if [ "$do_ci" -eq 1 ]; then
   claimed="$(gh api "search/issues?q=is:pr+author:$user+is:open&per_page=1" --jq '.total_count' 2>/dev/null)"
   case "$claimed" in
     ''|*[!0-9]*) echo "CENSUS UNVERIFIED: could not read the open pull request count from the API" ;;
-    *) [ "$claimed" -eq "$total" ] || echo "CENSUS INCOMPLETE: search returned $total of $claimed open pull requests, so this census covers only part of them; re-run when the search rate limit recovers" ;;
+    *) [ "$total" -ge "$claimed" ] || echo "CENSUS INCOMPLETE: search returned $total of $claimed open pull requests, so this census covers only part of them; re-run when the search rate limit recovers" ;;
   esac
   flagged=0
+  unreadable=0
+  unreadable_list=""
   while read -r repo num draft; do
     [ -n "$repo" ] || continue
-    j="$(gh pr view "$num" --repo "$repo" --json mergeable,reviewDecision,statusCheckRollup 2>/dev/null)" || continue
+    j="$(gh pr view "$num" --repo "$repo" --json mergeable,reviewDecision,statusCheckRollup 2>/dev/null)"
+    if [ -z "$j" ]; then
+      # A pull request we could not read is not a clean one: say so rather than skipping in silence.
+      unreadable=$((unreadable + 1)); unreadable_list="$unreadable_list $repo#$num"; continue
+    fi
     why="$(jq -r --arg draft "$draft" '
       [ ( [.statusCheckRollup[]? | (.conclusion // .state // "")] | if any(. == "FAILURE" or . == "ERROR") then "FAILING" elif any(. == "ACTION_REQUIRED") then "needs-run-approval" else empty end ),
         ( if .mergeable == "CONFLICTING" then "CONFLICTING" else empty end ),
@@ -143,6 +149,7 @@ if [ "$do_ci" -eq 1 ]; then
       echo "$repo#$num: $why${fails:+  [$fails]}"
     fi
   done <<<"$prs"
+  [ "$unreadable" -eq 0 ] || echo "CENSUS UNREADABLE: could not read $unreadable of $total pull requests, so their state is unknown, not clean:$unreadable_list"
   echo "$flagged of $total open pull requests flagged"
 fi
 

{housebroken_cli-0.2.6 → housebroken_cli-0.2.8}/skills/housebroken/SKILL.md

@@ -71,11 +71,18 @@ report it in one line and do not proceed to the next step.
    that fails on the default branch for a wrong value, a crash or an
    out-of-bounds access, and "less memory" is not that test.
 
-4. **Prove it red first.**
+4. **Prove it red first, and prove the proof.**
    On a fresh clone of the upstream default branch, not the tree you found
    the bug in, write the test that fails. Run it and keep the failing output.
    Apply the patch. Run it again. Both results go into the pull request as
-   the test itself; the body states the fact in one sentence. When the
+   the test itself; the body states the fact in one sentence.
+   Ask what each step would print if it did nothing, and make that answer
+   different from success: revert by content and compare hashes rather than
+   trusting a command's exit code, check the clone's line endings before the
+   first edit, export PATH explicitly in any detached script and report every
+   step's exit code. Two arms of an experiment that agree exactly have not
+   tested the variable. Before filing, hash the changed file on disk against
+   the blob in the commit: a branch can carry the test and not the fix. When the
    patched function serves several public entry points or has several
    branches, the test is a grid: every entry point through every branch,
    plus the zero, identity and signed-boundary rows. A reviewer lists the