holmesgpt 0.14.1__tar.gz → 0.14.2__tar.gz

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: holmesgpt
-Version: 0.14.1
+Version: 0.14.2
 Summary: 
 Author: Natan Yellin
 Author-email: natan@robusta.dev

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/holmes/__init__.py

@@ -1,5 +1,5 @@
 # This is patched by github actions during release
-__version__ = "0.14.1"
+__version__ = "0.14.2"
 
 # Re-export version functions from version module for backward compatibility
 from .version import (

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/holmes/common/env_vars.py

@@ -73,11 +73,11 @@ LOG_LLM_USAGE_RESPONSE = load_bool("LOG_LLM_USAGE_RESPONSE", False)
 # For CLI only, enable user approval for potentially sensitive commands that would otherwise be rejected
 ENABLE_CLI_TOOL_APPROVAL = load_bool("ENABLE_CLI_TOOL_APPROVAL", True)
 
-MAX_GRAPH_POINTS = float(os.environ.get("MAX_GRAPH_POINTS", 200))
+MAX_GRAPH_POINTS = float(os.environ.get("MAX_GRAPH_POINTS", 100))
 
 # Limit each tool response to N% of the total context window.
 # Number between 0 and 100
 # Setting to either 0 or any number above 100 disables the logic that limits tool response size
 TOOL_MAX_ALLOCATED_CONTEXT_WINDOW_PCT = float(
-    os.environ.get("TOOL_MAX_ALLOCATED_CONTEXT_WINDOW_PCT", 10)
+    os.environ.get("TOOL_MAX_ALLOCATED_CONTEXT_WINDOW_PCT", 15)
 )

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/holmes/plugins/toolsets/grafana/toolset_grafana_tempo.py

@@ -242,9 +242,9 @@ Examples:
             import logging
 
             logger = logging.getLogger(__name__)
-            logger.info(f"Tempo query: {stats_query}")
+            logger.debug(f"Tempo query: {stats_query}")
 
-            logger.info(f"start: {start}, end: {end}")
+            logger.debug(f"start: {start}, end: {end}")
 
             all_traces_response = api.search_traces_by_query(
                 q=stats_query,
@@ -253,7 +253,7 @@ Examples:
                 limit=1000,
             )
 
-            logger.info(f"Response: {all_traces_response}")
+            logger.debug(f"Response: {all_traces_response}")
 
             traces = all_traces_response.get("traces", [])
             if not traces:

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/holmes/plugins/toolsets/prometheus/prometheus.py

@@ -43,14 +43,12 @@ PROMETHEUS_METADATA_API_LIMIT = 100  # Default limit for Prometheus metadata API
 DEFAULT_QUERY_TIMEOUT_SECONDS = 20
 MAX_QUERY_TIMEOUT_SECONDS = 180
 # Default character limit for query responses to prevent token limit issues
-DEFAULT_QUERY_RESPONSE_SIZE_LIMIT = 20000
+DEFAULT_QUERY_RESPONSE_SIZE_LIMIT = 30000
 # Default timeout for metadata API calls (discovery endpoints)
 DEFAULT_METADATA_TIMEOUT_SECONDS = 20
 MAX_METADATA_TIMEOUT_SECONDS = 60
 # Default time window for metadata APIs (in hours)
 DEFAULT_METADATA_TIME_WINDOW_HRS = 1
-# Sample size for data summaries when results are too large
-DATA_SUMMARY_SAMPLE_SIZE = 10
 
 
 class PrometheusConfig(BaseModel):

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/holmes/plugins/toolsets/prometheus/prometheus_instructions.jinja2

@@ -6,11 +6,20 @@
 * Combine multiple patterns with regex OR (|) to reduce API calls:
   - `{__name__=~"node_cpu.*|node_memory.*|node_disk.*"}` - get all node resource metrics in one call
   - `{__name__=~"container.*|pod.*|kube.*"}` - get all Kubernetes-related metrics
-  - `{namespace=~"default|kube-system|monitoring"}` - metrics from multiple namespaces
+  - `{namespace=~"example1|example2|example3"}` - metrics from multiple namespaces
 * Use `get_metric_metadata` after discovering names to get types/descriptions if needed
 * Use `get_label_values` to discover pods, namespaces, jobs: e.g., get_label_values(label="pod")
 * Only use `get_series` when you need full label sets (slower than other methods)
 
+## Retrying queries that return too much data
+* When a Prometheus query returns too much data (e.g., truncation error), you MUST retry with a more specific query or less data points or topk/bottomk
+* NEVER EVER EVER answer a question based on Prometheus data that was truncated as you might be missing important information and give the totally wrong answer
+* Prefer telling the user you can't answer the question because of too much data rather than answering based on incomplete data
+* You are also able to show graphs to the user (using the promql embed functionality mentioned below) so you can show users graphs and THEY can interpret the data themselves, even if you can't answer.
+* Do NOT hestitate to try alternative queries and try to reduce the amount of data returned until you get a successful query
+* Be extremely, extremely cautious when answering based on get_label_values because the existence of a label value says NOTHING about the metric value itself (is it high, low, or perhaps the label exists in Prometheus but its an older series not present right now)
+* DO NOT give answers about metrics based on what 'is typically the case' or 'common knowledge' - if you can't see the actual metric value, you MUST NEVER EVER answer about it - just tell the user your limitations due to the size of the data
+
 ## Alert Investigation & Query Execution
 * When investigating a Prometheus alert, ALWAYS call list_prometheus_rules to get the alert definition
 * Use Prometheus to query metrics from the alert promql
@@ -37,24 +46,19 @@
 * ALWAYS use `topk()` or `bottomk()` to limit the number of series returned
 * Standard pattern for high-cardinality queries:
   - Use `topk(5, <your_query>)` to get the top 5 series
-  - Example: `topk(5, rate(container_cpu_usage_seconds_total{namespace="default"}[5m]))`
+  - Example: `topk(5, rate(container_cpu_usage_seconds_total{namespace="example"}[5m]))`
   - This prevents context overflow and focuses on the most relevant data
 * To also capture the aggregate of remaining series as "other":
   ```
-  topk(5, rate(container_cpu_usage_seconds_total{namespace="default"}[5m]))
-  or
-  label_replace(
-    (sum(rate(container_cpu_usage_seconds_total{namespace="default"}[5m])) - sum(topk(5, rate(container_cpu_usage_seconds_total{namespace="default"}[5m])))),
-    "pod", "other", "", ""
-  )
+  topk(5, rate(container_cpu_usage_seconds_total{namespace="example"}[5m])) or label_replace((sum(rate(container_cpu_usage_seconds_total{namespace="example"}[5m])) - sum(topk(5, rate(container_cpu_usage_seconds_total{namespace="example"}[5m])))), "pod", "other", "", "")
   ```
 * Common high-cardinality scenarios requiring topk():
   - Pod-level metrics in namespaces with many pods
   - Container-level CPU/memory metrics
   - HTTP metrics with many endpoints or status codes
   - Any query returning more than 10 time series
-* For initial exploration, use instant queries with `count()` to check cardinality:
-  - Example: `count(count by (pod) (container_cpu_usage_seconds_total{namespace="default"}))`
+* For initial exploration, you may use instant queries with `count()` to check cardinality:
+  - Example: `count(count by (pod) (container_cpu_usage_seconds_total{namespace="example"}))`
   - If count > 10, use topk() in your range query
 * When doing queries, always extend the time range, to 15 min before and after the alert start time
 * ALWAYS embed the execution results into your answer

{holmesgpt-0.14.1 → holmesgpt-0.14.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "holmesgpt"
-version = "0.14.1"
+version = "0.14.2"
 description = ""
 authors = ["Natan Yellin <natan@robusta.dev>"]
 readme = "README.md"