hilbert-modular-group 0.1.1__tar.gz → 0.1.2__tar.gz

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/Dockerfile

@@ -1,7 +1,7 @@
 ARG REMOTE_SRC=1
 ARG GIT_BRANCH=develop
 
-FROM sagemath/sagemath:9.7 as base
+FROM --platform=linux/amd64 sagemath/sagemath:10.3 as base
 RUN sudo apt-get update
 RUN sudo apt-get -y install git
 

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/Makefile

@@ -46,7 +46,7 @@ examples:
 
 tox:
 	sage -pip install tox meson
-	sage --python -m tox src -c tox.ini -e $(TOX_ARGS)
+	sage --python -m tox -c tox.ini -e $(TOX_ARGS)
 
 docker:
 	docker build --build-arg GIT_BRANCH=$(GIT_BRANCH) --build-arg REMOTE_SRC=$(REMOTE_SRC) -t hilbertmodgroup-$(TAG) .
@@ -55,19 +55,19 @@ docker-rebuild:
 	docker build --build-arg GIT_BRANCH=$(GIT_BRANCH) --build-arg REMOTE_SRC=$(REMOTE_SRC) --no-cache -t hilbertmodgroup-$(TAG) .
 
 docker-test: docker
-	docker run -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) test
+	docker run --platform linux/amd64 -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) test
 
 docker-examples: docker
-	docker run -p $(NBPORT):$(NBPORT) -it -e GIT_BRANCH=$(GIT_BRANCH) -e NBPORT=$(NBPORT) --init hilbertmodgroup-$(TAG) examples $(EXAMPLES_ARGS)
+	docker run --platform linux/amd64 -p $(NBPORT):$(NBPORT) -it -e GIT_BRANCH=$(GIT_BRANCH) -e NBPORT=$(NBPORT) --init hilbertmodgroup-$(TAG) examples $(EXAMPLES_ARGS)
 
 docker-tox: docker
-	docker run -it -e GIT_BRANCH=$(GIT_BRANCH) -e TOX_ARGS=$(TOX_ARGS) --init hilbertmodgroup-$(TAG) tox
+	docker run --platform linux/amd64 -it -e GIT_BRANCH=$(GIT_BRANCH) -e TOX_ARGS=$(TOX_ARGS) --init hilbertmodgroup-$(TAG) tox
 
 docker-shell: docker
-	docker run -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) shell
+	docker run --platform linux/amd64 -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) shell
 
 docker-sage: docker
-	docker run -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) run
+	docker run --platform linux/amd64 -it -e GIT_BRANCH=$(GIT_BRANCH) --init hilbertmodgroup-$(TAG) run
 
 
 clean:

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: hilbert_modular_group
-Version: 0.1.1
+Version: 0.1.2
 Summary: Algorithms for Hilbert modular groups
 Home-page: https://github.com/fredstro/hilbertmodgroup
 Author: Fredrik Stromberg
@@ -30,7 +30,7 @@ and is dependent on SageMath.
 
 ## Requirements
 - SageMath v9.6+ (https://www.sagemath.org/)
-  (Tested on v9.6, v9.7 and v10.0)
+  (Tested on v9.6, v9.7, v10.0 and v10.2)
 
 ## Installation
 ### Using sage pip

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/README.md

@@ -6,7 +6,7 @@ and is dependent on SageMath.
 
 ## Requirements
 - SageMath v9.6+ (https://www.sagemath.org/)
-  (Tested on v9.6, v9.7 and v10.0)
+  (Tested on v9.6, v9.7, v10.0 and v10.2)
 
 ## Installation
 ### Using sage pip

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/entrypoint.sh

@@ -20,7 +20,7 @@ case $1 in
     tox)
       echo "Docker container running tox with $TOX_ARGS"
       sage -pip install tox
-      sage -python -m tox -c tox.ini src -e $TOX_ARGS
+      sage -python -m tox -c tox.ini -e $TOX_ARGS
       ;;
     examples)
       echo "Docker container with Jupyter Notebook interface to run example notebooks."

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/hilbert_modular_group.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: hilbert-modular-group
-Version: 0.1.1
+Version: 0.1.2
 Summary: Algorithms for Hilbert modular groups
 Home-page: https://github.com/fredstro/hilbertmodgroup
 Author: Fredrik Stromberg
@@ -30,7 +30,7 @@ and is dependent on SageMath.
 
 ## Requirements
 - SageMath v9.6+ (https://www.sagemath.org/)
-  (Tested on v9.6, v9.7 and v10.0)
+  (Tested on v9.6, v9.7, v10.0 and v10.2)
 
 ## Installation
 ### Using sage pip

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/src/hilbert_modgroup/hilbert_modular_group_class.py

@@ -21,9 +21,9 @@ from sage.groups.matrix_gps.linear import LinearMatrixGroup_generic
 from sage.modular.cusps_nf import NFCusp
 from sage.rings.infinity import infinity
 from sage.rings.number_field.number_field import QuadraticField, CyclotomicField
-from sage.all import latex, Integer, Matrix, matrix
+from sage.all import latex, Integer, Matrix, matrix, ZZ
 from sage.misc.cachefunc import cached_method
-from sage.rings.number_field.order import is_NumberFieldOrder
+from sage.rings.number_field.order import Order
 
 # from .upper_half_plane import ComplexPlaneOtimesK
 from hilbert_modgroup.upper_half_plane import ComplexPlaneProductElement__class
@@ -35,7 +35,7 @@ logger = logging.getLogger(__name__)
 logger.setLevel(10)
 
 
-def is_HilbertModularGroup(x):
+def is_HilbertModularGroup(x) -> bool:
     """
     Return `True` if ``x`` is an instance of a HilbertModularGroup
 
@@ -61,34 +61,32 @@ def is_HilbertModularGroup(x):
 
 def HilbertModularGroup(number_field, projective=True):
     r"""
-        Create the Hilbert modular group over the ring of integers in the given number field
+    Create the Hilbert modular group over the ring of integers in the given number field
 
 
-        INPUT:
-
-        - ``number_field`` (NumberField) -- a totally real number field or positive integer.
-                                            If a positive integer D is specified
-                                            then the number field $Q(\sqrt(D))$ is used.
-        - ``projective`` (bool) - True if you want PSL(2,K) and False for SL(2,K)
+    INPUT:
 
+    - ``number_field`` (NumberField) -- a totally real number field or positive integer.
+      If a positive integer D is specified
+      then the number field $Q(\sqrt(D))$ is used.
+    - ``projective`` (bool) - ``True`` if you want PSL(2,K) and ``False`` for SL(2,K)
 
-        EXAMPLES::
-
-            sage: from hilbert_modgroup.all import HilbertModularGroup
-            sage: HilbertModularGroup(5)
-            Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
-            sage: HilbertModularGroup(QuadraticField(5))
-            Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
 
+    EXAMPLES::
 
-        TESTS::
+        sage: from hilbert_modgroup.all import HilbertModularGroup
+        sage: HilbertModularGroup(5)
+        Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
+        sage: HilbertModularGroup(QuadraticField(5))
+        Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
 
-            sage: from hilbert_modgroup.all import HilbertModularGroup
-            sage: HilbertModularGroup(5)
-            Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
-            sage: HilbertModularGroup(QuadraticField(5))
-            Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
+    TESTS::
 
+        sage: from hilbert_modgroup.all import HilbertModularGroup
+        sage: HilbertModularGroup(5)
+        Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
+        sage: HilbertModularGroup(QuadraticField(5))
+        Hilbert Modular Group ... x^2 - 5 with a = 2.236067977499790?
 
     """
     if isinstance(number_field, (int, Integer)) and number_field > 0:
@@ -120,13 +118,14 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         r"""
          Init a Hilbert modular group over the ring of integers in the given number field
 
-
         INPUT:
+
         - ``base_ring`` - ring
         - ``sage_name`` - string
         - ``latex_string`` - string
 
         EXAMPLES::
+
             sage: from hilbert_modgroup.hilbert_modular_group_class import *
             sage: OK=QuadraticField(5).OK()
             sage: name = f'Hilbert Modular Group PSL(2) over {OK}'
@@ -149,7 +148,8 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
             [          1 1/2*a + 1/2]
             [          0           1]
         """
-        if not is_NumberFieldOrder(base_ring) or not base_ring.number_field().is_totally_real():
+        if base_ring != ZZ and (not isinstance(base_ring, Order)
+                                or not base_ring.number_field().is_totally_real()):
             raise ValueError("Input (={0}) can not be used to create a Hilbert modular group. " +
                              "Need an order of a totally real number field")
         # Instance data related to elliptic elements
@@ -166,31 +166,30 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         self._cusp_normalizing_maps_inverse = {}
         # At the moment we only deal with full level (1)
         self._level = base_ring.fractional_ideal(1)
-        super(HilbertModularGroup_class, self).__init__(degree=Integer(2), base_ring=base_ring,
-                                                        special=True,
-                                                        sage_name=sage_name,
-                                                        latex_string=latex_string,
-                                                        category=Groups().Infinite(),
-                                                        invariant_form=None)
+        super().__init__(degree=Integer(2), base_ring=base_ring,
+                         special=True,
+                         sage_name=sage_name,
+                         latex_string=latex_string,
+                         category=Groups().Infinite(),
+                         invariant_form=None)
 
     @cached_method
     def generators(self, algorithm='standard'):
         r"""
-        Return a list of generators of self.
+        Return a list of generators of ``self``.
 
         INPUT:
 
-
         - ``algorithm`` (string) either 'standard' or 'elementary'.
-            If 'elementary' is given return a set of generators
-         consisting of elementary (i.e. upper- and lower-triangular) matrices.
-         Otherwise return a set of reflections and translations.
 
+        If 'elementary' is given return a set of generators
+        consisting of elementary (i.e. upper- and lower-triangular) matrices.
+        Otherwise return a set of reflections and translations.
 
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import HilbertModularGroup
-            sage: H=HilbertModularGroup(5)
+            sage: H = HilbertModularGroup(5)
             sage: H.generators()
             [
             [ 0 -1]  [          1 1/2*a + 1/2]  [1 a]
@@ -207,15 +206,15 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         """
         if algorithm == 'standard':
             gens = [self.S()]
-            for x in self.base_ring().basis():
-                gens.append(self.T(x))
+            gens.extend(self.T(x) for x in self.base_ring().basis())
         elif algorithm == 'elementary':
             gens = []
             for x in self.base_ring().basis():
                 gens.append(self.T(x))
                 gens.append(self.L(x))
         else:
-            raise ValueError("Unknown algorithm '{0}'. Expected one of 'standard' or 'elementary'")
+            raise ValueError(f"Unknown algorithm '{algorithm}'. "
+                             f"Expected one of 'standard' or 'elementary'")
         return gens
 
     @cached_method
@@ -247,7 +246,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import HilbertModularGroup
-            sage: H=HilbertModularGroup(5)
+            sage: H = HilbertModularGroup(5)
             sage: H.T()
             [1 1]
             [0 1]
@@ -269,6 +268,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         INPUT:
 
         - ``a`` -- integer in number field
+
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import HilbertModularGroup
@@ -441,7 +441,6 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         """
         A set of cusp representatives of self.
 
-
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import HilbertModularGroup
@@ -552,6 +551,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         Return a representative cusp and optionally a corresponding map.
 
         INPUT:
+
         - ``cusp`` -- cusp
         - ``return_map`` -- bool (default: False)
                             Set to True to also return the map giving the equivalence.
@@ -704,7 +704,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import HilbertModularGroup
-            sage: H=HilbertModularGroup(5)
+            sage: H = HilbertModularGroup(5)
             sage: H.traces_of_elliptic_elements()
             [-1, 0, -1/2*a - 1/2, 1/2*a - 1/2, 1, -1/2*a + 1/2, 1/2*a + 1/2]
 
@@ -715,7 +715,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
             sage: var('x')
             x
             sage: K = NumberField(x^3-36*x-1, names='a')
-            sage: H=HilbertModularGroup(K)
+            sage: H = HilbertModularGroup(K)
             sage: H2.traces_of_elliptic_elements()
             [-1, 0, 1]
 
@@ -776,12 +776,12 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         Returns None if no elliptic element with this trace exists.
 
         INPUT:
+
         - `t` number field element
 
         OUTPUT:
-        - integer or None
-
 
+        - integer or ``None``
 
         EXAMPLES::
 
@@ -880,7 +880,7 @@ class HilbertModularGroup_class(LinearMatrixGroup_generic):
         if not isinstance(cusp, NFCusp) or cusp.number_field() != base_nf:
             raise ValueError(f"Input should be a NF cusp defined over {base_nf}!")
         ca, cb = (cusp.numerator(), cusp.denominator())
-        if not (ca, cb) in self._cusp_normalizing_maps:
+        if (ca, cb) not in self._cusp_normalizing_maps:
             # First find the equivalent representative
             # crep, B = self.cusp_representative(cusp,return_map=True)
             # crepa,crepb = crep.numerator(),crep.denominator()

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/src/hilbert_modgroup/pullback.py

@@ -19,14 +19,14 @@ from sage.misc.misc_c import prod
 from sage.modular.cusps_nf import NFCusp
 from sage.modules.free_module_element import vector
 from sage.rings.infinity import Infinity
-from sage.rings.number_field.number_field_ideal import is_NumberFieldIdeal
+from sage.rings.number_field.number_field_ideal import NumberFieldIdeal
 from sage.rings.real_double import RDF
 from sage.rings.real_mpfr import RealField
 from sage.structure.sage_object import SageObject
 from sage.matrix.all import Matrix
 
 from hilbert_modgroup.upper_half_plane import \
-    ComplexPlaneProductElement__class,\
+    ComplexPlaneProductElement__class, \
     UpperHalfPlaneProductElement__class, UpperHalfPlaneProductElement
 
 from hilbert_modgroup.utils import upper, lower
@@ -466,7 +466,7 @@ class HilbertPullback(SageObject):
 
         """
         ideala = self._construct_ideal(a)
-        entries = [[x for x in beta.complex_embeddings(prec)] for beta in ideala.integral_basis()]
+        entries = [list(beta.complex_embeddings(prec)) for beta in ideala.integral_basis()]
         n = self.group().base_ring().degree()
         return matrix(RealField(prec), n, n, entries).transpose()
 
@@ -517,7 +517,7 @@ class HilbertPullback(SageObject):
 
         """
         ideala = self._construct_ideal(a)
-        entries = [[x for x in beta.vector()] for beta in ideala.integral_basis()]
+        entries = [list(beta.vector()) for beta in ideala.integral_basis()]
         n = self.group().base_ring().degree()
         return matrix(self.number_field(), n, n, entries).transpose()
 
@@ -789,31 +789,33 @@ class HilbertPullback(SageObject):
         Try to find a heuristic closest cusp using LLL.
 
         INPUT:
+
         - ``z`` -- point in the upper half-plane
         - ``a`` -- ideal or number field element (default = None)
-                    If None then this is set to the entire ring of integers.
+          If None then this is set to the entire ring of integers.
         - ``as_cusp`` -- boolean (default: False)
-                    If True we return an element of type NFCusp
+          If True we return an element of type NFCusp
+
         EXAMPLES::
 
             sage: from hilbert_modgroup.all import *
             sage: H1 = HilbertModularGroup(5)
             sage: P1 = HilbertPullback(H1)
-            sage: z=UpperHalfPlaneProductElement([CC(0,1),CC(0,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(0,1),CC(0,1)])
             sage: P1.get_heuristic_closest_cusp(z)
             (-1, 0)
-            sage: z=UpperHalfPlaneProductElement([CC(0,0.5),CC(0,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(0,0.5),CC(0,1)])
             sage: P1.get_heuristic_closest_cusp(z)
             (0, 1)
-            sage: z=UpperHalfPlaneProductElement([CC(2.2,0.5),CC(1,0.5)])
+            sage: z = UpperHalfPlaneProductElement([CC(2.2,0.5),CC(1,0.5)])
             sage: P1.get_heuristic_closest_cusp(z)
             (-1/2*a + 3/2, 1)
             sage: H2 = HilbertModularGroup(10)
             sage: P2 = HilbertPullback(H2)
-            sage: z=UpperHalfPlaneProductElement([CC(2,0.5),CC(1,0.2)])
+            sage: z = UpperHalfPlaneProductElement([CC(2,0.5),CC(1,0.2)])
             sage: P2.get_heuristic_closest_cusp(z)
             (1, 1)
-            sage: z=UpperHalfPlaneProductElement([23.3400000000000 + 0.0100000000000000*I,\
+            sage: z = UpperHalfPlaneProductElement([23.3400000000000 + 0.0100000000000000*I,\
                                                         0.0200000000000000 + 0.0300000000000000*I])
             sage: P2.get_heuristic_closest_cusp(z)
             (3*a - 10, -a - 4)
@@ -856,23 +858,28 @@ class HilbertPullback(SageObject):
 
     def _construct_ideal(self, a, b=None):
         r"""
-        Construct an ideal of the number field associated with self from a
+        Construct an ideal of the number field associated with self from a.
 
         EXAMPLES::
 
-        sage: from hilbert_modgroup.all import *
-        sage: P1=HilbertPullback(HilbertModularGroup(5))
-        sage: P1._construct_ideal(1)
-        Fractional ideal (1)
-        sage: P1._construct_ideal(P1.number_field().fractional_ideal(1))
-        Fractional ideal (1)
-
-
+            sage: from hilbert_modgroup.all import *
+            sage: P1 = HilbertPullback(HilbertModularGroup(5))
+            sage: P1._construct_ideal(1)
+            Fractional ideal (1)
+            sage: P1._construct_ideal(P1.number_field().fractional_ideal(1))
+            Fractional ideal (1)
+            sage: a = P1.number_field().fractional_ideal(1)
+            sage: b = P1.number_field().fractional_ideal(2)
+            sage: P1._construct_ideal(a, b)
+            Fractional ideal (1/2)
         """
         if a is None:
             ideala = self.group().base_ring().fractional_ideal(1)
-        elif is_NumberFieldIdeal(a):
-            ideala = a
+        elif isinstance(a, NumberFieldIdeal):
+            if b:
+                ideala = a / b
+            else:
+                ideala = a
         elif a in self.group().base_ring() and not b:
             ideala = self.group().base_ring().fractional_ideal(a)
         elif a in self.group().base_ring() and b in self.group().base_ring():
@@ -886,18 +893,23 @@ class HilbertPullback(SageObject):
         Return an instance of NFCusp for the number field of self from input c and optional d
 
         INPUT:
+
         - ``c`` -- instance of NFCusp, element or tuple of elements of number field
         - ``d`` -- element of number field or None (default: None)
+
         EXAMPLES::
 
-        sage: from hilbert_modgroup.all import *
-        sage: P1=HilbertPullback(HilbertModularGroup(5))
-        sage: P1._construct_cusp(1,0)
-        Cusp Infinity of Number Field in a with ... polynomial x^2 - 5 with a = 2.236067977499790?
-        sage: P1._construct_cusp((1,0))
-        Cusp Infinity of Number Field in a with ... polynomial x^2 - 5 with a = 2.236067977499790?
-        sage: P1._construct_cusp(0,1)
-        Cusp [0: 1] of Number Field in a with ... polynomial x^2 - 5 with a = 2.236067977499790?
+            sage: from hilbert_modgroup.all import *
+            sage: P1=HilbertPullback(HilbertModularGroup(5))
+            sage: P1._construct_cusp(1,0)
+            Cusp Infinity of Number Field in a with ... polynomial
+            x^2 - 5 with a = 2.236067977499790?
+            sage: P1._construct_cusp((1,0))
+            Cusp Infinity of Number Field in a with ... polynomial
+            x^2 - 5 with a = 2.236067977499790?
+            sage: P1._construct_cusp(0,1)
+            Cusp [0: 1] of Number Field in a with ... polynomial
+            x^2 - 5 with a = 2.236067977499790?
         """
         if isinstance(c, NFCusp) and c.number_field() == self.number_field():
             return c
@@ -921,7 +933,7 @@ class HilbertPullback(SageObject):
             sage: from hilbert_modgroup.upper_half_plane import UpperHalfPlaneProductElement
             sage: H1 = HilbertModularGroup(5)
             sage: P1 = HilbertPullback(H1)
-            sage: z=UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
             sage: P1.X(z)
             (1.00000000000000, 0.000000000000000)
             sage: b1,b2 = H1.base_ring().fractional_ideal(1).integral_basis(); b1,b2
@@ -957,7 +969,7 @@ class HilbertPullback(SageObject):
             sage: from hilbert_modgroup.upper_half_plane import UpperHalfPlaneProductElement
             sage: H1 = HilbertModularGroup(5)
             sage: P1 = HilbertPullback(H1)
-            sage: z=UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
             sage: P1.reduce_by_translations(z,return_map=True)
             (
                                                       [ 1 -1]
@@ -965,7 +977,7 @@ class HilbertPullback(SageObject):
             )
 
 
-            sage: z=UpperHalfPlaneProductElement([CC(3,1),CC(-1,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(3,1),CC(-1,1)])
             sage: P1.reduce_by_translations(z,return_map=True) # abs tol 1e-10
             (
             [-0.236067977499790 + 1.00000000000000*I, 0.236067977499790 + 1.00000000000000*I],
@@ -985,12 +997,12 @@ class HilbertPullback(SageObject):
 
             sage: H3=HilbertModularGroup(NumberField(x^3-36*x-1, names='a'))
             sage: P3=HilbertPullback(H3)
-            sage: z=UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(1,1),CC(1,1)])
             sage: P3.reduce_by_translations(z,return_map=True)
             Traceback (most recent call last):
             ...
             ValueError: Need an element of type: UpperHalfPlaneProductElement__class of degree 3
-            sage: z=UpperHalfPlaneProductElement([CC(1,1),CC(1,1),CC(1,1)])
+            sage: z = UpperHalfPlaneProductElement([CC(1,1),CC(1,1),CC(1,1)])
             sage: P3.reduce_by_translations(z,return_map=True)
             (
                                                                           [ 1 -1]
@@ -1023,7 +1035,6 @@ class HilbertPullback(SageObject):
 
         EXAMPLES::
 
-
             sage: from hilbert_modgroup.all import *
             sage: from hilbert_modgroup.upper_half_plane import UpperHalfPlaneProductElement
             sage: H1 = HilbertModularGroup(5)
@@ -1068,7 +1079,7 @@ class HilbertPullback(SageObject):
 
         - ``z`` -- point in the upper half-plane
         - ``return_map`` -- boolean (default False)
-                            Set to ``True`` to return the map which performed the reduction.
+          Set to ``True`` to return the map which performed the reduction.
 
         EXAMPLES::
 
@@ -1109,8 +1120,8 @@ class HilbertPullback(SageObject):
         - ``z`` -- point in the upper half-plane.
         - ``cusp`` -- cusp of the group of self.
         - ``return_map`` -- boolean (default=False)
-                            Return the map A such that AN^-1z is reduced where N is the
-                            cusp normalizing map for the cusp.
+          Return the map A such that AN^-1z is reduced where N is the
+          cusp normalizing map for the cusp.
 
         EXAMPLES::
 
@@ -1132,8 +1143,8 @@ class HilbertPullback(SageObject):
             [1.00000000000000*I, 1.00000000000000*I], [ 0  1]
             )
 
-        :: Check that if we apply a cusp-normalizing map to a point then the reduction with respect
-        :: to that cusp is the same as the reduction of the original point with respect to infinity
+        Check that if we apply a cusp-normalizing map to a point then the reduction with respect
+        to that cusp is the same as the reduction of the original point with respect to infinity ::
 
             sage: c=NFCusp(P1.group().base_ring().number_field(),1,2)
             sage: N=H1.cusp_normalizing_map(c)
@@ -1161,19 +1172,18 @@ class HilbertPullback(SageObject):
             [     1 a - 1]
             [     0      1]
             )
-            sage: H3=HilbertModularGroup(NumberField(x^3-36*x-1, names='a'))
-            sage: P3=HilbertPullback(H3)
+            sage: H3 = HilbertModularGroup(NumberField(x^3-36*x-1, names='a'))
+            sage: P3 = HilbertPullback(H3)
             sage: z=UpperHalfPlaneProductElement([CC(1,1),CC(2,1),CC(10,1)])
-            sage: P3.reduce_in_cuspidal_region(z,P3.group().cusps()[0],\
-                                                    return_map=True) # abs tol 1e-10
+            sage: cusp = P3.group().cusps()[0]
+            sage: P3.reduce_in_cuspidal_region(z, cusp,  # abs tol 1e-10
+            ....:                   return_map=True)
             (
             [2.98606258583498 + 1.0*I, -1.97222162680976 + 1.0*I, -0.0138409590252291 + 1.0*I],
             <BLANKLINE>
             [     1 -a - 4]
             [     0      1]
             )
-
-
         """
         self._check_upper_half_plane_element(z)
         if not cusp:
@@ -1351,7 +1361,7 @@ class HilbertPullback(SageObject):
         if not B:
             return p1
         # Hypercube containing the integral points of the coordinates wrt the integral basis
-        vertices = [vector([y for y in B * vector(x)]) for x in p1.vertices()]
+        vertices = [vector(list(B * vector(x))) for x in p1.vertices()]
         # Try to make a polyhedron of the mapped vertices.
         return Polyhedron(vertices, base_ring=RDF)
 
@@ -1380,9 +1390,10 @@ class HilbertPullback(SageObject):
 
     def _matrix_BLambda_row_sum(self, i=None):
         r"""
-        Compute r_i(B_{\Lambda}) = sum_j |b_ij| or sum_ij |b_ij|.
+        Compute ``r_i(B_{\Lambda}) = sum_j |b_ij|`` or ``sum_ij |b_ij|``.
 
         INPUT:
+
         -`` i`` -- integer (default: None)
                     If i is given then return sum of absolute values in row nr. i,
                     otherwise return the sum.
@@ -1429,7 +1440,7 @@ class HilbertPullback(SageObject):
     @cached_method
     def _exp_matrix_BLambda_row_sum(self, i=None):
         r"""
-        Compute exp(r_i(B_{\Lambda})) = sum_j |b_ij| or sum_ij |b_ij|.
+        Compute ``exp(r_i(B_{\Lambda})) = sum_j |b_ij|`` or ``sum_ij |b_ij|``.
 
         INPUT:
 
@@ -1599,6 +1610,7 @@ class HilbertPullback(SageObject):
         Return the constant `a_i` used to bound the embeddings of sigma in Algorithm XXX.
 
         INPUT:
+
         - ``z`` -- point in the upper half-plane
         - ``initial_bd_d`` -- an initial bound for the distance to nearest cusp (default None)
         - ``use_initial_bd_d`` -- boolean (default: 'True') Use the initial bound or not.
@@ -1658,6 +1670,7 @@ class HilbertPullback(SageObject):
         Return the vector of all bounds Dzi
 
         INPUT:
+
         - ``z`` -- point in the upper half-plane
         - ``initial_bd_d`` -- an initial bound for the distance to nearest cusp (default None)
         - ``use_initial_bd_d`` -- boolean (default: 'True') Use the initial bound or not.
@@ -1825,9 +1838,11 @@ class HilbertPullback(SageObject):
                                   prec=16):
         """
         Bound for the embeddings of the numerator of the closest cusp to z.
+
         Reference: Corollary 5
 
-            rho_i in [sigma_i x_i - delta*y_i**0.5 , sigma_i x_i - delta*y_i**0.5]
+        ``rho_i in [sigma_i x_i - delta*y_i**0.5 , sigma_i x_i - delta*y_i**0.5]``
+
         INPUT:
 
         - ``z`` -- point in the upper half-plane
@@ -1897,8 +1912,10 @@ class HilbertPullback(SageObject):
         """
         Bound for the coordinates, with respect to the ring of integers,
         of the numerator of the closest cusp to z.
+
         Reference: Lemma XXX
-            rho_i in [sigma_i x_i - delta*y_i**0.5 , sigma_i x_i - delta*y_i**0.5]
+
+        ``rho_i in [sigma_i x_i - delta*y_i**0.5 , sigma_i x_i - delta*y_i**0.5]``
 
         INPUT:
 
@@ -2206,13 +2223,13 @@ class HilbertPullback(SageObject):
 
 
         EXAMPLES::
+
             sage: from hilbert_modgroup.all import *
             sage: H1 = HilbertModularGroup(5)
             sage: P1 = HilbertPullback(H1)
             sage: z = UpperHalfPlaneProductElement([CC(0,1),CC(0,1)])
             sage: P1._candidate_closest_cusps(z)
              [(1, 0), (-1, -1), (0, 1), (1, -1)]
-
         """
         cusp_candidates = find_candidate_cusps(self, z, use_lll=use_lll,
                                                use_norm_bound=use_norm_bound,

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/src/hilbert_modgroup/pullback_cython.pyx

@@ -6,15 +6,9 @@ Note: These are the algorithms that needs optimizing to make it all faster.
 """
 from sage.all import ceil,floor,cartesian_product
 from sage.arith.misc import gcd
-from sage.modular.cusps_nf import NFCusp
-from sage.rings.infinity import Infinity
 from sage.structure.sage_object cimport SageObject
 from hilbert_modgroup.upper_half_plane cimport UpperHalfPlaneProductElement__class
-# from sage.rings.number_field.number_field_ideal import NumberFieldIdeal
 from sage.rings.number_field.number_field_element cimport NumberFieldElement
-from sage.rings.number_field.number_field_element import is_NumberFieldElement
-from sage.matrix.constructor import identity_matrix
-from sage.matrix.all import Matrix
 
 cpdef integral_coordinates_in_box(bounds):
     """

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/src/hilbert_modgroup/upper_half_plane.pyx

@@ -8,7 +8,7 @@ Note: The structure of this class is based on ArithmeticSubgroupElement from sag
 
 """
 import sage
-from sage.groups.perm_gps.permgroup_element import is_PermutationGroupElement
+from sage.groups.perm_gps.permgroup_element import PermutationGroupElement
 from sage.rings.real_mpfr import RealField
 from sage.structure.element cimport Element
 from sage.rings.all import Integer, CC
@@ -1625,7 +1625,7 @@ cdef class ComplexPlaneProductElement__class(Element):
 
 
         """
-        if not is_PermutationGroupElement(s):
+        if not isinstance(s, PermutationGroupElement):
             raise ValueError("Input must be a permutation group element")
         znew = [0 for i in range(self._degree)]
         for i in range(self._degree):

hilbert_modular_group-0.1.2/src/hilbert_modgroup/version.py

@@ -0,0 +1,16 @@
+# file generated by setuptools_scm
+# don't change, don't track in version control
+TYPE_CHECKING = False
+if TYPE_CHECKING:
+    from typing import Tuple, Union
+    VERSION_TUPLE = Tuple[Union[int, str], ...]
+else:
+    VERSION_TUPLE = object
+
+version: str
+__version__: str
+__version_tuple__: VERSION_TUPLE
+version_tuple: VERSION_TUPLE
+
+__version__ = version = '0.1.2'
+__version_tuple__ = version_tuple = (0, 1, 2)

{hilbert_modular_group-0.1.1 → hilbert_modular_group-0.1.2}/tox.ini

@@ -5,7 +5,7 @@
 envlist = doctest, coverage, pycodestyle, relint, codespell, flake8
 skipsdist = true
 requires =
-     tox>=3.18
+     tox>=4.12
 
 [testenv]
 setenv =
@@ -75,4 +75,10 @@ per-file-ignores =
 description =
     check for misspelled words in source code
 deps = flake8
-commands = flake8 {posargs:{toxinidir}/src/}
+commands = flake8 {posargs:{toxinidir}/src/}
+
+[testenv:rst]
+description =
+    validate Python docstrings markup as reStructuredText
+deps = flake8-rst-docstrings
+commands = flake8 --select=RST {posargs:{toxinidir}/sage/}

hilbert_modular_group-0.1.1/src/hilbert_modgroup/version.py

@@ -1,5 +0,0 @@
-# coding: utf-8
-# file generated by setuptools_scm
-# don't change, don't track in version control
-__version__ = version = '0.1.1'
-__version_tuple__ = version_tuple = (0, 1, 1)