hgitaly 2.7.0__tar.gz → 2.7.1__tar.gz

{hgitaly-2.7.0 → hgitaly-2.7.1}/.hgtags

@@ -120,3 +120,4 @@ c1b00e1bc1bf0a2d41907b345c48cf795f910a4f 2.5.0
 7dbcba18d83708ff81d8cec9696a86d24ed5d20a 2.5.2
 3a83836b7408f1318a80f1ba97051086596edd12 2.5.3
 b956f11f1342d8aada221b747ee16e1328037fcd 2.6.0
+fe4e6866234771c53963b6e53b7fedd755eb11d1 2.7.0

{hgitaly-2.7.0 → hgitaly-2.7.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: hgitaly
-Version: 2.7.0
+Version: 2.7.1
 Summary: Server-side implementation of Gitaly protocol for Mercurial
 Home-page: https://foss.heptapod.net/heptapod/hgitaly
 Author: Georges Racinet

hgitaly-2.7.1/hgitaly/VERSION

@@ -0,0 +1 @@
+2.7.1

{hgitaly-2.7.0 → hgitaly-2.7.1}/hgitaly/service/commit.py

@@ -950,6 +950,15 @@ class CommitServicer(CommitServiceServicer, HGitalyServicer):
             #  or [=\n"
             context.abort(StatusCode.INTERNAL, "Invalid filter: " + str(exc))
 
+        # `skip` has to be interpreted before pagination
+        # smartset.slice insists on having a "last" value:
+        # it constructs a list internally, which would be a performance
+        # issue to skip the first 3 revisions of a million-sized revset.
+        # Too bad there is no cheap way to consume the revset as an iterator.
+        # Anyway we'd do that in a Rust implementation if ever needed.
+        if request.skip > 0:
+            revs = revs.slice(request.skip, len(revs))
+
         # according to protocol comment, the page token
         # is the last commit OID already sent (similar to blob/tree requests)
         cursor = request.pagination_params.page_token

{hgitaly-2.7.0 → hgitaly-2.7.1}/hgitaly/service/tests/test_commit.py

@@ -1353,6 +1353,7 @@ def test_list_commits(commit_fixture_empty_repo):
 
     assert list_commits(sha4, caret(ctx1)) == [sha4, sha3, sha2]
     assert list_commits(sha4, caret(ctx1), reverse=True) == [sha2, sha3, sha4]
+    assert list_commits(sha4, caret(ctx1), skip=1) == [sha3, sha2]
 
     # limit and page token
     assert list_commits(sha4, limit=2) == [sha4, sha3]

{hgitaly-2.7.0 → hgitaly-2.7.1}/hgitaly.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: hgitaly
-Version: 2.7.0
+Version: 2.7.1
 Summary: Server-side implementation of Gitaly protocol for Mercurial
 Home-page: https://foss.heptapod.net/heptapod/hgitaly
 Author: Georges Racinet

{hgitaly-2.7.0 → hgitaly-2.7.1}/tests_with_gitaly/test_commit.py

@@ -752,6 +752,7 @@ def test_compare_list_commits(gitaly_comparison):
     # using special cases where they coincide, which is worse than no test)
     Order = ListCommitsRequest.Order
     assert_compare(revisions=[ctx4.hex()], order=Order.TOPO)
+    assert_compare(revisions=[ctx4.hex()], order=Order.TOPO, skip=2)
 
     # commit message patterns
     #
@@ -787,6 +788,14 @@ def test_compare_list_commits(gitaly_comparison):
         pagination_params=PaginationParameter(limit=10,
                                               page_token=ctx2.hex()))
 
+    # skip and pagination params
+    assert_compare(
+        revisions=[ctx4.hex()],
+        order=Order.TOPO,
+        skip=1,
+        pagination_params=PaginationParameter(limit=10,
+                                              page_token=ctx2.hex()))
+
     # unknown revision
     assert_compare_errors(revisions=[b'1234' * 10], same_details=False)
 

hgitaly-2.7.0/hgitaly/VERSION

@@ -1 +0,0 @@
-2.7.0