hap-cli 0.8.29__tar.gz → 0.8.30__tar.gz

{hap_cli-0.8.29 → hap_cli-0.8.30}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: hap-cli
-Version: 0.8.29
+Version: 0.8.30
 Summary: CLI harness for Mingdao HAP - Enterprise no-code platform
 Author: hap-cli
 License: Apache-2.0

{hap_cli-0.8.29 → hap_cli-0.8.30}/hap_cli/__init__.py

@@ -1,3 +1,3 @@
 """CLI harness for Mingdao HAP (hap-cli)."""
 
-__version__ = "0.8.29"
+__version__ = "0.8.30"

{hap_cli-0.8.29 → hap_cli-0.8.30}/hap_cli/core/app_creator/seed/executor.py

@@ -141,18 +141,12 @@ class _Resolver:
 
 def _record_attachment_cell(descriptors: list[dict[str, Any]]) -> dict[str, Any]:
     """Wrap general uploaded-file descriptors into a worksheet Attachment
-    (type 14) cell value (mirrors core upload.record_attachment_cell)."""
-    attachments = []
-    for i, d in enumerate(descriptors):
-        attachments.append({
-            "fileID": d.get("fileID"), "fileSize": d.get("fileSize"),
-            "serverName": d.get("serverName"), "filePath": d.get("filePath"),
-            "fileName": d.get("fileName"), "fileExt": d.get("fileExt"),
-            "originalFileName": d.get("originalFileName"), "key": d.get("key"),
-            "url": d.get("url"), "oldOriginalFileName": d.get("originalFileName"),
-            "index": i, "isEdit": False,
-        })
-    return {"attachmentData": [], "attachments": attachments, "knowledgeAtts": []}
+    (type 14) cell value. Delegates to the core wrapper so the seeded rows
+    carry exactly what any other CLI upload does — the local copy this
+    replaced silently dropped each file's download permission."""
+    from hap_cli.core.upload import record_attachment_cell
+
+    return record_attachment_cell(descriptors)
 
 
 def _upload_row_attachments(

{hap_cli-0.8.29 → hap_cli-0.8.30}/hap_cli/core/upload.py

@@ -209,6 +209,23 @@ def _iso(deadline: Optional[int]) -> Optional[str]:
     return datetime.fromtimestamp(deadline, tz=timezone.utc).astimezone().isoformat()
 
 
+def _download_permission(ext: str) -> dict[str, Any]:
+    """The per-file download permission the holder of the file is sent.
+
+    Whoever stores an attachment decides, per file, whether anyone but
+    the uploader may download it — an omitted flag used to read as "no",
+    so a file attached by the CLI answered 权限不足 for every colleague.
+    pd-openweb sets it in ``formatResponseData``
+    (src/components/UploadFiles/utils.js:202-206): non-pictures get
+    ``allowDown: true`` plus an empty ``docVersionID``, pictures get
+    neither because the viewer already treats a picture as downloadable
+    (UploadFiles/File.js:724). Mirrored verbatim, empty dict included.
+    """
+    if ext.lower() in _PICTURE_EXTS:
+        return {}
+    return {"allowDown": True, "docVersionID": ""}
+
+
 def upload_bytes(
     session: Session,
     *,
@@ -239,7 +256,7 @@ def upload_bytes(
     up = _post_to_store(upload_host(session), token, content,
                         original_name=original, ext=ext,
                         server_name=server_name)
-    return {
+    descriptor = {
         "fileID": generate_file_oid(),
         "fileSize": len(content),
         "etag": up.get("etag"),
@@ -256,6 +273,8 @@ def upload_bytes(
         # (public-bucket) address, which does not expire.
         "urlExpiresAt": _iso(url_expires_at(token.get("url"))),
     }
+    descriptor.update(_download_permission(ext))
+    return descriptor
 
 
 def source_descriptors(sources: "list[str] | tuple[str, ...]") -> list[dict[str, str]]:
@@ -324,4 +343,9 @@ def record_attachment_cell(descriptors: list[dict[str, Any]]) -> dict[str, Any]:
             "index": i,
             "isEdit": False,
         })
+        # Carried, not recomputed: the descriptor already decided this at
+        # upload time — see _download_permission().
+        for key in ("allowDown", "docVersionID"):
+            if key in d:
+                attachments[-1][key] = d[key]
     return {"attachmentData": [], "attachments": attachments, "knowledgeAtts": []}

hap_cli-0.8.30/hap_cli/tests/test_upload_allow_down.py

@@ -0,0 +1,118 @@
+"""Uploaded files must carry their download permission.
+
+Reported as "日程/讨论里别人上传的文件下载不了": a colleague opening a file
+attached through the CLI got *您权限不足，无法下载，请联系管理员或文件上传者*,
+while the same file attached from the web UI downloaded fine.
+
+The file store does not decide this — the *client* does, per file, when
+it hands the upload result to whatever will hold it. pd-openweb does it
+in ``formatResponseData`` (src/components/UploadFiles/utils.js:202-206):
+every non-picture upload gets ``allowDown: true`` and an empty
+``docVersionID``; pictures are left alone because the viewer treats them
+as downloadable anyway (UploadFiles/File.js:724). Every attachment
+payload the frontend sends — record comments, record attachment cells —
+is that same object, stringified.
+
+The CLI's uploaded-file descriptor never had the field, so anything it
+attached was stored with the permission unset and only the uploader
+could get the bytes back.
+"""
+
+import json
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from hap_cli.core import record as rec_mod
+from hap_cli.core import upload as up_mod
+from hap_cli.core.session import Session
+
+
+@pytest.fixture
+def session():
+    return Session(server_url="https://test.mingdao.com", auth_token="tok123")
+
+
+class _store:
+    """Stand in for the credential + store round trip of an upload."""
+
+    def __init__(self, ext=".pdf"):
+        self.ext = ext
+
+    def __enter__(self):
+        token = {"uptoken": "t", "key": f"doc/20260909/k{self.ext}",
+                 "serverName": "https://doc.mingdao.com/",
+                 "fileName": f"k{self.ext}",
+                 "url": f"https://doc.mingdao.com/doc/k{self.ext}"}
+        self._patches = [
+            patch.object(up_mod, "get_upload_token", return_value=token),
+            patch.object(up_mod, "upload_host",
+                         return_value="https://upload.qiniup.com/"),
+            patch.object(up_mod, "_post_to_store", return_value={
+                "key": f"doc/20260909/k{self.ext}", "etag": "e",
+                "bucket": "mdoc", "filePath": "doc/20260909/", "fileName": "k",
+                "fileExt": self.ext, "originalFileName": "spec",
+            }),
+        ]
+        for p in self._patches:
+            p.start()
+        return self
+
+    def __exit__(self, *exc):
+        for p in self._patches:
+            p.stop()
+        return False
+
+
+class TestDescriptorCarriesDownloadPermission:
+
+    def test_document_upload_is_downloadable(self, session):
+        with _store(".pdf"):
+            d = up_mod.upload_bytes(session, content=b"x", name="spec.pdf")
+        assert d["allowDown"] is True
+        assert d["docVersionID"] == ""
+
+    def test_archive_upload_is_downloadable(self, session):
+        # The reported file was a 13 MB .zip attached to a calendar comment.
+        with _store(".zip"):
+            d = up_mod.upload_bytes(session, content=b"x", name="proto.zip")
+        assert d["allowDown"] is True
+
+    def test_picture_upload_leaves_the_field_alone(self, session):
+        # Mirrors formatResponseData: pictures get neither field.
+        with _store(".png"):
+            d = up_mod.upload_bytes(session, content=b"x", name="cover.png")
+        assert "allowDown" not in d
+        assert "docVersionID" not in d
+
+
+class TestConsumersKeepThePermission:
+
+    _META = {"md.global": {"APPInfo": {"worksheetRowAppID": "row-app-id"}}}
+
+    def test_record_comment_attachment_keeps_it(self):
+        session = MagicMock()
+        session.get_global_meta.return_value = self._META
+        session.api_call.return_value = {"code": 1, "data": {"discussionId": "d1"}}
+        rec_mod.add_discussion(
+            session, "ws1", "row1", "here you go", app_id="app1",
+            attachments=[{"fileID": "o_1", "fileExt": ".zip", "allowDown": True,
+                          "docVersionID": ""}],
+        )
+        _, _, payload = session.api_call.call_args[0][:3]
+        assert json.loads(payload["attachments"])[0]["allowDown"] is True
+
+    def test_attachment_cell_keeps_it(self):
+        cell = up_mod.record_attachment_cell([
+            {"fileID": "o_1", "fileExt": ".zip", "originalFileName": "proto",
+             "allowDown": True, "docVersionID": ""},
+        ])
+        assert cell["attachments"][0]["allowDown"] is True
+        assert cell["attachments"][0]["docVersionID"] == ""
+
+    def test_attachment_cell_leaves_a_picture_alone(self):
+        cell = up_mod.record_attachment_cell([
+            {"fileID": "o_2", "fileExt": ".png", "originalFileName": "cover"},
+        ])
+        assert "allowDown" not in cell["attachments"][0]
+        assert "docVersionID" not in cell["attachments"][0]

{hap_cli-0.8.29 → hap_cli-0.8.30}/hap_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: hap-cli
-Version: 0.8.29
+Version: 0.8.30
 Summary: CLI harness for Mingdao HAP - Enterprise no-code platform
 Author: hap-cli
 License: Apache-2.0

{hap_cli-0.8.29 → hap_cli-0.8.30}/hap_cli.egg-info/SOURCES.txt

@@ -218,6 +218,7 @@ hap_cli/tests/test_select_rejects_relation_value.py
 hap_cli/tests/test_semantic_types_registry.py
 hap_cli/tests/test_update.py
 hap_cli/tests/test_update_mode.py
+hap_cli/tests/test_upload_allow_down.py
 hap_cli/tests/test_upload_host_resolution.py
 hap_cli/tests/test_v3_api_schema_loader.py
 hap_cli/tests/test_v3_dispatcher.py