ha-mcp-dev 7.6.0.dev628__tar.gz → 7.6.0.dev630__tar.gz

{ha_mcp_dev-7.6.0.dev628/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.6.0.dev630}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.6.0.dev628
+Version: 7.6.0.dev630
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.6.0.dev628"
+version = "7.6.0.dev630"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 requires-python = ">=3.13,<3.14"

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630}/src/ha_mcp/client/websocket_client.py

@@ -235,6 +235,10 @@ class HomeAssistantWebSocketClient:
         self._send_lock: asyncio.Lock | None = None
         self._lock_loop: asyncio.AbstractEventLoop | None = None
         self._state = WebSocketConnectionState()
+        # Reason the most recent connect() attempt failed (exception text),
+        # or None. Surfaced by callers so the agent sees *why* a WebSocket
+        # connection failed instead of an opaque "Failed to connect" string.
+        self._last_connect_error: str | None = None
 
         # Parse URL to get WebSocket endpoint
         parsed = urlparse(self.base_url)
@@ -259,6 +263,7 @@ class HomeAssistantWebSocketClient:
         try:
             logger.info(f"Connecting to Home Assistant WebSocket: {self.ws_url}")
             self._state.reset_connection()
+            self._last_connect_error = None
 
             # Only configure an SSLContext for wss://; ws:// (Supervisor
             # proxy) doesn't use TLS and gets ssl=None.
@@ -326,6 +331,7 @@ class HomeAssistantWebSocketClient:
             return True
 
         except Exception as e:
+            self._last_connect_error = f"{type(e).__name__}: {e}"
             if _is_ssl_error(e) and self.verify_ssl:
                 logger.error(
                     "WebSocket TLS verification failed for %s: %s. "
@@ -925,6 +931,17 @@ class HomeAssistantWebSocketClient:
         """Check if WebSocket is connected and authenticated."""
         return self._state.is_ready
 
+    @property
+    def last_connect_error(self) -> str | None:
+        """Reason the most recent ``connect()`` attempt failed, or ``None``.
+
+        Captured from the underlying exception (e.g. an auth timeout, a
+        handshake HTTP/TLS error, or "Did not receive auth_required") so
+        callers can surface *why* the connection failed instead of an
+        opaque "Failed to connect to Home Assistant WebSocket".
+        """
+        return self._last_connect_error
+
 
 MAX_POOL_SIZE = 50
 
@@ -1059,7 +1076,14 @@ class WebSocketManager:
 
             connected = await client.connect()
             if not connected:
-                raise Exception("Failed to connect to Home Assistant WebSocket")
+                reason = client.last_connect_error
+                # Append only an actual string reason; the isinstance guard
+                # keeps a non-str (e.g. a MagicMock in tests) from polluting
+                # the message with a repr.
+                detail = f": {reason}" if isinstance(reason, str) else ""
+                raise Exception(
+                    "Failed to connect to Home Assistant WebSocket" + detail
+                )
 
             self._clients[key] = client
             self._last_used[key] = time.monotonic()

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630}/src/ha_mcp/settings_ui.py

@@ -602,6 +602,10 @@ _SETTINGS_HTML = (
 <meta charset="UTF-8">
 <meta name="viewport" content="width=device-width, initial-scale=1.0">
 <title>HA-MCP Tool Settings</title>
+<!-- Empty data URI: tells the browser "no favicon" so it never requests
+     /favicon.ico (which would 404 and log a console error, since the
+     settings server serves no such asset in any deployment mode). -->
+<link rel="icon" href="data:,">
 <style>
   :root {
     --bg: #1c1c1e; --surface: #2c2c2e; --surface-hover: #3a3a3c;
@@ -2548,9 +2552,36 @@ function renderCodeModeSubRows(parentEl, masterOn, codeModeOn) {
 
     const info = document.createElement('div');
     info.className = 'feature-info';
-    const lockedNote = f.origin === 'env'
-      ? `<div class="feature-locked-note">Set via env var <code>${escapeHtml(f.env_var)}</code> — unset it to edit here.</div>`
-      : '';
+    // code_mode_saved_tools_path needs honest, field-specific copy:
+    //  - add-on mode: hardcoded by start.py (setdefault to /data); not
+    //    Supervisor-managed and absent from the addon schema, so it
+    //    genuinely can't be changed — don't imply a lever exists.
+    //  - standalone with the env var set: the "unset it" hint IS
+    //    actionable (the operator controls the env var), so keep it.
+    //  - standalone with no path: a blank path disables persistence —
+    //    warn that saved tools live in memory only.
+    // Other env-locked code-mode sub-fields keep the shared helper.
+    let lockedNote = '';
+    if (f.field === 'code_mode_saved_tools_path') {
+      if (IS_ADDON_MODE) {
+        lockedNote =
+          '<div class="feature-locked-note">Hardcoded to ' +
+          '<code>/data/saved_tools.json</code> in add-on mode and cannot ' +
+          'be changed (fixed here so saved tools survive add-on updates).' +
+          '</div>';
+      } else if (f.origin === 'env') {
+        lockedNote =
+          `<div class="feature-locked-note">${envLockedNoteHtml(f.env_var, f.field)}</div>`;
+      } else if (!f.value) {
+        lockedNote =
+          '<div class="feature-locked-note">If blank, custom tools are kept ' +
+          'in memory only and lost on restart. Set a path on persistent ' +
+          'storage to keep them.</div>';
+      }
+    } else if (f.origin === 'env') {
+      lockedNote =
+        `<div class="feature-locked-note">${envLockedNoteHtml(f.env_var, f.field)}</div>`;
+    }
     info.innerHTML =
       `<div class="feature-name">${escapeHtml(meta.label)}</div>` +
       `<div class="feature-help">${escapeHtml(meta.help)}</div>` +
@@ -5373,16 +5404,34 @@ def build_settings_handlers(
             if is_addon_synced:
                 addon_writes_present = True
             elif os.environ.get(env_name) is not None:
+                # Add-on mode has no env-var surface for non-schema keys
+                # (e.g. CODE_MODE_SAVED_TOOLS_PATH, set by start.py), so
+                # "unset it to edit here" is unactionable there — give
+                # add-on-aware copy instead of implying a lever exists.
+                if addon_mode:
+                    message = (
+                        f"{fname!r} is fixed by the add-on runtime and "
+                        "cannot be changed from the web UI."
+                    )
+                    suggestions = [
+                        "This value is baked into the add-on and is not "
+                        "exposed as an editable setting.",
+                    ]
+                else:
+                    message = (
+                        f"{fname!r} is set via {env_name} env var — "
+                        "unset it to edit here."
+                    )
+                    suggestions = [
+                        f"Unset the {env_name} environment variable (or "
+                        "remove it from your Docker config), then restart "
+                        "to edit this setting from the UI.",
+                    ]
                 return JSONResponse(
                     create_error_response(
                         ErrorCode.VALIDATION_INVALID_PARAMETER,
-                        f"{fname!r} is set via {env_name} env var — "
-                        "unset it to edit here.",
-                        suggestions=[
-                            f"Unset the {env_name} environment variable (or "
-                            "remove it from your addon/Docker config), then "
-                            "restart to edit this setting from the UI.",
-                        ],
+                        message,
+                        suggestions=suggestions,
                         context={"env_var": env_name},
                     ),
                     status_code=409,

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630}/src/ha_mcp/tools/helpers.py

@@ -182,14 +182,19 @@ async def get_connected_ws_client(
     ws_client = HomeAssistantWebSocketClient(base_url, token, verify_ssl=verify_ssl)
     connected = await ws_client.connect()
     if not connected:
+        reason = ws_client.last_connect_error
+        details = (
+            reason
+            if isinstance(reason, str)
+            else "WebSocket connection could not be established"
+        )
         return None, create_connection_error(
             "Failed to connect to Home Assistant WebSocket",
-            details="WebSocket connection could not be established",
+            details=details,
         )
     return ws_client, None
 
 
-
 def _classify_api_status(
     error: HomeAssistantAPIError,
     error_msg: str,
@@ -202,13 +207,17 @@ def _classify_api_status(
             if entity_id:
                 result = create_entity_not_found_error(entity_id, details=error_msg)
             else:
-                result = create_error_response(ErrorCode.RESOURCE_NOT_FOUND, error_msg, context=context)
+                result = create_error_response(
+                    ErrorCode.RESOURCE_NOT_FOUND, error_msg, context=context
+                )
         case 401 | 403:
             result = create_auth_error(error_msg, context=context)
         case 400:
             result = create_validation_error(error_msg, context=context)
         case _:
-            result = create_error_response(ErrorCode.SERVICE_CALL_FAILED, error_msg, context=context)
+            result = create_error_response(
+                ErrorCode.SERVICE_CALL_FAILED, error_msg, context=context
+            )
     return result
 
 
@@ -244,7 +253,9 @@ def _classify_exception(
         case TimeoutError():
             operation = context.get("operation", "request") if context else "request"
             timeout_seconds = context.get("timeout_seconds", 30) if context else 30
-            result = create_timeout_error(operation, timeout_seconds, details=error_msg, context=context)
+            result = create_timeout_error(
+                operation, timeout_seconds, details=error_msg, context=context
+            )
         case ValueError():
             result = create_validation_error(error_msg, context=context)
 
@@ -276,7 +287,9 @@ def _classify_by_message(
                 "unknown type",
             )
         )
-        or re.search(r"expected (?:a |str|int|bool|dict|list|float|type|one of)", error_str)
+        or re.search(
+            r"expected (?:a |str|int|bool|dict|list|float|type|one of)", error_str
+        )
     ):
         # Supervisor schema validation: vol.Invalid message arriving as a
         # HomeAssistantCommandError via HA Core's hassio WS bridge. The
@@ -298,20 +311,27 @@ def _classify_by_message(
         if entity_id:
             result = create_entity_not_found_error(entity_id, details=error_msg)
         else:
-            result = create_error_response(ErrorCode.RESOURCE_NOT_FOUND, error_msg, context=context)
+            result = create_error_response(
+                ErrorCode.RESOURCE_NOT_FOUND, error_msg, context=context
+            )
     elif "timeout" in error_str:
-        result = create_timeout_error("operation", 30, details=error_msg, context=context)
+        result = create_timeout_error(
+            "operation", 30, details=error_msg, context=context
+        )
     elif "connection" in error_str or "connect" in error_str:
         result = create_connection_error(error_msg, context=context)
-    elif any(
-        phrase in error_str
-        for phrase in (
-            "unauthorized",
-            "authentication",
-            "invalid token",
-            "access denied",
+    elif (
+        any(
+            phrase in error_str
+            for phrase in (
+                "unauthorized",
+                "authentication",
+                "invalid token",
+                "access denied",
+            )
         )
-    ) or "401" in error_str:
+        or "401" in error_str
+    ):
         result = create_auth_error(error_msg, context=context)
     elif error_str.startswith("command failed:"):
         # HomeAssistantCommandError fallback: WS ``success=False`` with a
@@ -319,10 +339,15 @@ def _classify_by_message(
         # known failure mode (the WS command itself failed), not an
         # unexpected internal error — route to SERVICE_CALL_FAILED,
         # mirroring the 4xx fallback in _classify_api_status.
-        result = create_error_response(ErrorCode.SERVICE_CALL_FAILED, error_msg, context=context)
+        result = create_error_response(
+            ErrorCode.SERVICE_CALL_FAILED, error_msg, context=context
+        )
     else:
         result = create_error_response(
-            ErrorCode.INTERNAL_ERROR, "An unexpected error occurred", details=error_msg, context=context
+            ErrorCode.INTERNAL_ERROR,
+            "An unexpected error occurred",
+            details=error_msg,
+            context=context,
         )
     return result
 
@@ -418,7 +443,11 @@ def exception_to_structured_error(
     ):
         logger.exception("Unclassified exception: %s", error_msg)
 
-    if suggestions and "error" in error_response and isinstance(error_response["error"], dict):
+    if (
+        suggestions
+        and "error" in error_response
+        and isinstance(error_response["error"], dict)
+    ):
         # Set both `suggestion` (singular, first item) and `suggestions`
         # (plural, full list). create_error_response (errors.py) sets the
         # singular key; existing tests for exception_to_structured_error
@@ -535,6 +564,4 @@ def register_tool_methods(mcp: Any, instance: Any) -> None:
             mcp.add_tool(method)
             count += 1
     if count == 0:
-        logger.warning(
-            f"No @tool-decorated methods found on {type(instance).__name__}"
-        )
+        logger.warning(f"No @tool-decorated methods found on {type(instance).__name__}")

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630}/src/ha_mcp/tools/tools_code.py

@@ -1290,5 +1290,16 @@ def register_code_tools(mcp: Any, client: Any, **kwargs: Any) -> None:
                     "in-memory cache. Check operator logs for the "
                     "underlying I/O error."
                 )
+            elif not settings.code_mode_saved_tools_path:
+                # Blank path = persistence disabled: the in-memory save
+                # succeeded but is lost on restart. Surface a warning so
+                # the agent doesn't assume the entry is durable — mirrors
+                # the write-failure branch above.
+                response["data"]["save_warning"] = (
+                    f"save_as={save_as!r} is kept in memory only — "
+                    "code_mode_saved_tools_path is unset, so custom tools "
+                    "are not persisted and are lost on restart. Set a path "
+                    "on persistent storage to keep them."
+                )
 
         return response

{ha_mcp_dev-7.6.0.dev628 → ha_mcp_dev-7.6.0.dev630/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.6.0.dev628
+Version: 7.6.0.dev630
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT