ha-mcp-dev 7.6.0.dev610__tar.gz → 7.6.0.dev612__tar.gz

{ha_mcp_dev-7.6.0.dev610/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.6.0.dev612}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.6.0.dev610
+Version: 7.6.0.dev612
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.6.0.dev610"
+version = "7.6.0.dev612"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 requires-python = ">=3.13,<3.14"

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612}/src/ha_mcp/tools/best_practice_checker.py

@@ -77,6 +77,13 @@ _RE_SUN = re.compile(r"(?:is_state|state_attr|states)\s*\(\s*['\"]sun\.sun['\"]"
 _RE_STATE_IN = re.compile(r"states\s*\([^)]+\)\s+in\s+[\[(]")
 # Unsafe direct state access: states.sensor.x.state
 _RE_DIRECT_STATE = re.compile(r"\bstates\.\w+\.\w+\.state\b")
+# Duration/recency checks via last_changed or last_updated arithmetic.
+# Both alternations require at least one dotted qualifier (e.g. ``states.sensor.x.``)
+# so bare Jinja variables named ``last_changed`` are not falsely flagged.
+_RE_DURATION_MATH = re.compile(
+    r"\bnow\(\)\s*-\s*(?:\w+\.)+last_(?:changed|updated)\b"
+    r"|\b(?:\w+\.)+last_(?:changed|updated)\s*<\s*now\(\)"
+)
 # Motion entity pattern
 _RE_MOTION = re.compile(r"binary_sensor\.\w*motion", re.IGNORECASE)
 # Any Jinja template marker — catch-all and target-field scan.
@@ -273,6 +280,16 @@ def _check_template_string(
             "function instead (returns 'unknown' if missing rather than raising)."
             + _ref(skill_prefix, "template-guidelines.md#common-patterns")
         )
+    if _RE_DURATION_MATH.search(template):
+        warnings.append(
+            f"{label} uses template for duration/recency check "
+            "(`now() - X.last_changed/last_updated`) — use the native `for:` field "
+            "on a `state` trigger or condition instead "
+            "(e.g., `platform: state, entity_id: binary_sensor.motion, to: 'off', "
+            "for: {minutes: 5}`). Native `for:` is event-driven and avoids repeated "
+            "template evaluation on every state change."
+            + _ref(skill_prefix, "automation-patterns.md#native-conditions")
+        )
 
     # Generic fallback: any Jinja in this logic position that didn't match
     # a specific detector. Catches new anti-patterns (issue #1011) and
@@ -505,6 +522,19 @@ def _check_triggers(
                             "automation-patterns.md#trigger-types",
                         )
                     )
+                if _RE_DURATION_MATH.search(vt):
+                    warnings.append(
+                        "Trigger uses template for duration/recency check "
+                        "(`now() - X.last_changed/last_updated`) — use the native "
+                        "`for:` field on a `state` trigger instead "
+                        "(e.g., `platform: state, entity_id: binary_sensor.motion, "
+                        "to: 'off', for: {minutes: 5}`). Native `for:` is event-driven "
+                        "and doesn't re-evaluate on every state change."
+                        + _ref(
+                            skill_prefix,
+                            "automation-patterns.md#trigger-types",
+                        )
+                    )
                 # Generic fallback for unmatched template triggers.
                 if len(warnings) == initial and _RE_ANY_TEMPLATE.search(vt):
                     warnings.append(
@@ -518,6 +548,21 @@ def _check_triggers(
                         )
                     )
 
+        # numeric_state trigger: value_template can also contain duration math
+        # (e.g. transforming last_changed into a seconds value for the threshold).
+        if platform == "numeric_state":
+            vt = trigger.get("value_template", "")
+            if isinstance(vt, str) and _RE_DURATION_MATH.search(vt):
+                warnings.append(
+                    "`numeric_state` trigger uses `value_template` for duration/recency "
+                    "check (`now() - X.last_changed/last_updated`) — use the native "
+                    "`for:` field on a `state` trigger instead "
+                    "(e.g., `platform: state, entity_id: binary_sensor.motion, "
+                    "to: 'off', for: {minutes: 5}`). Native `for:` is event-driven "
+                    "and doesn't re-evaluate on every state change."
+                    + _ref(skill_prefix, "automation-patterns.md#trigger-types")
+                )
+
 
 # ---------------------------------------------------------------------------
 # Mode + motion check

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612}/src/ha_mcp/tools/tools_config_automations.py

@@ -482,8 +482,8 @@ class AutomationConfigTools:
           `{{ states(x) in [...] }}`
         - `condition: time` instead of `{{ now().hour ... }}` or `{{ now().weekday() ... }}`
         - `condition: sun` instead of `{{ is_state('sun.sun', ...) }}`
-        - Native `for:` field on `state`/`numeric_state` triggers and conditions over
-          `{{ now() - X.last_changed > timedelta(...) }}` duration math.
+        - Native `for:` field on `state`/`numeric_state` triggers and `state`
+          conditions over `{{ now() - X.last_changed > timedelta(...) }}` duration math.
         - `wait_for_trigger` instead of `wait_template`
         - `choose` action instead of template-based service names
         - For one-shot date firing, use a `time` trigger plus `automation.turn_off` on a

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612}/src/ha_mcp/tools/tools_config_scripts.py

@@ -436,6 +436,9 @@ class ConfigScriptTools:
         schema. Templates in logic positions fail silently and obscure intent.
         - `choose` / `if/then/else` instead of template-based service names
         - `wait_for_trigger` instead of `wait_template`
+        - Native `for:` field on `state` conditions inside `choose`/`if`, and on
+          `state`/`numeric_state` triggers in `wait_for_trigger`, instead of
+          `{{ now() - X.last_changed > timedelta(...) }}` duration math.
         - `repeat` with `for_each` instead of template loops
         - Hardcode `target.entity_id` literals — never `{{ this.entity_id }}`.
         Templates are appropriate ONLY in `data.*` fields, notification message/title,

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612}/src/ha_mcp/tools/tools_utility.py

@@ -1206,7 +1206,7 @@ def register_utility_tools(mcp: Any, client: Any, **kwargs: Any) -> None:
         - `condition: numeric_state` over `{{ states('x') | float > N }}`
         - `condition: state` over `{{ is_state(...) }}`
         - `condition: time` / `condition: sun` over `now().hour` / `is_state('sun.sun', ...)`
-        - Native `for:` field on state/numeric_state triggers and conditions over
+        - Native `for:` field on state/numeric_state triggers and state conditions over
           `{{ now() - X.last_changed > timedelta(...) }}` duration math
         - `choose` action over templated `service:` / `action:` strings
         See `ha_get_skill_guide` (best-practices skill) for the full anti-pattern list.

{ha_mcp_dev-7.6.0.dev610 → ha_mcp_dev-7.6.0.dev612/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.6.0.dev610
+Version: 7.6.0.dev612
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT