ha-mcp-dev 7.5.0.dev533__tar.gz → 7.5.0.dev535__tar.gz

{ha_mcp_dev-7.5.0.dev533/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.5.0.dev535}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev533
+Version: 7.5.0.dev535
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.5.0.dev533"
+version = "7.5.0.dev535"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 requires-python = ">=3.13,<3.14"

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535}/src/ha_mcp/tools/helpers.py

@@ -396,6 +396,19 @@ def exception_to_structured_error(
 
     error_response = _classify_exception(error, error_str, error_msg, context)
 
+    # Tracebacks are operationally valuable only for genuinely unclassified
+    # exceptions (programmer errors, library bugs) — every other branch in
+    # _classify_exception produces a structured signal that's sufficient on
+    # its own. Logging at exception level here gives operators line numbers
+    # for the bug class where ``str(error)`` is least informative, without
+    # re-introducing the duplicate ERROR-log noise that classified failures
+    # produced.
+    if (
+        isinstance(error_response.get("error"), dict)
+        and error_response["error"].get("code") == ErrorCode.INTERNAL_ERROR
+    ):
+        logger.exception("Unclassified exception: %s", error_msg)
+
     if suggestions and "error" in error_response and isinstance(error_response["error"], dict):
         # Set both `suggestion` (singular, first item) and `suggestions`
         # (plural, full list). create_error_response (errors.py) sets the

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535}/src/ha_mcp/tools/tools_config_automations.py

@@ -325,7 +325,6 @@ class AutomationConfigTools:
         except ToolError:
             raise
         except Exception as e:
-            logger.error(f"Error getting automation: {e}")
             exception_to_structured_error(
                 e,
                 context={"identifier": identifier, "action": "get"},
@@ -761,7 +760,6 @@ class AutomationConfigTools:
         except ToolError:
             raise
         except Exception as e:
-            logger.error(f"Error upserting automation: {e}")
             suggestions = [
                 "Check automation configuration format",
                 "Ensure required fields: alias, trigger, action",
@@ -1033,7 +1031,6 @@ class AutomationConfigTools:
         except ToolError:
             raise
         except Exception as e:
-            logger.error(f"Error deleting automation: {e}")
             exception_to_structured_error(
                 e,
                 context={"identifier": identifier, "action": "delete"},

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535}/src/ha_mcp/tools/tools_config_dashboards.py

@@ -803,12 +803,6 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
             raise
         except Exception as e:
             if search_mode:
-                logger.error(
-                    f"Error finding card in dashboard: url_path={url_path}, "
-                    f"entity_id={entity_id}, card_type={card_type}, heading={heading}, "
-                    f"error={e}",
-                    exc_info=True,
-                )
                 suggestions = [
                     "Check HA connection",
                     "Verify dashboard with ha_config_get_dashboard(list_only=True)",
@@ -821,7 +815,6 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
                     "heading": heading,
                 }
             else:
-                logger.error(f"Error getting dashboard: {e}", exc_info=True)
                 suggestions = [
                     "Use ha_config_get_dashboard(list_only=True) to see available dashboards",
                     "Check if you have permission to access this dashboard",
@@ -1482,7 +1475,6 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
         except ToolError:
             raise
         except Exception as e:
-            logger.error(f"Error setting dashboard: {e}")
             exception_to_structured_error(
                 e,
                 context={"action": "set", "url_path": url_path},
@@ -1564,8 +1556,6 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
                 else:
                     error_str = str(error_msg)
 
-                logger.error(f"Error deleting dashboard: {error_str}")
-
                 # If the error is "not found" / "doesn't exist", treat as success (idempotent)
                 if (
                     "unable to find" in error_str.lower()
@@ -1606,7 +1596,6 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
         except ToolError:
             raise
         except Exception as e:
-            logger.error(f"Error deleting dashboard: {e}")
             exception_to_structured_error(
                 e,
                 context={"action": "delete", "url_path": url_path},

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535}/src/ha_mcp/tools/tools_config_scripts.py

@@ -96,6 +96,8 @@ class ConfigScriptTools:
 
         The returned `config_hash` is stable across consecutive reads of an unchanged config — `compute_config_hash` documents the underlying contract.
 
+        The returned `script_id` is the canonical storage key resolved by the REST client (matching what `ha_config_set_script` / `ha_config_remove_script` expect), falling back to the input identifier on the rare path where the REST envelope omits it.
+
         EXAMPLES:
         - Get script: ha_config_get_script("morning_routine")
         - Get script: ha_config_get_script("backup_script")
@@ -128,10 +130,26 @@ class ConfigScriptTools:
             if cat_id:
                 config_result["category"] = cat_id
 
+            # Issue #1334: return the canonical storage key from the
+            # rest_client envelope so callers can thread the result into
+            # subsequent ha_config_*_script calls without re-resolving.
+            # Falls back to the input when the rest_client response omits
+            # the key — a contract violation that we surface via warning
+            # rather than mask silently.
+            canonical_id = config_result.get("script_id")
+            if canonical_id is None:
+                logger.warning(
+                    "get_script_config envelope missing 'script_id' for "
+                    "input %r; falling back to caller input. This indicates "
+                    "a rest_client contract violation.",
+                    script_id,
+                )
+                canonical_id = script_id
+
             return {
                 "success": True,
                 "action": "get",
-                "script_id": script_id,
+                "script_id": canonical_id,
                 "config": config_result,
                 "config_hash": config_hash_value,
             }

{ha_mcp_dev-7.5.0.dev533 → ha_mcp_dev-7.5.0.dev535/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev533
+Version: 7.5.0.dev535
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT