ha-mcp-dev 7.5.0.dev531__tar.gz → 7.5.0.dev533__tar.gz

{ha_mcp_dev-7.5.0.dev531/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.5.0.dev533}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev531
+Version: 7.5.0.dev533
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.5.0.dev531"
+version = "7.5.0.dev533"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 requires-python = ">=3.13,<3.14"

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/src/ha_mcp/tools/smart_search.py

@@ -22,6 +22,7 @@ from ..utils.fuzzy_search import (
     tokenize,
 )
 from .helpers import exception_to_structured_error, safe_info, safe_progress
+from .tools_config_dashboards import fetch_dashboards_list
 
 logger = logging.getLogger(__name__)
 
@@ -1773,14 +1774,9 @@ class SmartSearchTools:
             if "dashboard" in search_types:
                 try:
                     # List all storage-mode dashboards
-                    dash_list_resp = await self.client.send_websocket_message(
-                        {"type": "lovelace/dashboards/list"}
+                    dashboard_entries: list[dict[str, Any]] = (
+                        await fetch_dashboards_list(self.client) or []
                     )
-                    dashboard_entries: list[dict[str, Any]] = []
-                    if isinstance(dash_list_resp, dict) and dash_list_resp.get(
-                        "success"
-                    ):
-                        dashboard_entries = dash_list_resp.get("result", [])
 
                     # Build list of dashboards to search (include default)
                     dashboards_to_search: list[tuple[str, str]] = [

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/src/ha_mcp/tools/tools_config_automations.py

@@ -289,6 +289,21 @@ class AutomationConfigTools:
         For comprehensive automation documentation, use ha_get_skill_guide.
         """
         try:
+            # Empty/whitespace identifier would propagate to the internal
+            # config lookup and surface as a misleading
+            # ``RESOURCE_NOT_FOUND``. Structured ``VALIDATION_INVALID_PARAMETER``
+            # naming the parameter is cleaner — extension of the #1312
+            # validate_identifier_not_empty pattern to the automations
+            # family per #1313.
+            validate_identifier_not_empty(
+                identifier,
+                "identifier",
+                suggestions=[
+                    "Pass an automation entity_id (e.g. 'automation.morning_routine')",
+                    "Or pass the unique_id of an existing automation",
+                    "Use ha_search_entities(domain_filter='automation') to list automations",
+                ],
+            )
             normalized_config, config_hash = await self._get_automation_config_internal(identifier)
 
             # Resolve entity_id and fetch category from entity registry
@@ -542,6 +557,23 @@ class AutomationConfigTools:
         """
         bp_warnings: list[str] = []
         try:
+            # ``identifier`` is optional (omit → create new with generated
+            # unique_id; pass → update existing). When provided, reject
+            # empty/whitespace up-front so the caller gets a structured
+            # parameter error instead of a misleading ``RESOURCE_NOT_FOUND``
+            # from the downstream lookup. The ``not identifier`` check
+            # further down the python_transform branch still handles the
+            # explicit ``identifier is None`` case for that mode.
+            if identifier is not None:
+                validate_identifier_not_empty(
+                    identifier,
+                    "identifier",
+                    suggestions=[
+                        "Omit identifier to create a new automation",
+                        "Or pass a valid automation entity_id / unique_id to update",
+                    ],
+                    context={"action": "set"},
+                )
             # Validate mutual exclusivity of config and python_transform
             if config is not None and python_transform is not None:
                 raise_tool_error(

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/src/ha_mcp/tools/tools_config_dashboards.py

@@ -26,6 +26,7 @@ from .helpers import (
     extract_tool_error_message,
     log_tool_usage,
     raise_tool_error,
+    validate_identifier_not_empty,
 )
 from .util_helpers import parse_json_param
 
@@ -322,7 +323,7 @@ def _should_lazy_resolve(error_msg: str) -> bool:
     return _LAZY_RESOLVE_TRIGGER in error_msg
 
 
-async def _fetch_dashboards_list(
+async def fetch_dashboards_list(
     client: Any,
 ) -> list[dict[str, Any]] | None:
     """Fetch and normalise the lovelace/dashboards/list WebSocket response.
@@ -380,7 +381,7 @@ async def _resolve_dashboard(
       to the registry id before issuing the delete. Discards
       ``dashboards``.
     """
-    dashboards = await _fetch_dashboards_list(client)
+    dashboards = await fetch_dashboards_list(client)
     if dashboards is None:
         return None, None
 
@@ -597,7 +598,7 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
         try:
             # List mode
             if list_only:
-                dashboards = await _fetch_dashboards_list(client) or []
+                dashboards = await fetch_dashboards_list(client) or []
                 return {
                     "success": True,
                     "action": "list",
@@ -605,6 +606,25 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
                     "count": len(dashboards),
                 }
 
+            # ``url_path`` is optional in this tool (omitted with
+            # ``list_only=True`` lists all dashboards — handled above; omitted
+            # without ``list_only`` falls back to the default dashboard via
+            # the resolver below). When provided, reject empty/whitespace
+            # up-front so the caller gets a structured parameter error
+            # instead of a misleading ``RESOURCE_NOT_FOUND``. Extension of
+            # the #1312 validate_identifier_not_empty pattern to the
+            # dashboards family per #1313.
+            if url_path is not None:
+                validate_identifier_not_empty(
+                    url_path,
+                    "url_path",
+                    suggestions=[
+                        "Pass a dashboard URL path (e.g. 'lovelace-home')",
+                        "Omit url_path and pass list_only=True to list dashboards",
+                        "Use 'default' to target the default dashboard",
+                    ],
+                )
+
             # Search mode — find cards, badges, or header cards
             if search_mode:
                 get_data: dict[str, Any] = {"type": "lovelace/config", "force": True}
@@ -996,6 +1016,22 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
         are also updated if explicitly provided alongside (or instead of) a config change.
         """
         try:
+            # ``url_path`` is required (always non-None). Reject empty/
+            # whitespace up-front so the caller gets a structured parameter
+            # error instead of a misleading downstream failure (the
+            # subsequent "default" alias, pre-resolver, and hyphen check
+            # all assume a usable string). Extension of the #1312
+            # validate_identifier_not_empty pattern to the dashboards
+            # family per #1313.
+            validate_identifier_not_empty(
+                url_path,
+                "url_path",
+                suggestions=[
+                    "Pass a dashboard URL path (e.g. 'my-dashboard')",
+                    "Use 'default' or 'lovelace' for the default dashboard",
+                ],
+                context={"action": "set"},
+            )
             # Handle "default" as alias for the default dashboard
             # (matches ha_config_get_dashboard behavior)
             if url_path == "default":
@@ -1213,9 +1249,7 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
             if pre_fetched_dashboards is not None:
                 existing_dashboards = pre_fetched_dashboards
             else:
-                existing_dashboards = (
-                    await _fetch_dashboards_list(client) or []
-                )
+                existing_dashboards = await fetch_dashboards_list(client) or []
             dashboard_exists = any(
                 d.get("url_path") == url_path for d in existing_dashboards
             )
@@ -1490,6 +1524,20 @@ def register_config_dashboard_tools(mcp: Any, client: Any, **kwargs: Any) -> Non
         Note: The default dashboard cannot be deleted via this method.
         """
         try:
+            # ``url_path`` is required. Reject empty/whitespace up-front so
+            # the caller gets a structured parameter error instead of a
+            # misleading "no dashboard found" from the resolver below.
+            # Extension of the #1312 validate_identifier_not_empty pattern
+            # to the dashboards family per #1313.
+            validate_identifier_not_empty(
+                url_path,
+                "url_path",
+                suggestions=[
+                    "Pass a dashboard URL path or internal ID (e.g. 'my-dashboard')",
+                    "Use ha_config_get_dashboard(list_only=True) to list dashboards",
+                ],
+                context={"action": "delete"},
+            )
             resolved, _ = await _resolve_dashboard(client, url_path)
             if resolved is None:
                 raise_tool_error(

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/src/ha_mcp/tools/tools_config_scripts.py

@@ -103,6 +103,19 @@ class ConfigScriptTools:
         For detailed script configuration help, use ha_get_skill_guide.
         """
         try:
+            # Empty/whitespace script_id would propagate to
+            # ``get_script_config`` and surface as a misleading
+            # ``RESOURCE_NOT_FOUND``. Extension of the #1312
+            # validate_identifier_not_empty pattern to the scripts
+            # family per #1313.
+            validate_identifier_not_empty(
+                script_id,
+                "script_id",
+                suggestions=[
+                    "Pass a script identifier (e.g. 'morning_routine')",
+                    "Use ha_search_entities(domain_filter='script') to list scripts",
+                ],
+            )
             config_result = await self._client.get_script_config(script_id)
             # Extract actual script config body and compute hash before category injection
             actual_config = config_result.get("config", config_result)
@@ -412,6 +425,21 @@ class ConfigScriptTools:
         """
         bp_warnings: list[str] = []
         try:
+            # ``script_id`` is required (always non-None). Reject empty/
+            # whitespace up-front so the caller gets a structured parameter
+            # error instead of a misleading ``RESOURCE_NOT_FOUND`` from
+            # the downstream upsert/fetch. Extension of the #1312
+            # validate_identifier_not_empty pattern to the scripts family
+            # per #1313.
+            validate_identifier_not_empty(
+                script_id,
+                "script_id",
+                suggestions=[
+                    "Pass a script identifier (e.g. 'morning_routine')",
+                    "Use ha_search_entities(domain_filter='script') to list scripts",
+                ],
+                context={"action": "set"},
+            )
             # Validate mutual exclusivity of config and python_transform
             if config is not None and python_transform is not None:
                 raise_tool_error(

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533}/src/ha_mcp/tools/tools_yaml_config.py

@@ -20,6 +20,7 @@ from pydantic import Field
 from ..config import get_global_settings
 from ..errors import ErrorCode, create_error_response
 from .helpers import exception_to_structured_error, log_tool_usage, raise_tool_error
+from .tools_config_dashboards import fetch_dashboards_list
 from .tools_filesystem import (
     MCP_TOOLS_DOMAIN,
     _assert_mcp_tools_available,
@@ -45,9 +46,7 @@ async def _check_storage_mode_dashboard_collision(
         return
     url_path = yaml_path[len(_LOVELACE_DASHBOARD_PREFIX):]
     try:
-        result = await client.send_websocket_message(
-            {"type": "lovelace/dashboards/list"}
-        )
+        dashboards = await fetch_dashboards_list(client)
     except Exception as exc:
         logger.warning(
             "lovelace/dashboards/list WS query failed (%s); skipping collision check",
@@ -55,18 +54,6 @@ async def _check_storage_mode_dashboard_collision(
         )
         return
 
-    if isinstance(result, dict) and "result" in result:
-        dashboards = result["result"]
-    elif isinstance(result, list):
-        dashboards = result
-    else:
-        logger.warning(
-            "lovelace/dashboards/list returned unexpected shape (%s); "
-            "skipping collision check",
-            type(result).__name__,
-        )
-        return
-
     for entry in dashboards or []:
         if (
             isinstance(entry, dict)

{ha_mcp_dev-7.5.0.dev531 → ha_mcp_dev-7.5.0.dev533/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev531
+Version: 7.5.0.dev533
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT