ha-mcp-dev 7.5.0.dev527__tar.gz → 7.5.0.dev529__tar.gz

{ha_mcp_dev-7.5.0.dev527/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.5.0.dev529}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev527
+Version: 7.5.0.dev529
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.5.0.dev527 → ha_mcp_dev-7.5.0.dev529}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.5.0.dev527"
+version = "7.5.0.dev529"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 requires-python = ">=3.13,<3.14"

{ha_mcp_dev-7.5.0.dev527 → ha_mcp_dev-7.5.0.dev529}/src/ha_mcp/tools/tools_addons.py

@@ -1554,19 +1554,36 @@ async def _call_addon_api(
                 "token has admin rights and try again."
             )
         elif response.status_code == 403:
+            ports_dict = addon.get("network") or addon.get("ports") or {}
+            # Ingress nginx in peer add-ons typically rejects cross-container
+            # traffic; the direct-port fallback only works if the user mapped
+            # a host port. Detect and call out the unmapped case explicitly.
+            unmapped = sorted(k for k, v in ports_dict.items() if v is None)
             result["addon_config"] = {
                 "options": addon.get("options"),
-                "ports": addon.get("network") or addon.get("ports"),
+                "ports": ports_dict or None,
                 "host_network": addon.get("host_network"),
                 "ingress_port": addon.get("ingress_port"),
             }
-            result["suggestion"] = (
-                "This add-on is blocking direct connections (likely Nginx IP restriction). "
-                "Try using the 'port' parameter to connect to the add-on's direct access port "
-                "(see addon_config.ports above) with 'leave_front_door_open' enabled. "
-                "Example: ha_manage_addon(slug='...', path='...', port=<direct_port>). "
-                "The user may need to change add-on settings in the HA UI and restart the add-on."
-            )
+            slug = addon.get("slug") or "<slug>"
+            example_proto = unmapped[0] if unmapped else ""
+            example_port = example_proto.split("/", 1)[0] if example_proto else ""
+            if unmapped and example_port.isdigit():
+                addon_label = addon.get("name") or slug
+                result["suggestion"] = (
+                    f"Map {example_proto} to a host port in the HA UI "
+                    f"('{addon_label}' → Configuration → Network), restart the "
+                    f"add-on, then retry with ha_manage_addon(slug='{slug}', "
+                    f"path='...', port={example_port})."
+                )
+            else:
+                result["suggestion"] = (
+                    "This add-on is blocking direct connections (likely Nginx IP restriction). "
+                    "Try using the 'port' parameter to connect to the add-on's direct access port "
+                    "(see addon_config.ports above) with 'leave_front_door_open' enabled. "
+                    "Example: ha_manage_addon(slug='...', path='...', port=<direct_port>). "
+                    "The user may need to change add-on settings in the HA UI and restart the add-on."
+                )
 
     return result
 

{ha_mcp_dev-7.5.0.dev527 → ha_mcp_dev-7.5.0.dev529}/src/ha_mcp/tools/tools_config_scenes.py

@@ -32,6 +32,7 @@ from .helpers import (
     log_tool_usage,
     raise_tool_error,
     register_tool_methods,
+    validate_identifier_not_empty,
 )
 from .reference_validator import validate_config_references
 from .util_helpers import (
@@ -221,20 +222,20 @@ class ConfigSceneTools:
             # Issue #1168 R6 blocker 16: empty ``scene_id`` previously
             # surfaced as ``RESOURCE_NOT_FOUND`` with a misleading
             # `entities`-related suggestion. Pre-flight here so the caller
-            # gets the actual problem.
-            if not scene_id or not scene_id.strip():
-                raise_tool_error(
-                    create_error_response(
-                        ErrorCode.VALIDATION_INVALID_PARAMETER,
-                        "scene_id must not be empty",
-                        suggestions=[
-                            "Pass a non-empty scene identifier (e.g. 'movie_night')",
-                            "Use ha_search_entities(domain_filter='scene') "
-                            "to find existing scene_ids",
-                        ],
-                        context={"scene_id": scene_id},
-                    )
-                )
+            # gets the actual problem. Migrated to the shared
+            # ``validate_identifier_not_empty`` helper (#1314) — message
+            # and ``context["scene_id"]`` key preserved for callers.
+            validate_identifier_not_empty(
+                scene_id,
+                "scene_id",
+                message="scene_id must not be empty",
+                suggestions=[
+                    "Pass a non-empty scene identifier (e.g. 'movie_night')",
+                    "Use ha_search_entities(domain_filter='scene') "
+                    "to find existing scene_ids",
+                ],
+                context={"scene_id": scene_id},
+            )
             # Issue #1168 R3 blockers 3 + 6: unwrap the rest-client envelope
             # so the response carries the scene body directly (no nested
             # `success`/`scene_id`/`config` chain), and use the storage key
@@ -520,19 +521,19 @@ class ConfigSceneTools:
             # Issue #1168 R6 blocker 16: empty ``scene_id`` pre-flight before
             # any config dispatch — keeps the error code/message aligned with
             # the actual problem rather than the misleading
-            # ``RESOURCE_NOT_FOUND`` from a downstream lookup.
-            if not scene_id or not scene_id.strip():
-                raise_tool_error(
-                    create_error_response(
-                        ErrorCode.VALIDATION_INVALID_PARAMETER,
-                        "scene_id must not be empty",
-                        suggestions=[
-                            "Pass a non-empty scene identifier (e.g. 'movie_night')",
-                            "For a fresh create, use a name-derived slug",
-                        ],
-                        context={"scene_id": scene_id},
-                    )
-                )
+            # ``RESOURCE_NOT_FOUND`` from a downstream lookup. Migrated to
+            # the shared ``validate_identifier_not_empty`` helper (#1314) —
+            # message and ``context["scene_id"]`` key preserved for callers.
+            validate_identifier_not_empty(
+                scene_id,
+                "scene_id",
+                message="scene_id must not be empty",
+                suggestions=[
+                    "Pass a non-empty scene identifier (e.g. 'movie_night')",
+                    "For a fresh create, use a name-derived slug",
+                ],
+                context={"scene_id": scene_id},
+            )
             # Validate mutual exclusivity of config and python_transform
             if config is not None and python_transform is not None:
                 raise_tool_error(
@@ -942,20 +943,20 @@ class ConfigSceneTools:
         try:
             # Issue #1168 R6 blocker 16: empty ``scene_id`` pre-flight before
             # the resolver — keeps the error code/message aligned with the
-            # actual problem.
-            if not scene_id or not scene_id.strip():
-                raise_tool_error(
-                    create_error_response(
-                        ErrorCode.VALIDATION_INVALID_PARAMETER,
-                        "scene_id must not be empty",
-                        suggestions=[
-                            "Pass a non-empty scene identifier (e.g. 'old_scene')",
-                            "Use ha_search_entities(domain_filter='scene') "
-                            "to find existing scene_ids",
-                        ],
-                        context={"scene_id": scene_id},
-                    )
-                )
+            # actual problem. Migrated to the shared
+            # ``validate_identifier_not_empty`` helper (#1314) — message
+            # and ``context["scene_id"]`` key preserved for callers.
+            validate_identifier_not_empty(
+                scene_id,
+                "scene_id",
+                message="scene_id must not be empty",
+                suggestions=[
+                    "Pass a non-empty scene identifier (e.g. 'old_scene')",
+                    "Use ha_search_entities(domain_filter='scene') "
+                    "to find existing scene_ids",
+                ],
+                context={"scene_id": scene_id},
+            )
             # Issue #1168 R3 blocker 6: resolve once up-front so every later
             # callsite (entity_id resolver, delete call, response) uses the
             # storage key consistently — outer ``scene_id`` matches the

{ha_mcp_dev-7.5.0.dev527 → ha_mcp_dev-7.5.0.dev529/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.5.0.dev527
+Version: 7.5.0.dev529
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT