ha-mcp-dev 7.14.2.dev2180__tar.gz → 7.14.2.dev2183__tar.gz

{ha_mcp_dev-7.14.2.dev2180/src/ha_mcp_dev.egg-info → ha_mcp_dev-7.14.2.dev2183}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.14.2.dev2180
+Version: 7.14.2.dev2183
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ha-mcp-dev"
-version = "7.14.2.dev2180"
+version = "7.14.2.dev2183"
 description = "Home Assistant MCP Server - Complete control of Home Assistant through MCP"
 readme = "README.md"
 # Upper bound widened to <3.15 so the package installs on Home Assistant's
@@ -141,6 +141,26 @@ select = [
     "A",     # builtin shadowing
     "LOG",   # logging best practices
     "SIM",   # simplify
+    "PLE",   # pylint errors (real bugs: bad logging args, await outside async)
+    # Targeted pylint conventions/refactors/warnings. The PL family is NOT
+    # selected wholesale: PLC0415 (import-outside-top-level) fights the
+    # deliberate lazy-init architecture, and PLR2004 (magic values),
+    # PLR0913/PLR0917 (wide FastMCP tool signatures) and PLR0911 (too many
+    # returns -- a separate signal from C901's cyclomatic complexity, and
+    # noisy on this codebase's early-return validation style) are noise
+    # here. Add codes individually so a new upstream PLR rule does not land
+    # enabled by default.
+    "PLC0206", # dict-index-missing-items
+    "PLC0207", # missing-maxsplit-arg
+    "PLR0402", # manual-from-import
+    "PLR1711", # useless-return
+    "PLR1714", # repeated-equality-comparison
+    "PLR1730", # if-stmt-min-max
+    "PLR5501", # collapsible-else-if
+    "PLW0108", # unnecessary-lambda
+    "PLW0602", # global-variable-not-assigned
+    "PLW1510", # subprocess-run-without-check
+    "PLW2901", # redefined-loop-name
 ]
 ignore = [
     "E501",    # line too long — formatter handles this
@@ -163,6 +183,12 @@ ignore = [
 [tool.ruff.lint.per-file-ignores]
 "__init__.py" = ["F401"]
 "tests/**/*" = ["E501", "B011"]
+# Temporary: the equivalent PLC0207/PLR5501 fixes landed in
+# homeassistant-addon-webhook-proxy-dev/ only, per the dev-first/promote-only
+# flow (allow-stable-edit is for stable-only hotfixes, not routine sweeps —
+# see homeassistant-addon-webhook-proxy/AGENTS.md "Dev-first, promote-only").
+# Remove this ignore once the next promote carries the fix into stable.
+"homeassistant-addon-webhook-proxy/**" = ["PLC0207", "PLR5501"]
 # C901 is enforced repo-wide with no per-file exemptions (the grandfathered
 # list was fully cleared by issue #925). Do NOT add "path" = ["C901"] entries
 # here — extract helpers to bring the function below the threshold instead:

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/__main__.py

@@ -574,8 +574,6 @@ def _get_timestamped_uvicorn_log_config() -> dict:
 
 async def _cleanup_resources() -> None:
     """Clean up all server resources gracefully."""
-    global _server
-
     logger.info("Cleaning up server resources...")
 
     # Close WebSocket listener service if running
@@ -730,7 +728,7 @@ def _signal_handler(signum: int, frame: Any) -> None:
     This handler initiates graceful shutdown on first signal.
     On second signal, forces immediate exit.
     """
-    global _shutdown_in_progress, _shutdown_event
+    global _shutdown_in_progress
 
     sig_name = signal.Signals(signum).name
 

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/backup_manager.py

@@ -1128,15 +1128,15 @@ def _diff_dict_node(
     max_ops: int,
 ) -> None:
     """Diff two dicts into JSON-Patch ops (add/remove/recurse per key)."""
-    for key in stored:
+    for key, stored_value in stored.items():
         seg = _pointer_segment(str(key))
         sub_path = f"{path}/{seg}"
         if key not in current:
-            out.append({"op": "add", "path": sub_path, "value": stored[key]})
+            out.append({"op": "add", "path": sub_path, "value": stored_value})
             if len(out) >= max_ops:
                 return
         else:
-            _diff_node(stored[key], current[key], sub_path, out, max_ops)
+            _diff_node(stored_value, current[key], sub_path, out, max_ops)
             if len(out) >= max_ops:
                 return
     for key in current:

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/policy/evaluator.py

@@ -128,7 +128,7 @@ def match_predicate(predicate: Predicate, args: dict[str, Any]) -> bool:
 
 
 def match_rule(rule: Rule, tool_name: str, args: dict[str, Any]) -> bool:
-    if rule.tool_name != "*" and rule.tool_name != tool_name:
+    if rule.tool_name not in ("*", tool_name):
         return False
     return all(match_predicate(p, args) for p in rule.when)
 

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/settings_ui/_persistence.py

@@ -116,14 +116,14 @@ def _seed_tool_config_from_env(settings: Settings) -> dict[str, str]:
     tools: dict[str, str] = {}
     disabled_raw = getattr(settings, "disabled_tools", "")
     if disabled_raw:
-        for name in disabled_raw.split(","):
-            name = name.strip()
+        for raw_name in disabled_raw.split(","):
+            name = raw_name.strip()
             if name:
                 tools[name] = "disabled"
     pinned_raw = getattr(settings, "pinned_tools", "")
     if pinned_raw:
-        for name in pinned_raw.split(","):
-            name = name.strip()
+        for raw_name in pinned_raw.split(","):
+            name = raw_name.strip()
             if name and name not in tools:
                 tools[name] = "pinned"
     return tools
@@ -176,12 +176,12 @@ def env_pinned_tools(settings: Settings | None = None) -> dict[str, str]:
     if settings is None:
         settings = get_global_settings()
     pinned: dict[str, str] = {}
-    for name in (settings.disabled_tools or "").split(","):
-        name = name.strip()
+    for raw_name in (settings.disabled_tools or "").split(","):
+        name = raw_name.strip()
         if name:
             pinned[name] = "disabled"
-    for name in (settings.pinned_tools or "").split(","):
-        name = name.strip()
+    for raw_name in (settings.pinned_tools or "").split(","):
+        name = raw_name.strip()
         if name:
             pinned[name] = "pinned"
     return pinned

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/device_control.py

@@ -126,7 +126,7 @@ class DeviceControlTools:
                     )
                 )
 
-            domain = entity_id.split(".")[0]
+            domain = entity_id.split(".", maxsplit=1)[0]
             handler = get_domain_handler(domain)
 
             # Validate entity exists if requested
@@ -749,7 +749,7 @@ class DeviceControlTools:
         try:
             if "." not in entity_id:
                 return None
-            domain = entity_id.split(".")[0]
+            domain = entity_id.split(".", maxsplit=1)[0]
             handler = get_domain_handler(domain)
             valid_actions = handler.get("valid_actions", ["on", "off", "toggle"])
             if action not in valid_actions:

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/smart_search/_entities.py

@@ -680,7 +680,7 @@ class EntitySearchMixin(_SearchBase):
             "_hidden_by": "hidden" if entity_id in hidden_entity_ids else None,
         }
         if include_domain:
-            record["domain"] = entity_id.split(".")[0]
+            record["domain"] = entity_id.split(".", maxsplit=1)[0]
         return record
 
     @classmethod

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_addons.py

@@ -80,15 +80,13 @@ def _slice_ws_messages(
     offset/limit were applied.
     """
     total_collected = len(messages)
-    if offset < 0:
-        offset = 0
+    offset = max(offset, 0)
     if offset > total_collected:
         sliced: list[Any] = []
     elif limit is None:
         sliced = messages[offset:]
     else:
-        if limit < 0:
-            limit = 0
+        limit = max(limit, 0)
         sliced = messages[offset : offset + limit]
 
     pagination: dict[str, Any] = {
@@ -158,9 +156,8 @@ def _summarize_ws_messages(
                 flush(i)
                 run_start = None
             result.append(msg)
-        else:
-            if run_start is None:
-                run_start = i
+        elif run_start is None:
+            run_start = i
 
     if run_start is not None:
         flush(len(messages))

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_camera.py

@@ -120,7 +120,7 @@ class CameraTools:
                 "Expected format: camera.entity_name"
             )
 
-        domain = entity_id.split(".")[0]
+        domain = entity_id.split(".", maxsplit=1)[0]
         if domain != "camera":
             raise ValueError(
                 f"Entity {entity_id} is not a camera entity. "

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_config_dashboards.py

@@ -745,9 +745,8 @@ def _card_matches(
             pattern = entity_id.replace(".", r"\.").replace("*", ".*")
             if not any(re.match(pattern, e) for e in all_entities if e):
                 return False
-        else:
-            if entity_id not in all_entities:
-                return False
+        elif entity_id not in all_entities:
+            return False
 
     # Heading filter (for heading cards or section titles)
     if heading is not None:

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_entities.py

@@ -594,8 +594,8 @@ class EntityTools:
                     context={"new_entity_id": new_entity_id},
                 )
             )
-        current_domain = entity_id.split(".")[0]
-        new_domain = new_entity_id.split(".")[0]
+        current_domain = entity_id.split(".", maxsplit=1)[0]
+        new_domain = new_entity_id.split(".", maxsplit=1)[0]
         if current_domain != new_domain:
             raise_tool_error(
                 create_error_response(

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_registry.py

@@ -50,7 +50,11 @@ def _process_device_domain(
         return value, is_z2m, zwave_node_id
     # Z2M: identifier is ["mqtt", "zigbee2mqtt_0xIEEE"] or "zigbee2mqtt_bridge_0xIEEE"
     if domain == "mqtt" and "zigbee2mqtt" in value.lower():
-        extracted = "0x" + value.split("_0x")[-1] if "_0x" in value else ieee_address
+        extracted = (
+            "0x" + value.rsplit("_0x", maxsplit=1)[-1]
+            if "_0x" in value
+            else ieee_address
+        )
         return extracted, True, zwave_node_id
     # Z-Wave JS: identifier is ["zwave_js", "{home_id}-{node_id}"]
     if domain == "zwave_js" and "-" in value:

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_resources.py

@@ -333,7 +333,7 @@ def _decode_legacy_worker_url(url: str) -> str | None:
         return None
     try:
         # Extract base64 part: https://worker.dev/{base64}?type=module
-        encoded = url[len(prefix) :].split("?")[0]
+        encoded = url[len(prefix) :].split("?", maxsplit=1)[0]
         # validate=True mirrors _decode_data_uri: urlsafe_b64decode otherwise
         # silently DISCARDS non-alphabet characters, so a junk path could
         # decode to plausible text and be masked as inline content.

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/tools/tools_traces.py

@@ -734,7 +734,7 @@ def _categorize_step_path(path: str, domain: str) -> str | None:
         return "condition"
     if path == "action" or path.startswith(("action/", "sequence/")):
         return "action"
-    if domain == "script" and path.split("/")[0].isdigit():
+    if domain == "script" and path.split("/", maxsplit=1)[0].isdigit():
         return "action"
     return None
 

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/utils/domain_handlers.py

@@ -205,7 +205,7 @@ def get_domain_handler(entity_id: str) -> dict[str, Any]:
         # Fallback for invalid entity ID format
         return get_default_handler()
 
-    domain = entity_id.split(".")[0]
+    domain = entity_id.split(".", maxsplit=1)[0]
     return DOMAIN_HANDLERS.get(domain, get_default_handler())
 
 

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/src/ha_mcp/visibility/resolver.py

@@ -185,7 +185,7 @@ def _is_assist_exposed(
         entry.get("entity_category") is not None or entry.get("hidden_by") is not None
     ):
         return False
-    domain = eid.split(".")[0]
+    domain = eid.split(".", maxsplit=1)[0]
     if domain in DEFAULT_EXPOSED_DOMAINS:
         return True
     if domain == "binary_sensor":

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183/src/ha_mcp_dev.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ha-mcp-dev
-Version: 7.14.2.dev2180
+Version: 7.14.2.dev2183
 Summary: Home Assistant MCP Server - Complete control of Home Assistant through MCP
 Author-email: Julien <github@qc-h.net>
 License: MIT

{ha_mcp_dev-7.14.2.dev2180 → ha_mcp_dev-7.14.2.dev2183}/tests/test_env_manager.py

@@ -220,7 +220,9 @@ class HomeAssistantTestEnvironment:
         cmd = [sys.executable, "-m", "pytest", "tests/src/e2e/", "-v", "--tb=short"]
 
         try:
-            result = subprocess.run(cmd, env=env, cwd=Path(__file__).parent.parent)
+            result = subprocess.run(
+                cmd, env=env, cwd=Path(__file__).parent.parent, check=False
+            )
             if result.returncode == 0:
                 logger.info("✅ All tests passed!")
             else: