ha-deploy-kit 0.1.3__tar.gz → 0.1.4__tar.gz

{ha_deploy_kit-0.1.3 → ha_deploy_kit-0.1.4}/CHANGELOG.md

@@ -1,6 +1,21 @@
 # CHANGELOG
 
 
+## v0.1.4 (2026-10-29)
+
+### Bug Fixes
+
+- **ha**: Do not forward injected user_input into the restart confirm step
+  ([`31fdb48`](https://github.com/latrekc-meta/ha-deploy-kit/commit/31fdb48b7c344ef0fb49b8459a58df54e3d7613c))
+
+HA seeds the first fix-flow step's user_input with {"issue_id": ...} (RepairsFlowManager.async_init
+  -> data_entry_flow feeds it to async_step_init). async_step_init forwarded that into
+  async_step_confirm_restart, whose user_input-is-not-None branch then restarted Home Assistant the
+  instant the issue was opened -- no confirmation. Mirror HA's own ConfirmRepairFlow:
+  async_step_init delegates WITHOUT forwarding user_input, so the restart fires only on a real
+  submit. Add a regression test that opens the flow with {"issue_id": ...} and asserts no restart.
+
+
 ## v0.1.3 (2026-10-29)
 
 ### Bug Fixes

{ha_deploy_kit-0.1.3 → ha_deploy_kit-0.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: ha-deploy-kit
-Version: 0.1.3
+Version: 0.1.4
 Summary: HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components
 Project-URL: Homepage, https://github.com/latrekc-meta/ha-deploy-kit
 Project-URL: Repository, https://github.com/latrekc-meta/ha-deploy-kit

{ha_deploy_kit-0.1.3 → ha_deploy_kit-0.1.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "ha-deploy-kit"
-version = "0.1.3"
+version = "0.1.4"
 description = "HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components"
 readme = "README.md"
 license = { file = "LICENSE" }

{ha_deploy_kit-0.1.3 → ha_deploy_kit-0.1.4}/src/ha_deploy_kit/ha/repairs_flow.py

@@ -1,17 +1,20 @@
 """Optional opt-in confirm-and-restart Repairs flow.
 
 Opening the Repairs issue shows a confirmation dialog; the restart happens ONLY
-when the user submits it. The form is shown WITHOUT a data schema: Home Assistant
-renders a confirmation that waits for the user. (An empty ``vol.Schema({})`` has
-no fields, so the frontend auto-submits it and restarts immediately -- that is the
-bug this avoids.) No executable restart lives in the core engine; this flow is the
-single opt-in place a consumer may wire it.
+when the user submits it. This mirrors Home Assistant's own ``ConfirmRepairFlow``:
+``async_step_init`` delegates to the confirm step WITHOUT forwarding ``user_input``.
+That matters because HA seeds the first step's ``user_input`` with
+``{"issue_id": ...}`` (see repairs ``RepairsFlowManager.async_init``); forwarding it
+would look like a submit and restart Home Assistant the instant the issue is
+opened. No executable restart lives in the core engine; this flow is the single
+opt-in place a consumer may wire it.
 """
 
 from __future__ import annotations
 
 from typing import TYPE_CHECKING, Any
 
+import voluptuous as vol
 from homeassistant.components.repairs import RepairsFlow
 
 if TYPE_CHECKING:
@@ -25,16 +28,19 @@ class _RestartRequiredFixFlow(RepairsFlow):
     async def async_step_init(
         self, user_input: dict[str, Any] | None = None
     ) -> FlowResult:
-        return await self.async_step_confirm_restart(user_input)
+        # Do NOT forward user_input: HA seeds the first step with
+        # {"issue_id": ...}, which would look like a submit and restart on open.
+        return await self.async_step_confirm_restart()
 
     async def async_step_confirm_restart(
         self, user_input: dict[str, Any] | None = None
     ) -> FlowResult:
-        if user_input is None:
-            # No data schema: HA renders a confirmation that waits for submit.
-            return self.async_show_form(step_id="confirm_restart")
-        await self.hass.services.async_call("homeassistant", "restart")
-        return self.async_create_entry(title="", data={})
+        if user_input is not None:
+            await self.hass.services.async_call("homeassistant", "restart")
+            return self.async_create_entry(title="", data={})
+        return self.async_show_form(
+            step_id="confirm_restart", data_schema=vol.Schema({})
+        )
 
 
 def async_create_restart_fix_flow(

{ha_deploy_kit-0.1.3 → ha_deploy_kit-0.1.4}/tests/ha/test_repairs_flow.py

@@ -6,21 +6,32 @@ from ha_deploy_kit.ha import async_create_restart_fix_flow
 pytestmark = pytest.mark.ha
 
 
-async def test_showing_the_form_never_restarts(hass):
+async def test_opening_the_issue_shows_the_form_and_never_restarts(hass):
+    # HA seeds the first step's user_input with {"issue_id": ...} (see
+    # RepairsFlowManager.async_init). async_step_init must still only SHOW the
+    # confirmation dialog -- never restart on open.
     calls = async_mock_service(hass, "homeassistant", "restart")
 
     flow = async_create_restart_fix_flow(hass, "restart_required")
     assert flow is not None
     flow.hass = hass
 
-    shown = await flow.async_step_init()
+    shown = await flow.async_step_init({"issue_id": "restart_required"})
     assert shown["type"] == "form"
     assert shown["step_id"] == "confirm_restart"
-    # No data schema: HA must render a confirmation that WAITS for submit. An
-    # empty vol.Schema({}) would be auto-submitted by the frontend and restart
-    # immediately -- guard against that regression.
-    assert shown["data_schema"] is None
-    assert len(calls) == 0  # merely showing the confirmation dialog never restarts
+    assert len(calls) == 0  # opening the issue must not restart
+
+
+async def test_init_without_input_shows_the_form(hass):
+    calls = async_mock_service(hass, "homeassistant", "restart")
+
+    flow = async_create_restart_fix_flow(hass, "restart_required")
+    assert flow is not None
+    flow.hass = hass
+
+    shown = await flow.async_step_init()
+    assert shown["type"] == "form"
+    assert len(calls) == 0
 
 
 async def test_restart_only_after_submitting_the_dialog(hass):