ha-deploy-kit 0.1.2__tar.gz → 0.1.4__tar.gz

{ha_deploy_kit-0.1.2 → ha_deploy_kit-0.1.4}/CHANGELOG.md

@@ -1,6 +1,35 @@
 # CHANGELOG
 
 
+## v0.1.4 (2026-10-29)
+
+### Bug Fixes
+
+- **ha**: Do not forward injected user_input into the restart confirm step
+  ([`31fdb48`](https://github.com/latrekc-meta/ha-deploy-kit/commit/31fdb48b7c344ef0fb49b8459a58df54e3d7613c))
+
+HA seeds the first fix-flow step's user_input with {"issue_id": ...} (RepairsFlowManager.async_init
+  -> data_entry_flow feeds it to async_step_init). async_step_init forwarded that into
+  async_step_confirm_restart, whose user_input-is-not-None branch then restarted Home Assistant the
+  instant the issue was opened -- no confirmation. Mirror HA's own ConfirmRepairFlow:
+  async_step_init delegates WITHOUT forwarding user_input, so the restart fires only on a real
+  submit. Add a regression test that opens the flow with {"issue_id": ...} and asserts no restart.
+
+
+## v0.1.3 (2026-10-29)
+
+### Bug Fixes
+
+- **ha**: Show restart confirmation without an empty schema
+  ([`c6de7bb`](https://github.com/latrekc-meta/ha-deploy-kit/commit/c6de7bba87c0116d137a5cac918a5a050763ef59))
+
+HA's Repairs frontend auto-submits a form that has an empty data schema, so
+  async_show_form(step_id=..., data_schema=vol.Schema({})) restarted Home Assistant the instant the
+  user opened the issue -- no confirmation. Show the form with no data schema (as in the proven
+  hand-rolled flow) so HA renders a confirmation that waits for an explicit submit. Add a regression
+  guard asserting data_schema is None.
+
+
 ## v0.1.2 (2026-10-29)
 
 ### Bug Fixes

{ha_deploy_kit-0.1.2 → ha_deploy_kit-0.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: ha-deploy-kit
-Version: 0.1.2
+Version: 0.1.4
 Summary: HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components
 Project-URL: Homepage, https://github.com/latrekc-meta/ha-deploy-kit
 Project-URL: Repository, https://github.com/latrekc-meta/ha-deploy-kit

{ha_deploy_kit-0.1.2 → ha_deploy_kit-0.1.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "ha-deploy-kit"
-version = "0.1.2"
+version = "0.1.4"
 description = "HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components"
 readme = "README.md"
 license = { file = "LICENSE" }

ha_deploy_kit-0.1.4/src/ha_deploy_kit/ha/repairs_flow.py

@@ -0,0 +1,56 @@
+"""Optional opt-in confirm-and-restart Repairs flow.
+
+Opening the Repairs issue shows a confirmation dialog; the restart happens ONLY
+when the user submits it. This mirrors Home Assistant's own ``ConfirmRepairFlow``:
+``async_step_init`` delegates to the confirm step WITHOUT forwarding ``user_input``.
+That matters because HA seeds the first step's ``user_input`` with
+``{"issue_id": ...}`` (see repairs ``RepairsFlowManager.async_init``); forwarding it
+would look like a submit and restart Home Assistant the instant the issue is
+opened. No executable restart lives in the core engine; this flow is the single
+opt-in place a consumer may wire it.
+"""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING, Any
+
+import voluptuous as vol
+from homeassistant.components.repairs import RepairsFlow
+
+if TYPE_CHECKING:
+    from homeassistant.core import HomeAssistant
+    from homeassistant.data_entry_flow import FlowResult
+
+
+class _RestartRequiredFixFlow(RepairsFlow):
+    """Shows a confirmation dialog, then restarts only when the user submits it."""
+
+    async def async_step_init(
+        self, user_input: dict[str, Any] | None = None
+    ) -> FlowResult:
+        # Do NOT forward user_input: HA seeds the first step with
+        # {"issue_id": ...}, which would look like a submit and restart on open.
+        return await self.async_step_confirm_restart()
+
+    async def async_step_confirm_restart(
+        self, user_input: dict[str, Any] | None = None
+    ) -> FlowResult:
+        if user_input is not None:
+            await self.hass.services.async_call("homeassistant", "restart")
+            return self.async_create_entry(title="", data={})
+        return self.async_show_form(
+            step_id="confirm_restart", data_schema=vol.Schema({})
+        )
+
+
+def async_create_restart_fix_flow(
+    hass: HomeAssistant,
+    issue_id: str,
+    data: dict[str, Any] | None = None,
+    *,
+    expected_issue_id: str = "restart_required",
+) -> RepairsFlow | None:
+    """Return the opt-in restart fix flow, or ``None`` for other issue ids."""
+    if issue_id != expected_issue_id:
+        return None
+    return _RestartRequiredFixFlow()

{ha_deploy_kit-0.1.2 → ha_deploy_kit-0.1.4}/tests/ha/test_repairs_flow.py

@@ -6,17 +6,32 @@ from ha_deploy_kit.ha import async_create_restart_fix_flow
 pytestmark = pytest.mark.ha
 
 
-async def test_showing_the_form_never_restarts(hass):
+async def test_opening_the_issue_shows_the_form_and_never_restarts(hass):
+    # HA seeds the first step's user_input with {"issue_id": ...} (see
+    # RepairsFlowManager.async_init). async_step_init must still only SHOW the
+    # confirmation dialog -- never restart on open.
     calls = async_mock_service(hass, "homeassistant", "restart")
 
     flow = async_create_restart_fix_flow(hass, "restart_required")
     assert flow is not None
     flow.hass = hass
 
-    shown = await flow.async_step_init()
+    shown = await flow.async_step_init({"issue_id": "restart_required"})
     assert shown["type"] == "form"
     assert shown["step_id"] == "confirm_restart"
-    assert len(calls) == 0  # merely showing the confirmation dialog never restarts
+    assert len(calls) == 0  # opening the issue must not restart
+
+
+async def test_init_without_input_shows_the_form(hass):
+    calls = async_mock_service(hass, "homeassistant", "restart")
+
+    flow = async_create_restart_fix_flow(hass, "restart_required")
+    assert flow is not None
+    flow.hass = hass
+
+    shown = await flow.async_step_init()
+    assert shown["type"] == "form"
+    assert len(calls) == 0
 
 
 async def test_restart_only_after_submitting_the_dialog(hass):

ha_deploy_kit-0.1.2/src/ha_deploy_kit/ha/repairs_flow.py

@@ -1,50 +0,0 @@
-"""Optional opt-in confirm-and-restart Repairs flow.
-
-The restart happens ONLY after the user submits the confirmation dialog. Opening
-the Repairs issue shows a dialog describing the restart; clicking submit is the
-explicit confirmation. No executable restart lives in the core engine; this flow
-is the single opt-in place a consumer may wire it.
-"""
-
-from __future__ import annotations
-
-from typing import TYPE_CHECKING, Any
-
-import voluptuous as vol
-from homeassistant.components.repairs import RepairsFlow
-
-if TYPE_CHECKING:
-    from homeassistant.core import HomeAssistant
-    from homeassistant.data_entry_flow import FlowResult
-
-
-class _RestartRequiredFixFlow(RepairsFlow):
-    """Shows a confirmation dialog, then restarts only when the user submits it."""
-
-    async def async_step_init(
-        self, user_input: dict[str, Any] | None = None
-    ) -> FlowResult:
-        return await self.async_step_confirm_restart(user_input)
-
-    async def async_step_confirm_restart(
-        self, user_input: dict[str, Any] | None = None
-    ) -> FlowResult:
-        if user_input is None:
-            return self.async_show_form(
-                step_id="confirm_restart", data_schema=vol.Schema({})
-            )
-        await self.hass.services.async_call("homeassistant", "restart", blocking=False)
-        return self.async_create_entry(title="", data={})
-
-
-def async_create_restart_fix_flow(
-    hass: HomeAssistant,
-    issue_id: str,
-    data: dict[str, Any] | None = None,
-    *,
-    expected_issue_id: str = "restart_required",
-) -> RepairsFlow | None:
-    """Return the opt-in restart fix flow, or ``None`` for other issue ids."""
-    if issue_id != expected_issue_id:
-        return None
-    return _RestartRequiredFixFlow()