ha-deploy-kit 0.1.1__tar.gz → 0.1.2__tar.gz

{ha_deploy_kit-0.1.1 → ha_deploy_kit-0.1.2}/CHANGELOG.md

@@ -1,6 +1,19 @@
 # CHANGELOG
 
 
+## v0.1.2 (2026-10-29)
+
+### Bug Fixes
+
+- **ha**: Confirm restart via a dialog instead of a checkbox
+  ([`aeaf825`](https://github.com/latrekc-meta/ha-deploy-kit/commit/aeaf82541dced2e3e77828b97f28c34dab5e361a))
+
+The checkbox step added friction without benefit: opening the Repairs issue already shows a
+  confirmation dialog, and the restart should fire when the user submits it. Drop the required
+  confirm checkbox and the confirm_required error; restart only on submit of the dialog. Trim the
+  fix-flow strings snippet back to title + description.
+
+
 ## v0.1.1 (2026-10-29)
 
 ### Bug Fixes

{ha_deploy_kit-0.1.1 → ha_deploy_kit-0.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: ha-deploy-kit
-Version: 0.1.1
+Version: 0.1.2
 Summary: HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components
 Project-URL: Homepage, https://github.com/latrekc-meta/ha-deploy-kit
 Project-URL: Repository, https://github.com/latrekc-meta/ha-deploy-kit
@@ -110,7 +110,7 @@ how releases are published.
 | `ha.async_register_restart_service(hass, domain, ...)` | `ha_deploy_kit.ha` | Idempotently register the restart service (empty schema). Pass `fixable=True` for a one-click Repairs card (pair with the fix flow). |
 | `ha.async_raise_restart_issue(hass, domain, ...)` | `ha_deploy_kit.ha` | Raise the deduplicated, non-persistent restart Repairs issue. |
 | `ha.async_clear_restart_issue(hass, domain, ...)` | `ha_deploy_kit.ha` | Clear the restart issue. |
-| `ha.async_create_restart_fix_flow(hass, issue_id, ...)` | `ha_deploy_kit.ha` | Optional opt-in confirm-and-restart flow (restart only after the user ticks the confirmation checkbox). |
+| `ha.async_create_restart_fix_flow(hass, issue_id, ...)` | `ha_deploy_kit.ha` | Optional opt-in confirm-and-restart flow (shows a confirmation dialog; restart only when the user submits it). |
 | `ha.register_card_serving(hass, domain, lovelace_dir, card_url)` | `ha_deploy_kit.ha` | Serve the card and register it as a frontend module. |
 
 ## CLI

{ha_deploy_kit-0.1.1 → ha_deploy_kit-0.1.2}/README.md

@@ -62,7 +62,7 @@ how releases are published.
 | `ha.async_register_restart_service(hass, domain, ...)` | `ha_deploy_kit.ha` | Idempotently register the restart service (empty schema). Pass `fixable=True` for a one-click Repairs card (pair with the fix flow). |
 | `ha.async_raise_restart_issue(hass, domain, ...)` | `ha_deploy_kit.ha` | Raise the deduplicated, non-persistent restart Repairs issue. |
 | `ha.async_clear_restart_issue(hass, domain, ...)` | `ha_deploy_kit.ha` | Clear the restart issue. |
-| `ha.async_create_restart_fix_flow(hass, issue_id, ...)` | `ha_deploy_kit.ha` | Optional opt-in confirm-and-restart flow (restart only after the user ticks the confirmation checkbox). |
+| `ha.async_create_restart_fix_flow(hass, issue_id, ...)` | `ha_deploy_kit.ha` | Optional opt-in confirm-and-restart flow (shows a confirmation dialog; restart only when the user submits it). |
 | `ha.register_card_serving(hass, domain, lovelace_dir, card_url)` | `ha_deploy_kit.ha` | Serve the card and register it as a frontend module. |
 
 ## CLI

{ha_deploy_kit-0.1.1 → ha_deploy_kit-0.1.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "ha-deploy-kit"
-version = "0.1.1"
+version = "0.1.2"
 description = "HA-free SSH deploy / compare / notify / optional-frontend toolkit for Home Assistant custom components"
 readme = "README.md"
 license = { file = "LICENSE" }

{ha_deploy_kit-0.1.1 → ha_deploy_kit-0.1.2}/src/ha_deploy_kit/ha/repairs_flow.py

@@ -1,10 +1,9 @@
 """Optional opt-in confirm-and-restart Repairs flow.
 
-The restart happens ONLY when the user explicitly ticks the confirmation checkbox
-and submits. An empty-schema form can be submitted with nothing selected, so a
-required ``confirm`` boolean makes the restart a deliberate choice. No executable
-restart lives in the core engine; this flow is the single opt-in place a consumer
-may wire it.
+The restart happens ONLY after the user submits the confirmation dialog. Opening
+the Repairs issue shows a dialog describing the restart; clicking submit is the
+explicit confirmation. No executable restart lives in the core engine; this flow
+is the single opt-in place a consumer may wire it.
 """
 
 from __future__ import annotations
@@ -18,11 +17,9 @@ if TYPE_CHECKING:
     from homeassistant.core import HomeAssistant
     from homeassistant.data_entry_flow import FlowResult
 
-_CONFIRM_SCHEMA = vol.Schema({vol.Required("confirm", default=False): bool})
-
 
 class _RestartRequiredFixFlow(RepairsFlow):
-    """Restarts only after the user ticks the confirmation checkbox and submits."""
+    """Shows a confirmation dialog, then restarts only when the user submits it."""
 
     async def async_step_init(
         self, user_input: dict[str, Any] | None = None
@@ -32,13 +29,9 @@ class _RestartRequiredFixFlow(RepairsFlow):
     async def async_step_confirm_restart(
         self, user_input: dict[str, Any] | None = None
     ) -> FlowResult:
-        if not (user_input and user_input.get("confirm")):
-            # First render, or submitted without ticking the box: re-show the
-            # form and never restart.
+        if user_input is None:
             return self.async_show_form(
-                step_id="confirm_restart",
-                data_schema=_CONFIRM_SCHEMA,
-                errors={"base": "confirm_required"} if user_input else None,
+                step_id="confirm_restart", data_schema=vol.Schema({})
             )
         await self.hass.services.async_call("homeassistant", "restart", blocking=False)
         return self.async_create_entry(title="", data={})

ha_deploy_kit-0.1.2/src/ha_deploy_kit/metadata/strings.snippet.fixflow.json

@@ -0,0 +1,15 @@
+{
+  "issues": {
+    "restart_required": {
+      "title": "Restart required to finish updating",
+      "fix_flow": {
+        "step": {
+          "confirm_restart": {
+            "title": "Restart Home Assistant",
+            "description": "Newly deployed code is on disk. Click submit to restart Home Assistant now and load it."
+          }
+        }
+      }
+    }
+  }
+}

ha_deploy_kit-0.1.2/tests/ha/test_repairs_flow.py

@@ -0,0 +1,35 @@
+import pytest
+from pytest_homeassistant_custom_component.common import async_mock_service
+
+from ha_deploy_kit.ha import async_create_restart_fix_flow
+
+pytestmark = pytest.mark.ha
+
+
+async def test_showing_the_form_never_restarts(hass):
+    calls = async_mock_service(hass, "homeassistant", "restart")
+
+    flow = async_create_restart_fix_flow(hass, "restart_required")
+    assert flow is not None
+    flow.hass = hass
+
+    shown = await flow.async_step_init()
+    assert shown["type"] == "form"
+    assert shown["step_id"] == "confirm_restart"
+    assert len(calls) == 0  # merely showing the confirmation dialog never restarts
+
+
+async def test_restart_only_after_submitting_the_dialog(hass):
+    calls = async_mock_service(hass, "homeassistant", "restart")
+
+    flow = async_create_restart_fix_flow(hass, "restart_required")
+    assert flow is not None
+    flow.hass = hass
+
+    result = await flow.async_step_confirm_restart({})
+    assert result["type"] == "create_entry"
+    assert len(calls) == 1  # restart only when the user submits the dialog
+
+
+async def test_fix_flow_other_issue_returns_none(hass):
+    assert async_create_restart_fix_flow(hass, "something_else") is None

ha_deploy_kit-0.1.1/src/ha_deploy_kit/metadata/strings.snippet.fixflow.json

@@ -1,21 +0,0 @@
-{
-  "issues": {
-    "restart_required": {
-      "title": "Restart required to finish updating",
-      "fix_flow": {
-        "step": {
-          "confirm_restart": {
-            "title": "Restart Home Assistant",
-            "description": "Restart Home Assistant now to load the newly deployed code? Tick the box below to confirm.",
-            "data": {
-              "confirm": "Yes, restart Home Assistant now"
-            }
-          }
-        },
-        "error": {
-          "confirm_required": "Tick the box to confirm the restart, or close this dialog to cancel."
-        }
-      }
-    }
-  }
-}

ha_deploy_kit-0.1.1/tests/ha/test_repairs_flow.py

@@ -1,54 +0,0 @@
-import pytest
-from pytest_homeassistant_custom_component.common import async_mock_service
-
-from ha_deploy_kit.ha import async_create_restart_fix_flow
-
-pytestmark = pytest.mark.ha
-
-
-async def test_showing_the_form_never_restarts(hass):
-    calls = async_mock_service(hass, "homeassistant", "restart")
-
-    flow = async_create_restart_fix_flow(hass, "restart_required")
-    assert flow is not None
-    flow.hass = hass
-
-    shown = await flow.async_step_init()
-    assert shown["type"] == "form"
-    assert shown["step_id"] == "confirm_restart"
-    assert len(calls) == 0  # merely showing the form never restarts
-
-
-async def test_submitting_without_confirming_does_not_restart(hass):
-    calls = async_mock_service(hass, "homeassistant", "restart")
-
-    flow = async_create_restart_fix_flow(hass, "restart_required")
-    assert flow is not None
-    flow.hass = hass
-
-    # A bare submit (checkbox left unticked) must NOT restart; re-show the form.
-    unticked = await flow.async_step_confirm_restart({"confirm": False})
-    assert unticked["type"] == "form"
-    assert unticked["step_id"] == "confirm_restart"
-    assert len(calls) == 0
-
-    # An empty submit is treated the same as an unticked checkbox.
-    empty = await flow.async_step_confirm_restart({})
-    assert empty["type"] == "form"
-    assert len(calls) == 0
-
-
-async def test_restart_only_after_explicit_confirmation(hass):
-    calls = async_mock_service(hass, "homeassistant", "restart")
-
-    flow = async_create_restart_fix_flow(hass, "restart_required")
-    assert flow is not None
-    flow.hass = hass
-
-    result = await flow.async_step_confirm_restart({"confirm": True})
-    assert result["type"] == "create_entry"
-    assert len(calls) == 1  # restart only on explicit, ticked confirmation
-
-
-async def test_fix_flow_other_issue_returns_none(hass):
-    assert async_create_restart_fix_flow(hass, "something_else") is None