growthbook 2.1.1__tar.gz → 2.1.2__tar.gz

{growthbook-2.1.1/growthbook.egg-info → growthbook-2.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: growthbook
-Version: 2.1.1
+Version: 2.1.2
 Summary: Powerful Feature flagging and A/B testing for Python apps
 Home-page: https://github.com/growthbook/growthbook-python
 Author: GrowthBook

{growthbook-2.1.1 → growthbook-2.1.2}/growthbook/__init__.py

@@ -18,5 +18,5 @@ from .plugins import (
 )
 
 # x-release-please-start-version
-__version__ = "2.1.1"
+__version__ = "2.1.2"
 # x-release-please-end

{growthbook-2.1.1 → growthbook-2.1.2}/growthbook/growthbook_client.py

@@ -90,8 +90,8 @@ class FeatureCache:
     def update(self, features: Dict[str, Any], saved_groups: Dict[str, Any]) -> None:
         """Simple thread-safe update of cache with new API data"""
         with self._lock:
-            self._cache['features'].update(features)
-            self._cache['savedGroups'].update(saved_groups)
+            self._cache['features'] = dict(features)
+            self._cache['savedGroups'] = dict(saved_groups)
 
     def get_current_state(self) -> Dict[str, Any]:
         """Get current cache state"""

{growthbook-2.1.1 → growthbook-2.1.2/growthbook.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: growthbook
-Version: 2.1.1
+Version: 2.1.2
 Summary: Powerful Feature flagging and A/B testing for Python apps
 Home-page: https://github.com/growthbook/growthbook-python
 Author: GrowthBook

{growthbook-2.1.1 → growthbook-2.1.2}/setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 2.1.1
+current_version = 2.1.2
 commit = True
 tag = True
 

{growthbook-2.1.1 → growthbook-2.1.2}/tests/test_growthbook_client.py

@@ -158,19 +158,93 @@ async def test_concurrent_feature_updates():
         client_key="test_key"
     )
     features = {f"feature-{i}": {"defaultValue": i} for i in range(10)}
-    
+
     async def update_features(feature_subset):
         await repo._handle_feature_update({"features": feature_subset, "savedGroups": {}})
-            
+
     await asyncio.gather(*[
-        update_features({k: features[k]}) 
+        update_features({k: features[k]})
         for k in features
     ])
-    
+
     cache_state = repo._feature_cache.get_current_state()
     # Verify all features were properly stored
-    assert cache_state["features"] == features
+    assert len(cache_state["features"]) == 1
     assert cache_state["savedGroups"] == {}
+    feature_key = list(cache_state["features"].keys())[0]
+    assert feature_key in features
+    assert cache_state["features"][feature_key] == features[feature_key]
+
+
+@pytest.mark.asyncio
+async def test_feature_cache_thread_safety(cache):
+    """Verify FeatureCache is thread-safe during concurrent updates"""
+    repo = EnhancedFeatureRepository(
+        api_host="https://test.growthbook.io",
+        client_key="test_key"
+    )
+
+    feature_sets = [
+        {f"set-{i}-feature-{j}": {"value": j} for j in range(3)}
+        for i in range(5)
+    ]
+
+    async def update_full_set(feature_set):
+        await repo._handle_feature_update({
+            "features": feature_set,
+            "savedGroups": {}
+        })
+
+    # Concurrent updates
+    await asyncio.gather(*[update_full_set(fs) for fs in feature_sets])
+
+    cache = repo._feature_cache.get_current_state()
+
+    # One complete set should be in cache (race condition winner)
+    assert len(cache["features"]) == 3
+    cache_keys = set(cache["features"].keys())
+    assert any(cache_keys == set(fs.keys()) for fs in feature_sets)
+
+
+@pytest.mark.asyncio
+async def test_disabled_features_removed_from_cache(cache):
+    """
+    Regression test: disabled features must be removed from cache.
+
+    Previously, FeatureCache.update() used dict.update() which only
+    adds/modifies entries but never removes them. This caused disabled
+    features to persist in the cache indefinitely.
+    """
+    repo = EnhancedFeatureRepository(
+        api_host="https://test.growthbook.io",
+        client_key="test_key"
+    )
+
+    # Initial state: 2 features enabled
+    await repo._handle_feature_update({
+        "features": {
+            "feature-a": {"defaultValue": True},
+            "feature-b": {"defaultValue": False}
+        },
+        "savedGroups": {}
+    })
+
+    cache = repo._feature_cache.get_current_state()
+    assert "feature-a" in cache["features"]
+    assert "feature-b" in cache["features"]
+
+    # User disables feature-b in Growthbook UI
+    # API now returns only active features
+    await repo._handle_feature_update({
+        "features": {
+            "feature-a": {"defaultValue": True}
+        },
+        "savedGroups": {}
+    })
+
+    cache = repo._feature_cache.get_current_state()
+    assert "feature-a" in cache["features"]
+    assert "feature-b" not in cache["features"]  # Must be removed!
 
 @pytest.mark.asyncio
 async def test_callback_thread_safety():