growthbook 1.4.3__tar.gz → 1.4.4__tar.gz

{growthbook-1.4.3/growthbook.egg-info → growthbook-1.4.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: growthbook
-Version: 1.4.3
+Version: 1.4.4
 Summary: Powerful Feature flagging and A/B testing for Python apps
 Home-page: https://github.com/growthbook/growthbook-python
 Author: GrowthBook

{growthbook-1.4.3 → growthbook-1.4.4}/growthbook/__init__.py

@@ -18,5 +18,5 @@ from .plugins import (
 )
 
 # x-release-please-start-version
-__version__ = "1.4.3"
+__version__ = "1.4.4"
 # x-release-please-end

{growthbook-1.4.3 → growthbook-1.4.4}/growthbook/growthbook.py

@@ -100,7 +100,8 @@ class InMemoryFeatureCache(AbstractFeatureCache):
     def set(self, key: str, value: Dict, ttl: int) -> None:
         if key in self.cache:
             self.cache[key].update(value)
-        self.cache[key] = CacheEntry(value, ttl)
+        else:
+            self.cache[key] = CacheEntry(value, ttl)
 
     def clear(self) -> None:
         self.cache.clear()
@@ -327,6 +328,11 @@ class FeatureRepository(object):
         self.http: Optional[PoolManager] = None
         self.sse_client: Optional[SSEClient] = None
         self._feature_update_callbacks: List[Callable[[Dict], None]] = []
+        
+        # Background refresh support
+        self._refresh_thread: Optional[threading.Thread] = None
+        self._refresh_stop_event = threading.Event()
+        self._refresh_lock = threading.Lock()
 
     def set_cache(self, cache: AbstractFeatureCache) -> None:
         self.cache = cache
@@ -375,6 +381,7 @@ class FeatureRepository(object):
                 return res
         return cached
     
+    
     async def load_features_async(
         self, api_host: str, client_key: str, decryption_key: str = "", ttl: int = 600
     ) -> Optional[Dict]:
@@ -493,6 +500,52 @@ class FeatureRepository(object):
         if self.sse_client:
             self.sse_client.disconnect(timeout=timeout)
             self.sse_client = None
+    
+    def start_background_refresh(self, api_host: str, client_key: str, decryption_key: str, ttl: int = 600, refresh_interval: int = 300) -> None:
+        """Start periodic background refresh task"""
+        with self._refresh_lock:
+            if self._refresh_thread is not None:
+                return  # Already running
+            
+            self._refresh_stop_event.clear()
+            self._refresh_thread = threading.Thread(
+                target=self._background_refresh_worker,
+                args=(api_host, client_key, decryption_key, ttl, refresh_interval),
+                daemon=True
+            )
+            self._refresh_thread.start()
+            logger.debug("Started background refresh task")
+    
+    def _background_refresh_worker(self, api_host: str, client_key: str, decryption_key: str, ttl: int, refresh_interval: int) -> None:
+        """Worker method for periodic background refresh"""
+        while not self._refresh_stop_event.is_set():
+            try:
+                # Wait for the refresh interval or stop event
+                if self._refresh_stop_event.wait(refresh_interval):
+                    break  # Stop event was set
+                
+                logger.debug("Background refresh for Features - started")
+                res = self._fetch_features(api_host, client_key, decryption_key)
+                if res is not None:
+                    cache_key = api_host + "::" + client_key
+                    self.cache.set(cache_key, res, ttl)
+                    logger.debug("Background refresh completed")
+                    # Notify callbacks about fresh features
+                    self._notify_feature_update_callbacks(res)
+                else:
+                    logger.warning("Background refresh failed")
+            except Exception as e:
+                logger.warning(f"Background refresh error: {e}")
+    
+    def stop_background_refresh(self) -> None:
+        """Stop background refresh task"""
+        self._refresh_stop_event.set()
+        
+        with self._refresh_lock:
+            if self._refresh_thread is not None:
+                self._refresh_thread.join(timeout=1.0)  # Wait up to 1 second
+                self._refresh_thread = None
+                logger.debug("Stopped background refresh task")
 
     @staticmethod
     def _get_features_url(api_host: str, client_key: str) -> str:
@@ -522,6 +575,8 @@ class GrowthBook(object):
         savedGroups: dict = {},
         streaming: bool = False,
         streaming_connection_timeout: int = 30,
+        stale_while_revalidate: bool = False,
+        stale_ttl: int = 300,  # 5 minutes default
         plugins: List = None,
         # Deprecated args
         trackingCallback=None,
@@ -551,6 +606,8 @@ class GrowthBook(object):
 
         self._streaming = streaming
         self._streaming_timeout = streaming_connection_timeout
+        self._stale_while_revalidate = stale_while_revalidate
+        self._stale_ttl = stale_ttl
 
         # Deprecated args
         self._user = user
@@ -603,6 +660,13 @@ class GrowthBook(object):
         if self._streaming:
             self.load_features()
             self.startAutoRefresh()
+        elif self._stale_while_revalidate and self._client_key:
+            # Start background refresh task for stale-while-revalidate
+            self.load_features()  # Initial load
+            feature_repo.start_background_refresh(
+                self._api_host, self._client_key, self._decryption_key, 
+                self._cache_ttl, self._stale_ttl
+            )
 
     def _on_feature_update(self, features_data: Dict) -> None:
         """Callback to handle automatic feature updates from FeatureRepository"""
@@ -739,6 +803,13 @@ class GrowthBook(object):
         except Exception as e:
             logger.warning(f"Error stopping auto refresh during destroy: {e}")
         
+        try:
+            # Stop background refresh operations
+            if self._stale_while_revalidate and self._client_key:
+                feature_repo.stop_background_refresh()
+        except Exception as e:
+            logger.warning(f"Error stopping background refresh during destroy: {e}")
+        
         try:
             # Clean up feature update callback
             if self._client_key:
@@ -790,8 +861,8 @@ class GrowthBook(object):
     def _ensure_fresh_features(self) -> None:
         """Lazy refresh: Check cache expiry and refresh if needed, but only if client_key is provided"""
         
-        if self._streaming or not self._client_key:
-            return  # Skip cache checks - SSE handles freshness for streaming users
+        if self._streaming or self._stale_while_revalidate or not self._client_key:
+            return  # Skip cache checks - SSE or background refresh handles freshness
 
         try:
             self.load_features()

{growthbook-1.4.3 → growthbook-1.4.4/growthbook.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: growthbook
-Version: 1.4.3
+Version: 1.4.4
 Summary: Powerful Feature flagging and A/B testing for Python apps
 Home-page: https://github.com/growthbook/growthbook-python
 Author: GrowthBook

{growthbook-1.4.3 → growthbook-1.4.4}/setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.4.3
+current_version = 1.4.4
 commit = True
 tag = True
 

{growthbook-1.4.3 → growthbook-1.4.4}/tests/test_growthbook.py

@@ -1009,4 +1009,164 @@ def test_multiple_instances_get_updated_on_cache_expiry(mocker):
     finally:
         gb1.destroy()
         gb2.destroy()
+        feature_repo.clear_cache()
+
+
+def test_stale_while_revalidate_basic_functionality(mocker):
+    """Test basic stale-while-revalidate functionality"""
+    # Mock responses - first call returns v1, subsequent calls return v2
+    mock_responses = [
+        {"features": {"test_feature": {"defaultValue": "v1"}}, "savedGroups": {}},
+        {"features": {"test_feature": {"defaultValue": "v2"}}, "savedGroups": {}}
+    ]
+    
+    call_count = 0
+    def mock_fetch_features(api_host, client_key, decryption_key=""):
+        nonlocal call_count
+        response = mock_responses[min(call_count, len(mock_responses) - 1)]
+        call_count += 1
+        return response
+    
+    # Clear cache and mock the fetch method
+    feature_repo.clear_cache()
+    m = mocker.patch.object(feature_repo, '_fetch_features', side_effect=mock_fetch_features)
+    
+    # Create GrowthBook instance with stale-while-revalidate enabled and short refresh interval
+    gb = GrowthBook(
+        api_host="https://cdn.growthbook.io",
+        client_key="test-key",
+        cache_ttl=10,  # 10 second TTL
+        stale_while_revalidate=True,
+        stale_ttl=1  # 1 second refresh interval for testing
+    )
+    
+    try:
+        # Initial evaluation - should use initial loaded data
+        assert gb.get_feature_value('test_feature', 'default') == "v1"
+        assert call_count == 1  # Initial load
+        
+        # Wait for background refresh to happen
+        import time as time_module
+        time_module.sleep(1.5)  # Wait longer than refresh interval
+        
+        # Should have triggered background refresh
+        assert call_count >= 2
+        
+        # Next evaluation should get updated data from background refresh
+        assert gb.get_feature_value('test_feature', 'default') == "v2"
+        
+    finally:
+        gb.destroy()
+        feature_repo.clear_cache()
+
+
+def test_stale_while_revalidate_starts_background_task(mocker):
+    """Test that stale-while-revalidate starts background refresh task"""
+    mock_response = {"features": {"test_feature": {"defaultValue": "fresh"}}, "savedGroups": {}}
+    
+    call_count = 0
+    def mock_fetch_features(api_host, client_key, decryption_key=""):
+        nonlocal call_count
+        call_count += 1
+        return mock_response
+    
+    # Clear cache and mock the fetch method
+    feature_repo.clear_cache()
+    m = mocker.patch.object(feature_repo, '_fetch_features', side_effect=mock_fetch_features)
+    
+    # Create GrowthBook instance with stale-while-revalidate enabled
+    gb = GrowthBook(
+        api_host="https://cdn.growthbook.io",
+        client_key="test-key",
+        stale_while_revalidate=True,
+        stale_ttl=5
+    )
+    
+    try:
+        # Should have started background refresh task
+        assert feature_repo._refresh_thread is not None
+        assert feature_repo._refresh_thread.is_alive()
+        
+        # Initial evaluation should work
+        assert gb.get_feature_value('test_feature', 'default') == "fresh"
+        assert call_count == 1  # Initial load
+        
+    finally:
+        gb.destroy()
+        feature_repo.clear_cache()
+
+def test_stale_while_revalidate_disabled_fallback(mocker):
+    """Test that when stale_while_revalidate is disabled, it falls back to normal behavior"""
+    mock_response = {"features": {"test_feature": {"defaultValue": "normal"}}, "savedGroups": {}}
+    
+    call_count = 0
+    def mock_fetch_features(api_host, client_key, decryption_key=""):
+        nonlocal call_count
+        call_count += 1
+        return mock_response
+    
+    # Clear cache and mock the fetch method
+    feature_repo.clear_cache()
+    m = mocker.patch.object(feature_repo, '_fetch_features', side_effect=mock_fetch_features)
+    
+    # Create GrowthBook instance with stale-while-revalidate disabled (default)
+    gb = GrowthBook(
+        api_host="https://cdn.growthbook.io",
+        client_key="test-key",
+        cache_ttl=1,  # Short TTL
+        stale_while_revalidate=False  # Explicitly disabled
+    )
+    
+    try:
+        # Should NOT have started background refresh task
+        assert feature_repo._refresh_thread is None
+        
+        # Initial evaluation
+        assert gb.get_feature_value('test_feature', 'default') == "normal"
+        assert call_count == 1
+        
+        # Manually expire the cache
+        cache_key = "https://cdn.growthbook.io::test-key"
+        if hasattr(feature_repo.cache, 'cache') and cache_key in feature_repo.cache.cache:
+            feature_repo.cache.cache[cache_key].expires = time() - 10
+        
+        # Next evaluation should fetch synchronously (normal behavior)
+        assert gb.get_feature_value('test_feature', 'default') == "normal"
+        assert call_count == 2  # Should have fetched again
+        
+    finally:
+        gb.destroy()
+        feature_repo.clear_cache()
+
+
+def test_stale_while_revalidate_cleanup(mocker):
+    """Test that background refresh is properly cleaned up"""
+    mock_response = {"features": {"test_feature": {"defaultValue": "test"}}, "savedGroups": {}}
+    
+    # Mock the fetch method
+    feature_repo.clear_cache()
+    m = mocker.patch.object(feature_repo, '_fetch_features', return_value=mock_response)
+    
+    # Create GrowthBook instance with stale-while-revalidate enabled
+    gb = GrowthBook(
+        api_host="https://cdn.growthbook.io",
+        client_key="test-key",
+        stale_while_revalidate=True
+    )
+    
+    try:
+        # Should have started background refresh task
+        assert feature_repo._refresh_thread is not None
+        assert feature_repo._refresh_thread.is_alive()
+        
+        # Destroy should clean up the background task
+        gb.destroy()
+        
+        # Background task should be stopped
+        assert feature_repo._refresh_thread is None or not feature_repo._refresh_thread.is_alive()
+        
+    finally:
+        # Ensure cleanup even if test fails
+        if feature_repo._refresh_thread:
+            feature_repo.stop_background_refresh()
         feature_repo.clear_cache()