gridfleet-testkit 0.9.2__tar.gz → 0.9.3__tar.gz

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to the GridFleet testkit (`gridfleet-testkit` on PyPI) are documented here.
 
+## [0.9.3](https://github.com/quidow/gridfleet/compare/gridfleet-testkit-v0.9.2...gridfleet-testkit-v0.9.3) (2026-05-16)
+
+
+### Bug Fixes
+
+* bind testkit-registered sessions to their device ([35030ef](https://github.com/quidow/gridfleet/commit/35030eff438b3d8cfa17b54f1329dfeb03dadf07))
+* **testkit:** stop sending client-derived device identity on register ([c025d1e](https://github.com/quidow/gridfleet/commit/c025d1e10d2bd793dadc4ca167aaaf4a7a2e23e7))
+
 ## [0.9.2](https://github.com/quidow/gridfleet/compare/gridfleet-testkit-v0.9.1...gridfleet-testkit-v0.9.2) (2026-05-16)
 
 

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gridfleet-testkit
-Version: 0.9.2
+Version: 0.9.3
 Summary: Supported pytest and run-orchestration helpers for GridFleet integrations
 Project-URL: Homepage, https://github.com/quidow/gridfleet
 Project-URL: Repository, https://github.com/quidow/gridfleet

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/gridfleet_testkit/__init__.py

@@ -47,7 +47,7 @@ from .sessions import build_error_session_payload, resolve_device_handle_from_dr
 try:
     __version__ = version("gridfleet-testkit")
 except PackageNotFoundError:
-    __version__ = "0.9.2"
+    __version__ = "0.9.3"
 
 __all__ = [
     "GRIDFLEET_API_URL",

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/gridfleet_testkit/client.py

@@ -511,11 +511,23 @@ class GridFleetClient:
         run_id: str | None = None,
         suppress_errors: bool = True,
     ) -> JsonObject | None:
-        """Extract session metadata from an Appium driver and register it.
-
-        Also wraps ``driver.quit`` so that the first call after a successful
-        registration fires :meth:`notify_session_finished` automatically.
-        Errors from notify are suppressed — they must never break the caller.
+        """Register a running Appium session and wire ``driver.quit`` for notify.
+
+        The testkit does not try to derive a device identity from
+        ``driver.capabilities``. ``udid`` / ``deviceName`` are not unique
+        across drivers (Roku reuses the IP, AVDs reuse port-named handles,
+        iOS simulators reuse a UDID across reboots), and the Appium driver
+        strips the ``appium:`` vendor prefix and drops nested vendor keys
+        like ``appium:gridfleet:deviceId`` from the W3C echo, so identifying
+        caps cannot be read reliably from the client side at all.
+
+        The row is registered with only ``session_id`` + capabilities; the
+        backend ``session_sync_loop`` queries the Grid hub on each cycle and
+        binds the row to its Device by reading ``slot.session.stereotype``,
+        which is prefix-stable and carries ``appium:gridfleet:deviceId``.
+        ``driver.quit`` is wrapped so the first call posts to ``/finished``
+        exactly once; errors from notify are suppressed so they never break
+        the caller.
         """
         capabilities = cast("JsonObject", driver.capabilities) if isinstance(driver.capabilities, dict) else {}
         if not isinstance(capabilities, dict):
@@ -523,13 +535,9 @@ class GridFleetClient:
         session_id = getattr(driver, "session_id", None)
         if not isinstance(session_id, str) or not session_id:
             raise RuntimeError("Created Appium driver did not expose a session ID")
-        device_id = capabilities.get("appium:gridfleet:deviceId") or capabilities.get("gridfleet:deviceId")
-        connection_target = capabilities.get("appium:udid") or capabilities.get("appium:deviceName")
         result = self.register_session(
             session_id=session_id,
             test_name=test_name,
-            device_id=device_id if isinstance(device_id, str) and device_id else None,
-            connection_target=connection_target if isinstance(connection_target, str) and connection_target else None,
             requested_capabilities=capabilities,
             run_id=run_id,
             suppress_errors=suppress_errors,

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "gridfleet-testkit"
-version = "0.9.2"
+version = "0.9.3"
 description = "Supported pytest and run-orchestration helpers for GridFleet integrations"
 readme = "README.md"
 license = "Apache-2.0"

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/tests/test_client.py

@@ -549,7 +549,17 @@ def test_update_session_status_patches_status(monkeypatch):
     }
 
 
-def test_register_session_from_driver_extracts_gridfleet_capabilities(monkeypatch):
+def test_register_session_from_driver_does_not_send_client_side_device_identity(monkeypatch):
+    """The testkit deliberately does not attempt to identify the device.
+
+    Vendor-prefixed identifying caps do not survive the Appium driver's W3C
+    echo (``appium:`` stripped, ``appium:gridfleet:deviceId`` dropped) and
+    the stripped forms (``udid`` / ``deviceName``) are not globally unique
+    across drivers. The backend ``session_sync_loop`` reads the
+    prefix-stable ``slot.session.stereotype`` from the Grid hub instead, so
+    the registration payload carries only ``session_id`` + capabilities +
+    ``test_name`` + ``run_id``.
+    """
     captured: JsonObject = {}
 
     def fake_register_session(self: GridFleetClient, **kwargs: object) -> JsonObject:
@@ -561,10 +571,12 @@ def test_register_session_from_driver_extracts_gridfleet_capabilities(monkeypatc
     class FakeDriver:
         session_id = "sess-1"
         capabilities: ClassVar[dict[str, object]] = {
-            "appium:gridfleet:deviceId": "dev-1",
-            "appium:udid": "SERIAL123",
-            "appium:platform": "android_mobile",
-            "platformName": "Android",
+            # Real Appium echo: ``appium:`` stripped, no
+            # ``appium:gridfleet:deviceId`` survives.
+            "udid": "SERIAL123",
+            "deviceName": "SERIAL123",
+            "automationName": "UiAutomator2",
+            "platformName": "ANDROID",
         }
 
         def quit(self) -> None:
@@ -574,16 +586,16 @@ def test_register_session_from_driver_extracts_gridfleet_capabilities(monkeypatc
     client = GridFleetClient("http://manager/api")
 
     assert client.register_session_from_driver(driver, test_name="test_login", run_id="run-1") == {"ok": True}
+    assert "device_id" not in captured
+    assert "connection_target" not in captured
     assert captured == {
         "session_id": "sess-1",
         "test_name": "test_login",
-        "device_id": "dev-1",
-        "connection_target": "SERIAL123",
         "requested_capabilities": {
-            "appium:gridfleet:deviceId": "dev-1",
-            "appium:udid": "SERIAL123",
-            "appium:platform": "android_mobile",
-            "platformName": "Android",
+            "udid": "SERIAL123",
+            "deviceName": "SERIAL123",
+            "automationName": "UiAutomator2",
+            "platformName": "ANDROID",
         },
         "run_id": "run-1",
         "suppress_errors": True,

{gridfleet_testkit-0.9.2 → gridfleet_testkit-0.9.3}/uv.lock

@@ -136,7 +136,7 @@ wheels = [
 
 [[package]]
 name = "gridfleet-testkit"
-version = "0.9.2"
+version = "0.9.3"
 source = { editable = "." }
 dependencies = [
     { name = "appium-python-client" },