graphql-core 3.2.13__tar.gz → 3.2.14__tar.gz

{graphql_core-3.2.13 → graphql_core-3.2.14}/.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 3.2.13
+current_version = 3.2.14
 commit = False
 tag = False
 

{graphql_core-3.2.13 → graphql_core-3.2.14}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: graphql-core
-Version: 3.2.13
+Version: 3.2.14
 Summary: GraphQL implementation for Python, a port of GraphQL.js, the JavaScript reference implementation for GraphQL.
 Home-page: https://github.com/graphql-python/graphql-core
 Author: Christoph Zwerschke
@@ -51,7 +51,7 @@ a query language for APIs created by Facebook.
 ![Lint Status](https://github.com/graphql-python/graphql-core/actions/workflows/lint.yml/badge.svg)
 [![Code Style](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
 
-The current version 3.2.13 of GraphQL-core is up-to-date with GraphQL.js version 16.14.2.
+The current version 3.2.14 of GraphQL-core is up-to-date with GraphQL.js version 16.15.0.
 
 An extensive test suite with over 2500 unit tests and 100% coverage comprises a
 replication of the complete test suite of GraphQL.js, making sure this port is

{graphql_core-3.2.13 → graphql_core-3.2.14}/README.md

@@ -10,7 +10,7 @@ a query language for APIs created by Facebook.
 ![Lint Status](https://github.com/graphql-python/graphql-core/actions/workflows/lint.yml/badge.svg)
 [![Code Style](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
 
-The current version 3.2.13 of GraphQL-core is up-to-date with GraphQL.js version 16.14.2.
+The current version 3.2.14 of GraphQL-core is up-to-date with GraphQL.js version 16.15.0.
 
 An extensive test suite with over 2500 unit tests and 100% coverage comprises a
 replication of the complete test suite of GraphQL.js, making sure this port is

{graphql_core-3.2.13 → graphql_core-3.2.14}/docs/conf.py

@@ -61,7 +61,7 @@ author = "Christoph Zwerschke"
 # The short X.Y version.
 # version = '3.2'
 # The full version, including alpha/beta/rc tags.
-version = release = "3.2.13"
+version = release = "3.2.14"
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

{graphql_core-3.2.13 → graphql_core-3.2.14}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "graphql-core"
-version = "3.2.13"
+version = "3.2.14"
 description = """
 GraphQL-core is a Python port of GraphQL.js, \
 the JavaScript reference implementation for GraphQL."""

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/error/graphql_error.py

@@ -1,6 +1,5 @@
 """GraphQL Error"""
 
-from sys import exc_info
 from typing import Any, Collection, Dict, List, Optional, Union, TYPE_CHECKING
 
 try:
@@ -246,13 +245,18 @@ class GraphQLError(Exception):
         if not positions and node_locations:
             positions = [loc.start for loc in node_locations]
         self.positions = positions or None
-        if positions and source:
-            locations: Optional[List["SourceLocation"]] = [
-                source.get_location(pos) for pos in positions
-            ]
+        source_positions = (
+            [(source, pos) for pos in positions]
+            if positions and source
+            else [(loc.source, loc.start) for loc in node_locations]
+        )
+        if source_positions:
+            # Lazy import to avoid a cyclic dependency between error and language
+            from ..language.location import get_locations
+
+            self.locations = get_locations(source_positions)
         else:
-            locations = [loc.source.get_location(loc.start) for loc in node_locations]
-        self.locations = locations or None
+            self.locations = None
 
         if original_error:
             self.__traceback__ = original_error.__traceback__
@@ -265,8 +269,6 @@ class GraphQLError(Exception):
                 if isinstance(original_extensions, dict):
                     extensions = original_extensions
         self.extensions = extensions or {}
-        if not self.__traceback__:
-            self.__traceback__ = exc_info()[2]
 
     def __str__(self) -> str:
         """Get this error as a human-readable message with source locations.

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/execution/collect_fields.py

@@ -1,6 +1,6 @@
 """Collect fields"""
 
-from typing import Any, Dict, List, Set, Union, cast
+from typing import Any, Callable, Dict, List, Optional, Set, Union, cast
 
 from ..language import (
     FieldNode,
@@ -29,6 +29,7 @@ def collect_fields(
     variable_values: Dict[str, Any],
     runtime_type: GraphQLObjectType,
     selection_set: SelectionSetNode,
+    on_selection_set: Optional[Callable[[SelectionSetNode], None]] = None,
 ) -> Dict[str, List[FieldNode]]:
     """Collect fields.
 
@@ -44,7 +45,14 @@ def collect_fields(
     """
     fields: Dict[str, List[FieldNode]] = {}
     collect_fields_impl(
-        schema, fragments, variable_values, runtime_type, selection_set, fields, set()
+        schema,
+        fragments,
+        variable_values,
+        runtime_type,
+        selection_set,
+        fields,
+        set(),
+        on_selection_set,
     )
     return fields
 
@@ -93,11 +101,14 @@ def collect_fields_impl(
     selection_set: SelectionSetNode,
     fields: Dict[str, List[FieldNode]],
     visited_fragment_names: Set[str],
+    on_selection_set: Optional[Callable[[SelectionSetNode], None]] = None,
 ) -> None:
     """Collect fields (internal implementation).
 
     :meta private:
     """
+    if on_selection_set:
+        on_selection_set(selection_set)
     for selection in selection_set.selections:
         if isinstance(selection, FieldNode):
             if not should_include_node(variable_values, selection):
@@ -117,6 +128,7 @@ def collect_fields_impl(
                 selection.selection_set,
                 fields,
                 visited_fragment_names,
+                on_selection_set,
             )
         elif isinstance(selection, FragmentSpreadNode):  # pragma: no cover else
             frag_name = selection.name.value
@@ -138,6 +150,7 @@ def collect_fields_impl(
                 fragment.selection_set,
                 fields,
                 visited_fragment_names,
+                on_selection_set,
             )
 
 

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/execution/execute.py

@@ -12,6 +12,7 @@ from typing import (
     Dict,
     Iterable,
     List,
+    NoReturn,
     Optional,
     Set,
     Tuple,
@@ -82,6 +83,8 @@ __all__ = [
     "Middleware",
 ]
 
+SELECTIONS_NESTED_TOO_DEEPLY = "Selections are nested too deeply. Execution aborted."
+
 
 # Terminology
 #
@@ -377,6 +380,7 @@ class ExecutionContext:
         max_coercion_errors: int = 50,
         middleware: Optional[Middleware] = None,
         is_awaitable: Optional[Callable[[Any], bool]] = None,
+        hide_suggestions: bool = False,
     ) -> Union[List[GraphQLError], "ExecutionContext"]:
         """Build an execution context
 
@@ -430,6 +434,7 @@ class ExecutionContext:
             operation.variable_definitions or (),
             raw_variable_values or {},
             max_errors=max_coercion_errors,
+            hide_suggestions=hide_suggestions,
         )
 
         if isinstance(coerced_variable_values, list):
@@ -487,13 +492,20 @@ class ExecutionContext:
                 operation,
             )
 
-        root_fields = collect_fields(
-            self.schema,
-            self.fragments,
-            self.variable_values,
-            root_type,
-            operation.selection_set,
-        )
+        try:
+            root_fields = collect_fields(
+                self.schema,
+                self.fragments,
+                self.variable_values,
+                root_type,
+                operation.selection_set,
+            )
+        except RecursionError:
+            root_fields = None
+        # Leave the block above first, or the RecursionError would be kept as the
+        # context of this error and keep all the frames of the recursion alive.
+        if root_fields is None:
+            raise GraphQLError(SELECTIONS_NESTED_TOO_DEEPLY, operation)
 
         path = None
 
@@ -619,7 +631,7 @@ class ExecutionContext:
 
         :meta private:
         """
-        # The resolve function's first argument is a collection of information about
+        # The resolve function's second argument is a collection of information about
         # the current execution state.
         return GraphQLResolveInfo(
             field_nodes[0].name.value,
@@ -1160,6 +1172,7 @@ def execute(
     middleware: Optional[Middleware] = None,
     execution_context_class: Optional[Type["ExecutionContext"]] = None,
     is_awaitable: Optional[Callable[[Any], bool]] = None,
+    hide_suggestions: bool = False,
 ) -> AwaitableOrValue[ExecutionResult]:
     """Execute a GraphQL operation.
 
@@ -1195,6 +1208,7 @@ def execute(
         context.
     :param is_awaitable: The predicate to be used for checking whether values are
         awaitable.
+    :param hide_suggestions: Omit suggestions from input coercion errors.
     :returns: A completed execution result, or a coroutine object yielding one when
         execution is asynchronous.
 
@@ -1305,6 +1319,11 @@ def execute(
 
     # If a valid execution context cannot be created due to incorrect arguments,
     # a "Response" with only errors is returned.
+    # Pass this option only when it is set, so that subclasses
+    # overriding the build method with a fixed signature keep working.
+    build_options: Dict[str, Any] = (
+        {"hide_suggestions": True} if hide_suggestions else {}
+    )
     exe_context = execution_context_class.build(
         schema,
         document,
@@ -1318,6 +1337,7 @@ def execute(
         max_coercion_errors,
         middleware,
         is_awaitable,
+        **build_options,
     )
 
     # Return early errors if execution context failed.
@@ -1380,6 +1400,7 @@ def execute_sync(
     middleware: Optional[Middleware] = None,
     execution_context_class: Optional[Type["ExecutionContext"]] = None,
     check_sync: bool = False,
+    hide_suggestions: bool = False,
 ) -> ExecutionResult:
     """Execute a GraphQL operation synchronously.
 
@@ -1406,6 +1427,7 @@ def execute_sync(
         context.
     :param check_sync: Set this to ``True`` to still run checks that no awaitable
         values are returned. By default, everything is assumed to be synchronous.
+    :param hide_suggestions: Omit suggestions from input coercion errors.
     :returns: The completed execution result for a synchronous operation.
 
     Execute an operation synchronously when all resolvers are synchronous:
@@ -1433,13 +1455,13 @@ def execute_sync(
     ...             schema, document, {'greeting': greeting}, check_sync=True
     ...         )
     ...     except RuntimeError as error:
-    ...         return error
+    ...         return str(error)
     >>> with warnings.catch_warnings():
     ...     warnings.simplefilter('ignore', RuntimeWarning)
-    ...     error = asyncio.run(main())
+    ...     message = asyncio.run(main())
     ...     _ = gc.collect()
-    >>> error
-    RuntimeError('GraphQL execution failed to complete synchronously.')
+    >>> message
+    'GraphQL execution failed to complete synchronously.'
     """
     is_awaitable = (
         check_sync
@@ -1461,6 +1483,7 @@ def execute_sync(
         middleware,
         execution_context_class,
         is_awaitable,
+        hide_suggestions,
     )
 
     # Assert that the execution was synchronous.
@@ -1621,25 +1644,36 @@ def default_type_resolver(
     awaitable_types: List[GraphQLObjectType] = []
     append_awaitable_types = awaitable_types.append
 
-    for type_ in possible_types:
-        if type_.is_type_of:
-            is_type_of_result = type_.is_type_of(value, info)
-
-            if is_awaitable(is_type_of_result):
-                append_awaitable_results(cast(Awaitable, is_type_of_result))
-                append_awaitable_types(type_)
-            elif is_type_of_result:
-                if awaitable_is_type_of_results:
-                    # noinspection PyShadowingNames
-                    async def await_is_type_of_and_return_type(
-                        resolved_type_name: str = type_.name,
-                    ) -> str:
-                        with suppress(Exception):
-                            await gather(*awaitable_is_type_of_results)
-                        return resolved_type_name
-
-                    return await_is_type_of_and_return_type()
-                return type_.name
+    try:
+        for type_ in possible_types:
+            if type_.is_type_of:
+                is_type_of_result = type_.is_type_of(value, info)
+
+                if is_awaitable(is_type_of_result):
+                    append_awaitable_results(cast(Awaitable, is_type_of_result))
+                    append_awaitable_types(type_)
+                elif is_type_of_result:
+                    if awaitable_is_type_of_results:
+                        # noinspection PyShadowingNames
+                        async def await_is_type_of_and_return_type(
+                            resolved_type_name: str = type_.name,
+                        ) -> str:
+                            with suppress(Exception):
+                                await gather(*awaitable_is_type_of_results)
+                            return resolved_type_name
+
+                        return await_is_type_of_and_return_type()
+                    return type_.name
+    except Exception as error:
+        if awaitable_is_type_of_results:
+            # Settle the pending isTypeOf results so that their errors can be
+            # observed before they would be orphaned.
+            async def settle_and_raise(error: Exception = error) -> NoReturn:
+                await gather(*awaitable_is_type_of_results, return_exceptions=True)
+                raise error
+
+            return settle_and_raise()
+        raise
 
     if awaitable_is_type_of_results:
         # noinspection PyShadowingNames

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/execution/map_async_iterator.py

@@ -2,6 +2,7 @@
 
 from asyncio import CancelledError, Event, Task, ensure_future, wait
 from concurrent.futures import FIRST_COMPLETED
+from contextlib import suppress
 from inspect import isasyncgen, isawaitable
 from types import TracebackType
 from typing import Any, AsyncIterable, Callable, Optional, Set, Type, Union
@@ -118,7 +119,9 @@ class MapAsyncIterator:
         if athrow:
             await athrow(type_ if value is None else value)
         else:
-            await self.aclose()
+            # Keep the original error when closing the source also fails.
+            with suppress(Exception):
+                await self.aclose()
             if value is None:
                 if traceback is None:
                     raise type_  # pragma: no cover

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/execution/subscribe.py

@@ -13,6 +13,7 @@ from typing import (
 from ..error import GraphQLError, located_error
 from ..execution.collect_fields import collect_fields
 from ..execution.execute import (
+    SELECTIONS_NESTED_TOO_DEEPLY,
     assert_valid_execution_arguments,
     execute,
     get_field_def,
@@ -38,6 +39,7 @@ async def subscribe(
     field_resolver: Optional[GraphQLFieldResolver] = None,
     subscribe_field_resolver: Optional[GraphQLFieldResolver] = None,
     max_coercion_errors: int = 50,
+    hide_suggestions: bool = False,
 ) -> Union[AsyncIterator[ExecutionResult], ExecutionResult]:
     """Create a GraphQL subscription.
 
@@ -74,6 +76,7 @@ async def subscribe(
     :param subscribe_field_resolver: Resolver used for the root subscription field.
     :param max_coercion_errors: Set the maximum number of errors allowed for coercing
         variable values (defaults to 50).
+    :param hide_suggestions: Omit suggestions from input coercion errors.
     :returns: A source stream mapped to execution results, or an execution result
         containing subscription errors.
 
@@ -161,6 +164,7 @@ async def subscribe(
         operation_name,
         subscribe_field_resolver,
         max_coercion_errors,
+        hide_suggestions,
     )
     if isinstance(result_or_stream, ExecutionResult):
         return result_or_stream
@@ -183,6 +187,7 @@ async def subscribe(
             variable_values,
             operation_name,
             field_resolver,
+            hide_suggestions=hide_suggestions,
         )
         return await result if isawaitable(result) else result
 
@@ -199,6 +204,7 @@ async def create_source_event_stream(
     operation_name: Optional[str] = None,
     subscribe_field_resolver: Optional[GraphQLFieldResolver] = None,
     max_coercion_errors: int = 50,
+    hide_suggestions: bool = False,
 ) -> Union[AsyncIterable[Any], ExecutionResult]:
     """Create source event stream
 
@@ -233,6 +239,7 @@ async def create_source_event_stream(
     :param subscribe_field_resolver: Resolver used for the root subscription field.
     :param max_coercion_errors: Set the maximum number of errors allowed for coercing
         variable values (defaults to 50).
+    :param hide_suggestions: Omit suggestions from input coercion errors.
     :returns: The source event stream, or an execution result containing subscription
         errors.
 
@@ -275,6 +282,7 @@ async def create_source_event_stream(
         operation_name,
         subscribe_field_resolver=subscribe_field_resolver,
         max_coercion_errors=max_coercion_errors,
+        hide_suggestions=hide_suggestions,
     )
 
     # Return early errors if execution context failed.
@@ -296,6 +304,14 @@ async def create_source_event_stream(
         # Report it as an ExecutionResult, containing only errors and no data.
         return ExecutionResult(data=None, errors=[error])
 
+    except RecursionError:
+        # This error is never raised, so it has no traceback or context
+        # that would keep all the frames of the recursion alive.
+        return ExecutionResult(
+            data=None,
+            errors=[GraphQLError(SELECTIONS_NESTED_TOO_DEEPLY, context.operation)],
+        )
+
 
 async def execute_subscription(context: ExecutionContext) -> AsyncIterable[Any]:
     """Resolve the event stream of the root subscription field.

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/execution/values.py

@@ -1,6 +1,6 @@
 """Helpers for handling values"""
 
-from typing import Any, Callable, Collection, Dict, List, Optional, Union, cast
+from typing import Any, Callable, Collection, Dict, List, Optional, Tuple, Union, cast
 
 from ..error import GraphQLError
 from ..language import (
@@ -19,8 +19,9 @@ from ..language import (
     TypeExtensionNode,
     VariableDefinitionNode,
     VariableNode,
-    print_ast,
 )
+from ..language.parser import MAX_NESTING_DEPTH
+from ..language.printer import print_for_error
 from ..pyutils import Undefined, inspect, print_path_list
 from ..type import (
     GraphQLDirective,
@@ -29,6 +30,7 @@ from ..type import (
     GraphQLSchema,
     is_input_object_type,
     is_input_type,
+    is_list_type,
     is_non_null_type,
 )
 from ..utilities.coerce_input_value import coerce_input_value
@@ -46,12 +48,14 @@ def get_variable_values(
     var_def_nodes: Collection[VariableDefinitionNode],
     inputs: Dict[str, Any],
     max_errors: Optional[int] = None,
+    hide_suggestions: bool = False,
 ) -> CoercedVariableValues:
     """Get coerced variable values based on provided definitions.
 
     Prepares a dict of variable values of the correct type based on the provided
     variable definitions and arbitrary input. If the input cannot be parsed to match
-    the variable definitions, a list of GraphQLErrors will be returned instead.
+    the variable definitions, a list of GraphQLErrors will be returned instead. This
+    also applies to input nested too deeply for the recursion limit of the interpreter.
 
     :param schema: GraphQL schema to use.
     :param var_def_nodes: The variable definition AST nodes to coerce.
@@ -59,6 +63,7 @@ def get_variable_values(
     :param max_errors: The maximum number of coercion errors to report (unlimited by
         default). When the limit is exceeded, an additional error is added and
         coercion is aborted.
+    :param hide_suggestions: Omit suggestions from input coercion errors.
     :returns: Coerced variable values, or a list of request errors.
 
     Coerce provided variables and apply operation defaults:
@@ -118,20 +123,55 @@ def get_variable_values(
         errors.append(error)
 
     try:
-        coerced = coerce_variable_values(schema, var_def_nodes, inputs, on_error)
+        coerced = coerce_variable_values(
+            schema, var_def_nodes, inputs, on_error, hide_suggestions
+        )
         if not errors:
             return coerced
     except GraphQLError as e:
         errors.append(e)
+    except RecursionError:
+        # This error is never raised, so it has no traceback or context
+        # that would keep all the frames of the recursion alive.
+        errors.append(GraphQLError("Variable values are nested too deeply."))
 
     return errors
 
 
+def input_is_nested_too_deeply(value: Any, type_: GraphQLInputType) -> bool:
+    """Check whether coercing the given value would recurse too deeply.
+
+    See ``MAX_NESTING_DEPTH`` for why this is needed in addition to handling a stack
+    overflow. Only the nesting that the type follows counts, so a deep value of a
+    custom scalar is fine.
+
+    :meta private:
+    """
+    stack: List[Tuple[Any, Any, int]] = [(value, type_, 0)]
+    while stack:
+        current, current_type, depth = stack.pop()
+        if depth > MAX_NESTING_DEPTH:
+            return True
+        if is_non_null_type(current_type):
+            current_type = current_type.of_type
+        if is_list_type(current_type):
+            items = current if isinstance(current, (list, tuple)) else [current]
+            stack.extend((item, current_type.of_type, depth + 1) for item in items)
+        elif is_input_object_type(current_type) and isinstance(current, dict):
+            stack.extend(
+                (current[name], field.type, depth + 1)
+                for name, field in current_type.fields.items()
+                if name in current
+            )
+    return False
+
+
 def coerce_variable_values(
     schema: GraphQLSchema,
     var_def_nodes: Collection[VariableDefinitionNode],
     inputs: Dict[str, Any],
     on_error: Callable[[GraphQLError], None],
+    hide_suggestions: bool = False,
 ) -> Dict[str, Any]:
     """Coerce the variable values, reporting errors via the given callback.
 
@@ -144,7 +184,7 @@ def coerce_variable_values(
         if not is_input_type(var_type):
             # Must use input types for variables. This should be caught during
             # validation, however is checked again here for safety.
-            var_type_str = print_ast(var_def_node.type)
+            var_type_str = print_for_error(var_def_node.type)
             on_error(
                 GraphQLError(
                     f"Variable '${var_name}' expected value of type '{var_type_str}'"
@@ -202,8 +242,10 @@ def coerce_variable_values(
                 )
             )
 
+        if input_is_nested_too_deeply(value, var_type):
+            raise RecursionError
         coerced_values[var_name] = coerce_input_value(
-            value, var_type, on_input_value_error
+            value, var_type, on_input_value_error, None, hide_suggestions
         )
 
     return coerced_values
@@ -316,7 +358,7 @@ def get_argument_values(
             # execution. This is a runtime check to ensure execution does not
             # continue with an invalid argument value.
             raise GraphQLError(
-                f"Argument '{name}' has invalid value {print_ast(value_node)}.",
+                f"Argument '{name}' has invalid value {print_for_error(value_node)}.",
                 value_node,
             )
         coerced_values[arg_def.out_name or name] = coerced_value

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/graphql.py

@@ -29,6 +29,7 @@ async def graphql(
     middleware: Optional[Middleware] = None,
     execution_context_class: Optional[Type[ExecutionContext]] = None,
     is_awaitable: Optional[Callable[[Any], bool]] = None,
+    hide_suggestions: bool = False,
 ) -> ExecutionResult:
     """Execute a GraphQL operation asynchronously.
 
@@ -68,6 +69,8 @@ async def graphql(
         context.
     :param is_awaitable: The predicate to be used for checking whether values are
         awaitable.
+    :param hide_suggestions: Omit suggestions from validation and input coercion
+        errors.
     :returns: The execution result, or the request errors if parsing or validation
         fails.
 
@@ -135,6 +138,7 @@ async def graphql(
         middleware,
         execution_context_class,
         is_awaitable,
+        hide_suggestions,
     )
 
     if isawaitable(result):
@@ -163,6 +167,7 @@ def graphql_sync(
     middleware: Optional[Middleware] = None,
     execution_context_class: Optional[Type[ExecutionContext]] = None,
     check_sync: bool = False,
+    hide_suggestions: bool = False,
 ) -> ExecutionResult:
     """Execute a GraphQL operation synchronously.
 
@@ -194,6 +199,8 @@ def graphql_sync(
         context.
     :param check_sync: Set this to ``True`` to still run checks that no awaitable
         values are returned. By default, everything is assumed to be synchronous.
+    :param hide_suggestions: Omit suggestions from validation and input coercion
+        errors.
     :returns: The completed execution result, or the request errors if parsing or
         validation fails.
 
@@ -246,6 +253,7 @@ def graphql_sync(
         middleware,
         execution_context_class,
         is_awaitable,
+        hide_suggestions,
     )
 
     # Assert that the execution was synchronous.
@@ -270,6 +278,7 @@ def graphql_impl(
     middleware: Optional[Middleware],
     execution_context_class: Optional[Type[ExecutionContext]],
     is_awaitable: Optional[Callable[[Any], bool]],
+    hide_suggestions: bool,
 ) -> AwaitableOrValue[ExecutionResult]:
     """Execute a query, return asynchronously only if necessary.
 
@@ -289,7 +298,7 @@ def graphql_impl(
     # Validate
     from .validation import validate
 
-    validation_errors = validate(schema, document)
+    validation_errors = validate(schema, document, hide_suggestions=hide_suggestions)
     if validation_errors:
         return ExecutionResult(data=None, errors=validation_errors)
 
@@ -308,4 +317,5 @@ def graphql_impl(
         middleware,
         execution_context_class,
         is_awaitable,
+        hide_suggestions,
     )

{graphql_core-3.2.13 → graphql_core-3.2.14}/src/graphql/language/ast.py

@@ -541,7 +541,10 @@ class DocumentNode(Node):
     # that it is not treated as a traversable attribute, the equivalent of the
     # non-enumerable ``tokenCount`` property in graphql-js.
     token_count: int = 0
-    """The number of lexical tokens parsed for this document."""
+    """The number of tokens parsed for this document.
+
+    The count includes comments, unlike in GraphQL.js.
+    """
 
 
 class DefinitionNode(Node):