graphmark 0.3.1__tar.gz → 0.3.3__tar.gz

{graphmark-0.3.1 → graphmark-0.3.3}/CHANGELOG.md

@@ -1,6 +1,61 @@
 # CHANGELOG
 
 
+## v0.3.3 (2026-07-25)
+
+### Bug Fixes
+
+- **resolve**: [[note.md]] resolves like [[Note]]
+  ([#105](https://github.com/cdcoonce/graphmark/pull/105),
+  [`916da52`](https://github.com/cdcoonce/graphmark/commit/916da52465cc3c5295a9440ae86af1ee6065e1d5))
+
+Obsidian accepts an explicit .md extension, so [[Note.md]] and [[Note]] are the same link. graphmark
+  resolved only the second: the normalizer turned "Note.md" into the key "note md" while the file's
+  catalog key is "note", so the link never matched and was reported as broken. The path-suffix
+  branch was worse — it appends ".md" itself, so [[folder/note.md]] searched for folder/note.md.md.
+
+Strip a case-insensitive trailing ".md" after alias/anchor stripping and before both resolution
+  branches. A missing [[Nowhere.md]] stays unresolved and an ambiguous stem stays ambiguous; a title
+  merely ending in the word "MD" is untouched.
+
+Parity-safe: no frozen fixture uses a .md-style link, so every expected.json is unchanged (81 oracle
+  tests green). The change only adds resolutions that previously failed — it never removes one.
+
+Also updates the test added in #101 that documented this gap as current behavior; it now asserts the
+  fix.
+
+Closes #104
+
+
+## v0.3.2 (2026-07-25)
+
+### Bug Fixes
+
+- **graph**: Links to non-markdown files are out of scope, not broken
+  ([#102](https://github.com/cdcoonce/graphmark/pull/102),
+  [`0796aa0`](https://github.com/cdcoonce/graphmark/commit/0796aa02d1d582b85a8905fb4b43b72b076bd072))
+
+unresolved reported wikilinks targeting Obsidian Bases, Canvas, images and PDFs as broken. graphmark
+  only indexes *.md, so it has no basis to judge those targets — calling them broken just fills the
+  vault-health count with entries nobody can act on.
+
+Measured on the owner's live vault: 17 of 173 reported breaks (10%) targeted .base/.canvas, and all
+  9 distinct targets exist on disk, in a bases/ directory outside scoped_folders. Every one of those
+  links works in Obsidian.
+
+When the resolver returns None and the target ends in a plausible file extension other than .md,
+  treat it as out of scope: no edge, not counted. The extension test is deliberately strict
+  (trailing dot plus 1-10 alphanumerics) so a title like "v1.2 release notes" is still read as a
+  note. Applying the rule only after the resolver has already failed is what makes it safe — a note
+  that genuinely resolves, such as a real report.v2.md linked as [[report.v2]], never reaches it.
+
+Deliberately no filesystem existence check: it would couple build() to the disk and force
+  enumerating excluded trees like .git. "Out of scope" is the honest report for a file type
+  graphmark does not index.
+
+Closes #101
+
+
 ## v0.3.1 (2026-07-25)
 
 ### Bug Fixes

{graphmark-0.3.1 → graphmark-0.3.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: graphmark
-Version: 0.3.1
+Version: 0.3.3
 Summary: Deterministic knowledge-graph analysis for markdown / [[wikilink]] vaults.
 Project-URL: Homepage, https://github.com/cdcoonce/graphmark
 Project-URL: Repository, https://github.com/cdcoonce/graphmark

{graphmark-0.3.1 → graphmark-0.3.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "graphmark"
-version = "0.3.1"
+version = "0.3.3"
 description = "Deterministic knowledge-graph analysis for markdown / [[wikilink]] vaults."
 readme = "README.md"
 requires-python = ">=3.11"

{graphmark-0.3.1 → graphmark-0.3.3}/src/graphmark/graph.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import re
 import string
 from pathlib import Path
 
@@ -18,6 +19,27 @@ def _normalize(text: str) -> str:
     return " ".join(text.lower().translate(_PUNCT_TABLE).split())
 
 
+# A trailing dot plus a short alphanumeric run — a plausible file extension. Deliberately
+# strict so a note title like "v1.2 release notes" (spaces after the dot) is not mistaken
+# for one.
+_FILE_SUFFIX_RE = re.compile(r"\.[A-Za-z0-9]{1,10}$")
+
+
+def _targets_non_note_file(display: str) -> bool:
+    """True for a link to a file graphmark does not index, e.g. ``[[Board.canvas]]``.
+
+    Obsidian wikilinks legitimately target Bases, Canvas, images and PDFs. graphmark only
+    indexes markdown, so it has no basis to call such a link broken — reporting it as
+    unresolved just fills the vault-health count with entries nobody can act on.
+
+    Only ever consulted after the resolver has already failed, so a note that genuinely
+    resolves (say a real ``report.v2.md`` linked as ``[[report.v2]]``) is never suppressed.
+    """
+    target = display.split("|")[0].split("#")[0].strip()
+    match = _FILE_SUFFIX_RE.search(target)
+    return bool(match) and match.group(0).lower() != ".md"
+
+
 def _is_intra_note_reference(display: str) -> bool:
     """True for a link that targets no note, e.g. ``[[#Heading]]`` or ``[[#^block]]``.
 
@@ -62,6 +84,11 @@ class NormalizeResolver:
         display = display.split("|")[0]
         # Strip anchor: "Note#Section" → "Note"
         display = display.split("#")[0]
+        # Obsidian accepts an explicit extension, so "Note.md" is the same link as "Note".
+        # Stripped before both branches below: the path-suffix branch appends ".md" itself,
+        # and the bare branch would otherwise normalize to the key "note md".
+        if display.lower().endswith(".md"):
+            display = display[: -len(".md")]
 
         if "/" in display:
             # Path-suffix resolution: find unique rel_path ending with "display.md"
@@ -140,6 +167,8 @@ class VaultGraph:
                     continue
                 target = resolver.resolve(display, catalog)
                 if target is None:
+                    if _targets_non_note_file(display):
+                        continue  # out of scope, not a broken note link
                     # Unresolvable OR ambiguous — the Resolver protocol conflates the two, and
                     # both are equally broken from a vault-health view. Record the raw display
                     # (what a human has to go fix) once per occurrence.

{graphmark-0.3.1 → graphmark-0.3.3}/tests/test_graph.py

@@ -190,3 +190,50 @@ class TestVaultGraphBuild:
         assert degree("personal/gamma.md") == 2
         assert degree("reference/island.md") == 0
         assert degree("reference/stub.md") == 0
+
+
+class TestMarkdownExtensionInLinks:
+    """Obsidian treats [[Note.md]] and [[Note]] as the same link; so must the resolver."""
+
+    def setup_method(self):
+        self.resolver = NormalizeResolver()
+
+    def _catalog(self, *rel_paths: str) -> dict[str, list[str]]:
+        return build_catalog([_doc(p) for p in rel_paths])
+
+    def test_bare_link_with_md_extension_resolves(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("alpha.md", catalog) == "brain/alpha.md"
+
+    def test_extension_match_is_case_insensitive(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("Alpha.MD", catalog) == "brain/alpha.md"
+
+    def test_md_extension_with_alias_resolves(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("alpha.md|the first note", catalog) == "brain/alpha.md"
+
+    def test_md_extension_with_anchor_resolves(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("alpha.md#Section", catalog) == "brain/alpha.md"
+
+    def test_path_style_link_with_md_extension_resolves(self):
+        catalog = self._catalog("brain/alpha.md", "personal/beta.md")
+        assert self.resolver.resolve("brain/alpha.md", catalog) == "brain/alpha.md"
+
+    def test_missing_target_with_md_extension_stays_unresolved(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("nowhere.md", catalog) is None
+
+    def test_ambiguous_stem_stays_ambiguous_with_the_extension(self):
+        catalog = {"note": ["dir1/note.md", "dir2/note.md"]}
+        assert self.resolver.resolve("note.md", catalog) is None
+
+    def test_extensionless_links_are_unaffected(self):
+        catalog = self._catalog("brain/alpha.md")
+        assert self.resolver.resolve("alpha", catalog) == "brain/alpha.md"
+
+    def test_a_title_ending_in_md_as_a_word_is_not_stripped(self):
+        # "Doctor MD" ends with "md" but not ".md" — it must not be truncated.
+        catalog = self._catalog("org/Doctor MD.md")
+        assert self.resolver.resolve("Doctor MD", catalog) == "org/Doctor MD.md"

{graphmark-0.3.1 → graphmark-0.3.3}/tests/test_unresolved.py

@@ -175,3 +175,61 @@ class TestIntraNoteAnchorLinks:
     def test_mixed_note_keeps_only_the_real_break(self, tmp_path):
         _write(tmp_path, "a.md", "[[#Local]] and [[Missing]] and [[#Other|x]].\n")
         assert _build(tmp_path).unresolved == {"a.md": ["Missing"]}
+
+
+class TestNonMarkdownTargets:
+    """A link to a file graphmark does not index is out of scope, not broken.
+
+    Obsidian wikilinks legitimately target Bases (.base), Canvas (.canvas), images and PDFs.
+    graphmark only indexes *.md, so it has no basis to call those links broken — on a real
+    vault they were 10% of the reported total, every one of them a working link.
+    """
+
+    @pytest.mark.parametrize(
+        "display",
+        [
+            "Stale Side-Projects.base",
+            "Board.canvas",
+            "diagram.png",
+            "spec.pdf",
+            "sketch.excalidraw",
+            "People Missing Context.base|People Missing Context",
+            "Board.canvas#Section",
+        ],
+    )
+    def test_non_markdown_target_is_not_unresolved(self, tmp_path, display):
+        _write(tmp_path, "a.md", f"See [[{display}]].\n")
+        graph = _build(tmp_path)
+        assert graph.unresolved == {}
+        assert graph.out_links["a.md"] == set()
+
+    def test_md_targets_are_exempt_from_the_rule(self, tmp_path):
+        # .md is excluded from the non-note rule, so a link ending in .md is left to the
+        # resolver — which now resolves it (a trailing ".md" is stripped, matching Obsidian).
+        _write(tmp_path, "a.md", "See [[b.md]].\n")
+        _write(tmp_path, "b.md", "Target.\n")
+        graph = _build(tmp_path)
+        assert graph.unresolved == {}
+        assert graph.out_links["a.md"] == {"b.md"}
+
+    def test_missing_md_target_is_still_unresolved(self, tmp_path):
+        _write(tmp_path, "a.md", "See [[Nowhere.md]].\n")
+        assert _build(tmp_path).unresolved == {"a.md": ["Nowhere.md"]}
+
+    def test_dotted_title_is_not_mistaken_for_a_file_extension(self, tmp_path):
+        # "v1.2 release notes" has spaces after the dot — it is a note title, so a missing
+        # one must still be reported.
+        _write(tmp_path, "a.md", "See [[v1.2 release notes]].\n")
+        assert _build(tmp_path).unresolved == {"a.md": ["v1.2 release notes"]}
+
+    def test_a_resolvable_dotted_note_is_never_suppressed(self, tmp_path):
+        # The rule only applies after the resolver fails, so a real note wins.
+        _write(tmp_path, "a.md", "See [[report.v2]].\n")
+        _write(tmp_path, "report.v2.md", "Target.\n")
+        graph = _build(tmp_path)
+        assert graph.unresolved == {}
+        assert graph.out_links["a.md"] == {"report.v2.md"}
+
+    def test_mixed_note_keeps_only_the_missing_note(self, tmp_path):
+        _write(tmp_path, "a.md", "[[Chart.base]] and [[Missing]] and [[#local]].\n")
+        assert _build(tmp_path).unresolved == {"a.md": ["Missing"]}