gramps-webapi 3.22.0__tar.gz → 3.22.2__tar.gz

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/Dockerfile.base

@@ -8,7 +8,10 @@ WORKDIR /app
 # install poppler (needed for PDF thumbnails)
 # ffmpeg (needed for video thumbnails)
 # postgresql client (needed for PostgreSQL backend)
+# Noto fonts (needed to render non-Latin scripts in generated reports -
+# without them, Pango has no glyphs and PDF output is garbled)
 RUN apt-get update && apt-get install -y \
+  fonts-dejavu-core fonts-noto-core fonts-noto-cjk \
   appstream pkg-config libcairo2-dev \
   gir1.2-gtk-3.0 libgirepository1.0-dev libicu-dev \
   graphviz gir1.2-gexiv2-0.10 gir1.2-osmgpsmap-1.0 \

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gramps-webapi
-Version: 3.22.0
+Version: 3.22.2
 Summary: A RESTful web API for the Gramps genealogical database.
 Author: Gramps Development Team
 Author-email: "David M. Straub" <straub@protonmail.com>
@@ -39,7 +39,7 @@ Requires-Dist: alembic
 Requires-Dist: celery[redis]
 Requires-Dist: Unidecode
 Requires-Dist: pytesseract
-Requires-Dist: gramps-object-query-language<0.6,>=0.5.0
+Requires-Dist: gramps-object-query-language<0.6,>=0.5.1
 Requires-Dist: gramps-ql>=0.5.0
 Requires-Dist: object-ql>=0.1.3
 Requires-Dist: sifts>=1.1.0

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/ROADMAP.md

@@ -13,14 +13,14 @@ removed no earlier than the next major.
 
 | Version | Target | Gramps | Breaking changes |
 |---|---|---|---|
-| 3.21.x | current | 6.0 | none |
-| 3.22.0 | September 2026 | 6.0 | none |
+| 3.22.x | current | 6.0 | none |
+| 3.23.0 | October 2026 | 6.0 | none |
 | 3.x | as needed | 6.0 | none |
 | 4.0.0 | TBD | 6.0, 6.1 or 6.2 (open) | multi-tree by default, removals below |
 
-## Notable in 3.22
+## Notable in 3.23
 
-E-mail addresses no longer have to be unique across accounts; a user database migration drops the constraint ([#961](https://github.com/gramps-project/gramps-web-api/pull/961)).
+TBD
 
 ## Breaking in 4.0
 

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/_version.py

@@ -19,4 +19,4 @@
 
 """Version information."""
 
-__version__ = "3.22.0"
+__version__ = "3.22.2"

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/__init__.py

@@ -176,6 +176,7 @@ def register_endpt(
     name: str,
     tags: Optional[List[str]] = None,
     request_body: Optional[dict] = None,
+    object_name: Optional[str] = None,
 ):
     """Register an endpoint.
 
@@ -188,6 +189,11 @@ def register_endpt(
     `request_body` documents the JSON payload of a POST/PUT endpoint (e.g.
     via `object_request_body()`); omit it for endpoints that take no body
     or a non-JSON one (such as Media's raw file upload).
+
+    `object_name` names the Gramps object type (e.g. "Person") used to
+    build CRUD summary text ("Get a Gramps Person record", ...). Pass it
+    for endpoints that operate on a single typed object; omit it for
+    endpoints (transactions, tokens, queries, ...) that don't.
     """
     operation_name = name.replace("-", "_")
     for verb in ("get", "post", "put", "delete", "patch"):
@@ -195,6 +201,24 @@ def register_endpt(
         if method is None:
             continue
         doc_kwargs: dict = {"operationId": f"{verb}_{operation_name}"}
+        if object_name is not None:
+            collection_name = name.replace("-", " ").replace("_", " ")
+            if verb == "get":
+                summary = (
+                    f"Get a Gramps {object_name} record"
+                    if "<string:handle>" in url
+                    else f"List Gramps {collection_name} with filters"
+                )
+            elif verb == "post":
+                summary = f"Create a Gramps {object_name} record"
+            elif verb == "put":
+                summary = f"Update a Gramps {object_name} record"
+            elif verb == "delete":
+                summary = f"Delete a Gramps {object_name} record"
+            else:
+                summary = None
+            if summary is not None:
+                doc_kwargs["summary"] = summary
         if request_body is not None and verb in ("post", "put"):
             doc_kwargs["requestBody"] = request_body
         # setattr rather than plain assignment: mypy rejects assigning to a
@@ -295,6 +319,7 @@ register_endpt(
     "person",
     tags=["People"],
     request_body=object_request_body("Person"),
+    object_name="Person",
 )
 register_endpt(
     PersonDnaMatchesResource,
@@ -311,6 +336,7 @@ register_endpt(
     "people",
     tags=["People"],
     request_body=object_request_body("Person"),
+    object_name="Person",
 )
 register_endpt(PersonQueryResource, "/people/query/", "people-query", tags=["People"])
 register_endpt(
@@ -332,6 +358,7 @@ register_endpt(
     "family",
     tags=["Families"],
     request_body=object_request_body("Family"),
+    object_name="Family",
 )
 register_endpt(
     FamiliesResource,
@@ -339,6 +366,7 @@ register_endpt(
     "families",
     tags=["Families"],
     request_body=object_request_body("Family"),
+    object_name="Family",
 )
 register_endpt(
     FamilyQueryResource, "/families/query/", "families-query", tags=["Families"]
@@ -362,6 +390,7 @@ register_endpt(
     "event",
     tags=["Events"],
     request_body=object_request_body("Event"),
+    object_name="Event",
 )
 register_endpt(
     EventsResource,
@@ -369,6 +398,7 @@ register_endpt(
     "events",
     tags=["Events"],
     request_body=object_request_body("Event"),
+    object_name="Event",
 )
 register_endpt(EventQueryResource, "/events/query/", "events-query", tags=["Events"])
 register_endpt(
@@ -394,6 +424,7 @@ register_endpt(
     "place",
     tags=["Places"],
     request_body=object_request_body("Place"),
+    object_name="Place",
 )
 register_endpt(
     PlacesResource,
@@ -401,6 +432,7 @@ register_endpt(
     "places",
     tags=["Places"],
     request_body=object_request_body("Place"),
+    object_name="Place",
 )
 register_endpt(PlaceQueryResource, "/places/query/", "places-query", tags=["Places"])
 register_endpt(
@@ -416,6 +448,7 @@ register_endpt(
     "citation",
     tags=["Citations"],
     request_body=object_request_body("Citation"),
+    object_name="Citation",
 )
 register_endpt(
     CitationsResource,
@@ -423,6 +456,7 @@ register_endpt(
     "citations",
     tags=["Citations"],
     request_body=object_request_body("Citation"),
+    object_name="Citation",
 )
 register_endpt(
     CitationQueryResource, "/citations/query/", "citations-query", tags=["Citations"]
@@ -440,6 +474,7 @@ register_endpt(
     "source",
     tags=["Sources"],
     request_body=object_request_body("Source"),
+    object_name="Source",
 )
 register_endpt(
     SourcesResource,
@@ -447,6 +482,7 @@ register_endpt(
     "sources",
     tags=["Sources"],
     request_body=object_request_body("Source"),
+    object_name="Source",
 )
 register_endpt(
     SourceQueryResource, "/sources/query/", "sources-query", tags=["Sources"]
@@ -464,6 +500,7 @@ register_endpt(
     "repository",
     tags=["Repositories"],
     request_body=object_request_body("Repository"),
+    object_name="Repository",
 )
 register_endpt(
     RepositoriesResource,
@@ -471,6 +508,7 @@ register_endpt(
     "repositories",
     tags=["Repositories"],
     request_body=object_request_body("Repository"),
+    object_name="Repository",
 )
 register_endpt(
     RepositoryQueryResource,
@@ -491,10 +529,17 @@ register_endpt(
     "media_object",
     tags=["Media"],
     request_body=object_request_body("Media"),
+    object_name="Media",
 )
 # MediaObjectsResource's POST takes a raw file upload (multipart), not JSON,
 # so it gets no request_body doc here.
-register_endpt(MediaObjectsResource, "/media/", "media_objects", tags=["Media"])
+register_endpt(
+    MediaObjectsResource,
+    "/media/",
+    "media_objects",
+    tags=["Media"],
+    object_name="Media",
+)
 register_endpt(MediaQueryResource, "/media/query/", "media-query", tags=["Media"])
 register_endpt(
     MergeMediaResource,
@@ -509,6 +554,7 @@ register_endpt(
     "note",
     tags=["Notes"],
     request_body=object_request_body("Note"),
+    object_name="Note",
 )
 register_endpt(
     NotesResource,
@@ -516,6 +562,7 @@ register_endpt(
     "notes",
     tags=["Notes"],
     request_body=object_request_body("Note"),
+    object_name="Note",
 )
 register_endpt(NoteQueryResource, "/notes/query/", "notes-query", tags=["Notes"])
 register_endpt(
@@ -531,6 +578,7 @@ register_endpt(
     "tag",
     tags=["Tags"],
     request_body=object_request_body("Tag"),
+    object_name="Tag",
 )
 register_endpt(
     TagsResource,
@@ -538,6 +586,7 @@ register_endpt(
     "tags",
     tags=["Tags"],
     request_body=object_request_body("Tag"),
+    object_name="Tag",
 )
 register_endpt(TagQueryResource, "/tags/query/", "tags-query", tags=["Tags"])
 # Trees

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/deprecations.py

@@ -96,9 +96,12 @@ def check_deprecations(
             _deprecation(
                 "SEARCH_INDEX_DIR",
                 "SEARCH_INDEX_DB_URI",
+                # the configured directory is deliberately not interpolated here:
+                # the message is exposed via the API, so it must not disclose a
+                # server filesystem path
                 "The `SEARCH_INDEX_DIR` config option is deprecated. Please use"
                 " `SEARCH_INDEX_DB_URI` instead, e.g. setting it to"
-                f" `sqlite:///{config['SEARCH_INDEX_DIR']}/search_index.db`.",
+                " `sqlite:///<search index directory>/search_index.db`.",
             )
         )
     if (

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/image.py

@@ -29,7 +29,7 @@ from importlib.resources import as_file, files
 from pathlib import Path
 from typing import BinaryIO, Callable, Iterator, Union
 
-from PIL import Image, ImageOps, UnidentifiedImageError
+from PIL import Image, ImageCms, ImageOps, UnidentifiedImageError
 from PIL.Image import DecompressionBombError
 from PIL.Image import Image as ImageType
 
@@ -123,7 +123,36 @@ def save_image_buffer(image: ImageType, fmt="AVIF") -> BinaryIO:
     if image.mode == "RGBA" and not supports_alpha:
         image = image.convert("RGB")
     elif image.mode not in ("RGB", "RGBA"):
-        image = image.convert("RGB")
+        if image.mode == "L" and image.info.get("icc_profile"):
+            # `convert("RGB")` changes the pixel mode but keeps the source
+            # ICC profile as-is, which is invalid for RGB output and gets
+            # embedded verbatim on save, producing files some decoders
+            # (e.g. Chrome for AVIF) refuse to open.
+            try:
+                source_profile = ImageCms.ImageCmsProfile(
+                    io.BytesIO(image.info["icc_profile"])
+                )
+                transformed_image = ImageCms.profileToProfile(
+                    image,
+                    source_profile,
+                    ImageCms.createProfile("sRGB"),
+                    outputMode="RGB",
+                )
+                # `profileToProfile()` only returns `None` when called with
+                # `inPlace=True`, which we don't do here.
+                assert transformed_image is not None
+                image = transformed_image
+            except ImageCms.PyCMSError:
+                # The embedded profile is untrusted (uploaded) data: it can be
+                # malformed enough to open but still fail to build a color
+                # transform. Fall back to an uncolor-managed conversion rather
+                # than crashing.
+                image = image.convert("RGB")
+                image.info.pop("icc_profile", None)
+        else:
+            image = image.convert("RGB")
+            # the profile (if any) belonged to the previous color space
+            image.info.pop("icc_profile", None)
     image.save(buffer, format=fmt)
     buffer.seek(0)
     return buffer

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/media.py

@@ -390,6 +390,7 @@ def check_quota_media(
         usage_dict = get_tree_usage(tree)
         assert usage_dict is not None, "Unexpected error while looking up usage data."
     usage = usage_dict["usage_media"]
+    assert usage is not None, "Unexpected error while looking up usage data."
     quota = usage_dict.get("quota_media")
     if quota is None:
         return

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/report.py

@@ -59,7 +59,6 @@ from gramps.gen.plug.report import (
     CATEGORY_TEXT,
     CATEGORY_TREE,
 )
-from gramps.gen.utils.grampslocale import GrampsLocale
 from gramps.gen.utils.resourcepath import ResourcePath
 
 from ..const import MIME_TYPES, REPORT_DEFAULTS, REPORT_FILTERS
@@ -328,7 +327,11 @@ def cl_report_new(
     ):
         clr.option_class.handler.doc.set_css_filename(clr.css_filename)
     my_report = report_class(database, clr.option_class, User())
-    my_report.set_locale(language or GrampsLocale.DEFAULT_TRANSLATION_STR)
+    if language:
+        # Only reached for reports that have no "trans" option. Reports that do
+        # have one have already applied the language in their constructor, and
+        # setting it here would discard the option value chosen by the user.
+        my_report.set_locale(language)
     my_report.doc.init()
     my_report.begin_report()
     my_report.write_report()
@@ -368,6 +371,18 @@ def run_report(
             report_options["of"] = os.path.join(report_path, file_name)
             report_profile = get_report_profile(db_handle, plugin_manager, report_data)
             validate_options(report_profile, report_options, allow_file=allow_file)
+            if (
+                language
+                and "trans" in report_profile["options_dict"]
+                and language in glocale.get_language_dict().values()
+            ):
+                # Apply the language via the report's own localization option,
+                # which is evaluated in the report's constructor. Reports build
+                # locale-dependent objects there, so setting the locale
+                # afterwards is not enough. Languages the option does not accept
+                # are left to set_locale, which handles e.g. regional variants.
+                report_options["trans"] = language
+                language = None
             module = plugin_manager.load_plugin(report_data)
             option_class = getattr(module, report_data.optionclass)
             report_class = getattr(module, report_data.reportclass)

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/resources/base.py

@@ -56,7 +56,7 @@ from .delete import delete_object, remove_deleted_from_search_indices
 from .emit import GrampsJSONEncoder
 from .filters import apply_filter
 from .match import match_dates
-from .sort import sort_objects
+from .sort import sort_handles_by_raw_data, sort_objects
 from .util import (
     abort_with_message,
     add_object,
@@ -614,21 +614,66 @@ class GrampsObjectsResource(GrampsObjectResourceHelper, Resource):
                     pass
             return self.response(200, objects, args, total_items=len(objects))
 
+        query_method = self.db_handle.method("get_%s_handles", self.gramps_class_name)
+        assert query_method is not None  # type checker
+        # for all objects except events, repos, and notes, Gramps supports
+        # a database-backed default sort order. Use that if no sort order
+        # requested.
+        sort_by_default = self.gramps_class_name not in ["Event", "Repository", "Note"]
+
+        # if a single page is requested and no filtering is needed, try to sort
+        # the handles without loading all objects to memory
+        if args["page"] > 0 and not (
+            "filter" in args
+            or "rules" in args
+            or "gql" in args
+            or "oql" in args
+            or args["dates"]
+            or (self.gramps_class_name == "Media" and args.get("filemissing"))
+        ):
+            if "sort" in args:
+                # the database-backed default sort order is expensive and
+                # not needed here since the requested sort order replaces it
+                sorted_handles = sort_handles_by_raw_data(
+                    self.db_handle,
+                    self.gramps_class_name,
+                    query_method(),
+                    args["sort"],
+                    locale=locale,
+                )
+            elif sort_by_default:
+                sorted_handles = query_method(sort_handles=True, locale=locale)
+            else:
+                sorted_handles = query_method()
+            if sorted_handles is not None:
+                offset = (args["page"] - 1) * args["pagesize"]
+                page_handles = sorted_handles[offset : offset + args["pagesize"]]
+                objects = []
+                for handle in page_handles:
+                    try:
+                        obj = self.get_object_from_handle(handle)
+                    except HandleError:
+                        # object was deleted after the handles were fetched
+                        continue
+                    if obj is None:
+                        # object is no longer included by a proxy database
+                        continue
+                    objects.append(self.full_object(obj, args, locale=locale))
+                return self.response(
+                    200, objects, args, total_items=len(sorted_handles)
+                )
+
+        if sort_by_default:
+            handles = query_method(sort_handles=True, locale=locale)
+        else:
+            handles = query_method()
+
         # load all objects to memory
         objects_name = GRAMPS_OBJECT_PLURAL[self.gramps_class_name]
         iter_objects_method = self.db_handle.method("iter_%s", objects_name)
         assert iter_objects_method is not None  # type checker
         objects = list(iter_objects_method())
 
-        # for all objects except events, repos, and notes, Gramps supports
-        # a database-backed default sort order. Use that if no sort order
-        # requested.
-        query_method = self.db_handle.method("get_%s_handles", self.gramps_class_name)
-        assert query_method is not None  # type checker
-        if self.gramps_class_name in ["Event", "Repository", "Note"]:
-            handles = query_method()
-        else:
-            handles = query_method(sort_handles=True, locale=locale)
         handle_index = {handle: index for index, handle in enumerate(handles)}
         # sort objects by the sorted handle order
         objects = sorted(

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/resources/filters.py

@@ -22,6 +22,7 @@
 
 import inspect
 import json
+import re
 from collections import defaultdict
 from collections.abc import Callable
 from typing import Any
@@ -29,6 +30,7 @@ from typing import Any
 import gramps.gen.filters as filters
 from flask import Response, abort, current_app
 from gramps.gen.db.base import DbReadBase
+from gramps.gen.errors import FilterError
 from gramps.gen.filters import GenericFilter
 from gramps.gen.filters.rules import Rule
 from gramps.gen.lib import Media, Person
@@ -99,6 +101,23 @@ _ADDITIONAL_RULES: dict[str, list[type[Rule]]] = {
     "Media": [IsReferencedByObjectType],
 }
 
+# Rules shipped by Gramps that fail on every object of their namespace
+_EXCLUDED_RULES: dict[str, set[str]] = {
+    "Repository": {"HasAttribute"},  # Repository has no attribute_list
+}
+
+# Errors raised by Gramps rules when evaluated with invalid values
+# (e.g. unparsable dates or integers, invalid regular expressions)
+_RULE_VALUE_ERRORS = (
+    FilterError,
+    ValueError,
+    TypeError,
+    AttributeError,
+    IndexError,
+    KeyError,
+    re.error,
+)
+
 _RULE_CLASS_CACHE: dict[str, dict[str, type[Rule]]] = {}
 
 # Maps (parent_namespace, sub_namespace) to a function (db, obj) -> [sub_handle, ...]
@@ -130,7 +149,7 @@ def get_rule_map(namespace: str) -> dict[str, type[Rule]]:
         if mod is None:
             _RULE_CLASS_CACHE[namespace] = {}
         else:
-            seen: set[str] = set()
+            seen: set[str] = set(_EXCLUDED_RULES.get(namespace, set()))
             result: dict[str, type[Rule]] = {}
             for _, cls in inspect.getmembers(mod, inspect.isclass):
                 if (
@@ -211,16 +230,61 @@ def get_custom_filters(args: dict[str, Any], namespace: str) -> list[dict[str, A
     return filter_list
 
 
-def _build_rule_instance(rule_parms: dict[str, Any], namespace: str) -> Rule:
-    """Instantiate a single rule from its parameter dict."""
-    rule_class = get_rule_map(namespace).get(rule_parms["name"])
+def _validate_rule_parms(
+    rule_parms: dict[str, Any], namespace: str
+) -> tuple[type[Rule], list[str]]:
+    """Return the rule class and its values as strings, aborting on invalid input.
+
+    Gramps rules expect string values, one per label. The number of values is not
+    enforced, as existing clients rely on both directions. Like Gramps when loading
+    saved filters, extra values are ignored. Missing values are passed through:
+    some rules supply defaults (e.g. HasNote), the others fail during evaluation,
+    which returns 422.
+    """
+    name = rule_parms["name"]
+    rule_class = get_rule_map(namespace).get(name)
     if rule_class is None:
         abort(404)
     assert rule_class is not None
-    return rule_class(
-        rule_parms.get("values", []),
-        use_regex=rule_parms.get("regex", False),
-    )
+    values = rule_parms.get("values", [])
+    str_values = []
+    for value in values:
+        if isinstance(value, bool):
+            str_values.append("1" if value else "0")
+        elif isinstance(value, (str, int, float)):
+            str_values.append(str(value))
+        else:
+            abort_with_message(
+                422, f"Rule {name} values must be strings, numbers or booleans"
+            )
+    return rule_class, str_values[: len(rule_class.labels)]
+
+
+def _validate_filter_parms(
+    filter_parms: dict[str, Any], namespace: str, depth: int = 0
+) -> None:
+    """Validate a (possibly nested) filter spec before evaluating it."""
+    if depth >= MAX_FILTER_DEPTH:
+        abort_with_message(400, "Filter nesting depth exceeded")
+    for item in filter_parms["rules"]:
+        if "name" in item:
+            _validate_rule_parms(item, namespace)
+            continue
+        sub_namespace = item.get("namespace", namespace)
+        if (
+            sub_namespace != namespace
+            and (namespace, sub_namespace) not in _NAMESPACE_BRIDGES
+        ):
+            abort_with_message(
+                400, f"Unsupported namespace bridge: {namespace} → {sub_namespace}"
+            )
+        _validate_filter_parms(item, sub_namespace, depth + 1)
+
+
+def _build_rule_instance(rule_parms: dict[str, Any], namespace: str) -> Rule:
+    """Instantiate a single rule from its parameter dict."""
+    rule_class, values = _validate_rule_parms(rule_parms, namespace)
+    return rule_class(values, use_regex=rule_parms.get("regex", False))
 
 
 def _apply_filter_parms(
@@ -243,7 +307,12 @@ def _apply_filter_parms(
         if "name" in item:
             single = filters.GenericFilterFactory(namespace)()
             single.add_rule(_build_rule_instance(item, namespace))
-            result_sets.append(set(single.apply(db_handle, id_list=handles)))
+            try:
+                result_sets.append(set(single.apply(db_handle, id_list=handles)))
+            except _RULE_VALUE_ERRORS as exc:
+                abort_with_message(
+                    422, f"Rule {item['name']} could not be evaluated: {exc}"
+                )
         elif item.get("namespace", namespace) != namespace:
             sub_namespace = item["namespace"]
             bridge = _NAMESPACE_BRIDGES.get((namespace, sub_namespace))
@@ -316,7 +385,13 @@ def apply_filter(
     if args.get("filter"):
         for filter_class in filters.CustomFilters.get_filters(namespace):
             if args["filter"] == filter_class.get_name():
-                return filter_class.apply(db_handle, id_list=handles)
+                try:
+                    return filter_class.apply(db_handle, id_list=handles)
+                except _RULE_VALUE_ERRORS as exc:
+                    abort_with_message(
+                        422,
+                        f"Filter {args['filter']} could not be evaluated: {exc}",
+                    )
         abort(404)
 
     try:
@@ -325,6 +400,7 @@ def apply_filter(
         abort_with_message(400, "Error decoding JSON")
     except ValidationError:
         abort_with_message(422, "Filter does not adhere to schema")
+    _validate_filter_parms(filter_parms, namespace)
 
     if handles is None:
         query_method = db_handle.method("get_%s_handles", namespace)

{gramps_webapi-3.22.0 → gramps_webapi-3.22.2}/gramps_webapi/api/resources/import_media.py

@@ -54,7 +54,11 @@ def get_max_upload_bytes(free_bytes: int) -> int:
 
 
 def write_upload_to_file(file_path: str, max_bytes: int) -> None:
-    """Stream the request body to a file, aborting if it exceeds `max_bytes`."""
+    """Stream the request body to a file, aborting if it exceeds `max_bytes`.
+
+    Also aborts if the body size does not match the declared Content-Length
+    (e.g. a truncated upload). The caller is responsible for removing the file.
+    """
     request_stream = request.stream
     size = 0
     with open(file_path, "w+b") as ftmp:
@@ -67,6 +71,11 @@ def write_upload_to_file(file_path: str, max_bytes: int) -> None:
             if size > max_bytes:
                 abort_with_message(413, "Uploaded archive is too large")
             ftmp.write(chunk)
+    expected = request.content_length
+    if expected is not None and size and size != expected:
+        abort_with_message(
+            400, f"Upload incomplete: received {size} of {expected} bytes"
+        )
 
 
 class MediaUploadZipResource(ProtectedResource):