gplugins 2.0.1__tar.gz → 2.1.0__tar.gz

{gplugins-2.0.1 → gplugins-2.1.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gplugins
-Version: 2.0.1
+Version: 2.1.0
 Summary: gdsfactory plugins
 Keywords: python
 Author-email: gdsfactory <contact@gdsfactory.com>
@@ -11,11 +11,11 @@ Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3.13
 Classifier: Operating System :: OS Independent
 License-File: LICENSE
-Requires-Dist: gdsfactory>=9.15.1
+Requires-Dist: gdsfactory>=9.29.1
 Requires-Dist: pint
 Requires-Dist: tqdm
-Requires-Dist: numpy==2.2
-Requires-Dist: xarray==2025.7.1
+Requires-Dist: numpy>=2.0,<3
+Requires-Dist: xarray==2026.4.0
 Requires-Dist: hypothesis ; extra == "dev"
 Requires-Dist: numba ; extra == "dev"
 Requires-Dist: pre-commit ; extra == "dev"
@@ -24,12 +24,12 @@ Requires-Dist: pytest ; extra == "dev"
 Requires-Dist: pytest-cov ; extra == "dev"
 Requires-Dist: pytest_regressions ; extra == "dev"
 Requires-Dist: devsim ; extra == "devsim"
-Requires-Dist: pyvista<=0.46.0 ; extra == "devsim"
-Requires-Dist: tidy3d>=2.8.2,<2.9 ; extra == "devsim"
+Requires-Dist: pyvista<=0.48.2 ; extra == "devsim"
+Requires-Dist: tidy3d~=2.11.1 ; extra == "devsim"
 Requires-Dist: jupytext ; extra == "docs"
 Requires-Dist: matplotlib ; extra == "docs"
-Requires-Dist: jupyter-book~=1.0 ; extra == "docs"
-Requires-Dist: pyvista[all]<=0.46.0 ; extra == "docs"
+Requires-Dist: jupyter-book>=1,<3 ; extra == "docs"
+Requires-Dist: pyvista[all]<=0.48.2 ; extra == "docs"
 Requires-Dist: bokeh ; extra == "docs"
 Requires-Dist: scikit-learn ; extra == "docs"
 Requires-Dist: femwell~=0.1.11 ; extra == "femwell"
@@ -39,29 +39,30 @@ Requires-Dist: fastapi ; extra == "gfviz"
 Requires-Dist: shapely ; extra == "gfviz"
 Requires-Dist: natsort ; extra == "gfviz"
 Requires-Dist: klayout ; extra == "klayout"
-Requires-Dist: pyvis<=0.3.1 ; extra == "klayout"
+Requires-Dist: pyvis<=0.3.2 ; extra == "klayout"
 Requires-Dist: vlsir ; extra == "klayout"
 Requires-Dist: vlsirtools ; extra == "klayout"
 Requires-Dist: gitpython ; extra == "klayout"
-Requires-Dist: luminescent>=0.2.12,<0.4.0 ; extra == "luminescent"
+Requires-Dist: luminescent>=0.2.12,<4.1.0 ; extra == "luminescent"
 Requires-Dist: sortedcontainers ; extra == "luminescent"
 Requires-Dist: mypy ; extra == "maintainer"
 Requires-Dist: tbump ; extra == "maintainer"
 Requires-Dist: towncrier ; extra == "maintainer"
-Requires-Dist: meow-sim>=0.14.1,<0.15 ; extra == "meow"
-Requires-Dist: sax~=0.16.3 ; extra == "meow"
-Requires-Dist: tidy3d>=2.8.2,<2.9 ; extra == "meow"
+Requires-Dist: meow-sim>=0.15 ; extra == "meow"
+Requires-Dist: sax~=0.17.0 ; extra == "meow"
+Requires-Dist: tidy3d~=2.11.1 ; extra == "meow"
 Requires-Dist: shapely ; extra == "meshwell"
 Requires-Dist: meshwell~=2.1.1 ; extra == "meshwell"
 Requires-Dist: bokeh ; extra == "path-length-analysis"
 Requires-Dist: numba ; extra == "path-length-analysis"
 Requires-Dist: shapely ; extra == "path-length-analysis"
-Requires-Dist: sax~=0.16.3 ; extra == "sax"
+Requires-Dist: sax~=0.17.0 ; extra == "sax"
 Requires-Dist: bokeh ; extra == "schematic"
 Requires-Dist: ipywidgets ; extra == "schematic"
 Requires-Dist: natsort ; extra == "schematic"
-Requires-Dist: tidy3d>=2.8.2,<2.9 ; extra == "tidy3d"
+Requires-Dist: tidy3d~=2.11.1 ; extra == "tidy3d"
 Requires-Dist: gdstk ; extra == "tidy3d"
+Requires-Dist: pytz ; extra == "tidy3d"
 Requires-Dist: vlsir ; extra == "vlsir"
 Requires-Dist: vlsirtools ; extra == "vlsir"
 Provides-Extra: dev
@@ -80,7 +81,7 @@ Provides-Extra: schematic
 Provides-Extra: tidy3d
 Provides-Extra: vlsir
 
-# gplugins 2.0.1
+# gplugins 2.1.0
 
 [![docs](https://github.com/gdsfactory/gplugins/actions/workflows/pages.yml/badge.svg)](https://gdsfactory.github.io/gplugins/)
 [![PyPI](https://img.shields.io/pypi/v/gplugins)](https://pypi.org/project/gplugins/)
@@ -160,13 +161,14 @@ curl -LsSf https://astral.sh/uv/install.sh | sh
 powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex"
 ```
 
--Then you can install GDSFactory with:
+-Then you can install gplugins and its dependency groups with:
 
 ```bash
 uv venv --python 3.12
-uv sync --extra docs --extra dev
+uv sync --extra docs --extra dev # --extra tidy3d --extra femwell ...
 ```
 
+
 ## Getting started
 
 - [Read the gplugins docs](https://gdsfactory.github.io/gplugins/)

{gplugins-2.0.1 → gplugins-2.1.0}/README.md

@@ -1,4 +1,4 @@
-# gplugins 2.0.1
+# gplugins 2.1.0
 
 [![docs](https://github.com/gdsfactory/gplugins/actions/workflows/pages.yml/badge.svg)](https://gdsfactory.github.io/gplugins/)
 [![PyPI](https://img.shields.io/pypi/v/gplugins)](https://pypi.org/project/gplugins/)
@@ -78,13 +78,14 @@ curl -LsSf https://astral.sh/uv/install.sh | sh
 powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex"
 ```
 
--Then you can install GDSFactory with:
+-Then you can install gplugins and its dependency groups with:
 
 ```bash
 uv venv --python 3.12
-uv sync --extra docs --extra dev
+uv sync --extra docs --extra dev # --extra tidy3d --extra femwell ...
 ```
 
+
 ## Getting started
 
 - [Read the gplugins docs](https://gdsfactory.github.io/gplugins/)

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/__init__.py

@@ -1,6 +1,6 @@
 """gplugins - gdsfactory plugins."""
 
-__version__ = "2.0.1"
+__version__ = "2.1.0"
 
 import pathlib
 

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/common/utils/get_sparameters_path.py

@@ -1,9 +1,9 @@
 from __future__ import annotations
 
 import hashlib
-import pathlib
 from functools import partial
 from pathlib import Path
+from tempfile import TemporaryDirectory
 from typing import Any
 
 import gdsfactory as gf
@@ -21,9 +21,9 @@ def get_kwargs_hash(**kwargs: Any) -> str:
 
 
 def get_component_hash(component: gf.Component) -> str:
-    gdspath = pathlib.Path(component.write_gds())
-    h = hashlib.md5(gdspath.read_bytes()).hexdigest()
-    gdspath.unlink()
+    with TemporaryDirectory() as tmpdir:
+        gdspath = Path(component.write_gds(gdsdir=tmpdir, no_empty_cells=True, with_metadata=False))
+        h = hashlib.md5(gdspath.read_bytes()).hexdigest()
     return h
 
 
@@ -42,10 +42,10 @@ def _get_sparameters_path(
 
     """
     dirpath = dirpath or GDSDIR_TEMP / "sparameters"
-    dirpath = pathlib.Path(dirpath)
+    dirpath = Path(dirpath)
     component = gf.get_component(component)
 
-    dirpath = pathlib.Path(dirpath)
+    dirpath = Path(dirpath)
     dirpath = (
         dirpath / component.name
         if hasattr(component, "function_name")

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/gmeep/get_meep_geometry.py

@@ -3,15 +3,11 @@ from __future__ import annotations
 import gdsfactory as gf
 import meep as mp
 import numpy as np
-from kfactory import LayerEnum
-from typing import cast
-import shapely
-from gdsfactory.pdk import get_layer_stack, get_layer, get_layer_name
-from gdsfactory.technology import LayerStack
-from gdsfactory.technology import DerivedLayer, LayerStack, LayerViews, LogicalLayer
+
+from gdsfactory.pdk import get_layer_stack, get_layer
+from gdsfactory.technology import DerivedLayer, LayerStack, LogicalLayer
 from gdsfactory.typings import ComponentSpec, CrossSectionSpec, LayerSpecs
 
-from gplugins.common.utils.parse_layer_stack import order_layer_stack
 from gplugins.gmeep.get_material import get_material
 
 
@@ -20,7 +16,6 @@ def get_meep_geometry_from_component(
     layer_stack: LayerStack | None = None,
     material_name_to_meep: dict[str, str | float] | None = None,
     wavelength: float = 1.55,
-    is_3d: bool = False,
     dispersive: bool = False,
     exclude_layers: LayerSpecs | None = None,
     **kwargs,
@@ -32,28 +27,22 @@ def get_meep_geometry_from_component(
         layer_stack: for material layers.
         material_name_to_meep: maps layer_stack name to meep material name.
         wavelength: in um.
-        is_3d: renders in 3D.
         dispersive: add dispersion.
+        exclude_layers: these layers are ignored during geometry creation.
         kwargs: settings.
     """
     component = gf.get_component(component=component, **kwargs)
-    polygons_per_layer = component.get_polygons_points(merge=True)
-
-
     layer_stack = layer_stack or get_layer_stack()
-
-    layer_to_thickness = layer_stack.get_layer_to_thickness()
-    layer_to_material = layer_stack.get_layer_to_material()
-    layer_to_zmin = layer_stack.get_layer_to_zmin()
-    layer_to_sidewall_angle = layer_stack.get_layer_to_sidewall_angle()
     component_with_booleans = layer_stack.get_component_with_derived_layers(component)
+    polygons_per_layer = component_with_booleans.get_polygons_points(merge=True)
 
     geometry = []
-    exclude_layers = exclude_layers or []
-    layer_to_polygons = component_with_booleans.get_polygons_points()
-
-    # ordered_layer_stack_keys = order_layer_stack(layer_stack)[::-1]
+    if exclude_layers is None:
+        exclude_layers = []
+    else:
+        exclude_layers = [get_layer(l) for l in exclude_layers]
 
+    # TODO: currently ignores width_to_z, z_to_bias, bias, mesh_order of level
     for level in layer_stack.layers.values():
         layer = level.layer
 
@@ -66,45 +55,31 @@ def get_meep_geometry_from_component(
             layer_tuple = layer
         else:
             raise ValueError(f"Layer {layer!r} is not a DerivedLayer, LogicalLayer, or tuple")
-
         layer_index = int(get_layer(layer_tuple))
 
-        if layer_index in exclude_layers:
-            continue
-
-        if layer_index not in polygons_per_layer:
+        if layer_index in exclude_layers or layer_index not in polygons_per_layer:
             continue
 
-        zmin = level.zmin
-        zmin_um = layer_to_zmin[layer] if is_3d else 0
-        if zmin is not None:
-            has_polygons = True
-            polygons = polygons_per_layer[layer_index]
-            height = level.thickness
-            for polygon in polygons:
-                p = shapely.geometry.Polygon(polygon)
-                vertices = [mp.Vector3(p[0], p[1], zmin_um) for p in polygon]
-                material_name = layer_to_material[layer]
-
-                if material_name:
-                    material = get_material(
-                        name=material_name,
-                        dispersive=dispersive,
-                        material_name_to_meep=material_name_to_meep,
-                        wavelength=wavelength,
-                    )
-                    geometry.append(
-                        mp.Prism(
-                            vertices=vertices,
-                            height=height,
-                            sidewall_angle=np.pi * layer_to_sidewall_angle[layer] / 180
-                            if is_3d
-                            else 0,
-                            material=material,
-                            # center=center
-                        )
+        sw_angle = np.pi * level.sidewall_angle / 180
+        for polygon in polygons_per_layer[layer_index]:
+            vertices = [mp.Vector3(p[0], p[1], level.zmin) for p in polygon]
+            material_name = level.material
+
+            if material_name:
+                material = get_material(
+                    name=material_name,
+                    dispersive=dispersive,
+                    material_name_to_meep=material_name_to_meep,
+                    wavelength=wavelength,
+                )
+                geometry.append(
+                    mp.Prism(
+                        vertices=vertices,
+                        height=level.thickness,
+                        sidewall_angle=sw_angle,    # TODO: libctl has issues with slanted prisms -> incorrect geometry
+                        material=material,
                     )
-
+                )
     return geometry
 
 

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/gmeep/get_simulation.py

@@ -4,7 +4,7 @@ from __future__ import annotations
 
 import inspect
 import warnings
-from typing import Any
+from typing import Any, Literal
 
 import gdsfactory as gf
 import meep as mp
@@ -12,6 +12,7 @@ import numpy as np
 from gdsfactory.component import Component
 from gdsfactory.pdk import get_layer_stack
 from gdsfactory.technology import LayerStack
+from gdsfactory.typings import LayerSpecs, Float3
 
 from gplugins.common.base_models.component import move_polar_rad_copy
 from gplugins.gmeep.get_material import get_material
@@ -25,6 +26,19 @@ sig = inspect.signature(mp.Simulation)
 settings_meep = set(sig.parameters.keys())
 
 
+def is_point_in_plane(
+        test_point: Float3,
+        plane_support: Float3,
+        plane_normal: Float3,
+        tolerance: float = 1e-6,        # 1 pm for coordinates in µm
+):
+    a, b, c = plane_normal
+    xt, yt, zt = test_point
+    x0, y0, z0 = plane_support
+    distance = (a*(xt-x0) + b*(yt-y0) + c*(zt-z0)) / np.linalg.norm(plane_normal)
+    return bool(abs(distance) <= tolerance)
+
+
 def get_simulation(
     component: Component,
     resolution: int = 30,
@@ -35,6 +49,8 @@ def get_simulation(
     tpml: float = 1.5,
     clad_material: str = "SiO2",
     is_3d: bool = False,
+    normal_2d: Literal['X', 'Y', 'Z'] = 'Z',
+    point_2d: tuple[float, float, float] = (0, 0, 0),
     wavelength_start: float = 1.5,
     wavelength_stop: float = 1.6,
     wavelength_points: int = 50,
@@ -48,6 +64,7 @@ def get_simulation(
     dispersive: bool = False,
     material_name_to_meep: dict[str, str | float] | None = None,
     continuous_source: bool = False,
+    exclude_layers: LayerSpecs | None = None,
     **settings,
 ) -> dict[str, Any]:
     r"""Returns Simulation dict from gdsfactory Component.
@@ -103,6 +120,8 @@ def get_simulation(
         tpml: PML thickness (um).
         clad_material: material for cladding.
         is_3d: if True runs in 3D.
+        normal_2d: specified normal of 2D simulation plane
+        point_2d: specifies support point for 2D simulation plane
         wavelength_start: wavelength min (um).
         wavelength_stop: wavelength max (um).
         wavelength_points: wavelength steps.
@@ -117,6 +136,7 @@ def get_simulation(
         material_name_to_meep: map layer_stack names with meep material database name
             or refractive index. dispersive materials have a wavelength dependent index.
         continuous_source: if True, defines a continuous source at (wavelength_start + wavelength_stop)/2 instead of the ramped source
+        exclude_layers: these layers will be ignored in geometry generation.
 
     Keyword Args:
         settings: extra simulation settings (resolution, symmetries, etc.)
@@ -138,23 +158,19 @@ def get_simulation(
     for setting in settings:
         if setting not in settings_meep:
             raise ValueError(f"{setting!r} not in {sorted(settings_meep)}")
+    normal_2d = normal_2d.upper()
+    normal_vec = {'X': (1, 0, 0), 'Y': (0, 1, 0), 'Z': (0, 0, 1)}[normal_2d]
 
     layer_stack = layer_stack or get_layer_stack()
     layer_to_thickness = layer_stack.get_layer_to_thickness()
 
-    dummy_component = gf.Component()
-    component_ref = dummy_component << component
-    component_ref.x = 0
-    component_ref.y = 0
-
     wavelength = (wavelength_start + wavelength_stop) / 2
-
     wavelengths = np.linspace(wavelength_start, wavelength_stop, wavelength_points)
-    port_names = [port.name for port in component_ref.ports]
 
+    port_names = [port.name for port in component.ports]
     if port_source_name not in port_names:
         warnings.warn(f"port_source_name={port_source_name!r} not in {port_names}")
-        port_source = component_ref.ports[0]
+        port_source = component.ports[0]
         port_source_name = port_source.name
         warnings.warn(f"Selecting port_source_name={port_source_name!r} instead.")
 
@@ -162,14 +178,7 @@ def get_simulation(
         f"component needs to be a gf.Component, got Type {type(component)}"
     )
 
-    component_extended = (
-        gf.c.extend_ports(
-            component=component, length=extend_ports_length, centered=True
-        )
-        if extend_ports_length
-        else component
-    )
-
+    component_extended = gf.c.extend_ports(component=component, length=extend_ports_length)
     component_extended = component_extended.copy()
     component_extended.flatten()
 
@@ -188,12 +197,12 @@ def get_simulation(
     t_core = sum(
         layers_thickness
     )  # This isn't exactly what we want but I think it's better than max
-    cell_thickness = tpml + zmargin_bot + t_core + zmargin_top + tpml if is_3d else 0
+    cell_thickness = tpml + zmargin_bot + t_core + zmargin_top + tpml
 
     cell_size = mp.Vector3(
-        component.xsize + 2 * tpml,
-        component.ysize + 2 * tpml,
-        cell_thickness,
+        0 if normal_2d == 'X' and not is_3d else component.xsize + 2 * tpml,
+        0 if normal_2d == 'Y' and not is_3d else component.ysize + 2 * tpml,
+        0 if normal_2d == 'Z' and not is_3d else cell_thickness,
     )
 
     geometry = get_meep_geometry_from_component(
@@ -201,8 +210,8 @@ def get_simulation(
         layer_stack=layer_stack,
         material_name_to_meep=material_name_to_meep,
         wavelength=wavelength,
-        is_3d=is_3d,
         dispersive=dispersive,
+        exclude_layers=exclude_layers,
     )
 
     freqs = 1 / wavelengths
@@ -210,19 +219,23 @@ def get_simulation(
     frequency_width = dfcen * fcen
 
     # Add source
-    port = component_ref.ports[port_source_name]
+    port = component.ports[port_source_name]
     angle_rad = np.radians(port.orientation)
     width = port.width + 2 * port_margin
     size_x = width * abs(np.sin(angle_rad))
     size_y = width * abs(np.cos(angle_rad))
     size_x = 0 if size_x < 0.001 else size_x
     size_y = 0 if size_y < 0.001 else size_y
-    size_z = cell_thickness - 2 * tpml if is_3d else 20
-    size = [size_x, size_y, size_z]
+    size_z = cell_thickness - 2 * tpml
+    size = [
+        0 if normal_2d == 'X' and not is_3d else size_x,
+        0 if normal_2d == 'Y' and not is_3d else size_y,
+        0 if normal_2d == 'Z' and not is_3d else size_z,
+    ]
     xy_shifted = move_polar_rad_copy(
         np.array(port.center), angle=angle_rad, length=port_source_offset
     )
-    center = xy_shifted.tolist() + [0]  # (x, y, z=0)
+    center = xy_shifted.round(6).tolist() + [0]  # (x, y, z=0)
 
     if np.isclose(port.orientation, 0):
         direction = mp.X
@@ -238,6 +251,11 @@ def get_simulation(
             "not 0, 90, 180, 270 degrees"
         )
 
+    if not (is_3d or is_point_in_plane(center, point_2d, normal_vec)):
+        raise ValueError(
+            f"Source '{port_source_name}' (center={center}) is not in {normal_2d}-normal 2D simulation domain around {point_2d}."
+        )
+
     sources = [
         mp.EigenModeSource(
             src=mp.ContinuousSource(fcen)
@@ -246,15 +264,21 @@ def get_simulation(
             size=size,
             center=center,
             eig_band=port_source_mode + 1,
-            eig_parity=mp.NO_PARITY if is_3d else mp.EVEN_Y + mp.ODD_Z,
+            eig_parity=mp.NO_PARITY,
             eig_match_freq=True,
             eig_kpoint=-1 * mp.Vector3(x=1).rotate(mp.Vector3(z=1), angle_rad),
             direction=direction,
         )
     ]
 
+    sim_center = mp.Vector3(
+        point_2d[0] if normal_2d == 'X' and not is_3d else component.x,
+        point_2d[1] if normal_2d == 'Y' and not is_3d else component.y,
+        point_2d[2] if normal_2d == 'Z' and not is_3d else 0,
+    )
     sim = mp.Simulation(
         cell_size=cell_size,
+        geometry_center=sim_center,
         boundary_layers=[mp.PML(tpml)],
         sources=sources,
         geometry=geometry,
@@ -269,7 +293,7 @@ def get_simulation(
 
     # Add port monitors dict
     monitors = {}
-    for port in component_ref.ports:
+    for port in component.ports:
         port_name = port.name
         angle_rad = np.radians(port.orientation)
         width = port.width + 2 * port_margin
@@ -277,8 +301,11 @@ def get_simulation(
         size_y = width * abs(np.cos(angle_rad))
         size_x = 0 if size_x < 0.001 else size_x
         size_y = 0 if size_y < 0.001 else size_y
-        size = mp.Vector3(size_x, size_y, size_z)
-        size = [size_x, size_y, size_z]
+        size = mp.Vector3(
+            0 if normal_2d == 'X' and not is_3d else size_x,
+            0 if normal_2d == 'Y' and not is_3d else size_y,
+            0 if normal_2d == 'Z' and not is_3d else size_z,
+        )
 
         # if monitor has a source move monitor inwards
         length = (
@@ -289,10 +316,14 @@ def get_simulation(
         xy_shifted = move_polar_rad_copy(
             np.array(port.center), angle=angle_rad, length=length
         )
-        center = xy_shifted.tolist() + [0]  # (x, y, z=0)
-        m = sim.add_mode_monitor(freqs, mp.ModeRegion(center=center, size=size))
-        m.z = 0
-        monitors[port_name] = m
+        center = xy_shifted.round(6).tolist() + [0]  # (x, y, z=0)
+        if is_3d or is_point_in_plane(center, point_2d, normal_vec):
+            m = sim.add_mode_monitor(freqs, mp.ModeRegion(center=center, size=size))
+            m.z = 0
+            monitors[port_name] = m
+        else:
+            warnings.warn(f"Monitor at port '{port_name}' ignored, "
+                          f"because it is not in the {normal_2d}-normal 2D simulation domain around {point_2d}.")
     return dict(
         sim=sim,
         cell_size=cell_size,

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/gmeep/test_materials.py

@@ -3,6 +3,8 @@ import gdsfactory as gf
 from gplugins.common.utils import optical_constants
 from gplugins.gmeep.write_sparameters_meep import write_sparameters_meep
 
+gf.gpdk.PDK.activate()
+
 
 def test_materials_override() -> None:
     """Checks that materials are properly overridden if index is provided."""

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/gmeep/test_write_sparameters_meep.py

@@ -8,6 +8,7 @@ import numpy as np
 import gplugins as sim
 import gplugins.gmeep as gm
 
+gf.gpdk.PDK.activate()
 simulation_settings = dict(resolution=20, is_3d=False)
 
 

{gplugins-2.0.1 → gplugins-2.1.0}/gplugins/gmeep/write_sparameters_meep.py

@@ -19,7 +19,7 @@ from gdsfactory.component import Component
 from gdsfactory.pdk import get_layer_stack
 from gdsfactory.serialization import clean_value_json
 from gdsfactory.technology import LayerStack
-from gdsfactory.typings import ComponentSpec, PathType, Port, PortSymmetries, LayerSpec
+from gdsfactory.typings import ComponentSpec, PathType, Ports, PortSymmetries, LayerSpec
 from tqdm.auto import tqdm
 
 from gplugins.common.utils import port_symmetries
@@ -52,14 +52,15 @@ def remove_simulation_kwargs(d: dict[str, Any]) -> dict[str, Any]:
 
 
 def parse_port_eigenmode_coeff(
-    port_name: str, ports: dict[str, Port], sim_dict: dict, port_mode: int = 0
+    port_name: str, ports: Ports, sim_dict: dict, port_mode: int = 0
 ):
     """Returns the coefficients relative to whether the wavevector is entering or exiting simulation.
 
     Args:
-        port_index: index of port.
+        port_name: name of port.
         ports: component_ref.ports.
         sim_dict: simulation dict.
+        port_mode: mode to get coefficient for
 
     """
     if port_name not in ports:
@@ -285,6 +286,10 @@ def write_sparameters_meep(
         if setting not in settings_get_simulation:
             raise ValueError(f"{setting!r} not in {settings_get_simulation}")
 
+    port_names = [port.name for port in component.ports]
+    port_source_names = port_source_names or port_names
+    port_source_modes = port_source_modes or {key: [0] for key in port_source_names}
+    port_modes = port_modes or [0]
     port_symmetries = port_symmetries or {}
 
     xmargin_left = xmargin_left or xmargin
@@ -297,6 +302,9 @@ def write_sparameters_meep(
     zmargin_bot = zmargin_bot or zmargin
 
     sim_settings = dict(
+        port_source_names=port_source_names,
+        port_source_modes=port_source_modes,
+        port_modes=port_modes,
         resolution=resolution,
         port_symmetries=port_symmetries,
         wavelength_start=wavelength_start,
@@ -348,14 +356,6 @@ def write_sparameters_meep(
         right=xmargin_right,
     )
 
-    dummy = Component()
-    component_ref = dummy << component
-    ports = component_ref.ports
-    port_names = [port.name for port in ports]
-    port_source_names = port_source_names or port_names
-    port_source_modes = port_source_modes or {key: [0] for key in port_source_names}
-    port_modes = port_modes or [0]
-
     num_sims = len(port_source_names) - len(port_symmetries)
 
     # set verbosity
@@ -384,7 +384,7 @@ def write_sparameters_meep(
             sim.plot2D(
                 output_plane=mp.Volume(
                     size=mp.Vector3(sim.cell_size.x, sim.cell_size.y, 0),
-                    center=mp.Vector3(0, 0, z),
+                    center=mp.Vector3(component.x, component.y, z),
                 ),
                 **plot_args,
             )
@@ -406,7 +406,6 @@ def write_sparameters_meep(
         port_source_name: str,
         component: Component,
         port_symmetries: PortSymmetries | None = port_symmetries,
-        port_names: list[str] = port_names,
         port_source_mode: int = 0,
         wavelength_start: float = wavelength_start,
         wavelength_stop: float = wavelength_stop,
@@ -438,11 +437,8 @@ def write_sparameters_meep(
         )
 
         sim = sim_dict["sim"]
-        # freqs = sim_dict["freqs"]
-        # wavelengths = 1 / freqs
-        # print(sim.resolution)
 
-        # Terminate when the area in the whole area decayed
+        # Terminate when the energy in the whole area decayed
         termination = [mp.stop_when_energy_decayed(dt=50, decay_by=decay_by)]
 
         if animate:
@@ -493,7 +489,7 @@ def write_sparameters_meep(
             port_source_name, component.ports, sim_dict, port_mode=port_source_mode
         )
         # Get coefficients
-        for port_name in port_names:
+        for port_name in sim_dict['monitors'].keys():
             for port_mode in port_modes:
                 _, monitor_exiting = parse_port_eigenmode_coeff(
                     port_name,
@@ -535,7 +531,6 @@ def write_sparameters_meep(
             wavelength_stop=wavelength_stop,
             wavelength_points=wavelength_points,
             animate=animate,
-            port_names=port_names,
             **settings,
         )
         # Synchronize dicts
@@ -568,7 +563,6 @@ def write_sparameters_meep(
                         wavelength_stop=wavelength_stop,
                         wavelength_points=wavelength_points,
                         animate=animate,
-                        port_names=port_names,
                         **settings,
                     )
                 )