gitnc 0.1.2__tar.gz → 0.1.4__tar.gz

{gitnc-0.1.2 → gitnc-0.1.4}/CLAUDE.md

@@ -50,11 +50,17 @@ The two File menu entries (`action_short_file_list` / `action_long_file_list`) a
 
 Menu chrome is composed once and stays mounted, so `action_set_theme` / `_load_saved_theme` call `_restyle_menu_mnemonics()` to re-render the labels; otherwise they would keep the accelerator style of the theme that was active at compose time.
 
+**Starting inside a submodule:** `on_mount` loads nothing until `_offer_top_level_repository()` has settled which repository to read. `GIT.repository_chain()` returns this repo's top level followed by each superproject (`git rev-parse --show-superproject-working-tree`, asked again from every repository it finds), so nesting of any depth ends at the outermost one; a chain of one means not a submodule and the app starts at once. Otherwise a `_show_confirm()` lists the chain and asks to start in the last entry: Y goes through `_switch_repository()` — a new `GIT`, `repo_path`, and `os.chdir()` so the `Ctrl+O` shell lands there too — N keeps the submodule. Either answer then runs `_start()` (first loads, then the Midnight Commander warning), so the two startup questions come one after the other rather than stacked. The walk is a `rev-parse` per level, which doesn't grow with the repo, so it runs inline.
+
 **Chrome colors:** the menu bar and the footer are painted from four `UITheme` fields — `menu_bar_background` / `menu_bar_foreground` / `footer_background` / `footer_foreground` — which `css_variables()` emits as `$menu-bar-background`, `$menu-bar-foreground`, `$footer-background` and `$footer-foreground` (the last two are Textual's own Footer variables, so the app carries no `Footer` CSS at all). The defaults are `$panel` / `$foreground`, i.e. Textual's Header/Footer palette, so a theme that says nothing about the chrome gets the bars every other Textual app has; `midnight-commander.yaml` overrides all four to `$warning` / `$background` for the MC look. Don't tie the bars to a palette role in CSS (they used to read `background: $warning`): "warning" means cyan in one theme and yellow in the next, so the bar changed color for reasons that had nothing to do with chrome. `MenuLabel`'s hover and `-active` states derive from those two variables — a 15% tint of the bar's own text color, and a full reverse — so they stay legible on any palette.
 
 **Text selection colors:** selected text in the commit message box (Shift+arrows in the `TextArea`) is painted from `UITheme.text_selection_background` / `text_selection_foreground`, which `css_variables()` emits as Textual's own `$input-selection-background` / `$input-selection-foreground` — the variables `TextArea` and `Input` already read, so there is no selection CSS in the app. Unlike the chrome fields these are optional: an empty value emits nothing and leaves Textual's derived default (`$primary` lightened, at 40% over the background), because that default is fine in most themes and can't be written as a `$ref` `_resolve_refs()` understands. It is not fine in midnight-commander, where primary and background are both blue and a selection all but vanished; that theme sets `$warning` / `$background`, mcedit's dark-blue-on-cyan marked block. Set the selection through these fields, not through `variables`: `get_theme()` lets a `variables` entry win, so a second copy there would silently override the field.
 
-**Committing:** `action_commit_files()` asks twice, and the two questions are different. The first — only when a target still has unstaged changes — is `Stage N file(s) for commit?`, listing the `git add` commands that would run. The second always comes, after the message dialog: `_confirm_commit()` shows `Commit N file(s)?` over the commands from `GIT.commit_with_selection_commands()`, which is the last point at which the files going into the commit are visible before `commit_with_selection` walks the submodules and commits. The command list comes from that method rather than being rebuilt in `app.py` so the popup and the executor can't drift apart, and the message inside it is cut to `_commit_message_subject()` — its first line, marked with `TRUNCATION_MARKER` when there is more — because the popup renders one command per row and a multi-line `-m` argument would break that. N on it doesn't cancel: `_show_confirm()`'s `on_cancel` reopens the message editor — `CommitDialog`, or the external editor the settings name — on the message just written, so backing out of the confirmation costs nothing. That is the only reason `on_cancel` exists; every other caller wants the default, which hands focus back to the active view.
+**Warning notification color:** a `notify(..., severity="warning")` toast — today only the up-front branch-prefix warning (see *Committing*) — takes its text and left bar from `UITheme.warning_notification`, emitted as `$warning-notification` and applied by the `Toast.-warning` rules in the app `CSS`. It is a field of its own for the same reason the chrome colors are: Textual paints that bar in `$warning`, which is midnight-commander's cyan menu bar color and doesn't read as a warning there, so that theme sets a red (`#FF5555`) while every other theme keeps the default `$warning`.
+
+**Committing:** `action_commit_files()` asks twice, and the two questions are different. The first — only when a target still has unstaged changes — is `Stage N file(s) for commit?`, listing the `git add` commands that would run. The second always comes, after the message dialog: `_confirm_commit()` shows `Commit N file(s)?` over the commands from `GIT.commit_with_selection_commands()`, which is the last point at which the files going into the commit are visible before `commit_with_selection` walks the submodules and commits. The command list comes from that method rather than being rebuilt in `app.py` so the popup and the executor can't drift apart, and the message inside it is cut to `_commit_message_subject()` — its first line, marked with `TRUNCATION_MARKER` when there is more — because the popup renders one command per row and a multi-line `-m` argument would break that. N on it doesn't cancel: `_show_confirm()`'s `on_cancel` reopens the message editor — `CommitDialog`, or the external editor the settings name — on the message just written, so backing out of the confirmation costs nothing. That, the prefix warning below, which reopens the message the same way, and the startup submodule question (see *Starting inside a submodule*), whose N still has to start the app, are the only callers of `on_cancel`; every other caller wants the default, which hands focus back to the active view.
+
+A message prefixed with a branch the settings warn against gets a question of its own first: `_commit_result()` goes through `_confirm_commit_prefix()`, which — when the message starts with `<name>:` for a name in the `commit_prefix_warn_branches` setting — asks `Warning: commit message is prefixed with branch '…'. Continue?` over the message's subject line, and only on Y moves on to `Commit N file(s)?`. N reopens the message, the same way back the commit confirmation offers. It is a separate dialog rather than a row under the commands because a row only has to be overlooked. The setting is the *Warn on prefix* text row under the branch-prefix checkbox, a space- or comma-separated list read by `_branch_names()`. The check is on the message rather than the checked-out branch, because the prefill is editable and the prefix can have been typed by hand, and it comes after the editor because that is where the message is final whichever editor wrote it. `_begin_commit_message()` raises the same text — both come from `_commit_prefix_warning()` — as a warning notification when the prefill it is about to open already carries a listed prefix, so the user hears about it before writing the message around it.
 
 Cancelling the message dialog rolls the index back to where the flow found it. Both halves of the mutation are undone: `_restore_externals()` re-stages the files it unstaged, and `_unstage_pending()` unstages what the stage confirmation added, from the `_pending_commit_staged` list `_begin_commit_message()` was handed. Without the second half the files stayed staged, so a second `C` on the same selection found nothing left to stage and skipped straight past `Stage N file(s) for commit?` — the question never came back. Only entries that had *nothing* staged before go on that list (`not code.has_staged_changes`): an entry that was already partly staged had its index state built by the user, and `git restore --staged` would throw that away instead of putting it back. `_commit_submit()` clears the list without running it — the files it staged are the files it just committed.
 

{gitnc-0.1.2 → gitnc-0.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: gitnc
-Version: 0.1.2
+Version: 0.1.4
 Summary: GitNightCommander — a TUI git log browser built with Textual
 Project-URL: Homepage, https://github.com/thomashyldgaard/GitNightCommander
 Project-URL: Source, https://github.com/thomashyldgaard/GitNightCommander

{gitnc-0.1.2 → gitnc-0.1.4}/README.md

@@ -10,7 +10,9 @@ Main features:
 
 - **Easy handling of commits in projects that use git submodules** — staging
   and committing walk the submodules for you, and pull/push warn when a
-  submodule sits on a branch of its own.
+  submodule sits on a branch of its own. Started inside a submodule — at any
+  depth of nesting — the app offers to open the top-level repository instead
+  (`Y` / `N`).
 - **`Ctrl+O` switches to the command line** — drops the app to a `$SHELL` in
   the same terminal; press `Ctrl+O` again to switch back with the TUI right
   where you left it. Started from Midnight Commander's command line, mc keeps
@@ -90,6 +92,7 @@ first use, so no manual venv activation is needed for the commands below.
 
 ```sh
 hatch build              # sdist + wheel into dist/
+hatch run rebuild        # same, removing the old artifacts from dist/ first
 ```
 
 The artifacts land in `dist/` as `gitnc-<version>-py3-none-any.whl` and
@@ -270,6 +273,12 @@ Options -> Settings configures the things it uses:
 - **Use branch name as prefix in commit messages** — prefills the message with
   `<branch>: `, and puts that prefix in front of a drafted message that does not
   already start with the branch name.
+- **Warn on prefix** — branch names, separated by spaces or commas, that should
+  not end up in front of a commit message (e.g. `master main`). A message that
+  starts with `<name>:` is asked about in a confirmation of its own before the
+  `Commit N file(s)?` one: `Y` continues, `N` puts you back in the message to
+  change it. When the branch prefix setting prefills such a name, the same
+  warning also pops up as the message editor opens.
 - **Commit message editor** — where the message is written:
   - **Built-in editor** (the default) is the commit dialog described above.
   - **$EDITOR** runs the editor named by the `EDITOR` environment variable;

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/app.py

@@ -10,7 +10,7 @@ import subprocess
 import tempfile
 import textwrap
 import threading
-from collections.abc import Callable, Mapping
+from collections.abc import Callable, Iterable, Mapping
 from contextlib import ExitStack
 from dataclasses import dataclass
 from pathlib import Path
@@ -132,6 +132,9 @@ MIDNIGHT_COMMANDER_WARNING = (
 )
 # Wide enough for the warning to wrap into a few readable lines.
 MIDNIGHT_COMMANDER_DIALOG_WIDTH = 60
+# Asked at startup when the repository is a submodule, however deeply nested:
+# the question is always about the outermost repository.
+SUPERPROJECT_PROMPT = "This repository is a submodule. Start in the top-level repository?"
 
 # Where the commit message is written: the app's own dialog, the editor named
 # by $EDITOR, or a command line typed into Options -> Settings. The last two
@@ -812,6 +815,22 @@ def _caret_markup(text: str, *, column: int, style: str) -> str:
     return f"{_escape_markup(head)}[{style}]{_escape_markup(cell)}[/{style}]{_escape_markup(tail)}"
 
 
+def _branch_names(text: str) -> list[str]:
+    """The branch names in a settings value that lists several, separated by
+    spaces or commas — neither of which a branch name can contain."""
+    return [name for name in re.split(r"[\s,]+", text) if name]
+
+
+def _warned_commit_prefix(message: str, branches: Iterable[str]) -> str:
+    """Whichever of `branches` the message is prefixed with, or "".
+
+    The message is what is checked, not the branch that is checked out: the
+    prefill is editable, so the prefix can have been removed since — or typed
+    in by hand with the prefix setting off.
+    """
+    return next((branch for branch in branches if message.startswith(f"{branch}:")), "")
+
+
 def _setting_str(settings: Mapping[str, object], key: str, default: str) -> str:
     """`settings[key]` when it holds a string, else `default`.
 
@@ -894,6 +913,7 @@ class SettingsValues(NamedTuple):
     parse_suggestions: bool = False
     editor: str = COMMIT_EDITOR_BUILTIN
     editor_command: str = ""
+    prefix_warn_branches: str = ""
 
 
 # Rows of the settings dialog, in the order they are drawn. The checkbox rows
@@ -903,14 +923,15 @@ class SettingsValues(NamedTuple):
 # Experimental heading.
 SETTINGS_ROW_BRANCH = 0
 SETTINGS_ROW_PREFIX = 1
-SETTINGS_ROW_EDITOR_BUILTIN = 2
-SETTINGS_ROW_EDITOR_ENVIRONMENT = 3
-SETTINGS_ROW_EDITOR_COMMAND = 4
-SETTINGS_ROW_EDITOR_COMMAND_LINE = 5
-SETTINGS_ROW_COMMAND = 6
-SETTINGS_ROW_PROMPT = 7
-SETTINGS_ROW_PARSE = 8
-SETTINGS_ROW_COUNT = 9
+SETTINGS_ROW_PREFIX_WARN = 2
+SETTINGS_ROW_EDITOR_BUILTIN = 3
+SETTINGS_ROW_EDITOR_ENVIRONMENT = 4
+SETTINGS_ROW_EDITOR_COMMAND = 5
+SETTINGS_ROW_EDITOR_COMMAND_LINE = 6
+SETTINGS_ROW_COMMAND = 7
+SETTINGS_ROW_PROMPT = 8
+SETTINGS_ROW_PARSE = 9
+SETTINGS_ROW_COUNT = 10
 
 # Which editor each radio row selects.
 SETTINGS_EDITOR_ROWS: dict[int, str] = {
@@ -1281,6 +1302,7 @@ class SettingsDialog(ModalScreen["SettingsValues | None"]):
     # rows differ only by their label and the value they carry.
     TEXT_ROWS: ClassVar[dict[int, str]] = {
         SETTINGS_ROW_BRANCH: "_default_branch",
+        SETTINGS_ROW_PREFIX_WARN: "_prefix_warn_branches",
         SETTINGS_ROW_EDITOR_COMMAND_LINE: "_editor_command",
         SETTINGS_ROW_COMMAND: "_draft_command",
         SETTINGS_ROW_PROMPT: "_draft_prompt",
@@ -1300,11 +1322,13 @@ class SettingsDialog(ModalScreen["SettingsValues | None"]):
         parse_suggestions: bool = False,
         editor: str = COMMIT_EDITOR_BUILTIN,
         editor_command: str = "",
+        prefix_warn_branches: str = "",
     ) -> None:
         super().__init__()
         self._cursor: int = 0
         self._default_branch: str = default_branch
         self._branch_prefix: bool = branch_prefix
+        self._prefix_warn_branches: str = prefix_warn_branches
         self._draft_command: str = draft_command
         self._draft_prompt: str = draft_prompt
         self._parse_suggestions: bool = parse_suggestions
@@ -1519,6 +1543,12 @@ class SettingsDialog(ModalScreen["SettingsValues | None"]):
                 "Use branch name as prefix in commit messages",
             )
         )
+        lines.append(self._text_row(SETTINGS_ROW_PREFIX_WARN, "      Warn on prefix: "))
+        lines.append(
+            f"[{theme.dialog_hint}]"
+            "    (branch names, separated by spaces, e.g. master main)"
+            f"[/{theme.dialog_hint}]"
+        )
         lines.append("")
         lines.append(self._section_header("Commit message editor"))
         lines.append("")
@@ -1597,6 +1627,7 @@ class SettingsDialog(ModalScreen["SettingsValues | None"]):
             parse_suggestions=self._parse_suggestions,
             editor=self._editor,
             editor_command=self._editor_command,
+            prefix_warn_branches=self._prefix_warn_branches,
         )
 
 
@@ -2638,6 +2669,15 @@ class GitNightCommanderApp(App):
     ]
 
     CSS = """
+    /* Warning notifications take the theme's own color for them instead of
+       $warning, which a theme may have spent on its chrome. */
+    Toast.-warning {
+        border-left: outer $warning-notification;
+        color: $warning-notification;
+    }
+    Toast.-warning .toast--title {
+        color: $warning-notification;
+    }
     Screen {
         layout: horizontal;
         layers: default overlay;
@@ -2804,10 +2844,48 @@ class GitNightCommanderApp(App):
 
     def on_mount(self) -> None:
         self._load_saved_theme()
+        self._offer_top_level_repository(then=self._start)
+
+    def _start(self) -> None:
         self._load_status()
         self._load_commits()
         self._warn_if_started_from_midnight_commander()
 
+    def _offer_top_level_repository(self, then: Callable[[], None]) -> None:
+        """Ask to move to the outermost superproject when started in a submodule.
+
+        Runs *then* once the question is answered (or at once, when there is
+        nothing to ask), so the first `git status` reads the repository the
+        user settled on rather than one it is about to leave. The chain is a
+        `git rev-parse` per nesting level, which doesn't grow with the repo,
+        so it runs inline.
+        """
+        chain = self.git.repository_chain()
+        if len(chain) < 2:
+            then()
+            return
+        rows = [f"submodule  {path}" for path in chain[:-1]]
+        rows.append(f"top-level  {chain[-1]}")
+
+        def confirmed() -> None:
+            self._switch_repository(chain[-1])
+            then()
+
+        self._show_confirm(SUPERPROJECT_PROMPT, rows, on_confirm=confirmed, on_cancel=then)
+
+    def _switch_repository(self, path: str) -> None:
+        """Point the app at *path*; the caller reloads the views.
+
+        The process moves there too, so the `Ctrl+O` shell and the tools run
+        from the previous screen start where the file list is.
+        """
+        self.repo_path = path
+        self.git = GIT(path)
+        try:
+            os.chdir(path)
+        except OSError:
+            pass
+
     def _warn_if_started_from_midnight_commander(self) -> None:
         if not started_from_midnight_commander():
             return
@@ -3973,6 +4051,12 @@ class GitNightCommanderApp(App):
         self._pending_commit_targets = list(targets)
         branch = self._commit_branch_prefix()
         prefill = f"{branch}: " if branch else ""
+        warning = self._commit_prefix_warning(prefill)
+        if warning:
+            # Up front as well as in the question asked after the message:
+            # the prefix is already known here, and this is before the
+            # message has been written around it.
+            self.notify(warning, severity="warning")
         self._edit_commit_message(prefill)
 
     def _edit_commit_message(self, message: str) -> None:
@@ -4246,7 +4330,29 @@ class GitNightCommanderApp(App):
         if message is None:
             self._commit_cancel()
         else:
+            self._confirm_commit_prefix(message)
+
+    def _confirm_commit_prefix(self, message: str) -> None:
+        """Ask about a branch prefix the settings warn against, before the
+        commit confirmation rather than as a row inside it.
+
+        A question of its own has to be answered; a row under a list of
+        commands only has to be overlooked. It comes here rather than on the
+        message dialog because this is where the message is final, whichever
+        editor wrote it. Y goes on to the commit confirmation, N reopens the
+        message — the same way back that confirmation offers — and a message
+        without such a prefix goes straight through.
+        """
+        warning = self._commit_prefix_warning(message)
+        if not warning:
             self._confirm_commit(message)
+            return
+        self._show_confirm(
+            f"{warning}. Continue?",
+            [_commit_message_subject(message)],
+            lambda: self._confirm_commit(message),
+            lambda: self._edit_commit_message(message),
+        )
 
     def _confirm_commit(self, message: str) -> None:
         """Show what the commit will run and ask before running it.
@@ -4274,6 +4380,21 @@ class GitNightCommanderApp(App):
             fill_height=True,
         )
 
+    def _commit_prefix_warning(self, message: str) -> str:
+        """The warning for a message prefixed with a branch named in the
+        `commit_prefix_warn_branches` setting, or "" when it isn't.
+
+        One text for the notification the message editor opens with and the
+        question asked once the message is written, so the two can't drift.
+        """
+        branches = _branch_names(
+            _setting_str(self._load_settings(), "commit_prefix_warn_branches", "")
+        )
+        branch = _warned_commit_prefix(message, branches)
+        if not branch:
+            return ""
+        return f"Warning: commit message is prefixed with branch '{branch}'"
+
     def _commit_submit(self, message: str) -> None:
         result = self.git.commit_with_selection(self._pending_commit_targets, message)
         self._pending_commit_targets = []
@@ -4534,6 +4655,7 @@ class GitNightCommanderApp(App):
                 parse_suggestions=bool(settings.get("commit_draft_parse_suggestions", False)),
                 editor=_setting_str(settings, "commit_editor", COMMIT_EDITOR_BUILTIN),
                 editor_command=_setting_str(settings, "commit_editor_command", ""),
+                prefix_warn_branches=_setting_str(settings, "commit_prefix_warn_branches", ""),
             ),
             callback=self._settings_result,
         )
@@ -4551,6 +4673,7 @@ class GitNightCommanderApp(App):
         settings["commit_draft_parse_suggestions"] = values.parse_suggestions
         settings["commit_editor"] = values.editor
         settings["commit_editor_command"] = values.editor_command
+        settings["commit_prefix_warn_branches"] = values.prefix_warn_branches
         if not self._save_settings(settings):
             self.notify("Settings saved (could not write to disk)")
         else:

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/git.py

@@ -705,6 +705,28 @@ class GIT:
         name = (result.stdout or "").strip()
         return name or None
 
+    def repository_chain(self) -> list[str]:
+        """Return the working trees from this repository out to the top-level one.
+
+        The first entry is this repository's own top level, and each one after
+        it is the superproject the previous one is a submodule of, so the last
+        is the repository nothing contains. A repository that isn't a submodule
+        yields a single entry; a path outside any repository yields none.
+        """
+        result = self._run("rev-parse", "--show-toplevel")
+        toplevel = (result.stdout or "").strip()
+        if result.returncode != 0 or not toplevel:
+            return []
+        chain = [toplevel]
+        while True:
+            result = self._run_in(chain[-1], "rev-parse", "--show-superproject-working-tree")
+            parent = (result.stdout or "").strip()
+            # The membership check stops a misconfigured gitlink that points
+            # back into the chain from walking in circles.
+            if result.returncode != 0 or not parent or parent in chain:
+                return chain
+            chain.append(parent)
+
     def _branch_name_in(self, cwd: str) -> str | None:
         result = self._run_in(cwd, "branch", "--show-current")
         name = (result.stdout or "").strip()

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/atom-one-dark.yaml

@@ -89,6 +89,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/atom-one-light.yaml

@@ -89,6 +89,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/catppuccin-frappe.yaml

@@ -97,6 +97,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/catppuccin-latte.yaml

@@ -90,6 +90,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/catppuccin-macchiato.yaml

@@ -97,6 +97,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/catppuccin-mocha.yaml

@@ -97,6 +97,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/dracula.yaml

@@ -90,6 +90,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/flexoki.yaml

@@ -92,6 +92,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/gruvbox.yaml

@@ -91,6 +91,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/midnight-commander.yaml

@@ -93,6 +93,13 @@ menu_bar_foreground: $background
 footer_background: $warning
 footer_foreground: $background
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge. $warning is this theme's cyan — the color of the menu bar,
+# which reads as chrome rather than as a warning — so the toast gets a red
+# of its own.
+warning_notification: '#FF5555'
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/monokai.yaml

@@ -91,6 +91,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/nord.yaml

@@ -95,6 +95,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/rose-pine-dawn.yaml

@@ -96,6 +96,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/rose-pine-moon.yaml

@@ -96,6 +96,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/rose-pine.yaml

@@ -96,6 +96,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/solarized-dark.yaml

@@ -93,6 +93,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/solarized-light.yaml

@@ -93,6 +93,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/textual-ansi.yaml

@@ -99,6 +99,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/textual-dark.yaml

@@ -89,6 +89,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/textual-light.yaml

@@ -90,6 +90,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/themes/tokyo-night.yaml

@@ -90,6 +90,11 @@ menu_bar_foreground: $foreground
 footer_background: $panel
 footer_foreground: $foreground
 
+# Warning notifications (the toast that says a commit message is about to be
+# prefixed with a branch the settings warn against): its text and the bar on
+# its left edge.
+warning_notification: $warning
+
 # CSS variables emitted for the file-list cursor and multi-selection.
 # Values may reference Textual palette variables with `$name` (e.g. `$primary`).
 # References are resolved against this theme's own fields when the CSS is generated.

{gitnc-0.1.2 → gitnc-0.1.4}/gitnc/ui_theme.py

@@ -117,6 +117,13 @@ class UITheme:
     footer_background: str = "$panel"
     footer_foreground: str = "$foreground"
 
+    # CSS-side color of a warning notification: the toast's text and the bar
+    # on its left edge. The default is the palette's own warning role, which
+    # is what Textual paints that bar in anyway; a theme that has spent
+    # $warning on something else (midnight-commander's cyan chrome) names a
+    # color that still reads as a warning.
+    warning_notification: str = "$warning"
+
     # CSS-side palette for the file list cursor + multi-selection.
     cursor_row_background: str = "$primary"
     cursor_row_foreground: str = "$foreground"
@@ -184,6 +191,7 @@ class UITheme:
             "menu-bar-foreground": self._resolve_refs(self.menu_bar_foreground),
             "footer-background": self._resolve_refs(self.footer_background),
             "footer-foreground": self._resolve_refs(self.footer_foreground),
+            "warning-notification": self._resolve_refs(self.warning_notification),
             "cursor-row-background": self._resolve_refs(self.cursor_row_background),
             "cursor-row-foreground": self._resolve_refs(self.cursor_row_foreground),
             "selected-file-background": self._resolve_refs(self.selected_file_background),

{gitnc-0.1.2 → gitnc-0.1.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "gitnc"
-version = "0.1.2"
+version = "0.1.4"
 description = "GitNightCommander — a TUI git log browser built with Textual"
 requires-python = ">=3.12"
 dependencies = [
@@ -44,6 +44,7 @@ fmt = [
     "ruff format gitnc tests",
 ]
 start = "python -m gitnc {args}"
+rebuild = "hatch build --clean {args}"
 
 [tool.ruff]
 line-length = 100

{gitnc-0.1.2 → gitnc-0.1.4}/tests/test_app.py

@@ -346,6 +346,7 @@ try:
         SETTINGS_ROW_EDITOR_COMMAND_LINE,
         SETTINGS_ROW_EDITOR_ENVIRONMENT,
         SETTINGS_ROW_PARSE,
+        SETTINGS_ROW_PREFIX_WARN,
         SETTINGS_ROW_PROMPT,
         SETTINGS_SECTION_WIDTH,
         SHORTCUT_ALIASES,
@@ -441,6 +442,7 @@ except ModuleNotFoundError as exc:
         SETTINGS_ROW_EDITOR_COMMAND_LINE,
         SETTINGS_ROW_EDITOR_ENVIRONMENT,
         SETTINGS_ROW_PARSE,
+        SETTINGS_ROW_PREFIX_WARN,
         SETTINGS_ROW_PROMPT,
         SETTINGS_SECTION_WIDTH,
         SHORTCUT_ALIASES,
@@ -630,6 +632,92 @@ class TestGitNightCommanderApp(unittest.TestCase):
 
         _DialogProbe(app).assert_not_shown()
 
+    def test_on_mount_does_not_ask_outside_a_submodule(self):
+        app = _mock_app()
+        app._load_status = MagicMock()
+
+        with (
+            patch.object(app, "_load_saved_theme"),
+            patch.object(_app_module, "started_from_midnight_commander", return_value=False),
+        ):
+            app.on_mount()
+
+        _DialogProbe(app).assert_not_shown()
+        app._load_status.assert_called_once_with()
+
+    def test_on_mount_offers_the_outermost_superproject(self):
+        app = _mock_app()
+        app._load_status = MagicMock()
+        app.git.repository_chain.return_value = ["/top/mid/sub", "/top/mid", "/top"]
+
+        with (
+            patch.object(app, "_load_saved_theme"),
+            patch.object(_app_module, "started_from_midnight_commander", return_value=False),
+        ):
+            app.on_mount()
+
+        _DialogProbe(app).assert_confirm(
+            _app_module.SUPERPROJECT_PROMPT,
+            ["submodule  /top/mid/sub", "submodule  /top/mid", "top-level  /top"],
+        )
+        # Nothing is read until the user has picked the repository.
+        app._load_status.assert_not_called()
+
+    def test_superproject_confirm_switches_to_the_top_level_repository(self):
+        app = _mock_app()
+        app._load_status = MagicMock()
+        app.git.repository_chain.return_value = ["/top/sub", "/top"]
+
+        with (
+            patch.object(app, "_load_saved_theme"),
+            patch.object(_app_module, "started_from_midnight_commander", return_value=False),
+        ):
+            app.on_mount()
+        with (
+            patch.object(_app_module, "GIT") as git_class,
+            patch.object(_app_module.os, "chdir") as chdir,
+        ):
+            _DialogProbe(app).confirm()
+
+        self.assertEqual(app.repo_path, "/top")
+        git_class.assert_called_once_with("/top")
+        self.assertIs(app.git, git_class.return_value)
+        chdir.assert_called_once_with("/top")
+        app._load_status.assert_called_once_with()
+
+    def test_superproject_cancel_stays_in_the_submodule(self):
+        app = _mock_app()
+        app._load_status = MagicMock()
+        app.git.repository_chain.return_value = ["/top/sub", "/top"]
+        git = app.git
+
+        with (
+            patch.object(app, "_load_saved_theme"),
+            patch.object(_app_module, "started_from_midnight_commander", return_value=False),
+        ):
+            app.on_mount()
+        with patch.object(_app_module.os, "chdir") as chdir:
+            _DialogProbe(app).cancel()
+
+        self.assertIs(app.git, git)
+        self.assertEqual(app.repo_path, ".")
+        chdir.assert_not_called()
+        app._load_status.assert_called_once_with()
+
+    def test_midnight_commander_warning_follows_the_superproject_question(self):
+        app = _mock_app()
+        app.git.repository_chain.return_value = ["/top/sub", "/top"]
+
+        with (
+            patch.object(app, "_load_saved_theme"),
+            patch.object(_app_module, "started_from_midnight_commander", return_value=True),
+        ):
+            app.on_mount()
+            self.assertIsInstance(_DialogProbe(app).assert_open(), _app_module.ConfirmDialog)
+            _DialogProbe(app).cancel()
+
+        self.assertIsInstance(_DialogProbe(app).pushed[-1], _app_module.MidnightCommanderDialog)
+
     def test_midnight_commander_dialog_keys(self):
         dialog_class = _app_module.MidnightCommanderDialog
         for key, expected in (("c", True), ("enter", True), ("e", False), ("escape", False)):
@@ -852,6 +940,8 @@ def _mock_app() -> Any:
     app.git = MagicMock()
     app.git.load_status.return_value = GitFilelist()
     app.git.load_commits.return_value = []
+    # Not a submodule, so on_mount goes straight to the first load.
+    app.git.repository_chain.return_value = ["/repo"]
     # Route entry-aware methods through the legacy filename-keyed mocks so
     # assertions on stage_file / unstage_file / stage_command / commit / etc.
     # keep working without per-test rewires. Submodule-specific behaviour is
@@ -3306,6 +3396,36 @@ class TestSettingsDialog(unittest.TestCase):
         self.assertEqual(dialog.get_values().draft_prompt, "a ")
         self.assertFalse(dialog.get_values().branch_prefix)
 
+    def test_the_warned_prefixes_are_typed_under_the_prefix_checkbox(self):
+        dialog = SettingsDialog(prefix_warn_branches="master")
+        for _ in range(SETTINGS_ROW_PREFIX_WARN):
+            dialog.on_key(_key_event("down"))
+        self.assertEqual(dialog._cursor, SETTINGS_ROW_PREFIX_WARN)
+
+        for key, character in (("space", None), ("m", "m")):
+            dialog.on_key(_key_event(key, character=character))
+
+        self.assertEqual(dialog.get_values().prefix_warn_branches, "master m")
+        self.assertFalse(dialog.get_values().branch_prefix)
+
+    def test_the_warned_prefixes_round_trip_through_the_settings_file(self):
+        app = _mock_app()
+        with patch.object(
+            app, "_load_settings", return_value={"commit_prefix_warn_branches": "master main"}
+        ):
+            app.action_settings()
+        values = _pushed_screen(app).get_values()
+        self.assertEqual(values.prefix_warn_branches, "master main")
+
+        saved: dict[str, object] = {}
+        with (
+            patch.object(app, "_load_settings", return_value={}),
+            patch.object(app, "_save_settings", side_effect=lambda s: saved.update(s) or True),
+        ):
+            app._settings_result(values)
+
+        self.assertEqual(saved["commit_prefix_warn_branches"], "master main")
+
     def test_cursor_wraps_over_every_row(self):
         dialog = SettingsDialog()
 
@@ -4593,6 +4713,7 @@ class TestUIThemeCssVariables(unittest.TestCase):
         "menu-bar-foreground",
         "footer-background",
         "footer-foreground",
+        "warning-notification",
         "cursor-row-background",
         "cursor-row-foreground",
         "selected-file-background",
@@ -4634,6 +4755,28 @@ class TestUIThemeCssVariables(unittest.TestCase):
             self.assertNotIn("$", variables[field_name])
 
 
+class TestWarningNotificationThemeColor(unittest.TestCase):
+    """A warning toast is painted from the theme's `warning_notification`
+    field rather than from `$warning`, which a theme may use for chrome."""
+
+    def test_the_default_is_the_palette_warning_role(self):
+        from gitnc.ui_theme import UITheme
+
+        theme = UITheme(name="plain", primary="#123456", warning="#abcdef")
+
+        self.assertEqual(theme.css_variables()["warning-notification"], "#abcdef")
+
+    def test_midnight_commander_warns_in_red_not_in_its_chrome_cyan(self):
+        css_vars = MIDNIGHT_COMMANDER_THEME.css_variables()
+
+        self.assertEqual(css_vars["warning-notification"], "#FF5555")
+        self.assertNotEqual(css_vars["warning-notification"], MIDNIGHT_COMMANDER_THEME.warning)
+
+    def test_the_app_css_paints_warning_toasts_from_the_variable(self):
+        self.assertIn("border-left: outer $warning-notification;", GitNightCommanderApp.CSS)
+        self.assertIn("color: $warning-notification;", GitNightCommanderApp.CSS)
+
+
 class TestTextSelectionThemeColors(unittest.TestCase):
     """Selected text in the commit message box takes its colors from the
     theme's text selection fields, emitted as Textual's own
@@ -5107,6 +5250,97 @@ class TestCommitFlow(unittest.TestCase):
         self.assertTrue(dialogs.pushed[-1].fill_height)
         app.git.commit.assert_not_called()
 
+    def _warned_app(self):
+        entry = GitEntry(GitCode.MODIFIED_UNMODIFIED, "pkg/a.py")
+        app, dialogs, _ = self._app([entry], staged={"pkg/a.py"})
+        app._load_settings = MagicMock(return_value={"commit_prefix_warn_branches": "main, master"})
+        app.action_commit_files()
+        return app, dialogs
+
+    def test_a_warned_prefix_is_asked_about_before_the_commit_confirmation(self):
+        app, dialogs = self._warned_app()
+
+        dialogs._resolve("master: fix x")
+
+        self.assertEqual(
+            dialogs.prompt(),
+            "Warning: commit message is prefixed with branch 'master'. Continue?",
+        )
+        self.assertEqual(dialogs.commands(), ["master: fix x"])
+        app.git.commit.assert_not_called()
+
+    def test_accepting_the_prefix_warning_goes_on_to_the_commit_confirmation(self):
+        app, dialogs = self._warned_app()
+        dialogs._resolve("master: fix x")
+
+        dialogs.confirm()
+
+        self.assertEqual(dialogs.prompt(), "Commit 1 file(s)?")
+        self.assertEqual(dialogs.commands(), ["git commit -m master: fix x"])
+        app.git.commit.assert_not_called()
+
+    def test_declining_the_prefix_warning_reopens_the_message(self):
+        app, dialogs = self._warned_app()
+        dialogs._resolve("master: fix x")
+
+        dialogs.cancel()
+
+        reopened = dialogs.pushed[-1]
+        self.assertIsInstance(reopened, CommitDialog)
+        self.assertEqual(reopened.prefill, "master: fix x")
+        app.git.commit.assert_not_called()
+
+    def test_a_warned_prefix_is_announced_when_the_message_editor_opens(self):
+        entry = GitEntry(GitCode.MODIFIED_UNMODIFIED, "pkg/a.py")
+        app, dialogs, _ = self._app([entry], staged={"pkg/a.py"}, branch="master")
+        app._load_settings = MagicMock(
+            return_value={
+                "branch_prefix_in_commits": True,
+                "commit_prefix_warn_branches": "master",
+            }
+        )
+
+        with patch.object(app, "notify") as notify:
+            app.action_commit_files()
+
+        self.assertEqual(self._commit_screen(dialogs).prefill, "master: ")
+        notify.assert_called_once_with(
+            "Warning: commit message is prefixed with branch 'master'", severity="warning"
+        )
+
+    def test_an_unlisted_prefix_opens_the_message_editor_quietly(self):
+        entry = GitEntry(GitCode.MODIFIED_UNMODIFIED, "pkg/a.py")
+        app, dialogs, _ = self._app([entry], staged={"pkg/a.py"}, branch="feature")
+        app._load_settings = MagicMock(
+            return_value={
+                "branch_prefix_in_commits": True,
+                "commit_prefix_warn_branches": "master",
+            }
+        )
+
+        with patch.object(app, "notify") as notify:
+            app.action_commit_files()
+
+        self.assertEqual(self._commit_screen(dialogs).prefill, "feature: ")
+        notify.assert_not_called()
+
+    def test_other_prefixes_go_straight_to_the_commit_confirmation(self):
+        """Only a whole listed name followed by the colon counts — not a
+        branch that merely starts with one, and not the name mid-message."""
+        entry = GitEntry(GitCode.MODIFIED_UNMODIFIED, "pkg/a.py")
+        for message in ("master-fix: x", "feature: merge master: x", "masterful change"):
+            with self.subTest(message=message):
+                app, dialogs, _ = self._app([entry], staged={"pkg/a.py"})
+                app._load_settings = MagicMock(
+                    return_value={"commit_prefix_warn_branches": "master"}
+                )
+                app.action_commit_files()
+
+                dialogs._resolve(message)
+
+                self.assertEqual(dialogs.prompt(), "Commit 1 file(s)?")
+                self.assertEqual(dialogs.commands(), [f"git commit -m {message}"])
+
     def test_the_confirmation_shows_only_the_subject_of_a_long_message(self):
         """The popup renders one command per row, so a multi-line `-m` has to
         be cut down to its first line — marked as cut."""

{gitnc-0.1.2 → gitnc-0.1.4}/tests/test_git.py

@@ -734,6 +734,48 @@ class TestShutdown(unittest.TestCase):
         self.assertEqual(result.stdout, "")
 
 
+class TestRepositoryChain(unittest.TestCase):
+    """`GIT.repository_chain()`: this repo's top level out to the outermost superproject."""
+
+    def test_not_a_submodule_is_a_chain_of_one(self):
+        git = GIT("/top/src")
+        with fake_git_processes(results=[(0, "/top\n", ""), (0, "", "")]) as processes:
+            self.assertEqual(git.repository_chain(), ["/top"])
+
+        self.assertEqual(
+            processes.commands[1][-3:], ["/top", "rev-parse", "--show-superproject-working-tree"]
+        )
+
+    def test_nested_submodules_walk_out_to_the_top_level(self):
+        git = GIT("/top/mid/sub/src")
+        results = [
+            (0, "/top/mid/sub\n", ""),
+            (0, "/top/mid\n", ""),
+            (0, "/top\n", ""),
+            (0, "", ""),
+        ]
+        with fake_git_processes(results=results) as processes:
+            chain = git.repository_chain()
+
+        self.assertEqual(chain, ["/top/mid/sub", "/top/mid", "/top"])
+        # Each step asks from the repository the previous step found.
+        self.assertEqual(
+            [argv[4] for argv in processes.commands[1:]], ["/top/mid/sub", "/top/mid", "/top"]
+        )
+
+    def test_outside_a_repository_is_empty(self):
+        git = GIT("/tmp")
+        with fake_git_processes(returncode=128, stderr="fatal: not a git repository") as processes:
+            self.assertEqual(git.repository_chain(), [])
+
+        self.assertEqual(processes.call_count, 1)
+
+    def test_a_cycle_stops_the_walk(self):
+        git = GIT("/a")
+        with fake_git_processes(results=[(0, "/a\n", ""), (0, "/b\n", ""), (0, "/a\n", "")]):
+            self.assertEqual(git.repository_chain(), ["/a", "/b"])
+
+
 class TestRemoteCommands(unittest.TestCase):
     """git pull / push: upstream detection and the argv it produces."""