gitmole 0.6.5__tar.gz → 0.6.6__tar.gz

{gitmole-0.6.5 → gitmole-0.6.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gitmole
-Version: 0.6.5
+Version: 0.6.6
 Summary: Offline git repository analysis with a terminal report: hotspots, coupling, ownership, code age, secrets, repo health.
 License: MIT
 Project-URL: Homepage, https://github.com/antvinni/gitmole

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/__init__.py

@@ -1,3 +1,3 @@
 """gitmole: offline git repository analysis with a terminal report."""
 
-__version__ = "0.6.5"
+__version__ = "0.6.6"

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/cli.py

@@ -15,7 +15,7 @@ from rich.live import Live
 from rich.spinner import Spinner
 from rich.text import Text
 
-from . import __version__, banner, filetypes, findings, load, loss, run
+from . import __version__, banner, blame, filetypes, findings, load, loss, run
 
 
 def parse_args(argv):
@@ -294,6 +294,8 @@ def _meta_for_run(repo_dir: str, args, estimate, age_ok: bool, plots_ok: bool, p
     meta = run.collect_meta(repo_dir, since=args.since_date)
     meta["file_types"] = types_spec   # the loader filters scc's size data the way every other step was filtered
     meta["gone_months"] = args.gone
+    ignore = list(run.DATA_IGNORES if args.ignore_data else []) + list(args.ignore)
+    meta["generated"] = filetypes.generated_files(repo_dir, blame.text_files(repo_dir, ignore))   # hidden from the tables, out of the findings
     if args.since_date and meta["commits"] == 0:
         raise NoCommits(f"no commits since {args.since_date}; widen --since")
     if args.now:

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/filetypes.py

@@ -2,6 +2,8 @@
 Standalone so blame.py and maat.py can import it as scripts."""
 from __future__ import annotations
 
+import fnmatch
+import os
 import re
 import subprocess
 from collections import Counter
@@ -83,6 +85,63 @@ def is_vendor_path(path: str) -> bool:
     return bool(_VENDOR_PATH.search(path))
 
 
+_RELEASE_NAMES = {"version", "version.rb", "version.py", "version.go", "version.rs", "version.txt", "__version__.py", "package.json",
+                  "package-lock.json", "yarn.lock", "pnpm-lock.yaml", "gemfile", "gemfile.lock", "cargo.toml", "cargo.lock",
+                  "pyproject.toml", "setup.py", "setup.cfg", "poetry.lock", "uv.lock", "go.mod", "go.sum", "composer.json", "composer.lock"}
+
+
+def is_release_path(path: str) -> bool:
+    """Release plumbing: version files, manifests, lock files and changelogs. Two of them changing
+    together is a release commit, not a dependency between them."""
+    name = path.rsplit("/", 1)[-1].lower()
+    return name in _RELEASE_NAMES or name.endswith(".gemspec") or name.startswith(("changelog", "changes.", "history.", "news."))
+
+
+# What a generated file says about itself in its first lines: protoc, ajv, code generators of every kind.
+_GENERATED = re.compile(r"auto[- ]?generated|generated (by|from|file|code|automatically|with)|do not (edit|modify)|@generated|code generated", re.I)
+GENERATED_HEAD_LINES = 5
+
+
+def _generated_patterns(repo: str) -> list:
+    """The .gitattributes patterns marked linguist-generated at the repository root."""
+    try:
+        with open(os.path.join(repo, ".gitattributes"), encoding="utf-8", errors="replace") as fh:
+            lines = fh.read().splitlines()
+    except OSError:
+        return []
+    out = []
+    for line in lines:
+        parts = line.split()
+        if len(parts) >= 2 and any(p in ("linguist-generated", "linguist-generated=true") for p in parts[1:]):
+            out.append(parts[0].lstrip("/"))
+    return out
+
+
+def _attribute_match(path: str, pattern: str) -> bool:
+    if "/" in pattern:
+        return fnmatch.fnmatchcase(path, pattern) or fnmatch.fnmatchcase(path, pattern.rstrip("/") + "/*")
+    return fnmatch.fnmatchcase(path.rsplit("/", 1)[-1], pattern)
+
+
+def generated_files(repo: str, paths: list) -> list:
+    """The tracked files that are generated: marked linguist-generated in .gitattributes, or saying so
+    in their first lines. Their complexity and churn are the generator's, not the repository's."""
+    patterns = _generated_patterns(repo)
+    out = []
+    for path in paths:
+        if any(_attribute_match(path, p) for p in patterns):
+            out.append(path)
+            continue
+        try:
+            with open(os.path.join(repo, path), "rb") as fh:
+                head = fh.read(2048)
+        except OSError:
+            continue
+        if any(_GENERATED.search(line) for line in head.decode("utf-8", "replace").splitlines()[:GENERATED_HEAD_LINES]):
+            out.append(path)
+    return sorted(out)
+
+
 def key(path: str) -> str:
     """The lowercased extension, or the whole lowercased name when there is none."""
     name = path.rsplit("/", 1)[-1].lower()

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/findings.py

@@ -185,10 +185,12 @@ def hotspot_dominance(report: dict, ratio: float = 2.0, minimum: int = 20) -> li
 
 def tight_coupling(report: dict, min_degree: int = 80, min_revs: int = 5) -> list:
     """A file and its test are expected to change together, so pairs with a test file on either side are
-    left out; so are pairs where either file is no longer in the tree, which are history, not a dependency."""
+    left out; so are pairs where either file is no longer in the tree, which are history, not a dependency,
+    and pairs of release plumbing (two version files, a manifest and its lock file), which are a release."""
     tree = _tree(report)
     pairs = [p for p in report.get("coupling") or [] if p["degree"] >= min_degree and p["average-revs"] >= min_revs
              and not (filetypes.is_test_path(p["entity"]) or filetypes.is_test_path(p["coupled"]))
+             and not (filetypes.is_release_path(p["entity"]) and filetypes.is_release_path(p["coupled"]))
              and not (tree and (p["entity"] not in tree or p["coupled"] not in tree))]
     if not pairs:
         return []
@@ -386,20 +388,36 @@ def _partial_functions(report: dict) -> str:
 
 
 def brain_methods(report: dict, min_ccn: int = 15, min_lines: int = 100) -> list:
-    """Functions that are both long and complex, in this repository's own source files: test files and
-    vendored code are left out. A warning when one sits in a hotspot."""
+    """Functions that are both long and complex, in this repository's own source files: test files,
+    vendored code and generated files are left out. A warning when one sits in a hotspot."""
+    generated = _generated(report)
     big = [f for f in report.get("functions") or [] if f["ccn"] >= min_ccn and f["nloc"] >= min_lines
-           and not (filetypes.is_test_path(f["file"]) or filetypes.is_vendor_path(f["file"]))]
+           and not (filetypes.is_test_path(f["file"]) or filetypes.is_vendor_path(f["file"]) or f["file"] in generated)]
     if not big:
         return []
     big.sort(key=lambda f: (-f["ccn"], -f["nloc"], f["file"], f["function"], f["start"]))
     hot = hotspots.top(report)
     sev = "warning" if any(f["file"] in hot for f in big) else "info"
-    listed = "; ".join(f"{f['function']} ({f['file']}) complexity {f['ccn']}, {f['nloc']} lines, {f['params']} params" for f in big[:5])
+    listed = "; ".join(f"{f['function']} ({_place(f)}) complexity {f['ccn']}, {f['nloc']} lines, {f['params']} params" for f in big[:5])
     more = f" and {len(big) - 5} more" if len(big) > 5 else ""
+    first = big[0]
+    which = f"the anonymous function at {_place(first)}" if first["function"] == ANONYMOUS else f"{first['function']} in {first['file']}"
     return [_f(sev, "Brain methods",
                f"{len(big)} function(s) are both long and complex: {listed}{more}.{_partial_functions(report)}",
-               f"Split {big[0]['function']} in {big[0]['file']} first, before the next change lands there.")]
+               f"Split {which} first, before the next change lands there.")]
+
+
+ANONYMOUS = "(anonymous)"
+
+
+def _place(f: dict) -> str:
+    """Where a function is: its file, or file:line when it has no name to find it by."""
+    return f"{f['file']}:{f['start']}" if f["function"] == ANONYMOUS else f["file"]
+
+
+def _generated(report: dict) -> set:
+    """Files the run found to be generated (a header marker or a linguist-generated attribute)."""
+    return set((report.get("meta") or {}).get("generated") or [])
 
 
 def complexity_growth(report: dict, min_growers: int = 3, min_pct: int = 25, top_n: int = 10) -> list:

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/identity.py

@@ -20,8 +20,26 @@ def _tokens(name: str) -> set:
     return {t for t in re.split(r"[^a-z0-9]+", name.lower()) if len(t) >= 3}
 
 
+# A bare first name under two emails may be two people; anything else spelled identically is one.
+_COMMON_FIRST_NAMES = {
+    "adam", "alex", "alexander", "andrew", "andy", "ann", "anna", "ben", "bob", "chris", "dan", "daniel", "dave", "david", "ed",
+    "eric", "frank", "george", "jack", "james", "jan", "jean", "jim", "joe", "john", "jon", "josh", "kevin", "lee", "li", "luke",
+    "mark", "martin", "matt", "max", "michael", "mike", "nick", "paul", "pete", "peter", "phil", "rob", "robert", "ryan", "sam",
+    "scott", "steve", "tim", "tom", "tony", "will",
+}
+
+
+def _plain(name: str) -> str:
+    return " ".join(name.lower().split())
+
+
 def same_person(a: dict, b: dict) -> bool:
-    return a["email"].lower() == b["email"].lower() or len(_tokens(a["name"]) & _tokens(b["name"])) >= 2
+    """Same email, two shared name tokens, or the same name spelled identically (a handle such as
+    KaKa under three emails), unless that name is a bare common first name."""
+    if a["email"].lower() == b["email"].lower() or len(_tokens(a["name"]) & _tokens(b["name"])) >= 2:
+        return True
+    name = _plain(a["name"])
+    return bool(name) and name == _plain(b["name"]) and name not in _COMMON_FIRST_NAMES
 
 
 def merge(identities: list) -> list:

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/load.py

@@ -151,7 +151,7 @@ def parse_functions(text: str) -> list:
     for r in csv.reader(io.StringIO(text)):
         if len(r) < 11:
             continue
-        rows.append({"file": _rel(r[6]), "function": r[7], "ccn": _num(r[1]), "nloc": _num(r[0]), "params": _num(r[3]),
+        rows.append({"file": _rel(r[6]), "function": r[7] or "(anonymous)", "ccn": _num(r[1]), "nloc": _num(r[0]), "params": _num(r[3]),
                      "start": _num(r[9]), "end": _num(r[10])})
     return rows
 

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole/render.py

@@ -111,6 +111,24 @@ def _hide_vendor(rows: list, path_of, full, noun="file in vendored code", plural
     return _hide_rows(rows, path_of, full, filetypes.is_vendor_path, noun, plural)
 
 
+def _hide_generated(rows: list, path_of, report: dict, full, noun="generated file", plural=None) -> tuple:
+    """Generated files (a header marker or a linguist-generated attribute, found at run time): the
+    generator's churn and complexity, not the repository's."""
+    generated = set((report.get("meta") or {}).get("generated") or [])
+    return _hide_rows(rows, path_of, full, lambda p: p in generated, noun, plural)
+
+
+def _hide_release(pairs: list, full) -> tuple:
+    """Coupled pairs where both files are release plumbing (version files, manifests, lock files,
+    changelogs): they change together because a release touches them all, not because one depends on
+    the other. A version file paired with real code stays."""
+    if full is True:
+        return pairs, None
+    kept = [p for p in pairs if not (filetypes.is_release_path(p["entity"]) and filetypes.is_release_path(p["coupled"]))]
+    hidden = len(pairs) - len(kept)
+    return kept, (f"{hidden} release pair{'s' if hidden != 1 else ''} hidden{HIDDEN_SUFFIX}" if hidden else None)
+
+
 def _join_hidden(*notes) -> str:
     """Several hidden-row notes as one caption phrase: 'A hidden; B hidden; --full shows them'."""
     parts = [n[:-len(HIDDEN_SUFFIX)] if n.endswith(HIDDEN_SUFFIX) else n for n in notes if n]
@@ -376,7 +394,8 @@ def hotspots_section(report: dict, full: bool = True, width=None) -> dict:
     scored = hotspots.ranked(report)
     scored, hidden_note = _hide_tests(scored, lambda h: h["entity"], full)
     scored, deleted_note = _hide_deleted(scored, report, full)
-    hidden_note = _join_hidden(hidden_note, deleted_note)
+    scored, generated_note = _hide_generated(scored, lambda h: h["entity"], report, full)
+    hidden_note = _join_hidden(hidden_note, deleted_note, generated_note)
     title = "Hotspots (score = revisions × lines of code)" if full is True else "Hotspots"
     limit = _limit("Hotspots", full)
     series = (report.get("trend") or {}).get("files") or {}
@@ -408,6 +427,8 @@ def coupling_section(report: dict, full: bool = True, width=None) -> dict:
     pairs = sorted((p for p in report.get("coupling") or [] if p["average-revs"] >= 5), key=lambda p: (-p["degree"], -p["average-revs"]))
     pairs, hidden_note = _hide_tests(pairs, lambda p: (p["entity"], p["coupled"]), full, noun="test pair")
     pairs, gone_note = _hide_gone(pairs, report, full)
+    pairs, release_note = _hide_release(pairs, full)
+    gone_note = _join_hidden(gone_note, release_note)
     groups, cluster_note = [], None
     if full is not True:
         # a directory whose files all change together is one row; --full lists every pair
@@ -474,7 +495,8 @@ def functions_section(report: dict, full: bool = True, width=None) -> dict:
     funcs = sorted((f for f in measured if f["ccn"] >= CCN_FLOOR), key=lambda f: (-f["ccn"], -f["nloc"], f["file"], f["function"], f["start"]))
     funcs, hidden_note = _hide_tests(funcs, lambda f: f["file"], full, noun="function in a test file", plural="functions in test files")
     funcs, vendor_note = _hide_vendor(funcs, lambda f: f["file"], full, noun="function in vendored code", plural="functions in vendored code")
-    hidden_note = _join_hidden(hidden_note, vendor_note)
+    funcs, generated_note = _hide_generated(funcs, lambda f: f["file"], report, full, noun="function in a generated file", plural="functions in generated files")
+    hidden_note = _join_hidden(hidden_note, vendor_note, generated_note)
     limit = _limit("Complex functions", full)
     rows = [(f["function"], f["file"], f["ccn"], f["nloc"], f["params"]) for f in funcs[:limit]]
     columns = [("function", {"overflow": "fold"}), ("file", PATH), ("ccn", RIGHT), ("lines", RIGHT), ("params", RIGHT)]

{gitmole-0.6.5 → gitmole-0.6.6}/gitmole.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: gitmole
-Version: 0.6.5
+Version: 0.6.6
 Summary: Offline git repository analysis with a terminal report: hotspots, coupling, ownership, code age, secrets, repo health.
 License: MIT
 Project-URL: Homepage, https://github.com/antvinni/gitmole

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_cli.py

@@ -592,6 +592,28 @@ class Arguments(unittest.TestCase):
         self.assertNotIn("jar", text)
 
 
+class GeneratedFiles(unittest.TestCase):
+    def test_a_run_records_the_generated_files_in_meta(self):
+        with tempfile.TemporaryDirectory() as d:
+            _tiny_repo(d)
+            os.makedirs(os.path.join(d, "lib"))
+            with open(os.path.join(d, "lib", "validator.js"), "w") as fh:
+                fh.write("// This file is autogenerated by build/build.js, do not edit\nmodule.exports = 1\n")
+            with open(os.path.join(d, "lib", "app.js"), "w") as fh:
+                fh.write("module.exports = 2\n")
+            import subprocess
+            subprocess.run(["git", "-C", d, "add", "-A"], check=True)
+            subprocess.run(["git", "-C", d, "-c", "user.name=T", "-c", "user.email=t@x.com", "commit", "-q", "-m", "files"], check=True)
+            out = os.path.join(d, "out")
+            planner = lambda repo, o, branch="HEAD", **kw: [{"name": "q", "argv": ["true"], "stdout": None, "deps": []}]
+            rc = cli.main([d, "--out", out], console=console(), tool_check=lambda **kw: [], planner=planner,
+                          estimator=lambda repo, interval, **kw: {"files": 2, "samples": 1, "blames": 2})
+            with open(os.path.join(out, "meta.json")) as fh:
+                meta = json.load(fh)
+        self.assertEqual(rc, 0)
+        self.assertEqual(meta["generated"], ["lib/validator.js"])
+
+
 class Clean(unittest.TestCase):
     """--clean lists what gitmole left behind and deletes on a yes. TMPDIR is pointed at a scratch dir so the
     real temp folder is never listed or touched."""

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_filetypes.py

@@ -104,6 +104,33 @@ class TestPaths(unittest.TestCase):
         for path in ("app/settings.py", "examplesite/app.py", "src/rulesets/a.go", "sampler/x.py", "config/betterleaks.toml"):
             self.assertFalse(filetypes.is_sample_path(path), path)
 
+    def test_release_plumbing_files(self):
+        for path in ("lib/sinatra/version.rb", "VERSION", "src/pkg/__version__.py", "package.json", "package-lock.json", "Gemfile.lock",
+                     "Cargo.toml", "pyproject.toml", "go.sum", "CHANGELOG.md", "CHANGES.rst", "sinatra.gemspec", "uv.lock"):
+            self.assertTrue(filetypes.is_release_path(path), path)
+        for path in ("lib/version_check.py", "src/app.py", "docs/versions.md", "Makefile", "lib/sinatra/base.rb"):
+            self.assertFalse(filetypes.is_release_path(path), path)
+
+    def test_generated_files_by_header_marker_or_attribute(self):
+        with tempfile.TemporaryDirectory() as d:
+            files = {
+                "lib/config-validator.js": "// This file is autogenerated by build/build-validation.js, do not edit\n'use strict'\n",
+                "pb/api.pb.go": "// Code generated by protoc-gen-go. DO NOT EDIT.\npackage pb\n",
+                "gen/schema.py": "# @generated\nx = 1\n",
+                "src/app.py": "# the app; it generated reports once\ndef main():\n    pass\n",
+                "docs/notes.md": "generated notes are the best notes\n",
+                "dist/bundle.js": "var a = 1;\n",
+                "src/late.py": "\n" * 10 + "# generated by hand, do not edit\n",   # a marker past the first lines does not count
+            }
+            for path, text in files.items():
+                os.makedirs(os.path.join(d, os.path.dirname(path)), exist_ok=True)
+                with open(os.path.join(d, path), "w") as fh:
+                    fh.write(text)
+            with open(os.path.join(d, ".gitattributes"), "w") as fh:
+                fh.write("* text=auto\ndist/* linguist-generated=true\n*.min.js linguist-generated\n")
+            found = filetypes.generated_files(d, sorted(files))
+        self.assertEqual(found, ["dist/bundle.js", "gen/schema.py", "lib/config-validator.js", "pb/api.pb.go"])
+
     def test_vendored_trees(self):
         for path in ("vendor/github.com/x/y.go", "web/node_modules/a/index.js", "third_party/z/a.c", "thirdparty/a.c", "_vendor/a.py",
                      "external/lib/a.cpp"):

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_findings.py

@@ -254,6 +254,15 @@ class TightCoupling(unittest.TestCase):
         f = findings.tight_coupling(report(coupling=pairs))
         self.assertIn("2 pairs", f[0]["detail"], "without a tree listing every pair counts")
 
+    def test_release_plumbing_pairs_are_not_a_dependency(self):
+        pairs = [{"entity": "lib/sinatra/version.rb", "coupled": "rack-protection/lib/rack/protection/version.rb", "degree": 100, "average-revs": 60},
+                 {"entity": "package.json", "coupled": "package-lock.json", "degree": 95, "average-revs": 40},
+                 {"entity": "lib/sinatra/version.rb", "coupled": "lib/sinatra/base.rb", "degree": 85, "average-revs": 10}]
+        f = findings.tight_coupling(report(coupling=pairs))
+        self.assertIn("1 pair changes together", f[0]["detail"], "a version file paired with real code still counts")
+        self.assertNotIn("package.json", f[0]["detail"])
+        self.assertEqual(findings.tight_coupling(report(coupling=pairs[:2])), [])
+
     def test_single_pair_reads_grammatically(self):
         pairs = [{"entity": "a", "coupled": "b", "degree": 100, "average-revs": 10}]
         f = findings.tight_coupling(report(coupling=pairs))
@@ -374,6 +383,21 @@ class BrainMethods(unittest.TestCase):
         self.assertNotIn("test_all", f[0]["detail"])
         self.assertEqual(findings.brain_methods(report(functions=fns[:1])), [])
 
+    def test_an_anonymous_function_is_named_by_its_place(self):
+        fns = [{"file": "completions.go", "function": "(anonymous)", "ccn": 47, "nloc": 136, "params": 1, "start": 316, "end": 585}]
+        f = findings.brain_methods(report(functions=fns))
+        self.assertIn("(anonymous) (completions.go:316) complexity 47, 136 lines, 1 params", f[0]["detail"])
+        self.assertEqual(f[0]["advice"], "Split the anonymous function at completions.go:316 first, before the next change lands there.")
+
+    def test_generated_files_are_not_brain_methods(self):
+        fns = [{"file": "lib/config-validator.js", "function": "validate10", "ccn": 373, "nloc": 1150, "params": 5, "start": 1, "end": 1150},
+               {"file": "lib/reply.js", "function": "onSendEnd", "ccn": 34, "nloc": 180, "params": 2, "start": 1, "end": 180}]
+        r = report(functions=fns)
+        r["meta"]["generated"] = ["lib/config-validator.js"]
+        f = findings.brain_methods(r)
+        self.assertEqual(f[0]["advice"], "Split onSendEnd in lib/reply.js first, before the next change lands there.")
+        self.assertNotIn("validate10", f[0]["detail"])
+
     def test_vendored_functions_are_not_brain_methods(self):
         fns = [{"file": "vendor/github.com/google/jsonschema-go/jsonschema/validate.go", "function": "validate", "ccn": 179, "nloc": 424, "params": 3, "start": 1, "end": 424},
                {"file": "processor/workers.go", "function": "countLoopGeneric", "ccn": 56, "nloc": 164, "params": 8, "start": 1, "end": 164}]

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_identity.py

@@ -18,6 +18,19 @@ class Merge(unittest.TestCase):
         names = [m["name"] for m in merged]
         self.assertEqual(names, ["Bob", "Grzegorz Bankosz", "Ann"])
 
+    def test_an_identical_handle_under_several_emails_is_one_person(self):
+        ids = [{"name": "KaKa", "email": "kaka@a.com", "commits": 57}, {"name": "KaKa", "email": "23028015+climba@users.noreply.github.com", "commits": 56},
+               {"name": "kaka", "email": "climba@b.com", "commits": 10}, {"name": "namusyaka", "email": "n@a.com", "commits": 180},
+               {"name": "namusyaka", "email": "n@b.com", "commits": 8}, {"name": "Li Yu", "email": "li@a.com", "commits": 5},
+               {"name": "Li Yu", "email": "li@b.com", "commits": 3}]
+        merged = {m["name"]: m["commits"] for m in identity.merge(ids)}
+        self.assertEqual(merged, {"KaKa": 123, "namusyaka": 188, "Li Yu": 8})
+
+    def test_a_bare_common_first_name_is_not_enough(self):
+        ids = [{"name": "Jean", "email": "jean@a.com", "commits": 24}, {"name": "Jean", "email": "jean@b.com", "commits": 18},
+               {"name": "Alex", "email": "alex@a.com", "commits": 3}, {"name": "alex", "email": "alex@b.com", "commits": 2}]
+        self.assertEqual(len(identity.merge(ids)), 4, "two Jeans and two Alexes may be four people")
+
     def test_merged_row_sums_commits_and_lists_aliases(self):
         merged = {m["name"]: m for m in identity.merge(IDS)}
         self.assertEqual(merged["Grzegorz Bankosz"]["commits"], 41)

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_load.py

@@ -138,6 +138,11 @@ class ParseFunctions(unittest.TestCase):
     def test_empty(self):
         self.assertEqual(load.parse_functions(""), [])
 
+    def test_a_nameless_function_is_called_anonymous(self):
+        # lizard names Go function literals with an empty string where it names JavaScript's "(anonymous)"
+        rows = load.parse_functions('136,47,926,1,270,"@316-585@completions.go","completions.go",""," c * Command",316,585\n')
+        self.assertEqual((rows[0]["function"], rows[0]["start"]), ("(anonymous)", 316))
+
     def test_a_row_cut_short_by_a_killed_step_does_not_abort_the_report(self):
         rows = load.parse_functions(self.CSV + '5,3,40,1,5,"g@1-5@a.py","a.py","g","g( )",1,\n')
         self.assertEqual(len(rows), 3)

{gitmole-0.6.5 → gitmole-0.6.6}/tests/test_render.py

@@ -318,6 +318,36 @@ class Report(unittest.TestCase):
         full = _section_text(rendered(r, [], width=200, full=True), "Complex functions")
         self.assertIn("vendor/github.com/x/y.go", full)
 
+    def test_default_tables_hide_generated_files_and_say_so(self):
+        r = sample_report()
+        r["meta"]["generated"] = ["lib/config-validator.js"]
+        r["size"]["files"]["lib/config-validator.js"] = {"code": 1153, "complexity": 373}
+        r["revisions"].append({"entity": "lib/config-validator.js", "n-revs": 8})
+        r["functions"].append({"file": "lib/config-validator.js", "function": "validate10", "ccn": 373, "nloc": 1150, "params": 5, "start": 1, "end": 1150})
+        text = rendered(r, [], width=200)
+        hot = text[text.index("◆ Hotspots"):text.index("Change coupling")]
+        self.assertNotIn("config-validator", hot)
+        self.assertIn("1 generated file hidden; --full shows them", hot)
+        fn = _section_text(text, "Complex functions")
+        self.assertNotIn("validate10", fn)
+        self.assertIn("1 function in a generated file hidden; --full shows them", fn)
+        full = rendered(r, [], width=200, full=True)
+        self.assertIn("validate10", full)
+
+    def test_default_coupling_hides_release_plumbing_pairs_and_says_so(self):
+        r = sample_report()
+        for f in ("lib/version.rb", "contrib/version.rb", "Gemfile", "Gemfile.lock"):
+            r["size"]["files"][f] = {"code": 3, "complexity": 0}
+        r["coupling"] = [{"entity": "lib/version.rb", "coupled": "contrib/version.rb", "degree": 64, "average-revs": 60},
+                         {"entity": "Gemfile", "coupled": "Gemfile.lock", "degree": 90, "average-revs": 20},
+                         {"entity": "static/index.html", "coupled": "static/apps-metadata.json", "degree": 90, "average-revs": 11}]
+        coupling = _section_text(rendered(r, [], width=200), "Change coupling")
+        self.assertIn("static/index.html", coupling)
+        self.assertNotIn("version.rb", coupling)
+        self.assertIn("2 release pairs hidden; --full shows them", coupling)
+        full = _section_text(rendered(r, [], width=200, full=True), "Change coupling")
+        self.assertIn("version.rb", full)
+
     def test_hotspots_with_only_test_files_say_what_was_hidden(self):
         r = sample_report()
         r["revisions"] = [{"entity": "tests/test_a.py", "n-revs": 200}]