github2gerrit 1.4.0__tar.gz → 1.4.2__tar.gz

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/.pre-commit-config.yaml

@@ -59,7 +59,7 @@ repos:
         types: [yaml]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: c59bba8fb259db0fec2bbb77ad8ba51ea7341b56  # frozen: v0.15.20
+    rev: 01a675ea018f2fb714478a5ffb83fcea8374bb06  # frozen: v0.15.21
     hooks:
       - id: ruff
         files: ^(src|scripts|tests)/.+\.py$
@@ -68,7 +68,7 @@ repos:
         files: ^(src|scripts|tests)/.+\.py$
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: d2823d321df3af8f878f7ee3414dc94d037145b9  # frozen: v2.1.0
+    rev: 41e691678310dfd3833f7ab4e180ddb014310356  # frozen: v2.3.0
     hooks:
       - id: mypy
         files: ^src/.+\.py$

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: github2gerrit
-Version: 1.4.0
+Version: 1.4.2
 Summary: Submit a GitHub pull request to a Gerrit repository.
 Project-URL: Homepage, https://github.com/lfreleng-actions/github2gerrit-action
 Project-URL: Repository, https://github.com/lfreleng-actions/github2gerrit-action
@@ -353,9 +353,11 @@ dispatches the caller workflow to report a merged or abandoned
 change, forward these dispatch inputs and the tool closes the source
 GitHub PR instead of processing pull requests.
 
-Setting the repository variable `G2G_NO_GERRIT` to `true` makes runs
-skip Gerrit interaction. Test-only settings (`CI_TESTING`,
-`USE_LOCAL_ACTION`) remain composite-action-only by design.
+Repository variables provide operational kill switches: set
+`G2G_NO_GERRIT` to `true` to skip Gerrit interaction, or
+`G2G_DISABLED` to `true` to exit immediately without processing.
+Test-only settings (`CI_TESTING`, `USE_LOCAL_ACTION`) remain
+composite-action-only by design.
 
 ## Documentation
 

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/README.md

@@ -307,9 +307,11 @@ dispatches the caller workflow to report a merged or abandoned
 change, forward these dispatch inputs and the tool closes the source
 GitHub PR instead of processing pull requests.
 
-Setting the repository variable `G2G_NO_GERRIT` to `true` makes runs
-skip Gerrit interaction. Test-only settings (`CI_TESTING`,
-`USE_LOCAL_ACTION`) remain composite-action-only by design.
+Repository variables provide operational kill switches: set
+`G2G_NO_GERRIT` to `true` to skip Gerrit interaction, or
+`G2G_DISABLED` to `true` to exit immediately without processing.
+Test-only settings (`CI_TESTING`, `USE_LOCAL_ACTION`) remain
+composite-action-only by design.
 
 ## Documentation
 

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/action.yaml

@@ -22,6 +22,15 @@ inputs:
     description: "Fetch depth for checkout"
     required: false
     default: "10"
+  SKIP_CHECKOUT:
+    description: >-
+      Skip the internal repository checkout. Set when the caller has
+      already checked out the target repository at the desired ref
+      (e.g. the bundled reusable workflow, which also checks out this
+      action into the workspace and must not have it deleted by a
+      nested checkout)
+    required: false
+    default: "false"
   PR_NUMBER:
     description: "Pull request number to process, use 0 to process all open"
     required: false
@@ -108,7 +117,7 @@ inputs:
     required: false
     default: ""
   GERRIT_SERVER_PORT:
-    description: "Gerrit serverSSH TCP/port"
+    description: "Gerrit server SSH TCP port"
     required: false
     default: "29418"
   GERRIT_PROJECT:
@@ -205,7 +214,8 @@ runs:
         fi
 
     - name: "Checkout repository"
-      if: steps.disabled-check.outputs.disabled != 'true'
+      # yamllint disable-line rule:line-length
+      if: steps.disabled-check.outputs.disabled != 'true' && inputs.SKIP_CHECKOUT != 'true'
       # yamllint disable-line rule:line-length
       uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0  # v7.0.0
       with:
@@ -227,7 +237,7 @@ runs:
     - name: "Setup uv"
       if: steps.disabled-check.outputs.disabled != 'true'
       # yamllint disable-line rule:line-length
-      uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39  # v8.2.0
+      uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990  # v8.3.2
       with:
         enable-cache: false
 

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/docs/cli.md

@@ -159,26 +159,33 @@ Some settings have no CLI flag and use environment variables:
 
 <!-- markdownlint-disable MD013 -->
 
-| Variable                   | Default                                     | Description                                                                      |
-| -------------------------- | ------------------------------------------- | -------------------------------------------------------------------------------- |
-| `G2G_CONFIG_PATH`          | `~/.config/github2gerrit/configuration.txt` | Path to the per-organization configuration file                                  |
-| `G2G_LOG_LEVEL`            | `WARNING`                                   | Logging level; set `DEBUG` for verbose output                                    |
-| `G2G_TOPIC_PREFIX`         | `GH`                                        | Prefix used when generating Gerrit topics                                        |
-| `G2G_SKIP_GERRIT_COMMENTS` | `false`                                     | Skip posting back-reference comments on Gerrit changes                           |
-| `G2G_ENABLE_DERIVATION`    | `true`                                      | Enable automatic derivation of Gerrit parameters from organization defaults      |
-| `G2G_AUTO_SAVE_CONFIG`     | context-dependent                           | Save derived parameters back to the configuration file                           |
-| `G2G_RESPECT_USER_SSH`     | `false` (`true` in direct URL mode)         | Use the local user's SSH configuration and keys instead of provided key material |
-| `G2G_USE_SSH_AGENT`        | `true`                                      | Use SSH agent authentication; set `false` to force file-based SSH keys           |
-| `G2G_NO_GERRIT`            | `false`                                     | Run the full pipeline without contacting Gerrit (forces dry-run behavior)        |
-| `G2G_DISABLED`             | `false`                                     | Exit immediately with success without processing anything                        |
-| `CLEANUP_ABANDONED`        | `true`                                      | Close GitHub PRs whose Gerrit changes have status abandoned                      |
-| `CLEANUP_GERRIT`           | `true`                                      | Abandon Gerrit changes for closed GitHub PRs                                     |
-| `PR_NUMBER`                | unset                                       | Pull request number to process in CI/CD mode (`0` means bulk mode)               |
-| `SYNC_ALL_OPEN_PRS`        | `false`                                     | Process all open PRs in the repository (bulk mode)                               |
-| `GERRIT_HTTP_USER`         | unset                                       | Username for the Gerrit REST API (when required)                                 |
-| `GERRIT_HTTP_PASSWORD`     | unset                                       | HTTP password/token for the Gerrit REST API                                      |
-| `GERRIT_HTTP_BASE_PATH`    | unset                                       | Gerrit REST base path for non-standard deployments (e.g., `/r`)                  |
-| `GITHUB_TOKEN`             | unset                                       | GitHub API token; required for PR queries, comments, and closing PRs             |
+| Variable                      | Default                                     | Description                                                                      |
+| ----------------------------- | ------------------------------------------- | -------------------------------------------------------------------------------- |
+| `G2G_CONFIG_PATH`             | `~/.config/github2gerrit/configuration.txt` | Path to the per-organization configuration file                                  |
+| `G2G_LOG_LEVEL`               | `WARNING`                                   | Logging level; set `DEBUG` for verbose output                                    |
+| `G2G_TOPIC_PREFIX`            | `GH`                                        | Prefix used when generating Gerrit topics                                        |
+| `G2G_SKIP_GERRIT_COMMENTS`    | `false`                                     | Skip posting back-reference comments on Gerrit changes                           |
+| `G2G_ENABLE_DERIVATION`       | `true`                                      | Enable automatic derivation of Gerrit parameters from organization defaults      |
+| `G2G_AUTO_SAVE_CONFIG`        | context-dependent                           | Save derived parameters back to the configuration file                           |
+| `G2G_RESPECT_USER_SSH`        | `false` (`true` in direct URL mode)         | Use the local user's SSH configuration and keys instead of provided key material |
+| `G2G_USE_SSH_AGENT`           | `true`                                      | Use SSH agent authentication; set `false` to force file-based SSH keys           |
+| `G2G_NO_GERRIT`               | `false`                                     | Run the full pipeline without contacting Gerrit (forces dry-run behavior)        |
+| `G2G_DISABLED`                | `false`                                     | Exit immediately with success without processing anything                        |
+| `CLEANUP_ABANDONED`           | `true`                                      | Close GitHub PRs whose Gerrit changes have status abandoned                      |
+| `CLEANUP_GERRIT`              | `true`                                      | Abandon Gerrit changes for closed GitHub PRs                                     |
+| `PR_NUMBER`                   | unset                                       | Pull request number to process in CI/CD mode (`0` means bulk mode)               |
+| `SYNC_ALL_OPEN_PRS`           | `false`                                     | Process all open PRs in the repository (bulk mode)                               |
+| `GERRIT_HTTP_USER`            | unset                                       | Username for the Gerrit REST API (when required)                                 |
+| `GERRIT_HTTP_PASSWORD`        | unset                                       | HTTP password/token for the Gerrit REST API                                      |
+| `GERRIT_HTTP_BASE_PATH`       | unset                                       | Gerrit REST base path for non-standard deployments (e.g., `/r`)                  |
+| `GITHUB_TOKEN`                | unset                                       | GitHub API token; required for PR queries, comments, and closing PRs             |
+| `GH_TOKEN`                    | unset                                       | Fallback source for `GITHUB_TOKEN` when the latter is unset                      |
+| `GERRIT_CHANGE_URL`           | unset                                       | Gerrit change URL for Gerrit-event dispatch mode (close the source PR)           |
+| `GERRIT_EVENT_TYPE`           | unset                                       | Gerrit event type for dispatch mode (`change-merged` or `change-abandoned`)      |
+| `GERRIT_BRANCH`               | unset                                       | Gerrit branch for dispatch mode change queries                                   |
+| `G2G_DRYRUN_DISABLE_NETWORK`  | `false`                                     | Skip DNS/network checks in dry-run; set automatically by `G2G_NO_GERRIT`         |
+| `G2G_ANON_SUPERSEDE_FALLBACK` | `true`                                      | Allow anonymous supersession queries when Gerrit credentials are unavailable     |
+| `VERIFY_DIGEST_STRICT`        | `true`                                      | Fail (rather than warn) on reconciliation digest mismatch after push             |
 
 <!-- markdownlint-enable MD013 -->
 

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/docs/features.md

@@ -44,8 +44,8 @@ When a PR updates (for example, Dependabot rebases or updates dependencies):
 1. The `synchronize` event triggers UPDATE mode.
 2. The tool recovers the existing Gerrit change using five strategies,
    in order:
-   - Topic-based query (`GH-<owner>-<repo>-<pr-number>`, where `<repo>` is
-     the GitHub repository name without the owner prefix)
+   - Topic-based query (`<prefix>-<project>-<pr-number>`, matching the
+     topic the tool pushed; see "Topic naming" under Behavior Details)
    - `GitHub-Hash` trailer matching
    - `GitHub-PR` trailer URL matching
    - Mapping comment parsing from PR comments
@@ -702,12 +702,11 @@ Lookup logic:
 
 - Branch resolution: uses `GITHUB_BASE_REF` as the target branch for Gerrit,
   defaulting to `master` when unset.
-- Topic naming: pushes use `<prefix>-<project>-<pr-number>`, where
-  `<prefix>` comes from `G2G_TOPIC_PREFIX` (default `GH`) and `<project>`
-  is the Gerrit project path with `/` replaced by `-` (or the GitHub
-  repository name when `.gitreview` is unavailable). Change recovery
-  queries use `GH-<owner>-<repo>-<pr-number>` with the GitHub owner and
-  repository name.
+- Topic naming: pushes and change recovery queries use
+  `<prefix>-<project>-<pr-number>`, where `<prefix>` comes from
+  `G2G_TOPIC_PREFIX` (default `GH`) and `<project>` is the Gerrit
+  project path with `/` replaced by `-` (or the GitHub repository name
+  when `.gitreview` is unavailable).
 - GitHub Enterprise support: direct URL mode accepts enterprise GitHub hosts
   when explicitly enabled via `--allow-ghe-urls` or `ALLOW_GHE_URLS="true"`
   (default: off). The tool determines the GitHub API base URL from

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/pyproject.toml

@@ -199,10 +199,6 @@ ignore_missing_imports = true
 module = ["typer", "typer.*"]
 ignore_missing_imports = true
 
-[[tool.mypy.overrides]]
-module = ["importlib_metadata"]
-ignore_missing_imports = true
-
 [[tool.mypy.overrides]]
 module = ["pytest", "pytest.*"]
 ignore_missing_imports = true
@@ -220,6 +216,12 @@ disallow_untyped_calls = false
 
 [tool.coverage.run]
 branch = true
+# Keep transient coverage data out of the working tree so tests that
+# inspect on-disk repository content never see .coverage* files.
+# During pytest runs tests/conftest.py sets COVERAGE_FILE (env), which
+# takes precedence; this value covers direct coverage invocations and
+# satisfies python-test-action's data_file configuration check.
+data_file = "${TMPDIR-/tmp}/.coverage.github2gerrit"
 source = ["github2gerrit"]
 omit = [
   "tests/*",

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/src/github2gerrit/cli.py

@@ -88,15 +88,10 @@ from .utils import parse_bool_env
 
 
 def get_version(package: str) -> str:
-    """Get package version, trying importlib.metadata first, then fallback."""
-    try:
-        from importlib.metadata import version as stdlib_version
-
-        return str(stdlib_version(package))
-    except ImportError:
-        from importlib_metadata import version as backport_version
+    """Get the installed package version via importlib.metadata."""
+    from importlib.metadata import version
 
-        return str(backport_version(package))
+    return str(version(package))
 
 
 # Legacy error handling functions - now use centralized error_codes module
@@ -184,7 +179,6 @@ def _check_automation_only(
         "pre-commit-ci",
     ]
 
-    # Get PR author
     pr_author = getattr(getattr(pr_obj, "user", None), "login", "")
     if not pr_author:
         log.warning("Unable to determine PR author, allowing PR to proceed")
@@ -262,10 +256,8 @@ def _extract_and_display_pr_info(
         # Check if automation_only is enabled and reject non-automation PRs
         _check_automation_only(pr_obj, gh, progress_tracker)
 
-        # Extract PR information
         title, _body = get_pr_title_body(pr_obj)
 
-        # Get additional PR details
         pr_info = {
             "Repository": gh.repository,
             "PR Number": gh.pr_number,
@@ -364,7 +356,6 @@ def _parse_github_target(url: str) -> GitHubPRTarget | GitHubRepoTarget:
 
     owner, repo = parts[0], parts[1]
 
-    # Check for PR URL
     if len(parts) >= 4 and parts[2] in ("pull", "pulls"):
         try:
             pr_number = int(parts[3])
@@ -378,7 +369,6 @@ def _parse_github_target(url: str) -> GitHubPRTarget | GitHubRepoTarget:
 
 APP_NAME = "github2gerrit"
 
-
 if TYPE_CHECKING:
     BaseGroup = object
 else:
@@ -429,10 +419,8 @@ def _resolve_issue_id_from_json(json_str: str, github_actor: str) -> str:
         return ""
 
     try:
-        # Parse JSON
         lookup_data = json.loads(json_str)
 
-        # Validate it's an array
         if not isinstance(lookup_data, list):
             log.warning(
                 "⚠️ Warning: Issue-ID JSON was not valid (expected array)"
@@ -484,8 +472,11 @@ def _print_version_banner() -> None:
     try:
         app_version = get_version("github2gerrit")
         print(f"🏷️  github2gerrit version {app_version}")
-    except Exception:
-        print("⚠️  github2gerrit version information not available")
+    # The banner is cosmetic: a missing or unreadable package version
+    # must never block CLI startup.
+    # aislop-ignore-next-line swallowed-exception
+    except Exception as exc:
+        print(f"⚠️  github2gerrit version information not available: {exc}")
 
 
 # Show version information when --help is used or in GitHub Actions mode
@@ -531,7 +522,6 @@ def _save_derived_parameters_after_success(data: Inputs) -> None:
     """Save derived parameters to config file after successful Gerrit
     submission."""
     try:
-        # Get the organization used for derivation
         org_for_cfg = (
             data.organization
             or os.getenv("ORGANIZATION")
@@ -756,8 +746,6 @@ def main(
         envvar="G2G_SHOW_PROGRESS",
         help="Show real-time progress updates with Rich formatting.",
     ),
-    # BREAKING CHANGE v0.2.0: Default changed from True to False
-    # for more flexible commit reconciliation
     similarity_files: bool = typer.Option(
         False,
         "--similarity-files/--no-similarity-files",
@@ -852,7 +840,6 @@ def main(
     - No arguments: environment variables determine behaviour (CI/CD mode)
     """
 
-    # Handle version flag first
     if version_flag:
         try:
             app_version = get_version("github2gerrit")
@@ -931,7 +918,6 @@ def main(
 
     # Handle netrc credential loading if enabled
     if not no_netrc:
-        # Get the Gerrit server from environment or CLI
         gerrit_host = gerrit_server or os.getenv("GERRIT_SERVER", "")
         if gerrit_host:
             try:
@@ -963,21 +949,18 @@ def main(
                 safe_typer_echo(f"❌ Failed to parse .netrc file: {e}")
                 sys.exit(int(ExitCode.CONFIGURATION_ERROR))
 
-    # Set up logging level based on verbose flag
     if verbose:
         os.environ["G2G_LOG_LEVEL"] = "DEBUG"
         _reconfigure_logging()
 
-    # Initialize Rich-aware logging system
     setup_rich_aware_logging()
 
-    # Log version to logs in GitHub Actions environment
     if _is_github_actions_context():
         try:
             app_version = get_version("github2gerrit")
             log.debug("github2gerrit version %s", app_version)
-        except Exception:
-            log.warning("Version information not available")
+        except Exception as exc:
+            log.warning("Version information not available: %s", exc)
 
     # Show initial progress if Rich is available and progress is enabled
     if show_progress and not RICH_AVAILABLE:
@@ -1041,7 +1024,6 @@ def main(
     if reuse_strategy:
         os.environ["REUSE_STRATEGY"] = reuse_strategy
 
-    # Validate similarity parameters
     if not (0.0 <= similarity_subject <= 1.0):
         msg = (
             f"similarity_subject must be between 0.0 and 1.0, "
@@ -1231,7 +1213,6 @@ def _build_inputs_from_env() -> Inputs:
 
 
 def _process_bulk(data: Inputs, gh: GitHubContext) -> bool:
-    # Initialize progress tracker for processing
     show_progress = env_bool("G2G_SHOW_PROGRESS", True)
     target = gh.repository
 
@@ -1303,7 +1284,6 @@ def _process_bulk(data: Inputs, gh: GitHubContext) -> bool:
             gh.event_action,
         )
 
-        # Update progress tracker for this PR
         progress_tracker.update_operation(f"Processing PR #{pr_number}...")
         progress_tracker.pr_processed()
 
@@ -1391,7 +1371,6 @@ def _process_bulk(data: Inputs, gh: GitHubContext) -> bool:
         )
         pr_tasks.append((pr, per_ctx))
 
-    # Process PRs in parallel
     with ThreadPoolExecutor(max_workers=max_workers) as executor:
         log.debug(
             "Processing %d PRs with %d parallel workers",
@@ -1495,7 +1474,6 @@ def _process_bulk(data: Inputs, gh: GitHubContext) -> bool:
         }
     )
 
-    # Stop progress tracker and show final results
     if failed_count == 0:
         progress_tracker.update_operation("Processing completed ✅")
     else:
@@ -1544,7 +1522,6 @@ def _process_single(
     gh: GitHubContext,
     progress_tracker: G2GProgressTracker | DummyProgressTracker | None = None,
 ) -> tuple[bool, SubmissionResult]:
-    # Create temporary directory for all git operations
     with tempfile.TemporaryDirectory() as temp_dir:
         workspace = Path(temp_dir)
 
@@ -1770,7 +1747,6 @@ def _process_single(
 
 
 def _load_effective_inputs() -> Inputs:
-    # Build inputs from environment (used by URL callback path)
     data = _build_inputs_from_env()
 
     # Detect GitHub CI mode and configure accordingly
@@ -1789,7 +1765,6 @@ def _load_effective_inputs() -> Inputs:
     )
     cfg = load_org_config(org_for_cfg)
 
-    # Get repository for GERRIT_PROJECT derivation
     repository = os.getenv("GITHUB_REPOSITORY", "")
 
     # Apply dynamic parameter derivation for missing Gerrit parameters
@@ -1939,7 +1914,6 @@ def _process_close_gerrit_change(
     # Check if close_merged_prs is enabled
     close_merged_prs = env_bool("CLOSE_MERGED_PRS", True)
 
-    # Check Gerrit change status
     status = check_gerrit_change_status(gerrit_change_url)
 
     # Validate status: without --force, reject MERGED/ABANDONED changes
@@ -1956,7 +1930,9 @@ def _process_close_gerrit_change(
             error_msg,
         )
 
-    # Log status information
+    # Branches vary in log level and nested close_merged_prs handling,
+    # so a dispatch table would obscure this status logging.
+    # aislop-ignore-next-line python-repetitive-dispatch
     if status == "ABANDONED":
         if close_merged_prs:
             log.debug(
@@ -1983,7 +1959,6 @@ def _process_close_gerrit_change(
 
     log.debug("Found GitHub PR URL: %s", pr_url)
 
-    # Parse PR URL to get owner info for auto-discovery
     parsed = parse_pr_url(pr_url)
     if not parsed:
         log.error("Failed to parse PR URL: %s", pr_url)
@@ -2007,6 +1982,9 @@ def _process_close_gerrit_change(
             progress_tracker=None,
             close_merged_prs=close_merged_prs,
         )
+    # log.exception records the caught error and traceback; keep
+    # processing so one PR failure cannot abort the remaining closures.
+    # aislop-ignore-next-line silent-recovery
     except Exception:
         log.exception("Failed to close GitHub PR #%d", pr_number)
 
@@ -2028,7 +2006,6 @@ def _process_close_merged_prs(data: Inputs, gh: GitHubContext) -> None:
     """
     log.info("🔄 Processing merged Gerrit changes to close GitHub PRs")
 
-    # Initialize progress tracker
     show_progress = env_bool("G2G_SHOW_PROGRESS", True)
     target = gh.repository
 
@@ -2054,7 +2031,6 @@ def _process_close_merged_prs(data: Inputs, gh: GitHubContext) -> None:
                 with gh.event_path.open() as f:
                     event_payload = json.load(f)
 
-                # Extract commit SHAs from the push event
                 if "commits" in event_payload:
                     commit_shas = [
                         commit["id"]
@@ -2141,7 +2117,6 @@ def _process_close_merged_prs(data: Inputs, gh: GitHubContext) -> None:
 def _process() -> None:
     data = _load_effective_inputs()
 
-    # Validate inputs
     try:
         _validate_inputs(data)
     except ConfigurationError as exc:
@@ -2151,11 +2126,11 @@ def _process() -> None:
 
     gh = _read_github_context()
 
-    # --- G2G_NO_GERRIT: leverage DRY_RUN infrastructure ---
-    # G2G_NO_GERRIT reuses the existing DRY_RUN + G2G_DRYRUN_DISABLE_NETWORK
-    # code paths so that all tool logic runs but Gerrit network operations
-    # are no-ops.  Cleanup tasks (abandoned-PR / Gerrit-change sweeps) are
-    # also suppressed because they would hit a non-existent server.
+    # G2G_NO_GERRIT reuses the existing DRY_RUN +
+    # G2G_DRYRUN_DISABLE_NETWORK code paths so that all tool logic runs
+    # but Gerrit network operations are no-ops. Cleanup tasks
+    # (abandoned-PR / Gerrit-change sweeps) are also suppressed because
+    # they would hit a non-existent server.
     no_gerrit = env_bool("G2G_NO_GERRIT", False)
 
     if no_gerrit:
@@ -2336,7 +2311,6 @@ def _process() -> None:
     # 2. Direct Gerrit change URL provided in CLI
     # 3. Gerrit event dispatched via workflow_dispatch (GERRIT_CHANGE_URL set)
 
-    # Check for Gerrit event inputs from workflow_dispatch
     gerrit_event_change_url = os.getenv("GERRIT_CHANGE_URL")
     gerrit_event_type = os.getenv("GERRIT_EVENT_TYPE")
 
@@ -2469,7 +2443,6 @@ def _process() -> None:
     ):
         bulk_success = _process_bulk(data, gh)
 
-        # Log external API metrics summary
         try:
             log_api_metrics_summary()
         except Exception as exc:
@@ -2702,7 +2675,6 @@ def _process() -> None:
             # Don't fail the whole pipeline if cleanup fails
             log.warning("Gerrit cleanup failed: %s", exc)
 
-    # Log external API metrics summary
     try:
         log_api_metrics_summary()
     except Exception as exc:
@@ -2911,7 +2883,6 @@ def _validate_inputs(data: Inputs) -> None:
                 _MSG_MISSING_REQUIRED_INPUT.format(field_name=field_name)
             )
 
-    # Validate fetch depth is a positive integer
     if data.fetch_depth <= 0:
         log.error("Invalid FETCH_DEPTH: %s", data.fetch_depth)
         raise ConfigurationError(_MSG_INVALID_FETCH_DEPTH)

{github2gerrit-1.4.0 → github2gerrit-1.4.2}/src/github2gerrit/commit_normalization.py

@@ -149,7 +149,6 @@ class CommitNormalizer:
         if self._is_conventional_commit(title):
             return False
 
-        # Check for automation patterns
         return self._is_automation_pr(title, author)
 
     def normalize_commit_title(self, title: str, author: str) -> str:
@@ -165,7 +164,6 @@ class CommitNormalizer:
         # Determine the appropriate conventional commit type
         commit_type = self._determine_commit_type(title, author)
 
-        # Clean and normalize the title
         normalized_title = self._clean_title(title)
 
         # Apply conventional commit format
@@ -181,7 +179,6 @@ class CommitNormalizer:
 
     def _is_automation_pr(self, title: str, author: str) -> bool:
         """Check if this is an automation PR that should be normalized."""
-        # Check for known automation authors
         automation_authors = [
             "dependabot[bot]",
             "dependabot-preview[bot]",
@@ -195,7 +192,6 @@ class CommitNormalizer:
         ):
             return True
 
-        # Check for automation patterns in title
         automation_patterns = [
             r"^bump\s+",
             r"^update\s+.*\s+from\s+.*\s+to\s+",
@@ -216,10 +212,8 @@ class CommitNormalizer:
             self.workspace,
         )
 
-        # Check .pre-commit-config.yaml
         self._check_precommit_config()
 
-        # Check .github/release-drafter.yml
         self._check_release_drafter_config()
 
         # Analyze git history
@@ -239,12 +233,10 @@ class CommitNormalizer:
 
             ci_config = config.get("ci", {})
 
-            # Check autofix commit message
             autofix_msg = ci_config.get("autofix_commit_msg", "")
             if autofix_msg:
                 self._extract_preferences_from_message(autofix_msg)
 
-            # Check autoupdate commit message
             autoupdate_msg = ci_config.get("autoupdate_commit_msg", "")
             if autoupdate_msg:
                 self._extract_preferences_from_message(autoupdate_msg)
@@ -272,7 +264,6 @@ class CommitNormalizer:
                     titles = rule.get("title", [])
 
                     for title_pattern in titles:
-                        # Extract conventional commit type from pattern
                         if title_pattern.startswith(
                             "/"
                         ) and title_pattern.endswith("/i"):
@@ -292,7 +283,6 @@ class CommitNormalizer:
     def _analyze_git_history(self) -> None:
         """Analyze recent git history for conventional commit patterns."""
         try:
-            # Get recent commit messages
             git_cmd = shutil.which("git")
             if not git_cmd:
                 log.debug("git command not found in PATH")
@@ -332,7 +322,6 @@ class CommitNormalizer:
                                 1
                             )
 
-            # Update preferences based on analysis
             if type_counts:
                 # Determine most common capitalization
                 if capitalization_examples:
@@ -344,7 +333,6 @@ class CommitNormalizer:
                     else:
                         self.preferences.capitalization = "lower"
 
-                # Update preferred types
                 for commit_type in type_counts:
                     if commit_type in CONVENTIONAL_COMMIT_TYPES:
                         self.preferences.preferred_types[commit_type] = (
@@ -374,13 +362,11 @@ class CommitNormalizer:
         """Determine the appropriate conventional commit type."""
         title_lower = title.lower()
 
-        # Check for dependabot patterns first
         if "dependabot" in author.lower() or any(
             re.search(pattern, title_lower) for pattern in DEPENDABOT_PATTERNS
         ):
             return self.preferences.dependency_type
 
-        # Check for pre-commit.ci patterns
         if "pre-commit" in author.lower() or "pre-commit" in title_lower:
             return self.preferences.automation_type
 
@@ -395,10 +381,8 @@ class CommitNormalizer:
 
     def _clean_title(self, title: str) -> str:
         """Clean and normalize the title text."""
-        # Remove markdown links
         title = re.sub(r"\[([^\]]+)\]\([^)]+\)", r"\1", title)
 
-        # Remove trailing ellipsis
         title = re.sub(r"\s*[.]{3,}.*$", "", title)
 
         # Remove markdown bold/code formatting but preserve underscores