github2gerrit 1.3.0__tar.gz → 1.3.1__tar.gz

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: github2gerrit
-Version: 1.3.0
+Version: 1.3.1
 Summary: Submit a GitHub pull request to a Gerrit repository.
 Project-URL: Homepage, https://github.com/lfreleng-actions/github2gerrit-action
 Project-URL: Repository, https://github.com/lfreleng-actions/github2gerrit-action

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/src/github2gerrit/cli.py

@@ -504,9 +504,12 @@ def _resolve_org(default_org: str | None) -> str:
 if TYPE_CHECKING:
     F = TypeVar("F", bound=Callable[..., object])
 
-    def typed_app_command(
-        *args: object, **kwargs: object
-    ) -> Callable[[F], F]: ...
+    # Typed stub so basedpyright treats @typed_app_command as a typed
+    # decorator. The body raises rather than using an ellipsis so static
+    # analysers do not model it as a procedure that returns None; this
+    # branch is never executed at runtime.
+    def typed_app_command(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
 else:
     typed_app_command = app.command
 
@@ -865,7 +868,7 @@ def main(
     ) -> bool:
         """Return *current* if the CLI flag was explicit, else parse env."""
         source = ctx.get_parameter_source(param_name)  # pyright: ignore[reportAttributeAccessIssue]
-        if source == click.core.ParameterSource.COMMANDLINE:  # pyright: ignore[reportAttributeAccessIssue]
+        if source == click.core.ParameterSource.COMMANDLINE:  # pyright: ignore[reportAttributeAccessIssue, reportUnnecessaryComparison]
             return current
         env_val = os.getenv(env_var)
         if env_val is not None:

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/src/github2gerrit/gerrit_rest.py

@@ -321,7 +321,6 @@ class GerritRestClient:
             )
 
             with urllib.request.urlopen(req, timeout=self._timeout) as resp:
-                status = getattr(resp, "status", None)
                 content = resp.read()
                 # Gerrit prepends ")]}'" in JSON responses to prevent JSON
                 # hijacking; strip if present

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/src/github2gerrit/ssh_config_parser.py

@@ -272,8 +272,9 @@ class SSHConfig:
         try:
             return bool(re.match(regex_pattern, hostname))
         except re.error:
-            # If regex is invalid, fall back to exact match
-            return pattern == hostname
+            # An invalid regex cannot match. The exact-match case is
+            # already handled above, so there is nothing left to match.
+            return False
 
 
 # Global cache for SSH config instances to avoid re-parsing

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/tests/test_config_helpers.py

@@ -28,7 +28,12 @@ from github2gerrit.config import overlay_missing
 if TYPE_CHECKING:
     F = TypeVar("F", bound=Callable[..., object])
 
-    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]: ...
+    # Typed stub so basedpyright treats @parametrize as a typed decorator
+    # (reportUntypedFunctionDecorator). The body raises rather than using
+    # an ellipsis so static analysers do not model it as a procedure that
+    # returns None; this code is never executed at runtime.
+    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
 else:
     from pytest import mark
 

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/tests/test_core_config_and_errors.py

@@ -287,7 +287,11 @@ def test_configure_git_raises_on_git_review_init_failure(
 if TYPE_CHECKING:
     F = TypeVar("F", bound=Callable[..., object])
 
-    def fixture(*args: object, **kwargs: object) -> Callable[[F], F]: ...
+    # Typed stub (raising body, never executed) so basedpyright treats
+    # @fixture as a typed decorator and static analysers do not model it
+    # as a procedure returning None.
+    def fixture(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
 else:
     fixture = pytest.fixture
 

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/tests/test_core_ssh_setup.py

@@ -52,8 +52,14 @@ def snapshot_dir_state(directory: Path) -> dict[str, str]:
 if TYPE_CHECKING:
     F = TypeVar("F", bound=Callable[..., object])
 
-    def fixture(*args: object, **kwargs: object) -> Callable[[F], F]: ...
-    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]: ...
+    # Typed stubs (raising bodies, never executed) so basedpyright treats
+    # @fixture/@parametrize as typed decorators and static analysers do not
+    # model them as procedures returning None.
+    def fixture(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
+
+    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
 else:
     from pytest import fixture as _fixture
     from pytest import mark as _mark

{github2gerrit-1.3.0 → github2gerrit-1.3.1}/tests/test_url_parser.py

@@ -11,7 +11,11 @@ from typing import TypeVar
 if TYPE_CHECKING:
     F = TypeVar("F", bound=Callable[..., object])
 
-    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]: ...
+    # Typed stub (raising body, never executed) so basedpyright treats
+    # @parametrize as a typed decorator and static analysers do not model
+    # it as a procedure returning None.
+    def parametrize(*args: object, **kwargs: object) -> Callable[[F], F]:
+        raise NotImplementedError
 else:
     from pytest import mark