github-backup 0.66.0__tar.gz → 0.67.0__tar.gz

{github_backup-0.66.0 → github_backup-0.67.0}/CHANGES.rst

@@ -1,9 +1,55 @@
 Changelog
 =========
 
-0.66.0 (2026-10-28)
+0.67.0 (2026-11-04)
 -------------------
 ------------------------
+- Drop support for Python 3.10 (end of life) [Rodos]
+
+  Python 3.10 reached end of life on 2026-10-01 and no longer receives
+  security fixes. Require Python 3.11 or higher, and remove 3.10 from the
+  package classifiers and the CI test and lint matrices.
+- Fix --incremental-by-files skipping updated items east of UTC. [Rodos]
+
+  The modification time of a saved issue, pull request or discussion was
+  formatted in local time but labelled UTC, then compared with GitHub's UTC
+  updated_at. East of UTC, items updated within the offset after they were saved
+  were skipped and their changes missed; west of UTC, unchanged items were
+  fetched again. The checkpoint time used when a repository has no updated_at or
+  pushed_at had the same local-time mistake.
+
+
+0.66.1 (2026-11-03)
+-------------------
+- Skip hooks for repositories without admin access instead of logging a
+  404 error (#532) [Rodos]
+
+  Reading hooks needs admin access, and GitHub returns 404 without it. When the
+  repository listing says the token isn't an admin, skip hooks without making the
+  request. The 404 skip message now names the repository and the permission it
+  needs, and the README note about hooks blocking starred backups is updated.
+- Chore(deps): bump pytest. [dependabot[bot]]
+
+  Bumps the python-packages group with 1 update: [pytest](https://github.com/pytest-dev/pytest).
+
+
+  Updates `pytest` from 9.1.1 to 9.2.0
+  - [Release notes](https://github.com/pytest-dev/pytest/releases)
+  - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
+  - [Commits](https://github.com/pytest-dev/pytest/compare/9.1.1...9.2.0)
+
+  ---
+  updated-dependencies:
+  - dependency-name: pytest
+    dependency-version: 9.2.0
+    dependency-type: direct:production
+    update-type: version-update:semver-minor
+    dependency-group: python-packages
+  ...
+
+
+0.66.0 (2026-10-28)
+-------------------
 - List a user's private repositories when authenticated as a GitHub App.
   [AC Capehart, Claude Opus 5.5]
 

{github_backup-0.66.0/github_backup.egg-info → github_backup-0.67.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: github-backup
-Version: 0.66.0
+Version: 0.67.0
 Summary: backup a github user or organization
 Home-page: http://github.com/josegonzalez/python-github-backup
 Author: Jose Diaz-Gonzalez
@@ -9,12 +9,11 @@ License: MIT
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Topic :: System :: Archiving :: Backup
 Classifier: License :: OSI Approved :: MIT License
-Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3.13
 Classifier: Programming Language :: Python :: 3.14
-Requires-Python: >=3.10
+Requires-Python: >=3.11
 Description-Content-Type: text/x-rst
 License-File: LICENSE.txt
 Dynamic: author
@@ -39,7 +38,7 @@ The package can be used to backup an *entire* `Github <https://github.com/>`_ or
 Requirements
 ============
 
-- Python 3.10 or higher
+- Python 3.11 or higher
 - GIT 1.9+
 
 Installation
@@ -437,11 +436,9 @@ If the incremental argument is used, per-resource checkpoints are only advanced
 
 It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
 
-**Starred public repo hooks blocking**
+**Hooks need admin access**
 
-Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
-
-This is due to needing the correct permission for ``--hooks`` on public repos.
+Reading a repository's hooks requires admin access to it, and fine-grained tokens also need the Webhooks read permission. Since the ``--all`` argument includes ``--hooks``, repositories you don't administer, such as starred repositories with ``--all-starred``, are skipped for hooks and the rest of the backup continues.
 
 
 "bare" is actually "mirror"

{github_backup-0.66.0 → github_backup-0.67.0}/README

@@ -9,7 +9,7 @@ The package can be used to backup an *entire* `Github <https://github.com/>`_ or
 Requirements
 ============
 
-- Python 3.10 or higher
+- Python 3.11 or higher
 - GIT 1.9+
 
 Installation
@@ -407,11 +407,9 @@ If the incremental argument is used, per-resource checkpoints are only advanced
 
 It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
 
-**Starred public repo hooks blocking**
+**Hooks need admin access**
 
-Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
-
-This is due to needing the correct permission for ``--hooks`` on public repos.
+Reading a repository's hooks requires admin access to it, and fine-grained tokens also need the Webhooks read permission. Since the ``--all`` argument includes ``--hooks``, repositories you don't administer, such as starred repositories with ``--all-starred``, are skipped for hooks and the rest of the backup continues.
 
 
 "bare" is actually "mirror"

{github_backup-0.66.0 → github_backup-0.67.0}/README.rst

@@ -9,7 +9,7 @@ The package can be used to backup an *entire* `Github <https://github.com/>`_ or
 Requirements
 ============
 
-- Python 3.10 or higher
+- Python 3.11 or higher
 - GIT 1.9+
 
 Installation
@@ -407,11 +407,9 @@ If the incremental argument is used, per-resource checkpoints are only advanced
 
 It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
 
-**Starred public repo hooks blocking**
+**Hooks need admin access**
 
-Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
-
-This is due to needing the correct permission for ``--hooks`` on public repos.
+Reading a repository's hooks requires admin access to it, and fine-grained tokens also need the Webhooks read permission. Since the ``--all`` argument includes ``--hooks``, repositories you don't administer, such as starred repositories with ``--all-starred``, are skipped for hooks and the rest of the backup continues.
 
 
 "bare" is actually "mirror"

github_backup-0.67.0/github_backup/__init__.py

@@ -0,0 +1 @@
+__version__ = "0.67.0"

{github_backup-0.66.0 → github_backup-0.67.0}/github_backup/github_backup.py

@@ -20,7 +20,7 @@ import threading
 import time
 import traceback
 from collections.abc import Generator
-from datetime import datetime
+from datetime import datetime, timezone
 from http.client import IncompleteRead
 from urllib.error import HTTPError, URLError
 from urllib.parse import urlencode, urlparse
@@ -2004,7 +2004,7 @@ def get_repository_checkpoint_time(repository):
     if timestamps:
         return max(timestamps)
 
-    return time.strftime("%Y-%m-%dT%H:%M:%SZ", time.localtime())
+    return time.strftime("%Y-%m-%dT%H:%M:%SZ", time.gmtime())
 
 
 def resource_backup_exists(resource_cwd):
@@ -2525,7 +2525,9 @@ def backup_discussions(args, repo_cwd, repository):
 
         if args.incremental_by_files and os.path.isfile(discussion_file):
             modified = os.path.getmtime(discussion_file)
-            modified = datetime.fromtimestamp(modified).strftime("%Y-%m-%dT%H:%M:%SZ")
+            modified = datetime.fromtimestamp(modified, timezone.utc).strftime(
+                "%Y-%m-%dT%H:%M:%SZ"
+            )
             if modified > summary["updatedAt"]:
                 logger.info(
                     "Skipping discussion {0} because it wasn't modified since last backup".format(
@@ -2805,7 +2807,9 @@ def backup_issues(args, repo_cwd, repository, repos_template):
             and number not in stale_timelines
         ):
             modified = os.path.getmtime(issue_file)
-            modified = datetime.fromtimestamp(modified).strftime("%Y-%m-%dT%H:%M:%SZ")
+            modified = datetime.fromtimestamp(modified, timezone.utc).strftime(
+                "%Y-%m-%dT%H:%M:%SZ"
+            )
             if modified > issue["updated_at"]:
                 logger.info(
                     "Skipping issue {0} because it wasn't modified since last backup".format(
@@ -3006,7 +3010,9 @@ def backup_pulls(args, repo_cwd, repository, repos_template):
 
         if args.incremental_by_files and os.path.isfile(pull_file):
             modified = os.path.getmtime(pull_file)
-            modified = datetime.fromtimestamp(modified).strftime("%Y-%m-%dT%H:%M:%SZ")
+            modified = datetime.fromtimestamp(modified, timezone.utc).strftime(
+                "%Y-%m-%dT%H:%M:%SZ"
+            )
             if modified > pull["updated_at"] and not needs_review_backfill:
                 logger.info(
                     "Skipping pull request {0} because it wasn't modified since last backup".format(
@@ -3155,6 +3161,15 @@ def backup_hooks(args, repo_cwd, repository, repos_template):
     if not auth:
         logger.info("Skipping hooks since no authentication provided")
         return
+    # Reading hooks needs admin access, and GitHub returns 404 without it.
+    # Skip the request when the repository listing says we aren't an admin.
+    if repository.get("permissions", {}).get("admin") is False:
+        logger.info(
+            "Skipping hooks for {0} since admin access is required".format(
+                repository["full_name"]
+            )
+        )
+        return
     hook_cwd = os.path.join(repo_cwd, "hooks")
     output_file = "{0}/hooks.json".format(hook_cwd)
     template = "{0}/{1}/hooks".format(repos_template, repository["full_name"])
@@ -3162,7 +3177,12 @@ def backup_hooks(args, repo_cwd, repository, repos_template):
         _backup_data(args, "hooks", template, output_file, hook_cwd)
     except HTTPError as e:
         if e.code == 404:
-            logger.info("Unable to read hooks, skipping")
+            logger.info(
+                "Unable to read hooks for {0}, skipping (requires admin access, "
+                "or Webhooks read permission for fine-grained tokens)".format(
+                    repository["full_name"]
+                )
+            )
         else:
             raise e
 

{github_backup-0.66.0 → github_backup-0.67.0/github_backup.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: github-backup
-Version: 0.66.0
+Version: 0.67.0
 Summary: backup a github user or organization
 Home-page: http://github.com/josegonzalez/python-github-backup
 Author: Jose Diaz-Gonzalez
@@ -9,12 +9,11 @@ License: MIT
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Topic :: System :: Archiving :: Backup
 Classifier: License :: OSI Approved :: MIT License
-Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3.13
 Classifier: Programming Language :: Python :: 3.14
-Requires-Python: >=3.10
+Requires-Python: >=3.11
 Description-Content-Type: text/x-rst
 License-File: LICENSE.txt
 Dynamic: author
@@ -39,7 +38,7 @@ The package can be used to backup an *entire* `Github <https://github.com/>`_ or
 Requirements
 ============
 
-- Python 3.10 or higher
+- Python 3.11 or higher
 - GIT 1.9+
 
 Installation
@@ -437,11 +436,9 @@ If the incremental argument is used, per-resource checkpoints are only advanced
 
 It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
 
-**Starred public repo hooks blocking**
+**Hooks need admin access**
 
-Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
-
-This is due to needing the correct permission for ``--hooks`` on public repos.
+Reading a repository's hooks requires admin access to it, and fine-grained tokens also need the Webhooks read permission. Since the ``--all`` argument includes ``--hooks``, repositories you don't administer, such as starred repositories with ``--all-starred``, are skipped for hooks and the rest of the backup continues.
 
 
 "bare" is actually "mirror"

{github_backup-0.66.0 → github_backup-0.67.0}/github_backup.egg-info/SOURCES.txt

@@ -25,7 +25,9 @@ tests/test_case_sensitivity.py
 tests/test_disabled_issues_pulls.py
 tests/test_discussions.py
 tests/test_gists.py
+tests/test_hooks.py
 tests/test_http_451.py
+tests/test_incremental_by_files.py
 tests/test_incremental_per_repository.py
 tests/test_issue_timeline.py
 tests/test_json_dump_if_changed.py

{github_backup-0.66.0 → github_backup-0.67.0}/release-requirements.txt

@@ -4,7 +4,7 @@ black==26.10.1
 flake8==7.4.1
 
 # Testing
-pytest==9.1.1
+pytest==9.2.0
 
 # Release & Publishing
 twine==7.0.0

{github_backup-0.66.0 → github_backup-0.67.0}/setup.py

@@ -44,7 +44,6 @@ setup(
         "Development Status :: 5 - Production/Stable",
         "Topic :: System :: Archiving :: Backup",
         "License :: OSI Approved :: MIT License",
-        "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Programming Language :: Python :: 3.12",
         "Programming Language :: Python :: 3.13",
@@ -54,6 +53,6 @@ setup(
     long_description=open_file("README.rst").read(),
     long_description_content_type="text/x-rst",
     install_requires=open_file("requirements.txt").readlines(),
-    python_requires=">=3.10",
+    python_requires=">=3.11",
     zip_safe=True,
 )

github_backup-0.67.0/tests/test_hooks.py

@@ -0,0 +1,96 @@
+"""Tests for hooks backup permissions (GitHub issue #532).
+
+Reading ``/repos/{owner}/{repo}/hooks`` needs admin access to the repository.
+Without it GitHub responds with HTTP 404 rather than 403, which used to log an
+API error for every repository the user doesn't administer.
+"""
+
+import logging
+from urllib.error import HTTPError
+
+import pytest
+
+from github_backup import github_backup
+
+REPOS_TEMPLATE = "https://api.github.com/repos"
+
+
+@pytest.fixture
+def hook_args(create_args):
+    return create_args(include_hooks=True, token_classic="ghp_token")
+
+
+def _repository(**fields):
+    return {"full_name": "owner/repo", **fields}
+
+
+def test_hooks_skipped_without_request_when_not_admin(
+    hook_args, tmp_path, monkeypatch, caplog
+):
+    def fail_retrieve_data(*args, **kwargs):
+        raise AssertionError("hooks should not be requested without admin access")
+
+    monkeypatch.setattr(github_backup, "retrieve_data", fail_retrieve_data)
+
+    with caplog.at_level(logging.INFO, logger=github_backup.logger.name):
+        github_backup.backup_hooks(
+            hook_args,
+            tmp_path,
+            _repository(permissions={"admin": False, "push": True, "pull": True}),
+            REPOS_TEMPLATE,
+        )
+
+    assert "Skipping hooks for owner/repo since admin access is required" in caplog.text
+    assert not (tmp_path / "hooks").exists()
+
+
+@pytest.mark.parametrize(
+    "repository",
+    [
+        _repository(permissions={"admin": True, "push": True, "pull": True}),
+        _repository(),
+    ],
+    ids=["admin", "no-permissions-field"],
+)
+def test_hooks_requested_when_admin_or_permissions_unknown(
+    hook_args, tmp_path, monkeypatch, repository
+):
+    requested = []
+
+    def fake_retrieve_data(passed_args, template, *args, **kwargs):
+        requested.append(template)
+        return [{"id": 1, "name": "web"}]
+
+    monkeypatch.setattr(github_backup, "retrieve_data", fake_retrieve_data)
+
+    github_backup.backup_hooks(hook_args, tmp_path, repository, REPOS_TEMPLATE)
+
+    assert requested == ["https://api.github.com/repos/owner/repo/hooks"]
+    assert (tmp_path / "hooks" / "hooks.json").exists()
+
+
+def test_hooks_404_is_skipped_with_reason(hook_args, tmp_path, monkeypatch, caplog):
+    def fake_retrieve_data(passed_args, template, *args, **kwargs):
+        raise HTTPError(template, 404, "Not Found", hdrs=None, fp=None)
+
+    monkeypatch.setattr(github_backup, "retrieve_data", fake_retrieve_data)
+
+    with caplog.at_level(logging.INFO, logger=github_backup.logger.name):
+        github_backup.backup_hooks(
+            hook_args,
+            tmp_path,
+            _repository(permissions={"admin": True}),
+            REPOS_TEMPLATE,
+        )
+
+    assert "Unable to read hooks for owner/repo, skipping" in caplog.text
+
+
+def test_hooks_non_404_error_propagates(hook_args, tmp_path, monkeypatch):
+    def fake_retrieve_data(passed_args, template, *args, **kwargs):
+        raise HTTPError(template, 500, "Server Error", hdrs=None, fp=None)
+
+    monkeypatch.setattr(github_backup, "retrieve_data", fake_retrieve_data)
+
+    with pytest.raises(HTTPError):
+        github_backup.backup_hooks(hook_args, tmp_path, _repository(), REPOS_TEMPLATE)

github_backup-0.67.0/tests/test_incremental_by_files.py

@@ -0,0 +1,130 @@
+"""Tests for --incremental-by-files timestamp comparison.
+
+A saved file is skipped when its modification time is newer than the item's
+``updated_at``. GitHub's timestamps are UTC, so the file's modification time
+must be compared in UTC too, whatever the local time zone is.
+"""
+
+import calendar
+import json
+import os
+import time
+
+import pytest
+
+from github_backup import github_backup
+
+UPDATED_AT = "2026-07-01T12:00:00Z"
+
+
+@pytest.fixture
+def east_of_utc(monkeypatch):
+    """Run the test with the local time zone at UTC+10 (no daylight saving)."""
+    monkeypatch.setenv("TZ", "Etc/GMT-10")
+    time.tzset()
+    yield
+    monkeypatch.undo()
+    time.tzset()
+
+
+def _stored(path, number, written_at):
+    """Save an item file whose modification time is ``written_at`` (UTC)."""
+    path.mkdir(parents=True, exist_ok=True)
+    item_file = path / "{0}.json".format(number)
+    item_file.write_text(json.dumps({"number": number, "title": "stored"}))
+    mtime = calendar.timegm(time.strptime(written_at, "%Y-%m-%dT%H:%M:%SZ"))
+    os.utime(item_file, (mtime, mtime))
+    return item_file
+
+
+def _fake_retrieve(items):
+    def _retrieve(args, template, query_args=None, **kwargs):
+        return items if template.endswith(("/issues", "/pulls")) else []
+
+    return _retrieve
+
+
+@pytest.mark.parametrize(
+    "written_at, refetched",
+    [
+        ("2026-07-01T10:00:00Z", True),  # updated 2 hours after it was saved
+        ("2026-07-01T14:00:00Z", False),  # saved 2 hours after the update
+    ],
+)
+def test_issue_skip_compares_in_utc(
+    create_args, tmp_path, monkeypatch, east_of_utc, written_at, refetched
+):
+    issue_file = _stored(tmp_path / "issues", 1, written_at)
+    issue = {"number": 1, "title": "updated", "updated_at": UPDATED_AT}
+    monkeypatch.setattr(github_backup, "retrieve_data", _fake_retrieve([issue]))
+    args = create_args(include_issues=True, incremental_by_files=True, since=None)
+
+    github_backup.backup_issues(
+        args, str(tmp_path), {"full_name": "owner/repo"}, "https://api.github.com/repos"
+    )
+
+    title = json.loads(issue_file.read_text())["title"]
+    assert title == ("updated" if refetched else "stored")
+
+
+@pytest.mark.parametrize(
+    "written_at, refetched",
+    [
+        ("2026-07-01T10:00:00Z", True),
+        ("2026-07-01T14:00:00Z", False),
+    ],
+)
+def test_pull_skip_compares_in_utc(
+    create_args, tmp_path, monkeypatch, east_of_utc, written_at, refetched
+):
+    pull_file = _stored(tmp_path / "pulls", 1, written_at)
+    pull = {"number": 1, "title": "updated", "updated_at": UPDATED_AT}
+    monkeypatch.setattr(github_backup, "retrieve_data", _fake_retrieve([pull]))
+    args = create_args(include_pulls=True, incremental_by_files=True, since=None)
+
+    github_backup.backup_pulls(
+        args, str(tmp_path), {"full_name": "owner/repo"}, "https://api.github.com/repos"
+    )
+
+    title = json.loads(pull_file.read_text())["title"]
+    assert title == ("updated" if refetched else "stored")
+
+
+@pytest.mark.parametrize(
+    "written_at, refetched",
+    [
+        ("2026-07-01T10:00:00Z", True),
+        ("2026-07-01T14:00:00Z", False),
+    ],
+)
+def test_discussion_skip_compares_in_utc(
+    create_args, tmp_path, monkeypatch, east_of_utc, written_at, refetched
+):
+    discussion_file = _stored(tmp_path / "discussions", 1, written_at)
+    summary = {"number": 1, "updatedAt": UPDATED_AT}
+    monkeypatch.setattr(
+        github_backup,
+        "retrieve_discussion_summaries",
+        lambda args, repository, since=None: ([summary], UPDATED_AT, True, 1),
+    )
+    monkeypatch.setattr(
+        github_backup,
+        "retrieve_discussion",
+        lambda args, repository, number: {"number": number, "title": "updated"},
+    )
+    args = create_args(
+        include_discussions=True, incremental_by_files=True, token_classic="ghp_test"
+    )
+
+    github_backup.backup_discussions(args, str(tmp_path), {"full_name": "owner/repo"})
+
+    title = json.loads(discussion_file.read_text())["title"]
+    assert title == ("updated" if refetched else "stored")
+
+
+def test_checkpoint_fallback_time_is_utc(east_of_utc):
+    before = time.strftime("%Y-%m-%dT%H:%M:%SZ", time.gmtime())
+    checkpoint = github_backup.get_repository_checkpoint_time({})
+    after = time.strftime("%Y-%m-%dT%H:%M:%SZ", time.gmtime())
+
+    assert before <= checkpoint <= after

github_backup-0.66.0/github_backup/__init__.py

@@ -1 +0,0 @@
-__version__ = "0.66.0"