git-commit-msg-ai 1.3.0__tar.gz → 1.4.1__tar.gz

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/PKG-INFO

@@ -1,9 +1,9 @@
 Metadata-Version: 2.4
 Name: git-commit-msg-ai
-Version: 1.3.0
+Version: 1.4.1
 Summary: AI-powered git commit message generator following Conventional Commits
 License-Expression: MIT
-Requires-Python: >=3.9
+Requires-Python: >=3.10
 Description-Content-Type: text/markdown
 Requires-Dist: anthropic
 Provides-Extra: dev
@@ -18,7 +18,7 @@ AI-powered git commit message generator that follows the [Conventional Commits](
 
 ## Prerequisites
 
-- Python 3.9+
+- Python 3.10+
 - An Anthropic API key set as an environment variable:
 
   ```sh
@@ -53,9 +53,9 @@ The tool will:
 [a]ccept / [e]dit / [r]eject:
 ```
 
-- **a** — commits immediately with the generated message
-- **e** — opens the message in your `$EDITOR`, lets you modify it, then commits
-- **r** — exits without committing
+- **a** - commits immediately with the generated message
+- **e** - opens the message in your `$EDITOR` (defaults to `notepad` on Windows, `vi` on Linux/macOS), lets you modify it, then commits
+- **r** - exits without committing
 
 ## Commit message format
 

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/README.md

@@ -4,7 +4,7 @@ AI-powered git commit message generator that follows the [Conventional Commits](
 
 ## Prerequisites
 
-- Python 3.9+
+- Python 3.10+
 - An Anthropic API key set as an environment variable:
 
   ```sh
@@ -39,9 +39,9 @@ The tool will:
 [a]ccept / [e]dit / [r]eject:
 ```
 
-- **a** — commits immediately with the generated message
-- **e** — opens the message in your `$EDITOR`, lets you modify it, then commits
-- **r** — exits without committing
+- **a** - commits immediately with the generated message
+- **e** - opens the message in your `$EDITOR` (defaults to `notepad` on Windows, `vi` on Linux/macOS), lets you modify it, then commits
+- **r** - exits without committing
 
 ## Commit message format
 

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/git_commit_msg_ai/editor.py

@@ -1,10 +1,18 @@
 import os
+import platform
 import subprocess
 import tempfile
 
 from git_commit_msg_ai.exceptions import EditorError
 
 
+def get_default_editor() -> str:
+    current_platform = platform.system()
+    is_windows = current_platform == 'Windows'
+
+    return 'notepad' if is_windows else 'vi'
+
+
 def open_in_editor(initial_text: str) -> str:
     try:
         with tempfile.NamedTemporaryFile(suffix='.txt', mode='w', delete=False) as temp_file:
@@ -13,7 +21,8 @@ def open_in_editor(initial_text: str) -> str:
     except OSError:
         raise EditorError('Could not create a temporary file.')
 
-    editor_command = os.environ.get('EDITOR', 'notepad')
+    platform_default_editor = get_default_editor()
+    editor_command = os.environ.get('EDITOR', platform_default_editor)
 
     try:
         try:

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/git_commit_msg_ai/git_ops.py

@@ -1,11 +1,19 @@
 import subprocess
+from typing import Final
 
 from git_commit_msg_ai.exceptions import GitError
 
+GIT_COMMAND: Final[str] = 'git'
+DIFF_SUBCOMMAND: Final[str] = 'diff'
+CACHED_FLAG: Final[str] = '--cached'
+COMMIT_SUBCOMMAND: Final[str] = 'commit'
+MESSAGE_FLAG: Final[str] = '-m'
+UTF8_ENCODING: Final[str] = 'utf-8'
+
 
 def get_staged_diff() -> str:
     try:
-        staged_diff = subprocess.check_output(['git', 'diff', '--cached']).decode()
+        staged_diff = subprocess.check_output([GIT_COMMAND, DIFF_SUBCOMMAND, CACHED_FLAG]).decode(UTF8_ENCODING)
     except FileNotFoundError:
         raise GitError('git is not installed or not on PATH.')
     except subprocess.CalledProcessError:
@@ -21,7 +29,7 @@ def get_staged_diff() -> str:
 
 def commit(message: str) -> None:
     try:
-        subprocess.run(['git', 'commit', '-m', message], check=True)
+        subprocess.run([GIT_COMMAND, COMMIT_SUBCOMMAND, MESSAGE_FLAG, message], check=True)
     except FileNotFoundError:
         raise GitError('git is not installed or not on PATH.')
     except subprocess.CalledProcessError:

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/git_commit_msg_ai.egg-info/PKG-INFO

@@ -1,9 +1,9 @@
 Metadata-Version: 2.4
 Name: git-commit-msg-ai
-Version: 1.3.0
+Version: 1.4.1
 Summary: AI-powered git commit message generator following Conventional Commits
 License-Expression: MIT
-Requires-Python: >=3.9
+Requires-Python: >=3.10
 Description-Content-Type: text/markdown
 Requires-Dist: anthropic
 Provides-Extra: dev
@@ -18,7 +18,7 @@ AI-powered git commit message generator that follows the [Conventional Commits](
 
 ## Prerequisites
 
-- Python 3.9+
+- Python 3.10+
 - An Anthropic API key set as an environment variable:
 
   ```sh
@@ -53,9 +53,9 @@ The tool will:
 [a]ccept / [e]dit / [r]eject:
 ```
 
-- **a** — commits immediately with the generated message
-- **e** — opens the message in your `$EDITOR`, lets you modify it, then commits
-- **r** — exits without committing
+- **a** - commits immediately with the generated message
+- **e** - opens the message in your `$EDITOR` (defaults to `notepad` on Windows, `vi` on Linux/macOS), lets you modify it, then commits
+- **r** - exits without committing
 
 ## Commit message format
 

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/pyproject.toml

@@ -4,11 +4,11 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "git-commit-msg-ai"
-version = "1.3.0"
+version = "1.4.1"
 description = "AI-powered git commit message generator following Conventional Commits"
 readme = "README.md"
 license = "MIT"
-requires-python = ">=3.9"
+requires-python = ">=3.10"
 dependencies = ["anthropic"]
 
 [project.scripts]
@@ -18,14 +18,14 @@ git-commit-msg-ai = "git_commit_msg_ai.cli:main"
 dev = ["mypy", "ruff", "pytest", "pytest-cov"]
 
 [tool.ruff]
-target-version = "py39"
+target-version = "py310"
 line-length = 320
 
 [tool.ruff.lint]
 select = ["E", "F", "I"]
 
 [tool.mypy]
-python_version = "3.9"
+python_version = "3.10"
 strict = true
 
 [tool.pytest.ini_options]

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/tests/test_ai_client.py

@@ -1,3 +1,4 @@
+from contextlib import ExitStack
 from unittest.mock import MagicMock, patch
 
 import anthropic
@@ -17,7 +18,7 @@ def _make_api_response(text: str) -> MagicMock:
     return mock_response
 
 
-def _make_status_error(exception_class: type, status_code: int) -> anthropic.APIStatusError:
+def _make_status_error(exception_class: type[anthropic.APIStatusError], status_code: int) -> anthropic.APIStatusError:
     mock_response = MagicMock()
     mock_response.status_code = status_code
 
@@ -25,8 +26,9 @@ def _make_status_error(exception_class: type, status_code: int) -> anthropic.API
 
 
 class TestGenerateCommitMessage:
-    def test_returns_stripped_commit_message(self):
-        with patch('git_commit_msg_ai.ai_client.anthropic.Anthropic') as mock_anthropic_class:
+    def test_returns_stripped_commit_message(self) -> None:
+        with ExitStack() as stack:
+            mock_anthropic_class = stack.enter_context(patch('git_commit_msg_ai.ai_client.anthropic.Anthropic'))
             mock_client = MagicMock()
             mock_client.messages.create.return_value = _make_api_response('  feat: add feature  ')
             mock_anthropic_class.return_value = mock_client
@@ -35,8 +37,9 @@ class TestGenerateCommitMessage:
 
         assert result == 'feat: add feature'
 
-    def test_raises_ai_error_on_authentication_error(self):
-        with patch('git_commit_msg_ai.ai_client.anthropic.Anthropic') as mock_anthropic_class:
+    def test_raises_ai_error_on_authentication_error(self) -> None:
+        with ExitStack() as stack:
+            mock_anthropic_class = stack.enter_context(patch('git_commit_msg_ai.ai_client.anthropic.Anthropic'))
             mock_client = MagicMock()
             mock_client.messages.create.side_effect = _make_status_error(anthropic.AuthenticationError, 401)
             mock_anthropic_class.return_value = mock_client
@@ -44,8 +47,9 @@ class TestGenerateCommitMessage:
             with pytest.raises(AIError, match='ANTHROPIC_API_KEY'):
                 generate_commit_message('diff content')
 
-    def test_raises_ai_error_on_rate_limit_error(self):
-        with patch('git_commit_msg_ai.ai_client.anthropic.Anthropic') as mock_anthropic_class:
+    def test_raises_ai_error_on_rate_limit_error(self) -> None:
+        with ExitStack() as stack:
+            mock_anthropic_class = stack.enter_context(patch('git_commit_msg_ai.ai_client.anthropic.Anthropic'))
             mock_client = MagicMock()
             mock_client.messages.create.side_effect = _make_status_error(anthropic.RateLimitError, 429)
             mock_anthropic_class.return_value = mock_client
@@ -53,10 +57,11 @@ class TestGenerateCommitMessage:
             with pytest.raises(AIError, match='rate limit'):
                 generate_commit_message('diff content')
 
-    def test_raises_ai_error_on_api_connection_error(self):
+    def test_raises_ai_error_on_api_connection_error(self) -> None:
         mock_request = MagicMock()
 
-        with patch('git_commit_msg_ai.ai_client.anthropic.Anthropic') as mock_anthropic_class:
+        with ExitStack() as stack:
+            mock_anthropic_class = stack.enter_context(patch('git_commit_msg_ai.ai_client.anthropic.Anthropic'))
             mock_client = MagicMock()
             mock_client.messages.create.side_effect = anthropic.APIConnectionError(request=mock_request)
             mock_anthropic_class.return_value = mock_client
@@ -64,8 +69,9 @@ class TestGenerateCommitMessage:
             with pytest.raises(AIError, match='network'):
                 generate_commit_message('diff content')
 
-    def test_raises_ai_error_on_api_status_error_with_status_code(self):
-        with patch('git_commit_msg_ai.ai_client.anthropic.Anthropic') as mock_anthropic_class:
+    def test_raises_ai_error_on_api_status_error_with_status_code(self) -> None:
+        with ExitStack() as stack:
+            mock_anthropic_class = stack.enter_context(patch('git_commit_msg_ai.ai_client.anthropic.Anthropic'))
             mock_client = MagicMock()
             mock_client.messages.create.side_effect = _make_status_error(anthropic.APIStatusError, 500)
             mock_anthropic_class.return_value = mock_client

git_commit_msg_ai-1.4.1/tests/test_cli.py

@@ -0,0 +1,149 @@
+from contextlib import ExitStack
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from git_commit_msg_ai.cli import main
+from git_commit_msg_ai.exceptions import AIError, GitError
+
+COMMIT_MESSAGE = 'feat: add feature'
+EDITED_COMMIT_MESSAGE = 'edited commit message'
+STAGED_DIFF = 'diff content'
+GENERIC_COMMIT_MESSAGE = 'generic commit message'
+
+
+class TestMain:
+    def _run_with_input(self, user_input: str, commit_message: str = COMMIT_MESSAGE) -> tuple[MagicMock, MagicMock, MagicMock]:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.return_value = commit_message
+
+        mock_editor = MagicMock()
+        mock_editor.open_in_editor.return_value = EDITED_COMMIT_MESSAGE
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            stack.enter_context(patch('git_commit_msg_ai.cli.editor', mock_editor))
+            stack.enter_context(patch('builtins.input', return_value=user_input))
+            main()
+
+        return mock_git_ops, mock_ai_client, mock_editor
+
+    def test_accept_calls_commit_with_generated_message(self) -> None:
+        mock_git_ops, _, _ = self._run_with_input('a', COMMIT_MESSAGE)
+
+        mock_git_ops.commit.assert_called_once_with(COMMIT_MESSAGE)
+
+    def test_edit_opens_editor_then_commits_edited_message(self) -> None:
+        mock_git_ops, _, mock_editor = self._run_with_input('e', COMMIT_MESSAGE)
+
+        mock_editor.open_in_editor.assert_called_once_with(COMMIT_MESSAGE)
+        mock_git_ops.commit.assert_called_once_with(EDITED_COMMIT_MESSAGE)
+
+    def test_reject_does_not_commit(self) -> None:
+        mock_git_ops, _, _ = self._run_with_input('r')
+
+        mock_git_ops.commit.assert_not_called()
+
+    def test_invalid_input_exits_with_code_1(self) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.return_value = GENERIC_COMMIT_MESSAGE
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            stack.enter_context(patch('git_commit_msg_ai.cli.editor'))
+            stack.enter_context(patch('builtins.input', return_value='x'))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+
+    def test_git_error_from_get_staged_diff_exits_with_message(self, capsys: pytest.CaptureFixture[str]) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.side_effect = GitError('staged error')
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+        assert 'staged error' in capsys.readouterr().out
+
+    def test_ai_error_from_generate_commit_message_exits_with_message(self, capsys: pytest.CaptureFixture[str]) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.side_effect = AIError('ai error')
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+        assert 'ai error' in capsys.readouterr().out
+
+    def test_git_error_from_commit_exits_with_message(self, capsys: pytest.CaptureFixture[str]) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+        mock_git_ops.commit.side_effect = GitError('commit error')
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.return_value = GENERIC_COMMIT_MESSAGE
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            stack.enter_context(patch('git_commit_msg_ai.cli.editor'))
+            stack.enter_context(patch('builtins.input', return_value='a'))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+        assert 'commit error' in capsys.readouterr().out
+
+    def test_keyboard_interrupt_exits_with_aborted_message(self, capsys: pytest.CaptureFixture[str]) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.return_value = GENERIC_COMMIT_MESSAGE
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            stack.enter_context(patch('git_commit_msg_ai.cli.editor'))
+            stack.enter_context(patch('builtins.input', side_effect=KeyboardInterrupt))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+        assert 'Aborted.' in capsys.readouterr().out
+
+    def test_eof_error_exits_with_aborted_message(self, capsys: pytest.CaptureFixture[str]) -> None:
+        mock_git_ops = MagicMock()
+        mock_git_ops.get_staged_diff.return_value = STAGED_DIFF
+
+        mock_ai_client = MagicMock()
+        mock_ai_client.generate_commit_message.return_value = GENERIC_COMMIT_MESSAGE
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.cli.git_ops', mock_git_ops))
+            stack.enter_context(patch('git_commit_msg_ai.cli.ai_client', mock_ai_client))
+            stack.enter_context(patch('git_commit_msg_ai.cli.editor'))
+            stack.enter_context(patch('builtins.input', side_effect=EOFError))
+            with pytest.raises(SystemExit) as exc_info:
+                main()
+
+        assert exc_info.value.code == 1
+        assert 'Aborted.' in capsys.readouterr().out

git_commit_msg_ai-1.4.1/tests/test_editor.py

@@ -0,0 +1,137 @@
+import os
+import subprocess
+import tempfile
+from contextlib import ExitStack
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from git_commit_msg_ai.editor import get_default_editor, open_in_editor
+from git_commit_msg_ai.exceptions import EditorError
+
+TEMP_FILE_PATH = os.path.join(tempfile.gettempdir(), 'tmpfile.txt')
+INITIAL_TEXT = 'initial text'
+EDITED_TEXT_WITH_WHITESPACE = '  edited text  '
+EDITED_TEXT = 'edited text'
+GENERIC_TEXT = 'text'
+VIM_EDITOR = 'vim'
+
+
+def _make_named_temporary_file_mock() -> MagicMock:
+    mock_temp_file = MagicMock()
+    mock_temp_file.name = TEMP_FILE_PATH
+    mock_temp_file.__enter__ = MagicMock(return_value=mock_temp_file)
+    mock_temp_file.__exit__ = MagicMock(return_value=False)
+
+    return mock_temp_file
+
+
+def _make_open_mock(text: str) -> MagicMock:
+    mock_file = MagicMock()
+    mock_file.read.return_value = text
+    mock_file.__enter__ = MagicMock(return_value=mock_file)
+    mock_file.__exit__ = MagicMock(return_value=False)
+
+    return mock_file
+
+
+class TestOpenInEditor:
+    def test_returns_stripped_edited_text(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock(EDITED_TEXT_WITH_WHITESPACE)))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+
+            result = open_in_editor(INITIAL_TEXT)
+
+        assert result == EDITED_TEXT
+
+    def test_uses_editor_env_var(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            mock_run = stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock(GENERIC_TEXT)))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.environ.get', return_value=VIM_EDITOR))
+
+            open_in_editor(INITIAL_TEXT)
+
+        mock_run.assert_called_once_with([VIM_EDITOR, TEMP_FILE_PATH], check=True)
+
+    def test_falls_back_to_platform_default_when_editor_not_set(self) -> None:
+        sentinel_editor = 'test-sentinel-editor'
+
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            mock_run = stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock(GENERIC_TEXT)))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.get_default_editor', return_value=sentinel_editor))
+            stack.enter_context(patch.dict('os.environ', {}, clear=True))
+
+            open_in_editor(INITIAL_TEXT)
+
+        mock_run.assert_called_once_with([sentinel_editor, TEMP_FILE_PATH], check=True)
+
+    def test_raises_editor_error_on_temp_file_creation_failure(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', side_effect=OSError))
+            mock_unlink = stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+
+            with pytest.raises(EditorError, match='temporary file'):
+                open_in_editor(INITIAL_TEXT)
+
+        mock_unlink.assert_not_called()
+
+    def test_raises_editor_error_when_editor_not_found(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run', side_effect=FileNotFoundError))
+            mock_unlink = stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.environ.get', return_value=VIM_EDITOR))
+
+            with pytest.raises(EditorError, match='was not found'):
+                open_in_editor(INITIAL_TEXT)
+
+        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)
+
+    def test_raises_editor_error_when_editor_exits_with_error(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run', side_effect=subprocess.CalledProcessError(1, VIM_EDITOR)))
+            mock_unlink = stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.os.environ.get', return_value=VIM_EDITOR))
+
+            with pytest.raises(EditorError, match='exited with an error'):
+                open_in_editor(INITIAL_TEXT)
+
+        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)
+
+    def test_raises_editor_error_when_file_read_fails(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()))
+            stack.enter_context(patch('git_commit_msg_ai.editor.subprocess.run'))
+            stack.enter_context(patch('git_commit_msg_ai.editor.open', side_effect=OSError))
+            mock_unlink = stack.enter_context(patch('git_commit_msg_ai.editor.os.unlink'))
+
+            with pytest.raises(EditorError, match='Could not read'):
+                open_in_editor(INITIAL_TEXT)
+
+        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)
+
+
+class TestGetDefaultEditor:
+    def test_returns_notepad_on_windows(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.platform.system', return_value='Windows'))
+            result = get_default_editor()
+
+        assert result == 'notepad'
+
+    def test_returns_vi_on_non_windows(self) -> None:
+        with ExitStack() as stack:
+            stack.enter_context(patch('git_commit_msg_ai.editor.platform.system', return_value='Linux'))
+            result = get_default_editor()
+
+        assert result == 'vi'

{git_commit_msg_ai-1.3.0 → git_commit_msg_ai-1.4.1}/tests/test_exceptions.py

@@ -1,25 +1,25 @@
 from git_commit_msg_ai.exceptions import AIError, EditorError, GitCommitAIError, GitError
 
 
-def test_git_error_is_subclass_of_base():
+def test_git_error_is_subclass_of_base() -> None:
     assert issubclass(GitError, GitCommitAIError)
 
 
-def test_ai_error_is_subclass_of_base():
+def test_ai_error_is_subclass_of_base() -> None:
     assert issubclass(AIError, GitCommitAIError)
 
 
-def test_editor_error_is_subclass_of_base():
+def test_editor_error_is_subclass_of_base() -> None:
     assert issubclass(EditorError, GitCommitAIError)
 
 
-def test_git_error_carries_message():
+def test_git_error_carries_message() -> None:
     assert str(GitError('git failed')) == 'git failed'
 
 
-def test_ai_error_carries_message():
+def test_ai_error_carries_message() -> None:
     assert str(AIError('api failed')) == 'api failed'
 
 
-def test_editor_error_carries_message():
+def test_editor_error_carries_message() -> None:
     assert str(EditorError('editor failed')) == 'editor failed'

git_commit_msg_ai-1.4.1/tests/test_git_ops.py

@@ -0,0 +1,81 @@
+import subprocess
+from contextlib import ExitStack
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from git_commit_msg_ai.exceptions import GitError
+from git_commit_msg_ai.git_ops import COMMIT_SUBCOMMAND, GIT_COMMAND, MESSAGE_FLAG, commit, get_staged_diff
+
+COMMIT_MESSAGE = 'my message'
+
+
+class TestGetStagedDiff:
+    def test_returns_decoded_diff(self) -> None:
+        with ExitStack() as stack:
+            mock_check_output = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.check_output'))
+            mock_check_output.return_value = b'diff content'
+
+            result = get_staged_diff()
+
+        assert result == 'diff content'
+
+    def test_raises_git_error_when_git_not_found(self) -> None:
+        with ExitStack() as stack:
+            mock_check_output = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.check_output'))
+            mock_check_output.side_effect = FileNotFoundError
+
+            with pytest.raises(GitError, match='not installed'):
+                get_staged_diff()
+
+    def test_raises_git_error_on_called_process_error(self) -> None:
+        with ExitStack() as stack:
+            mock_check_output = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.check_output'))
+            mock_check_output.side_effect = subprocess.CalledProcessError(1, 'git')
+
+            with pytest.raises(GitError, match='git repository'):
+                get_staged_diff()
+
+    def test_raises_git_error_on_unicode_decode_error(self) -> None:
+        mock_bytes = MagicMock()
+        mock_bytes.decode.side_effect = UnicodeDecodeError('utf-8', b'', 0, 1, 'reason')
+
+        with ExitStack() as stack:
+            mock_check_output = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.check_output'))
+            mock_check_output.return_value = mock_bytes
+
+            with pytest.raises(GitError, match='UTF-8'):
+                get_staged_diff()
+
+    def test_raises_git_error_when_diff_is_empty(self) -> None:
+        with ExitStack() as stack:
+            mock_check_output = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.check_output'))
+            mock_check_output.return_value = b''
+
+            with pytest.raises(GitError, match='No staged changes'):
+                get_staged_diff()
+
+
+class TestCommit:
+    def test_calls_subprocess_run_with_correct_args(self) -> None:
+        with ExitStack() as stack:
+            mock_run = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.run'))
+            commit(COMMIT_MESSAGE)
+
+        mock_run.assert_called_once_with([GIT_COMMAND, COMMIT_SUBCOMMAND, MESSAGE_FLAG, COMMIT_MESSAGE], check=True)
+
+    def test_raises_git_error_when_git_not_found(self) -> None:
+        with ExitStack() as stack:
+            mock_run = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.run'))
+            mock_run.side_effect = FileNotFoundError
+
+            with pytest.raises(GitError, match='not installed'):
+                commit(COMMIT_MESSAGE)
+
+    def test_raises_git_error_on_called_process_error(self) -> None:
+        with ExitStack() as stack:
+            mock_run = stack.enter_context(patch('git_commit_msg_ai.git_ops.subprocess.run'))
+            mock_run.side_effect = subprocess.CalledProcessError(1, GIT_COMMAND)
+
+            with pytest.raises(GitError, match='git commit failed'):
+                commit(COMMIT_MESSAGE)

git_commit_msg_ai-1.3.0/tests/test_cli.py

@@ -1,136 +0,0 @@
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from git_commit_msg_ai.cli import main
-from git_commit_msg_ai.exceptions import AIError, GitError
-
-
-class TestMain:
-    def _run_with_input(self, user_input: str, commit_message: str = 'feat: add feature') -> tuple[MagicMock, MagicMock, MagicMock]:
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.return_value = commit_message
-
-        mock_editor = MagicMock()
-        mock_editor.open_in_editor.return_value = 'edited message'
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with patch('git_commit_msg_ai.cli.editor', mock_editor):
-                    with patch('builtins.input', return_value=user_input):
-                        main()
-
-        return mock_git_ops, mock_ai_client, mock_editor
-
-    def test_accept_calls_commit_with_generated_message(self):
-        mock_git_ops, _, _ = self._run_with_input('a', 'feat: add feature')
-
-        mock_git_ops.commit.assert_called_once_with('feat: add feature')
-
-    def test_edit_opens_editor_then_commits_edited_message(self):
-        mock_git_ops, _, mock_editor = self._run_with_input('e', 'feat: add feature')
-
-        mock_editor.open_in_editor.assert_called_once_with('feat: add feature')
-        mock_git_ops.commit.assert_called_once_with('edited message')
-
-    def test_reject_does_not_commit(self):
-        mock_git_ops, _, _ = self._run_with_input('r')
-
-        mock_git_ops.commit.assert_not_called()
-
-    def test_invalid_input_exits_with_code_1(self):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.return_value = 'msg'
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with patch('git_commit_msg_ai.cli.editor'):
-                    with patch('builtins.input', return_value='x'):
-                        with pytest.raises(SystemExit) as exc_info:
-                            main()
-
-        assert exc_info.value.code == 1
-
-    def test_git_error_from_get_staged_diff_exits_with_message(self, capsys: pytest.CaptureFixture[str]):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.side_effect = GitError('staged error')
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with pytest.raises(SystemExit) as exc_info:
-                main()
-
-        assert exc_info.value.code == 1
-        assert 'staged error' in capsys.readouterr().out
-
-    def test_ai_error_from_generate_commit_message_exits_with_message(self, capsys: pytest.CaptureFixture[str]):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.side_effect = AIError('ai error')
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with pytest.raises(SystemExit) as exc_info:
-                    main()
-
-        assert exc_info.value.code == 1
-        assert 'ai error' in capsys.readouterr().out
-
-    def test_git_error_from_commit_exits_with_message(self, capsys: pytest.CaptureFixture[str]):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-        mock_git_ops.commit.side_effect = GitError('commit error')
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.return_value = 'msg'
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with patch('git_commit_msg_ai.cli.editor'):
-                    with patch('builtins.input', return_value='a'):
-                        with pytest.raises(SystemExit) as exc_info:
-                            main()
-
-        assert exc_info.value.code == 1
-        assert 'commit error' in capsys.readouterr().out
-
-    def test_keyboard_interrupt_exits_with_aborted_message(self, capsys: pytest.CaptureFixture[str]):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.return_value = 'msg'
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with patch('git_commit_msg_ai.cli.editor'):
-                    with patch('builtins.input', side_effect=KeyboardInterrupt):
-                        with pytest.raises(SystemExit) as exc_info:
-                            main()
-
-        assert exc_info.value.code == 1
-        assert 'Aborted.' in capsys.readouterr().out
-
-    def test_eof_error_exits_with_aborted_message(self, capsys: pytest.CaptureFixture[str]):
-        mock_git_ops = MagicMock()
-        mock_git_ops.get_staged_diff.return_value = 'diff content'
-
-        mock_ai_client = MagicMock()
-        mock_ai_client.generate_commit_message.return_value = 'msg'
-
-        with patch('git_commit_msg_ai.cli.git_ops', mock_git_ops):
-            with patch('git_commit_msg_ai.cli.ai_client', mock_ai_client):
-                with patch('git_commit_msg_ai.cli.editor'):
-                    with patch('builtins.input', side_effect=EOFError):
-                        with pytest.raises(SystemExit) as exc_info:
-                            main()
-
-        assert exc_info.value.code == 1
-        assert 'Aborted.' in capsys.readouterr().out

git_commit_msg_ai-1.3.0/tests/test_editor.py

@@ -1,96 +0,0 @@
-import subprocess
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from git_commit_msg_ai.editor import open_in_editor
-from git_commit_msg_ai.exceptions import EditorError
-
-TEMP_FILE_PATH = '/tmp/tmpfile.txt'
-
-
-def _make_named_temporary_file_mock() -> MagicMock:
-    mock_temp_file = MagicMock()
-    mock_temp_file.name = TEMP_FILE_PATH
-    mock_temp_file.__enter__ = MagicMock(return_value=mock_temp_file)
-    mock_temp_file.__exit__ = MagicMock(return_value=False)
-
-    return mock_temp_file
-
-
-def _make_open_mock(text: str) -> MagicMock:
-    mock_file = MagicMock()
-    mock_file.read.return_value = text
-    mock_file.__enter__ = MagicMock(return_value=mock_file)
-    mock_file.__exit__ = MagicMock(return_value=False)
-
-    return mock_file
-
-
-class TestOpenInEditor:
-    def test_returns_stripped_edited_text(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run'):
-                with patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock('  edited text  ')):
-                    with patch('git_commit_msg_ai.editor.os.unlink'):
-                        result = open_in_editor('initial text')
-
-        assert result == 'edited text'
-
-    def test_uses_editor_env_var(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run') as mock_run:
-                with patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock('text')):
-                    with patch('git_commit_msg_ai.editor.os.unlink'):
-                        with patch('git_commit_msg_ai.editor.os.environ.get', return_value='vim'):
-                            open_in_editor('initial text')
-
-        mock_run.assert_called_once_with(['vim', TEMP_FILE_PATH], check=True)
-
-    def test_falls_back_to_notepad_when_editor_not_set(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run') as mock_run:
-                with patch('git_commit_msg_ai.editor.open', return_value=_make_open_mock('text')):
-                    with patch('git_commit_msg_ai.editor.os.unlink'):
-                        with patch('git_commit_msg_ai.editor.os.environ.get', return_value='notepad'):
-                            open_in_editor('initial text')
-
-        mock_run.assert_called_once_with(['notepad', TEMP_FILE_PATH], check=True)
-
-    def test_raises_editor_error_on_temp_file_creation_failure(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', side_effect=OSError):
-            with patch('git_commit_msg_ai.editor.os.unlink') as mock_unlink:
-                with pytest.raises(EditorError, match='temporary file'):
-                    open_in_editor('initial text')
-
-        mock_unlink.assert_not_called()
-
-    def test_raises_editor_error_when_editor_not_found(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run', side_effect=FileNotFoundError):
-                with patch('git_commit_msg_ai.editor.os.unlink') as mock_unlink:
-                    with patch('git_commit_msg_ai.editor.os.environ.get', return_value='vim'):
-                        with pytest.raises(EditorError, match='was not found'):
-                            open_in_editor('initial text')
-
-        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)
-
-    def test_raises_editor_error_when_editor_exits_with_error(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run', side_effect=subprocess.CalledProcessError(1, 'vim')):
-                with patch('git_commit_msg_ai.editor.os.unlink') as mock_unlink:
-                    with patch('git_commit_msg_ai.editor.os.environ.get', return_value='vim'):
-                        with pytest.raises(EditorError, match='exited with an error'):
-                            open_in_editor('initial text')
-
-        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)
-
-    def test_raises_editor_error_when_file_read_fails(self):
-        with patch('git_commit_msg_ai.editor.tempfile.NamedTemporaryFile', return_value=_make_named_temporary_file_mock()):
-            with patch('git_commit_msg_ai.editor.subprocess.run'):
-                with patch('git_commit_msg_ai.editor.open', side_effect=OSError):
-                    with patch('git_commit_msg_ai.editor.os.unlink') as mock_unlink:
-                        with pytest.raises(EditorError, match='Could not read'):
-                            open_in_editor('initial text')
-
-        mock_unlink.assert_called_once_with(TEMP_FILE_PATH)

git_commit_msg_ai-1.3.0/tests/test_git_ops.py

@@ -1,70 +0,0 @@
-import subprocess
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from git_commit_msg_ai.exceptions import GitError
-from git_commit_msg_ai.git_ops import commit, get_staged_diff
-
-
-class TestGetStagedDiff:
-    def test_returns_decoded_diff(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.check_output') as mock_check_output:
-            mock_check_output.return_value = b'diff content'
-
-            result = get_staged_diff()
-
-        assert result == 'diff content'
-
-    def test_raises_git_error_when_git_not_found(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.check_output') as mock_check_output:
-            mock_check_output.side_effect = FileNotFoundError
-
-            with pytest.raises(GitError, match='not installed'):
-                get_staged_diff()
-
-    def test_raises_git_error_on_called_process_error(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.check_output') as mock_check_output:
-            mock_check_output.side_effect = subprocess.CalledProcessError(1, 'git')
-
-            with pytest.raises(GitError, match='git repository'):
-                get_staged_diff()
-
-    def test_raises_git_error_on_unicode_decode_error(self):
-        mock_bytes = MagicMock()
-        mock_bytes.decode.side_effect = UnicodeDecodeError('utf-8', b'', 0, 1, 'reason')
-
-        with patch('git_commit_msg_ai.git_ops.subprocess.check_output') as mock_check_output:
-            mock_check_output.return_value = mock_bytes
-
-            with pytest.raises(GitError, match='UTF-8'):
-                get_staged_diff()
-
-    def test_raises_git_error_when_diff_is_empty(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.check_output') as mock_check_output:
-            mock_check_output.return_value = b''
-
-            with pytest.raises(GitError, match='No staged changes'):
-                get_staged_diff()
-
-
-class TestCommit:
-    def test_calls_subprocess_run_with_correct_args(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.run') as mock_run:
-            commit('my message')
-
-        mock_run.assert_called_once_with(['git', 'commit', '-m', 'my message'], check=True)
-
-    def test_raises_git_error_when_git_not_found(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.run') as mock_run:
-            mock_run.side_effect = FileNotFoundError
-
-            with pytest.raises(GitError, match='not installed'):
-                commit('my message')
-
-    def test_raises_git_error_on_called_process_error(self):
-        with patch('git_commit_msg_ai.git_ops.subprocess.run') as mock_run:
-            mock_run.side_effect = subprocess.CalledProcessError(1, 'git')
-
-            with pytest.raises(GitError, match='git commit failed'):
-                commit('my message')