git-commit-guard 0.23.0__tar.gz → 0.23.1__tar.gz

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/.github/workflows/lint-commits.yml

@@ -22,6 +22,6 @@ jobs:
           key: nltk-averaged-perceptron-tagger-punkt
       - name: Lint commits
         # yamllint disable-line rule:line-length
-        uses: benner/commit-guard@4f989e92ddf04153ec33040da42bc2f788c71584  # v0.22.3
+        uses: benner/commit-guard@4fb9b57f3883d78854ffe4bbe68ddafac569f269  # v0.23.0
         with:
           range: origin/${{ github.base_ref }}..HEAD

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: git-commit-guard
-Version: 0.23.0
+Version: 0.23.1
 Summary: Opinionated conventional commit message linter with imperative mood detection
 Project-URL: Homepage, https://github.com/benner/commit-guard
 Project-URL: Repository, https://github.com/benner/commit-guard
@@ -316,7 +316,7 @@ COMMIT_GUARD_GIT_TIMEOUT=30 commit-guard --range origin/main..HEAD
 In GitHub Actions, set it at the step or job level:
 
 ```yaml
-- uses: benner/commit-guard@v0.23.0
+- uses: benner/commit-guard@v0.23.1
   env:
     COMMIT_GUARD_GIT_TIMEOUT: 30
   with:
@@ -416,7 +416,7 @@ steps:
   - uses: actions/checkout@v4
     with:
       fetch-depth: 0
-  - uses: benner/commit-guard@v0.23.0
+  - uses: benner/commit-guard@v0.23.1
 ```
 
 Check all commits in a pull request:
@@ -432,7 +432,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
 ```
@@ -440,7 +440,7 @@ jobs:
 Check a specific commit SHA (mirrors the positional CLI argument):
 
 ```yaml
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           rev: ${{ github.sha }}
 ```
@@ -458,7 +458,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature
@@ -478,7 +478,7 @@ jobs:
 When `output-file` is set the action exposes the path as an output:
 
 ```yaml
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -494,7 +494,7 @@ Add to your `.pre-commit-config.yaml`:
 ---
 repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.23.0
+    rev: v0.23.1
     hooks:
       - id: commit-guard
       - id: commit-guard-signature

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/README.md

@@ -295,7 +295,7 @@ COMMIT_GUARD_GIT_TIMEOUT=30 commit-guard --range origin/main..HEAD
 In GitHub Actions, set it at the step or job level:
 
 ```yaml
-- uses: benner/commit-guard@v0.23.0
+- uses: benner/commit-guard@v0.23.1
   env:
     COMMIT_GUARD_GIT_TIMEOUT: 30
   with:
@@ -395,7 +395,7 @@ steps:
   - uses: actions/checkout@v4
     with:
       fetch-depth: 0
-  - uses: benner/commit-guard@v0.23.0
+  - uses: benner/commit-guard@v0.23.1
 ```
 
 Check all commits in a pull request:
@@ -411,7 +411,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
 ```
@@ -419,7 +419,7 @@ jobs:
 Check a specific commit SHA (mirrors the positional CLI argument):
 
 ```yaml
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           rev: ${{ github.sha }}
 ```
@@ -437,7 +437,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature
@@ -457,7 +457,7 @@ jobs:
 When `output-file` is set the action exposes the path as an output:
 
 ```yaml
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -473,7 +473,7 @@ Add to your `.pre-commit-config.yaml`:
 ---
 repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.23.0
+    rev: v0.23.1
     hooks:
       - id: commit-guard
       - id: commit-guard-signature

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/docs/index.html

@@ -575,13 +575,13 @@ require-subject-pattern = "[A-Z]+-[0-9]+"</code></pre>
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.23.0
+      - uses: benner/commit-guard@v0.23.1
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature</code></pre>
 
         <p>Check a specific commit SHA:</p>
-        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.23.0
+        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.23.1
         with:
           rev: ${{ github.sha }}</code></pre>
 
@@ -600,7 +600,7 @@ require-subject-pattern = "[A-Z]+-[0-9]+"</code></pre>
           When <code>output-file</code> is set the action exposes the path as
           a step output, making JSONL results available to subsequent steps:
         </p>
-        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.23.0
+        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.23.1
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -613,7 +613,7 @@ require-subject-pattern = "[A-Z]+-[0-9]+"</code></pre>
         <p>Add to <code>.pre-commit-config.yaml</code>:</p>
         <pre><code class="language-yaml">repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.23.0
+    rev: v0.23.1
     hooks:
       - id: commit-guard
       - id: commit-guard-signature</code></pre>

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/src/git_commit_guard/__init__.py

@@ -231,22 +231,22 @@ def check_imperative(desc, result):
     if not tokens:
         return
     first = tokens[0]
-    if _NON_IMPERATIVE_SUFFIX_RE.search(first):
+    base = wordnet.morphy(first, wordnet.VERB)
+    if base is not None and base != first:
         result.error(
-            f"expected imperative verb, got '{first}' (non-imperative suffix)",
+            f"expected imperative verb, got '{first}' (inflected form of '{base}')",
             check=Check.IMPERATIVE,
         )
         return
-    base = wordnet.morphy(first, wordnet.VERB)
-    if base is not None and base != first:
+    if base is None and _NON_IMPERATIVE_SUFFIX_RE.search(first):
         result.error(
-            f"expected imperative verb, got '{first}' (inflected form of '{base}')",
+            f"expected imperative verb, got '{first}' (non-imperative suffix)",
             check=Check.IMPERATIVE,
         )
         return
     tagged = nltk.pos_tag(["to", *tokens])
     if tagged[1][1] != "VB":
-        if wordnet.morphy(first, wordnet.VERB) == first:
+        if base == first:
             return
         if "-" in first:
             hyphen_prefix, hyphen_base = first.split("-", 1)

{git_commit_guard-0.23.0 → git_commit_guard-0.23.1}/tests/test_git_commit_guard.py

@@ -516,6 +516,28 @@ class TestCheckImperative:
         check_imperative("adding token refresh", r)
         assert not r.ok
 
+    def test_base_verb_with_ing_suffix_passes(self):
+        r = Result()
+        check_imperative("bring back --verbose flag", r)
+        assert r.ok
+
+    def test_base_verb_with_ed_suffix_passes(self):
+        r = Result()
+        check_imperative("embed version string in binary", r)
+        assert r.ok
+
+    def test_oov_gerund_still_fails(self):
+        # wordnet has no verb entry for 'refactoring'; suffix backstop catches it
+        r = Result()
+        check_imperative("refactoring config loader", r)
+        assert not r.ok
+        assert "non-imperative suffix" in r.errors[0][2]
+
+    def test_known_gerund_reports_inflected_form(self):
+        r = Result()
+        check_imperative("adding token refresh", r)
+        assert "inflected form of 'add'" in r.errors[0][2]
+
     def test_third_person_fails(self):
         r = Result()
         check_imperative("adds token refresh", r)