git-commit-guard 0.17.0__tar.gz → 0.19.0__tar.gz

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/.github/workflows/lint-commits.yml

@@ -22,7 +22,7 @@ jobs:
           key: nltk-averaged-perceptron-tagger-punkt
       - name: Lint commits
         # yamllint disable-line rule:line-length
-        uses: benner/commit-guard@064132b8b0cf5ec26083de7193f4e78d37a615d4  # v0.15.1
+        uses: benner/commit-guard@8a007fe3ebc1346ec111f7782b26af7e4ca32025  # v0.18.0
         with:
           range: origin/${{ github.base_ref }}..HEAD
           disable: signature

git_commit_guard-0.19.0/.github/workflows/lint-workflows.yml

@@ -0,0 +1,70 @@
+---
+name: Lint GitHub Actions workflows
+on:  # yamllint disable-line rule:truthy
+  pull_request:
+permissions:
+  contents: read
+jobs:
+  actionlint:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Checkout code
+        # yamllint disable-line rule:line-length
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5  # ratchet:actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Run actionlint
+        # yamllint disable-line rule:line-length
+        uses: reviewdog/action-actionlint@6fb7acc99f4a1008869fa8a0f09cfca740837d9d  # ratchet:reviewdog/action-actionlint@v1
+        with:
+          github_token: ${{ github.token }}
+          reporter: github-pr-review
+  yamlfix:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Checkout code
+        # yamllint disable-line rule:line-length
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5  # ratchet:actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Set up uv
+        # yamllint disable-line rule:line-length
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78  # ratchet:astral-sh/setup-uv@v7
+      - name: Set up reviewdog
+        # yamllint disable-line rule:line-length
+        uses: reviewdog/action-setup@d8a7baabd7f3e8544ee4dbde3ee41d0011c3a93f  # ratchet:reviewdog/action-setup@v1
+      - name: Run yamlfix
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
+        run: |-
+          uvx yamlfix .github/workflows/
+          git diff .github/workflows/ |
+            reviewdog -f=diff -name=yamlfix \
+              -reporter=github-pr-review -fail-on-error
+  zizmor:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Checkout code
+        # yamllint disable-line rule:line-length
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5  # ratchet:actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Set up uv
+        # yamllint disable-line rule:line-length
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78  # ratchet:astral-sh/setup-uv@v7
+      - name: Set up reviewdog
+        # yamllint disable-line rule:line-length
+        uses: reviewdog/action-setup@d8a7baabd7f3e8544ee4dbde3ee41d0011c3a93f  # ratchet:reviewdog/action-setup@v1
+      - name: Run zizmor
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
+        run: |-
+          uvx zizmor==1.24.1 --format=sarif . |
+            reviewdog -f=sarif -name=zizmor \
+              -reporter=github-pr-review -fail-on-error

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/.github/workflows/release.yml

@@ -2,11 +2,11 @@
 name: Release
 on:  # yamllint disable-line rule:truthy
   push:
-    tags:
-      - 'v*'
+    tags: [v*]
 permissions:
   contents: write
   id-token: write
+  pull-requests: read
 jobs:
   release:
     runs-on: ubuntu-latest
@@ -34,6 +34,8 @@ jobs:
         id: git-cliff
         # yamllint disable-line rule:line-length
         uses: orhun/git-cliff-action@f50e11560dce63f7c33227798f90b924471a88b5  # ratchet:orhun/git-cliff-action@v4.8.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           args: --current
       - name: Create GitHub Release

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: git-commit-guard
-Version: 0.17.0
+Version: 0.19.0
 Summary: Opinionated conventional commit message linter with imperative mood detection
 Project-URL: Homepage, https://github.com/benner/commit-guard
 Project-URL: Repository, https://github.com/benner/commit-guard
@@ -94,7 +94,7 @@ commit-guard --disable body,signed-off,signature
 Available checks:
 
 * `subject` - Format matches `type(scope): description`, valid type,
-    lowercase start, no trailing period, max 72 chars
+    lowercase start, no trailing `.` `!` `?` or space, max 72 chars
 * `imperative` - First word is an imperative verb (for example `add` not `added`)
 * `body` - Blank line separates subject from body, and body is non-empty
 * `signed-off` - `Signed-off-by:` trailer exists
@@ -131,8 +131,8 @@ In `.commit-guard.toml`:
 require-lowercase = false
 ```
 
-By default trailing `.` is forbidden. To change the set of forbidden trailing
-characters (any character is valid, including space):
+By default `.`, `!`, `?`, and space are forbidden as trailing characters.
+To change the set (any character is valid):
 
 ```bash
 commit-guard --no-trailing-chars ".,"
@@ -181,6 +181,25 @@ commit-guard --require-scope
 commit-guard --scopes auth,api --require-scope
 ```
 
+### Required subject pattern
+
+Require the commit subject to match a regular expression. Useful for
+enforcing ticket references or any custom naming convention:
+
+```bash
+commit-guard --require-subject-pattern "[A-Z]+-[0-9]+"
+commit-guard --require-subject-pattern "#[0-9]+"
+```
+
+In `.commit-guard.toml`:
+
+```toml
+require-subject-pattern = "[A-Z]+-[0-9]+"
+```
+
+An invalid regex causes an immediate error at startup (exit 2). This
+check runs independently of `--enable`/`--disable`.
+
 ### Required custom trailers
 
 Require arbitrary trailers to be present in the commit message. Multiple
@@ -206,7 +225,7 @@ independently of `--enable`/`--disable`.
 Place `.commit-guard.toml` in your project root (or any parent directory) to
 set defaults for `enable`, `disable`, `scopes`, `require-scope`, `types`,
 `max-subject-length`, `min-description-length`, `require-lowercase`,
-`no-trailing-chars`, and `require-trailers`.
+`no-trailing-chars`, `require-subject-pattern`, and `require-trailers`.
 commit-guard searches upward from the working directory and uses the first
 file found.
 
@@ -246,7 +265,7 @@ COMMIT_GUARD_GIT_TIMEOUT=30 commit-guard --range origin/main..HEAD
 In GitHub Actions, set it at the step or job level:
 
 ```yaml
-- uses: benner/commit-guard@v0.17.0
+- uses: benner/commit-guard@v0.19.0
   env:
     COMMIT_GUARD_GIT_TIMEOUT: 30
   with:
@@ -330,7 +349,7 @@ steps:
   - uses: actions/checkout@v4
     with:
       fetch-depth: 0
-  - uses: benner/commit-guard@v0.17.0
+  - uses: benner/commit-guard@v0.19.0
 ```
 
 Check all commits in a pull request:
@@ -346,7 +365,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
 ```
@@ -354,7 +373,7 @@ jobs:
 Check a specific commit SHA (mirrors the positional CLI argument):
 
 ```yaml
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           rev: ${{ github.sha }}
 ```
@@ -372,12 +391,13 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature
           scopes: auth,api,db
           require-scope: 'true'
+          require-subject-pattern: '[A-Z]+-[0-9]+'
           require-trailer: 'Closes,Reviewed-by'
           max-subject-length: '100'
           min-description-length: '10'
@@ -391,7 +411,7 @@ jobs:
 When `output-file` is set the action exposes the path as an output:
 
 ```yaml
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -407,7 +427,7 @@ Add to your `.pre-commit-config.yaml`:
 ---
 repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.17.0
+    rev: v0.19.0
     hooks:
       - id: commit-guard
       - id: commit-guard-signature

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/README.md

@@ -73,7 +73,7 @@ commit-guard --disable body,signed-off,signature
 Available checks:
 
 * `subject` - Format matches `type(scope): description`, valid type,
-    lowercase start, no trailing period, max 72 chars
+    lowercase start, no trailing `.` `!` `?` or space, max 72 chars
 * `imperative` - First word is an imperative verb (for example `add` not `added`)
 * `body` - Blank line separates subject from body, and body is non-empty
 * `signed-off` - `Signed-off-by:` trailer exists
@@ -110,8 +110,8 @@ In `.commit-guard.toml`:
 require-lowercase = false
 ```
 
-By default trailing `.` is forbidden. To change the set of forbidden trailing
-characters (any character is valid, including space):
+By default `.`, `!`, `?`, and space are forbidden as trailing characters.
+To change the set (any character is valid):
 
 ```bash
 commit-guard --no-trailing-chars ".,"
@@ -160,6 +160,25 @@ commit-guard --require-scope
 commit-guard --scopes auth,api --require-scope
 ```
 
+### Required subject pattern
+
+Require the commit subject to match a regular expression. Useful for
+enforcing ticket references or any custom naming convention:
+
+```bash
+commit-guard --require-subject-pattern "[A-Z]+-[0-9]+"
+commit-guard --require-subject-pattern "#[0-9]+"
+```
+
+In `.commit-guard.toml`:
+
+```toml
+require-subject-pattern = "[A-Z]+-[0-9]+"
+```
+
+An invalid regex causes an immediate error at startup (exit 2). This
+check runs independently of `--enable`/`--disable`.
+
 ### Required custom trailers
 
 Require arbitrary trailers to be present in the commit message. Multiple
@@ -185,7 +204,7 @@ independently of `--enable`/`--disable`.
 Place `.commit-guard.toml` in your project root (or any parent directory) to
 set defaults for `enable`, `disable`, `scopes`, `require-scope`, `types`,
 `max-subject-length`, `min-description-length`, `require-lowercase`,
-`no-trailing-chars`, and `require-trailers`.
+`no-trailing-chars`, `require-subject-pattern`, and `require-trailers`.
 commit-guard searches upward from the working directory and uses the first
 file found.
 
@@ -225,7 +244,7 @@ COMMIT_GUARD_GIT_TIMEOUT=30 commit-guard --range origin/main..HEAD
 In GitHub Actions, set it at the step or job level:
 
 ```yaml
-- uses: benner/commit-guard@v0.17.0
+- uses: benner/commit-guard@v0.19.0
   env:
     COMMIT_GUARD_GIT_TIMEOUT: 30
   with:
@@ -309,7 +328,7 @@ steps:
   - uses: actions/checkout@v4
     with:
       fetch-depth: 0
-  - uses: benner/commit-guard@v0.17.0
+  - uses: benner/commit-guard@v0.19.0
 ```
 
 Check all commits in a pull request:
@@ -325,7 +344,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
 ```
@@ -333,7 +352,7 @@ jobs:
 Check a specific commit SHA (mirrors the positional CLI argument):
 
 ```yaml
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           rev: ${{ github.sha }}
 ```
@@ -351,12 +370,13 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature
           scopes: auth,api,db
           require-scope: 'true'
+          require-subject-pattern: '[A-Z]+-[0-9]+'
           require-trailer: 'Closes,Reviewed-by'
           max-subject-length: '100'
           min-description-length: '10'
@@ -370,7 +390,7 @@ jobs:
 When `output-file` is set the action exposes the path as an output:
 
 ```yaml
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -386,7 +406,7 @@ Add to your `.pre-commit-config.yaml`:
 ---
 repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.17.0
+    rev: v0.19.0
     hooks:
       - id: commit-guard
       - id: commit-guard-signature

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/action.yml

@@ -39,7 +39,7 @@ inputs:
     required: false
     default: 'false'
   no-trailing-chars:
-    description: Forbidden trailing characters, comma-separated (default '.')
+    description: Forbidden trailing characters, comma-separated (default '.', '!', '?', ' ')
     required: false
   allow-empty:
     description: Exit 0 when --range yields no commits
@@ -49,6 +49,9 @@ inputs:
     description: Include merge commits when checking a range
     required: false
     default: 'false'
+  require-subject-pattern:
+    description: Regex the subject line must match (e.g. '[A-Z]+-[0-9]+')
+    required: false
   require-trailer:
     description: Comma-separated list of required trailers (e.g. Closes,Reviewed-by)
     required: false
@@ -86,6 +89,7 @@ runs:
         CG_NO_TRAILING_CHARS: ${{ inputs.no-trailing-chars }}
         CG_ALLOW_EMPTY: ${{ inputs.allow-empty }}
         CG_INCLUDE_MERGES: ${{ inputs.include-merges }}
+        CG_REQUIRE_SUBJECT_PATTERN: ${{ inputs.require-subject-pattern }}
         CG_REQUIRE_TRAILER: ${{ inputs.require-trailer }}
         CG_OUTPUT_FILE: ${{ inputs.output-file }}
       run: |
@@ -105,6 +109,8 @@ runs:
         [[ -n "$CG_NO_TRAILING_CHARS" ]] && ARGS+=(--no-trailing-chars "$CG_NO_TRAILING_CHARS")
         [[ "$CG_ALLOW_EMPTY" == "true" ]] && ARGS+=(--allow-empty)
         [[ "$CG_INCLUDE_MERGES" == "true" ]] && ARGS+=(--include-merges)
+        [[ -n "$CG_REQUIRE_SUBJECT_PATTERN" ]] && \
+            ARGS+=(--require-subject-pattern "$CG_REQUIRE_SUBJECT_PATTERN")
         [[ -n "$CG_REQUIRE_TRAILER" ]] && ARGS+=(--require-trailer "$CG_REQUIRE_TRAILER")
         [[ -n "$CG_OUTPUT_FILE" ]] && ARGS+=(--output-file "$CG_OUTPUT_FILE")
         commit-guard "${ARGS[@]}"

git_commit_guard-0.19.0/cliff.toml

@@ -0,0 +1,56 @@
+[changelog]
+body = """
+{% if version %}\
+    ## [{{ version | trim_start_matches(pat="v") }}] - {{ timestamp | date(format="%Y-%m-%d") }}
+{% else %}\
+    ## [unreleased]
+{% endif %}\
+{% for group, commits in commits | group_by(attribute="group") %}
+    ### {{ group | striptags | trim | upper_first }}
+    {% for commit in commits %}
+        - {% if commit.scope %}*({{ commit.scope }})* {% endif %}\
+            {% if commit.breaking %}[**breaking**] {% endif %}\
+            {{ commit.message | upper_first }} \
+            ([`{{ commit.id | truncate(length=7, end="") }}`]\
+            (https://github.com/benner/commit-guard/commit/{{ commit.id }}))\
+    {% endfor %}
+{% endfor %}
+{%- if github.contributors | filter(attribute="is_first_time", value=true) | length != 0 %}
+
+### New Contributors
+{% for contributor in github.contributors | filter(attribute="is_first_time", value=true) %}
+    - @{{ contributor.username }} made their first contribution\
+        {% if contributor.pr_number %} in \
+            [#{{ contributor.pr_number }}]\
+            (https://github.com/benner/commit-guard/pull/{{ contributor.pr_number }})\
+        {% endif %}
+{% endfor %}
+{%- endif %}
+"""
+trim = true
+
+[remote.github]
+owner = "benner"
+repo = "commit-guard"
+
+[git]
+conventional_commits = true
+filter_unconventional = true
+split_commits = false
+protect_breaking_commits = false
+commit_parsers = [
+    { message = "^feat", group = "<!-- 0 -->🚀 Features" },
+    { message = "^fix", group = "<!-- 1 -->🐛 Bug Fixes" },
+    { message = "^perf", group = "<!-- 2 -->⚡ Performance" },
+    { message = "^refactor", group = "<!-- 3 -->🚜 Refactor" },
+    { message = "^style", group = "<!-- 4 -->🎨 Styling" },
+    { message = "^test", group = "<!-- 5 -->🧪 Testing" },
+    { message = "^docs", skip = true },
+    { message = "^ci", skip = true },
+    { message = "^chore", group = "<!-- 6 -->⚙️ Miscellaneous Tasks" },
+    { message = "^revert", group = "<!-- 7 -->◀️ Revert" },
+    { body = ".*security", group = "<!-- 8 -->🛡️ Security" },
+]
+filter_commits = true
+topo_order = false
+sort_commits = "oldest"

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/docs/index.html

@@ -355,7 +355,7 @@ $ echo "fix(auth): add token refresh" | commit-guard</code></pre>
                 <td><code>subject</code></td>
                 <td>
                   <a href="https://www.conventionalcommits.org/" target="_blank" rel="noopener">Conventional Commits</a>
-                  format: valid type, lowercase start, no trailing period,
+                  format: valid type, lowercase start, no trailing <code>.</code> <code>!</code> <code>?</code> or space,
                   max length (default 72). All limits are configurable. Use
                   <code>!</code> before the colon for breaking changes:
                   <code>feat!: remove endpoint</code>
@@ -400,7 +400,23 @@ max-subject-length = 100
 min-description-length = 10
 require-lowercase = false
 no-trailing-chars = [".", "!"]
-require-trailers = ["Closes", "Reviewed-by"]</code></pre>
+require-trailers = ["Closes", "Reviewed-by"]
+require-subject-pattern = "[A-Z]+-[0-9]+"</code></pre>
+
+        <h3>Required subject pattern</h3>
+        <p>
+          Require the commit subject to match a regular expression. Useful for
+          enforcing ticket references or any custom naming convention:
+        </p>
+        <pre><code class="language-bash">commit-guard --require-subject-pattern "[A-Z]+-[0-9]+"</code></pre>
+        <p>
+          In <code>.commit-guard.toml</code>:
+        </p>
+        <pre><code class="language-toml">require-subject-pattern = "[A-Z]+-[0-9]+"</code></pre>
+        <p>
+          An invalid regex causes an immediate error at startup (exit 2). This
+          check runs independently of <code>--enable</code>/<code>--disable</code>.
+        </p>
 
         <h3>Required trailers</h3>
         <p>
@@ -479,13 +495,13 @@ require-trailers = ["Closes", "Reviewed-by"]</code></pre>
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: benner/commit-guard@v0.17.0
+      - uses: benner/commit-guard@v0.19.0
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
           disable: signed-off,signature</code></pre>
 
         <p>Check a specific commit SHA:</p>
-        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.17.0
+        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.19.0
         with:
           rev: ${{ github.sha }}</code></pre>
 
@@ -504,7 +520,7 @@ require-trailers = ["Closes", "Reviewed-by"]</code></pre>
           When <code>output-file</code> is set the action exposes the path as
           a step output, making JSONL results available to subsequent steps:
         </p>
-        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.17.0
+        <pre><code class="language-yaml">      - uses: benner/commit-guard@v0.19.0
         id: cg
         with:
           range: ${{ env.PR_BASE }}..${{ env.PR_HEAD }}
@@ -517,7 +533,7 @@ require-trailers = ["Closes", "Reviewed-by"]</code></pre>
         <p>Add to <code>.pre-commit-config.yaml</code>:</p>
         <pre><code class="language-yaml">repos:
   - repo: https://github.com/benner/commit-guard
-    rev: v0.17.0
+    rev: v0.19.0
     hooks:
       - id: commit-guard
       - id: commit-guard-signature</code></pre>

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/src/git_commit_guard/__init__.py

@@ -153,7 +153,7 @@ def check_subject(  # noqa: PLR0913 Too many arguments in function definition (9
     allowed_types=TYPES,
     max_subject_length=MAX_SUBJECT_LEN,
     min_description_length=0,
-    no_trailing_chars=frozenset("."),
+    no_trailing_chars=frozenset({".", "!", "?", " "}),
     *,
     require_scope=False,
     require_lowercase=True,
@@ -241,6 +241,14 @@ def check_signed_off(message, result):
         result.error("missing 'Signed-off-by' trailer", check=Check.SIGNED_OFF)
 
 
+def check_subject_pattern(subject, pattern, result):
+    if not pattern.search(subject):
+        result.error(
+            f"subject must match pattern '{pattern.pattern}'",
+            check=Check.SUBJECT,
+        )
+
+
 def check_required_trailers(message, required, result):
     for trailer in required:
         pattern = re.compile(rf"^{re.escape(trailer)}:\s+\S", re.MULTILINE)
@@ -313,6 +321,7 @@ class Args:
     allow_empty: bool
     include_merges: bool
     required_trailers: list
+    subject_pattern: re.Pattern | None
     output: OutputFormat
     output_file: Path | None
 
@@ -362,7 +371,7 @@ def _resolve_no_trailing_chars(args, config):
         return frozenset(c for c in args.no_trailing_chars.split(",") if c)
     if "no-trailing-chars" in config:
         return frozenset(config["no-trailing-chars"])
-    return frozenset(".")
+    return frozenset({".", "!", "?", " "})
 
 
 def _resolve_required_trailers(args, config):
@@ -373,6 +382,12 @@ def _resolve_required_trailers(args, config):
     return []
 
 
+def _resolve_subject_pattern(args, config):
+    if args.require_subject_pattern is not None:
+        return args.require_subject_pattern
+    return config.get("require-subject-pattern")
+
+
 def _resolve_types(args, config):
     if args.types:
         return frozenset(t.strip() for t in args.types.split(","))
@@ -406,7 +421,7 @@ def _parse_checks(parser, value):
         parser.error(str(e))
 
 
-def _parse_args():
+def _parse_args():  # noqa: PLR0915 Too many statements (59 > 50)
     checks_list = ",".join(sorted(Check))
     parser = ArgumentParser(description="conventional commit checker")
     parser.add_argument("rev", nargs="?", default=None)
@@ -476,6 +491,12 @@ def _parse_args():
         default=False,
         help="exit 0 when --range yields no commits (default: exit 1)",
     )
+    parser.add_argument(
+        "--require-subject-pattern",
+        default=None,
+        metavar="REGEX",
+        help="require subject line to match this regular expression",
+    )
     parser.add_argument(
         "--require-trailer",
         metavar="TRAILER[,TRAILER,...]",
@@ -509,6 +530,16 @@ def _parse_args():
     require_lowercase = _resolve_require_lowercase(args, config)
     no_trailing_chars = _resolve_no_trailing_chars(args, config)
     required_trailers = _resolve_required_trailers(args, config)
+    subject_pattern_str = _resolve_subject_pattern(args, config)
+    if subject_pattern_str is not None:
+        try:
+            subject_pattern = re.compile(subject_pattern_str)
+        except re.error as e:
+            parser.error(
+                f"invalid regex for --require-subject-pattern {subject_pattern_str!r}: {e}"  # noqa: E501 Line too long
+            )
+    else:
+        subject_pattern = None
 
     if args.allow_empty and not args.rev_range:
         parser.error("--allow-empty requires --range")
@@ -548,6 +579,7 @@ def _parse_args():
         allow_empty=args.allow_empty,
         include_merges=args.include_merges,
         required_trailers=required_trailers,
+        subject_pattern=subject_pattern,
         output=OutputFormat(args.output),
         output_file=args.output_file,
     )
@@ -613,6 +645,8 @@ def _run_checks(args, rev, message, result):
         check_signed_off(message, result)
     if args.required_trailers:
         check_required_trailers(message, args.required_trailers, result)
+    if args.subject_pattern:
+        check_subject_pattern(lines[0], args.subject_pattern, result)
     if Check.SIGNATURE in args.enabled and rev:
         check_signature(rev, result)
 

{git_commit_guard-0.17.0 → git_commit_guard-0.19.0}/tests/test_git_commit_guard.py

@@ -1,4 +1,5 @@
 import json
+import re
 import subprocess
 from argparse import ArgumentParser, Namespace
 from unittest.mock import MagicMock, patch
@@ -22,7 +23,10 @@ from git_commit_guard import (
     _report_text,
     _resolve_max_subject_length,
     _resolve_min_description_length,
+    _resolve_no_trailing_chars,
+    _resolve_require_lowercase,
     _resolve_required_trailers,
+    _resolve_subject_pattern,
     _resolve_types,
     _strip_comments,
     check_body,
@@ -31,6 +35,7 @@ from git_commit_guard import (
     check_signature,
     check_signed_off,
     check_subject,
+    check_subject_pattern,
     main,
 )
 
@@ -392,6 +397,55 @@ class TestResolveRequiredTrailers:
         assert result == ["Fixes"]
 
 
+class TestCheckSubjectPattern:
+    def test_matching_subject_passes(self):
+        r = Result()
+        check_subject_pattern("feat: add PROJ-123 login", re.compile(r"[A-Z]+-\d+"), r)
+        assert r.ok
+
+    def test_non_matching_subject_fails(self):
+        r = Result()
+        check_subject_pattern(
+            "feat: implement OAuth login flow", re.compile(r"[A-Z]+-\d+"), r
+        )
+        assert not r.ok
+        assert "must match pattern" in r.errors[0][2]
+        assert "[A-Z]+-\\d+" in r.errors[0][2]
+
+    def test_error_includes_pattern(self):
+        r = Result()
+        check_subject_pattern("fix: oops", re.compile(r"#\d+"), r)
+        assert "#\\d+" in r.errors[0][2]
+
+
+class TestResolveSubjectPattern:
+    def test_defaults_to_none(self):
+        assert (
+            _resolve_subject_pattern(Namespace(require_subject_pattern=None), {})
+            is None
+        )
+
+    def test_cli_flag(self):
+        result = _resolve_subject_pattern(
+            Namespace(require_subject_pattern="[A-Z]+-\\d+"), {}
+        )
+        assert result == "[A-Z]+-\\d+"
+
+    def test_config(self):
+        result = _resolve_subject_pattern(
+            Namespace(require_subject_pattern=None),
+            {"require-subject-pattern": "#\\d+"},
+        )
+        assert result == "#\\d+"
+
+    def test_cli_overrides_config(self):
+        result = _resolve_subject_pattern(
+            Namespace(require_subject_pattern="[A-Z]+-\\d+"),
+            {"require-subject-pattern": "#\\d+"},
+        )
+        assert result == "[A-Z]+-\\d+"
+
+
 class TestCheckImperative:
     def test_imperative_verb_passes(self):
         r = Result()
@@ -454,6 +508,19 @@ class TestCheckImperative:
         check_imperative("", r)
         assert r.ok
 
+    def test_pos_fallback_unknown_word_fails(self):
+        r = Result()
+        with (
+            patch("git_commit_guard.wordnet.morphy", return_value=None),
+            patch(
+                "git_commit_guard.nltk.pos_tag",
+                return_value=[("to", "TO"), ("xyzzy", "NN")],
+            ),
+        ):
+            check_imperative("xyzzy something", r)
+        assert not r.ok
+        assert "POS=NN" in r.errors[0][2]
+
 
 class TestDownloadIfMissing:
     def test_skips_download_when_present(self):
@@ -617,6 +684,38 @@ class TestResolveMinDescriptionLength:
         assert result == 10
 
 
+class TestResolveRequireLowercase:
+    def test_cli_flag_overrides_default(self):
+        assert (
+            _resolve_require_lowercase(Namespace(require_lowercase=False), {}) is False
+        )
+
+    def test_config_overrides_default(self):
+        result = _resolve_require_lowercase(
+            Namespace(require_lowercase=None), {"require-lowercase": False}
+        )
+        assert result is False
+
+    def test_default_is_true(self):
+        assert _resolve_require_lowercase(Namespace(require_lowercase=None), {}) is True
+
+
+class TestResolveNoTrailingChars:
+    def test_cli_flag_overrides_default(self):
+        result = _resolve_no_trailing_chars(Namespace(no_trailing_chars=".,!"), {})
+        assert result == frozenset({".", "!"})
+
+    def test_config_overrides_default(self):
+        result = _resolve_no_trailing_chars(
+            Namespace(no_trailing_chars=None), {"no-trailing-chars": [".", "!"]}
+        )
+        assert result == frozenset({".", "!"})
+
+    def test_default_includes_common_punctuation_and_space(self):
+        result = _resolve_no_trailing_chars(Namespace(no_trailing_chars=None), {})
+        assert result == frozenset({".", "!", "?", " "})
+
+
 class TestGitTimeout:
     def test_default(self, monkeypatch):
         monkeypatch.delenv("COMMIT_GUARD_GIT_TIMEOUT", raising=False)
@@ -1391,6 +1490,69 @@ class TestRequireTrailerIntegration:
             assert main() == 0
 
 
+class TestRequireSubjectPatternIntegration:
+    def test_matching_pattern_passes(self, tmp_path):
+        f = tmp_path / "msg"
+        f.write_text(
+            "fix: resolve PROJ-42 auth timeout\n\nbody\n\nSigned-off-by: A <a@b.com>"
+        )
+        argv = [
+            "cg",
+            "--message-file",
+            str(f),
+            "--disable",
+            "signature,imperative",
+            "--require-subject-pattern",
+            "[A-Z]+-[0-9]+",
+        ]
+        with patch("sys.argv", argv):
+            assert main() == 0
+
+    def test_non_matching_pattern_fails(self, tmp_path):
+        f = tmp_path / "msg"
+        f.write_text("fix: resolve auth timeout\n\nbody\n\nSigned-off-by: A <a@b.com>")
+        argv = [
+            "cg",
+            "--message-file",
+            str(f),
+            "--disable",
+            "signature,imperative",
+            "--require-subject-pattern",
+            "[A-Z]+-[0-9]+",
+        ]
+        with patch("sys.argv", argv):
+            assert main() == 1
+
+    def test_invalid_regex_exits(self, tmp_path):
+        f = tmp_path / "msg"
+        f.write_text("fix: add thing\n\nbody\n\nSigned-off-by: A <a@b.com>")
+        argv = [
+            "cg",
+            "--message-file",
+            str(f),
+            "--disable",
+            "signature,imperative",
+            "--require-subject-pattern",
+            "[unclosed",
+        ]
+        with patch("sys.argv", argv), pytest.raises(SystemExit) as exc:
+            main()
+        assert exc.value.code == 2
+
+    def test_pattern_from_config(self, tmp_path):
+        f = tmp_path / "msg"
+        f.write_text("fix: resolve auth timeout\n\nbody\n\nSigned-off-by: A <a@b.com>")
+        argv = ["cg", "--message-file", str(f), "--disable", "signature,imperative"]
+        with (
+            patch("sys.argv", argv),
+            patch(
+                "git_commit_guard._load_config",
+                return_value={"require-subject-pattern": "[A-Z]+-[0-9]+"},
+            ),
+        ):
+            assert main() == 1
+
+
 class TestOutputJsonl:
     def test_single_commit_ok(self, tmp_path, capsys):
 
@@ -1458,6 +1620,27 @@ class TestOutputJsonl:
             assert data["sha"] == rev
             assert data["ok"] is True
 
+    def test_range_failing_commit_returns_nonzero(self, capsys):
+        with (
+            patch(
+                "sys.argv",
+                [
+                    "cg",
+                    "--range",
+                    "HEAD~1..HEAD",
+                    "--disable",
+                    "signature,imperative",
+                    "--output",
+                    "jsonl",
+                ],
+            ),
+            patch("git_commit_guard._get_range_revs", return_value=["aaa"]),
+            patch("git_commit_guard._get_message", return_value="bad message"),
+        ):
+            assert main() == 1
+        data = json.loads(capsys.readouterr().out)
+        assert data["ok"] is False
+
 
 class TestOutputFile:
     def test_single_commit_writes_jsonl_to_file(self, tmp_path, capsys):